@gitlab/eslint-plugin 10.0.2 → 11.0.0

package/lib/index.js

@@ -7,7 +7,6 @@ module.exports = {
     'no-runtime-template-compiler': require('./rules/no-runtime-template-compiler.js'),
     'require-i18n-strings': require('./rules/require-i18n-strings.js'),
     'require-valid-i18n-helpers': require('./rules/require-valid-i18n-helpers.js'),
-    'vue-emit-events-with-two-args': require('./rules/vue-emit-events-with-two-args.js'),
     'vue-no-data-toggle': require('./rules/vue-no-data-toggle.js'),
     'vue-no-new-non-primitive-in-template': require('./rules/vue-no-new-non-primitive-in-template.js'),
     'vue-require-i18n-attribute-strings': require('./rules/vue-require-i18n-attribute-strings.js'),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gitlab/eslint-plugin",
-  "version": "10.0.2",
+  "version": "11.0.0",
   "description": "GitLab package for our custom eslint rules",
   "main": "lib/index.js",
   "scripts": {

package/docs/rules/vue-emit-events-with-two-args.md

@@ -1,38 +0,0 @@
-# @gitlab/vue-emit-events-with-two-args
-
-Throw an error when emit is called with more than two arguments.
-
-## Rule Details
-
-It has been decided to use `mitt` as an event bus implementation and this library does not support argument list as the event arguments, [it expects two arguments only](https://github.com/developit/mitt#emit).
-
-To pass an argument list, an object should be used as the second argument.
-
-### Examples of **incorrect** code for this rule
-
-`emit` method called with more than two arguments.
-
-```javascript
-vm.$emit('keyspressed', 'enter', '1');
-vm.emit('keyspressed', 'enter', '1');
-```
-
-### Examples of **correct** code for this rule
-
-Pass an object as the second argument to `emit`.
-
-```javascript
-vm.$emit('keyspressed', { keys: ['enter', '1'] });
-vm.emit('keyspressed', { keys: ['enter', '1'] });
-```
-
-`emit` method called with one argument.
-
-```javascript
-vm.$emit('focus');
-vm.emit('focus');
-```
-
-## Options
-
-Nothing

package/lib/rules/vue-emit-events-with-two-args.js

@@ -1,54 +0,0 @@
-// ------------------------------------------------------------------------------
-// Requirements
-// ------------------------------------------------------------------------------
-const { DOCS_BASE_URL } = require('../constants');
-const { getFunctionName } = require('../utils/rule-utils');
-
-// ------------------------------------------------------------------------------
-//   Helpers
-// ------------------------------------------------------------------------------
-
-const EMIT_LIST = new Set(['$emit', 'emit']);
-const ERROR_MESSAGE = `Expected emit to be called with no more than two arguments.`;
-
-// ------------------------------------------------------------------------------
-// Rule Definition
-// ------------------------------------------------------------------------------
-
-module.exports = {
-  meta: {
-    type: 'problem',
-    docs: {
-      description: `Throw an error when emit is called with more than two arguments.`,
-      url: DOCS_BASE_URL + '/vue-emit-events-with-two-args.md',
-    },
-  },
-  create(context) {
-    function report(node) {
-      context.report({
-        node,
-        message: ERROR_MESSAGE,
-      });
-    }
-
-    function isEmitCall(node) {
-      const functionName = getFunctionName(node);
-
-      return functionName && EMIT_LIST.has(functionName);
-    }
-
-    function checkFunctionArguments(callExpression) {
-      if (callExpression.arguments.length > 2) {
-        report(callExpression);
-      }
-    }
-
-    return {
-      CallExpression(node) {
-        if (isEmitCall(node)) {
-          checkFunctionArguments(node);
-        }
-      },
-    };
-  },
-};