@gitlab/eslint-plugin 10.0.1 → 12.0.0

package/lib/configs/default.js

@@ -15,11 +15,11 @@ module.exports = {
     'plugin:promise/recommended',
   ],
   parserOptions: {
-    parser: 'babel-eslint',
+    parser: '@babel/eslint-parser',
   },
-  plugins: ['babel', 'filenames', 'promise', 'import', '@gitlab'],
+  plugins: ['@babel', 'unicorn', 'promise', 'import', '@gitlab'],
   rules: {
-    'babel/camelcase': [
+    camelcase: [
       'error',
       {
         properties: 'never',
@@ -27,7 +27,7 @@ module.exports = {
       },
     ],
     camelcase: 'off',
-    'filenames/match-regex': ['error', '^[a-z0-9_]+$'],
+    'unicorn/filename-case': ['error', { case: 'snakeCase' }],
     'import/prefer-default-export': 'off',
     'import/no-default-export': 'error',
     'import/no-deprecated': 'error',

package/lib/constants.js

@@ -1,3 +1,3 @@
 module.exports = {
-  DOCS_BASE_URL: 'https://gitlab.com/gitlab-org/frontend/eslint-plugin/blob/master/docs/rules/',
+  DOCS_BASE_URL: 'https://gitlab.com/gitlab-org/frontend/eslint-plugin/blob/main/docs/rules/',
 };

package/lib/index.js

@@ -7,7 +7,6 @@ module.exports = {
     'no-runtime-template-compiler': require('./rules/no-runtime-template-compiler.js'),
     'require-i18n-strings': require('./rules/require-i18n-strings.js'),
     'require-valid-i18n-helpers': require('./rules/require-valid-i18n-helpers.js'),
-    'vue-emit-events-with-two-args': require('./rules/vue-emit-events-with-two-args.js'),
     'vue-no-data-toggle': require('./rules/vue-no-data-toggle.js'),
     'vue-no-new-non-primitive-in-template': require('./rules/vue-no-new-non-primitive-in-template.js'),
     'vue-require-i18n-attribute-strings': require('./rules/vue-require-i18n-attribute-strings.js'),

package/lib/rules/require-i18n-strings.js

@@ -115,6 +115,10 @@ module.exports = {
       );
     }
 
+    function isMailto(str) {
+      return (str || '').startsWith('mailto:');
+    }
+
     function isPlaceholder(value) {
       return /^{?{\w+}}?$/.test(value);
     }
@@ -253,6 +257,7 @@ module.exports = {
         !isNumber(value) &&
         !isPath(value) &&
         !isUrl(value) &&
+        !isMailto(value) &&
         !isHtml(value) &&
         !isCssSelector(value) &&
         !isCssValue(value) &&

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gitlab/eslint-plugin",
-  "version": "10.0.1",
+  "version": "12.0.0",
   "description": "GitLab package for our custom eslint rules",
   "main": "lib/index.js",
   "scripts": {
@@ -27,14 +27,16 @@
   },
   "homepage": "https://gitlab.com/gitlab-org/frontend/eslint-plugin#readme",
   "engines": {
-    "node": ">=8.10.0"
+    "node": ">=14"
   },
   "dependencies": {
-    "babel-eslint": "^10.0.3",
+    "@babel/core": "^7.17.0",
+    "@babel/eslint-parser": "^7.17.0",
+    "@babel/eslint-plugin": "^7.17.7",
     "eslint-config-airbnb-base": "^14.2.1",
     "eslint-config-prettier": "^6.10.0",
     "eslint-plugin-babel": "^5.3.0",
-    "eslint-plugin-filenames": "^1.3.2",
+    "eslint-plugin-unicorn": "^40.1.0",
     "eslint-plugin-import": "^2.22.1",
     "eslint-plugin-jest": "^23.8.2",
     "eslint-plugin-promise": "^4.2.1",
@@ -53,6 +55,9 @@
     "pretty-quick": "^3.1.0"
   },
   "release": {
+    "branches": [
+      "main"
+    ],
     "verifyConditions": [
       "@semantic-release/changelog",
       "@semantic-release/npm",

package/docs/rules/vue-emit-events-with-two-args.md

@@ -1,38 +0,0 @@
-# @gitlab/vue-emit-events-with-two-args
-
-Throw an error when emit is called with more than two arguments.
-
-## Rule Details
-
-It has been decided to use `mitt` as an event bus implementation and this library does not support argument list as the event arguments, [it expects two arguments only](https://github.com/developit/mitt#emit).
-
-To pass an argument list, an object should be used as the second argument.
-
-### Examples of **incorrect** code for this rule
-
-`emit` method called with more than two arguments.
-
-```javascript
-vm.$emit('keyspressed', 'enter', '1');
-vm.emit('keyspressed', 'enter', '1');
-```
-
-### Examples of **correct** code for this rule
-
-Pass an object as the second argument to `emit`.
-
-```javascript
-vm.$emit('keyspressed', { keys: ['enter', '1'] });
-vm.emit('keyspressed', { keys: ['enter', '1'] });
-```
-
-`emit` method called with one argument.
-
-```javascript
-vm.$emit('focus');
-vm.emit('focus');
-```
-
-## Options
-
-Nothing

package/lib/rules/vue-emit-events-with-two-args.js

@@ -1,54 +0,0 @@
-// ------------------------------------------------------------------------------
-// Requirements
-// ------------------------------------------------------------------------------
-const { DOCS_BASE_URL } = require('../constants');
-const { getFunctionName } = require('../utils/rule-utils');
-
-// ------------------------------------------------------------------------------
-//   Helpers
-// ------------------------------------------------------------------------------
-
-const EMIT_LIST = new Set(['$emit', 'emit']);
-const ERROR_MESSAGE = `Expected emit to be called with no more than two arguments.`;
-
-// ------------------------------------------------------------------------------
-// Rule Definition
-// ------------------------------------------------------------------------------
-
-module.exports = {
-  meta: {
-    type: 'problem',
-    docs: {
-      description: `Throw an error when emit is called with more than two arguments.`,
-      url: DOCS_BASE_URL + '/vue-emit-events-with-two-args.md',
-    },
-  },
-  create(context) {
-    function report(node) {
-      context.report({
-        node,
-        message: ERROR_MESSAGE,
-      });
-    }
-
-    function isEmitCall(node) {
-      const functionName = getFunctionName(node);
-
-      return functionName && EMIT_LIST.has(functionName);
-    }
-
-    function checkFunctionArguments(callExpression) {
-      if (callExpression.arguments.length > 2) {
-        report(callExpression);
-      }
-    }
-
-    return {
-      CallExpression(node) {
-        if (isEmitCall(node)) {
-          checkFunctionArguments(node);
-        }
-      },
-    };
-  },
-};