@githolon/dsl 0.108.7 → 0.110.0

package/dart/test/event_plane_seam_test.dart

@@ -1,188 +1,74 @@
-// THE EVENT-PLANE TRIPWIRE (source-level, no mirrors).
+// Reception state-ownership tripwire (source-level, no mirrors).
 //
-// THE BUG CLASS THIS CLOSES: NomosSession extends NomosBridge but shares the parent's transport —
-// _onMessage only ever runs on the PARENT, so any Stream-returning member (or stateful snapshot) that
-// touches `this`'s controller registries registers on a session's DEAD registry and never emits
-// (shipped instances: watchPendingConflicts pre-0.48.1 + the five hand-written session watch overrides).
-// The structural fix: ONE overridable seam — `NomosBridge get _eventPlane` — and every event-dispatch /
-// plane-state access goes through it.
-//
-// WHAT THIS TEST ASSERTS (each chosen to FAIL if the bug class is re-opened):
-//  1. Every public Stream-returning member declared on NomosBridge routes through the seam: its body
-//     either references `_eventPlane` directly or delegates to `_watchStream` (whose own body must).
-//  2. The controller registries (`_watches[` / `_compatWatches[`) are only ever indexed via
-//     `_eventPlane.` inside Stream-returning members — a new method with its own local registry, or a
-//     bare `this._watches[subId] = ctrl`, trips it.
-//  3. NomosSession declares NO Stream-returning members and NO StreamController state of its own — a
-//     re-added per-method override (the old workaround, i.e. the smell) trips it.
-//  4. The seam override on NomosSession chases to the root (`parent._eventPlane`, not `parent`).
-//
-// HONESTY NOTE: this is a text-level check, not semantic analysis. It cannot prove an `_eventPlane`
-// mention is the LOAD-BEARING one — but every re-occurrence of the bug so far shipped as a member whose
-// body never named the parent plane at all, which this catches. Keep the seam's doc comment in
-// webview_bridge.dart in sync if the routing rule ever changes.
+// A NomosSession is a workspace-scoped view of one Reception plane. It must
+// never allocate another set of event controllers, registries, projections,
+// correlation counters or request gateways. Those objects have one owner for
+// the lifetime of Reception and every session view shares their exact identity.
 
 import 'dart:io';
 
 import 'package:test/test.dart';
 
-/// Extract `class <name> ... { ... }`'s body via brace matching.
-String classBody(String src, String name) {
-  final decl = RegExp('class $name[\\s<]').firstMatch(src);
-  if (decl == null) fail('class $name not found');
-  final open = src.indexOf('{', decl.start);
+String classBody(String source, String name) {
+  final declaration = RegExp('class $name[\\s<]').firstMatch(source);
+  if (declaration == null) fail('class $name not found');
+  final open = source.indexOf('{', declaration.start);
   var depth = 0;
-  for (var i = open; i < src.length; i++) {
-    final c = src[i];
-    if (c == '{') depth++;
-    if (c == '}') {
+  for (var index = open; index < source.length; index++) {
+    final character = source[index];
+    if (character == '{') depth++;
+    if (character == '}') {
       depth--;
-      if (depth == 0) return src.substring(open + 1, i);
+      if (depth == 0) return source.substring(open + 1, index);
     }
   }
   fail('unbalanced braces for class $name');
 }
 
-class Member {
-  Member(this.name, this.body);
-  final String name;
-  final String body; // the full text from `=>`/`{` to the member's end
-}
-
-/// Collect every member whose declared return type is `Stream<...>` (methods AND getters).
-/// Text-level: finds `Stream<` at member position, then captures the arrow-or-block body.
-List<Member> streamMembers(String body) {
-  final out = <Member>[];
-  final decl = RegExp(
-      r'\n  Stream<[^=;{]*?(?:get\s+(\w+)|(\w+)\s*\()',
-      dotAll: true);
-  for (final m in decl.allMatches(body)) {
-    final name = m.group(1) ?? m.group(2)!;
-    // scan from the end of the declaration match to the member's end (arrow → `;` at depth 0;
-    // block → matching `}`), tracking (), {}, [] together so `=>` inside args doesn't confuse it.
-    // for a method the regex consumed the opening `(` — rewind one so paren depth balances.
-    var i = m.group(2) != null ? m.end - 1 : m.end;
-    var depth = 0;
-    var start = -1; // where the body proper begins
-    var isBlock = false;
-    for (; i < body.length; i++) {
-      final c = body[i];
-      if (c == '(' || c == '[') depth++;
-      if (c == ')' || c == ']') depth--;
-      if (depth == 0 && start < 0) {
-        if (c == '=' && i + 1 < body.length && body[i + 1] == '>') {
-          start = i;
-          continue;
-        }
-        if (c == '{') {
-          start = i;
-          isBlock = true;
-          depth = 1;
-          continue;
-        }
-        continue;
-      }
-      if (start < 0) continue;
-      if (isBlock) {
-        if (c == '{') depth++;
-        if (c == '}') {
-          depth--;
-          if (depth == 0) break;
-        }
-      } else {
-        if (c == '{') depth++;
-        if (c == '}') depth--;
-        if (c == ';' && depth == 0) break;
-      }
-    }
-    out.add(Member(name, body.substring(m.start, i + 1)));
-  }
-  return out;
-}
-
 void main() {
-  final src = File('lib/src/webview_bridge.dart').readAsStringSync();
-  final bridge = classBody(src, 'NomosBridge');
-  final session = classBody(src, 'NomosSession');
-  final bridgeStreams = streamMembers(bridge);
-
-  test('found the known Stream surface on NomosBridge (parser sanity)', () {
-    final names = bridgeStreams.map((m) => m.name).toSet();
-    // if one of these is renamed/removed, update this list deliberately.
-    for (final expected in [
-      'custodyEvents', 'syncEvents', 'transferProgress', 'syncStatus',
-      'signalEvents', 'flameEvents', 'spanEvents', 'onLawChanged',
-      'watch', 'watchById', 'watchSpatial', 'watchPendingConflicts',
-      'watchActivity', 'watchCompatibility', '_watchStream',
-    ]) {
-      expect(names, contains(expected),
-          reason: 'the source parser lost sight of $expected — fix the '
-              'parser (or update the list if the member was deliberately '
-              'renamed)');
-    }
-  });
+  final source =
+      File('lib/src/reception/dart_reception.dart').readAsStringSync();
+  final reception = classBody(source, 'DartReception');
+  final session = classBody(source, 'NomosSession');
 
-  test('every NomosBridge Stream member routes through the _eventPlane seam',
-      () {
-    for (final m in bridgeStreams) {
-      final routed = m.body.contains('_eventPlane') ||
-          RegExp(r'\b_watchStream\(').hasMatch(m.body);
-      expect(routed, isTrue,
-          reason: 'NomosBridge.${m.name} returns a Stream but its body '
-              'references neither _eventPlane nor _watchStream — on a '
-              'NomosSession its events would resolve against a DEAD '
-              'registry (the watchPendingConflicts 0.48.1 bug class). '
-              'Register controllers/state on _eventPlane.<field>.');
-    }
-    // and the shared helper itself must land its registry on the plane.
-    final ws = bridgeStreams.firstWhere((m) => m.name == '_watchStream');
-    expect(ws.body, contains('_eventPlane._watches[subId] = ctrl'),
-        reason: '_watchStream must register its controller on the event '
-            'plane\'s registry');
-    final wc = bridgeStreams.firstWhere((m) => m.name == 'watchCompatibility');
-    expect(wc.body, contains('_eventPlane._compatWatches[subId] = ctrl'),
-        reason: 'watchCompatibility must register its controller on the '
-            'event plane\'s registry');
-  });
+  const sharedPlaneState = <String>[
+    '_transport',
+    '_events',
+    '_sessions',
+    '_receipts',
+    '_sequences',
+    '_runtimeV2',
+  ];
 
-  test('controller registries are only indexed via the seam in Stream members',
-      () {
-    for (final m in bridgeStreams) {
-      for (final reg in ['_watches[', '_compatWatches[']) {
-        var from = 0;
-        while (true) {
-          final at = m.body.indexOf(reg, from);
-          if (at < 0) break;
-          from = at + reg.length;
-          final prefix =
-              m.body.substring(at < 12 ? 0 : at - 12, at);
-          expect(prefix, endsWith('_eventPlane.'),
-              reason: 'NomosBridge.${m.name} indexes $reg without the '
-                  '_eventPlane. prefix — a bare registry access is the '
-                  'dead-registry bug on sessions');
-        }
-      }
+  test('a session view shares every Reception plane state owner', () {
+    final view = RegExp(
+      r'DartReception\._view\(DartReception parent\)([\s\S]*?)allowStaleRunnerBundle = false;',
+    ).firstMatch(reception)?.group(1);
+    expect(view, isNotNull,
+        reason: 'DartReception._view constructor not found');
+    for (final field in sharedPlaneState) {
+      expect(
+        view,
+        contains('$field = parent.$field'),
+        reason:
+            '$field must be the parent plane object, not session-local state',
+      );
     }
   });
 
-  test('NomosSession declares no Stream members and no controller state', () {
-    final sessionStreams = streamMembers(session);
-    expect(sessionStreams, isEmpty,
-        reason: 'NomosSession re-declares Stream member(s) '
-            '${sessionStreams.map((m) => m.name).toList()} — the per-method '
-            'override was the WORKAROUND for the dead-registry bug, not the '
-            'fix. Make the base implementation _eventPlane-correct instead.');
-    expect(session.contains('StreamController'), isFalse,
-        reason: 'NomosSession holds StreamController state of its own — '
-            'event state belongs on the plane (_eventPlane)');
+  test('NomosSession constructs a view of its parent, not another plane', () {
+    expect(session, contains('super._view(parent)'));
+    expect(session, isNot(contains('super._view(parent._transport)')));
+    expect(session, isNot(contains('StreamController')));
+    expect(session, isNot(contains('NmsRuntimeV2Gateway(')));
+    expect(session, isNot(contains('NmsObservedSessionDirectory')));
   });
 
-  test('the session seam chases to the root plane', () {
+  test('the session event-plane seam chases to the root', () {
     expect(
-        RegExp(r'NomosBridge get _eventPlane => parent\._eventPlane;')
-            .hasMatch(session),
-        isTrue,
-        reason: 'NomosSession._eventPlane must be parent._eventPlane (not '
-            'parent) so nested delegation stays correct');
+      RegExp(r'DartReception get _eventPlane => parent\._eventPlane;')
+          .hasMatch(session),
+      isTrue,
+    );
   });
 }

package/dart/test/extremum_read_test.dart

@@ -0,0 +1,58 @@
+import 'package:fixnum/fixnum.dart';
+import 'package:nomos_client/src/reception/extremum_read.dart';
+import 'package:nomos_types/nomos_kernel_protocol.dart' as protocol;
+import 'package:test/test.dart';
+
+protocol.QueryResponse result(protocol.NomosValue? value, {bool ok = true}) =>
+    protocol.QueryResponse(
+        value: protocol.NomosValue(
+            object: protocol.NomosStruct(
+                fields: {
+      'ok': protocol.NomosValue(boolean: ok),
+      if (value != null) 'value': value,
+    }.entries)));
+
+void main() {
+  test('fixed extremum query carries its declaration, kind and exact group',
+      () {
+    final query = extremumQuery('minimum', 'min', '');
+    expect(query.named.operation,
+        protocol.QueryOperation.QUERY_OPERATION_EXTREMUM);
+    expect(query.named.arguments.fields['extremumId']!.text, 'minimum');
+    expect(query.named.arguments.fields['kind']!.text, 'min');
+    expect(query.named.arguments.fields['groupKey']!.text, '');
+    expect(() => extremumQuery('', 'min', null), throwsArgumentError);
+    expect(() => extremumQuery('minimum', 'other', null), throwsArgumentError);
+  });
+
+  test('null and zero differ; signed extrema remain exact', () {
+    expect(extremumValue(result(protocol.NomosValue(null_1: protocol.Null()))),
+        isNull);
+    for (final value in [0, -7, 9, -9007199254740991, 9007199254740991]) {
+      final wire = value < 0
+          ? protocol.NomosValue(signedInteger: Int64(value))
+          : protocol.NomosValue(unsignedInteger: Int64(value));
+      expect(extremumValue(result(wire)), value);
+    }
+  });
+
+  test('missing, refused, malformed and unsafe values never become null', () {
+    for (final value in [
+      null,
+      protocol.NomosValue(),
+      protocol.NomosValue(text: '7'),
+      protocol.NomosValue(floatingPoint: 1.5),
+      protocol.NomosValue(boolean: false),
+      protocol.NomosValue(signedInteger: Int64(-9007199254740992)),
+      protocol.NomosValue(unsignedInteger: Int64(9007199254740992)),
+      protocol.NomosValue(unsignedInteger: Int64(-1))
+    ]) {
+      expect(() => extremumValue(result(value)), throwsStateError);
+    }
+    expect(
+        () => extremumValue(
+            result(protocol.NomosValue(null_1: protocol.Null()), ok: false)),
+        throwsStateError);
+    expect(() => extremumValue(protocol.QueryResponse()), throwsStateError);
+  });
+}

package/dart/test/fixtures/wedge/wedge-entry.mjs

@@ -1,22 +1,4 @@
 #!/usr/bin/env node
-// A WEDGING FAKE RUNNER for the hermetic HARNESS PHASE-TIMEOUT tests: speaks the NDJSON bridge protocol,
-// answers everything — EXCEPT the op named in NOMOS_WEDGE_OP (optionally only when the args carry an
-// authorSecret, i.e. the 3b keyed reconnect), which it swallows FOREVER. This forges the exact "silent
-// hang" co2 reported so the harness's typed HarnessPhaseTimeout can be asserted without a real wait.
-import { createInterface } from "node:readline";
-const post = (msg) => process.stdout.write(JSON.stringify(msg) + "\n");
-const wedgeOp = process.env.NOMOS_WEDGE_OP || "connect"; // default: wedge the KEYED reconnect (co2's shape)
-const wedgeOnlyKeyed = process.env.NOMOS_WEDGE_ONLY_KEYED !== "0";
-post({ v: 1, event: "ready", bundleVersion: "unbundled-dev" });
-const rl = createInterface({ input: process.stdin, crlfDelay: Infinity });
-rl.on("line", (line) => {
-  const s = line.trim();
-  if (!s) return;
-  let msg; try { msg = JSON.parse(s); } catch { return; }
-  const a = msg.args || {};
-  if (msg.op === wedgeOp && (!wedgeOnlyKeyed || a.authorSecret)) return; // THE WEDGE: never answer
-  if (msg.op === "authorKeygen") return post({ v: 1, id: msg.id, ok: true, result: { secret: "c2VjcmV0", public: "cHVibGlj" } });
-  if (msg.op === "connect") return post({ v: 1, id: msg.id, ok: true, result: { workspace: a.workspace, session: a.session } });
-  post({ v: 1, id: msg.id, ok: true, result: {} });
-});
-rl.on("close", () => process.exit(0));
+// A physical Platform Shell which deliberately never announces Runtime v2
+// readiness. It contains no alternate protocol or fake workspace lifecycle.
+process.stdin.resume();

package/dart/test/generated_query_test.dart

@@ -0,0 +1,32 @@
+import 'dart:typed_data';
+import 'package:nomos_client/src/generated_call.dart';
+import 'package:test/test.dart';
+
+void main() {
+  test(
+      'no-argument generated queries retain their nominal type with zero bytes',
+      () {
+    final query = NmsInternalGeneratedQueries.create(
+        domain: 'test',
+        query: 'first',
+        protobufType: 'type.nomos.dev/nomos.operation.v1.Query_1',
+        protobufPayload: Uint8List(0));
+    expect(query.protobufPayload, isEmpty);
+    expect(query.query, 'first');
+    expect(query.protobufType, 'type.nomos.dev/nomos.operation.v1.Query_1');
+    expect(
+        () => NmsInternalGeneratedQueries.create(
+            domain: '',
+            query: 'first',
+            protobufType: query.protobufType,
+            protobufPayload: Uint8List(0)),
+        throwsArgumentError);
+    expect(
+        () => NmsInternalGeneratedQueries.create(
+            domain: 'test',
+            query: 'first',
+            protobufType: '',
+            protobufPayload: Uint8List(0)),
+        throwsArgumentError);
+  });
+}

package/dart/test/harness_phase_timeout_test.dart

@@ -1,8 +1,7 @@
 // NO SILENT HANGS — the harness's per-phase deadline machinery, proven HERMETICALLY (no real waits, no
-// wasm, no network): a fake runner (test/fixtures/wedge/wedge-entry.mjs) speaks the bridge protocol but
-// SWALLOWS the 3b keyed reconnect forever — the exact wedge co2 reported. With a short `phaseTimeout` the
-// harness must throw the TYPED [HarnessPhaseTimeout] naming the phase/workspace/op, never hang; and the
-// failed construction must tear the runner down by itself (no leaked process holding the test runner).
+// wasm, no network): a fake Platform Shell never announces Runtime v2 readiness.
+// With a short `phaseTimeout` the harness must throw the typed
+// [HarnessPhaseTimeout], never hang, and tear the process down itself.
 @TestOn('vm')
 @Timeout(Duration(seconds: 60))
 library;
@@ -14,44 +13,41 @@ import 'package:test/test.dart';
 
 String get _fixtures => '${Directory.current.path}/test/fixtures/wedge';
 String get _wedgeEntry => '$_fixtures/wedge-entry.mjs';
-String get _fakeInstall => '$_fixtures/fake-install.mjs';
 
 void main() {
-  test('a wedged keyed reconnect fires HarnessPhaseTimeout naming phase 3b (typed, no hang)', () async {
+  test('a Platform Shell readiness wedge is typed and bounded', () async {
     final log = <String>[];
     Object? err;
     try {
       await NomosTestHarness.cluster(
         workspaces: {
-          'catalogue': ['unused.law.usdz'], // the fake install helper ignores the paths
+          'catalogue': ['unused.law.usdz'],
         },
-        deviceKeyed: {'catalogue'},
         nodeEntry: _wedgeEntry,
-        installHelper: _fakeInstall,
-        phaseTimeout: const Duration(seconds: 2), // hermetic: a short deadline, not a real 120s wait
+        runtimeDir: _fixtures,
+        phaseTimeout: const Duration(seconds: 2),
         onDiagnostic: log.add,
       );
     } catch (e) {
       err = e;
     }
     expect(err, isA<HarnessPhaseTimeout>(),
-        reason: 'the wedge must surface as the typed phase timeout, never an eternal await');
+        reason:
+            'the wedge must surface as the typed phase timeout, never an eternal await');
     final t = err as HarnessPhaseTimeout;
-    expect(t.phase, "3b: keyed reconnect of 'catalogue'");
-    expect(t.workspace, 'catalogue');
-    expect(t.awaiting, 'connect');
+    expect(t.phase, '1/2: open canonical test peer');
+    expect(t.workspace, isNull);
+    expect(t.awaiting, 'Peer Office + filesystem Git custody');
     expect(t.elapsed, const Duration(seconds: 2));
-    expect(t.likelyCauses, isNotEmpty, reason: 'known wedges carry their likely causes');
     expect(t, isA<NomosTestHarnessException>(),
         reason: 'existing on-NomosTestHarnessException handling keeps working');
-    expect(t.toString(), contains("3b: keyed reconnect of 'catalogue'"));
-    // ask 5 — the phases before the wedge logged enter AND exit; the wedged phase logged its enter.
-    expect(log.any((l) => l.contains('3: connect session') && l.contains('done')), isTrue);
-    expect(log.any((l) => l.contains('3b: device keygen') && l.contains('done')), isTrue);
-    expect(log.any((l) => l.contains("3b: keyed reconnect of 'catalogue'")), isTrue);
+    expect(t.toString(), contains('1/2: open canonical test peer'));
+    expect(log.any((line) => line.contains('1/2: open canonical test peer')),
+        isTrue);
   });
 
-  test('deviceKeyed naming an unknown workspace refuses typed (never a wedge)', () async {
+  test('deviceKeyed naming an unknown workspace refuses typed (never a wedge)',
+      () async {
     Object? err;
     try {
       await NomosTestHarness.cluster(
@@ -59,8 +55,7 @@ void main() {
           'catalogue': ['unused.law.usdz'],
         },
         deviceKeyed: {'not-a-workspace'},
-        nodeEntry: _wedgeEntry,
-        installHelper: _fakeInstall,
+        nodeEntry: '/unused-because-validation-is-pure',
         phaseTimeout: const Duration(seconds: 5),
       );
     } catch (e) {