@girardelli/architect 5.0.0 → 8.1.0

package/tests/github-action.test.ts

@@ -0,0 +1,109 @@
+import { jest } from '@jest/globals';
+import { AnalysisReport } from '@girardelli/architect-core/src/core/types/core.js';
+import { ValidationResult } from '@girardelli/architect-core/src/core/types/architect-rules.js';
+
+// Mock dependencies
+jest.unstable_mockModule('@actions/core', () => ({
+  info: jest.fn(),
+  error: jest.fn(),
+}));
+
+  // @ts-ignore
+  const createCommentMock = jest.fn().mockResolvedValue({});
+  jest.unstable_mockModule('@actions/github', () => ({
+    context: {
+      repo: { owner: 'test', repo: 'test-repo' },
+      payload: {
+        pull_request: {
+          number: 42,
+          base: { ref: 'main' }
+        }
+      }
+    },
+    getOctokit: jest.fn().mockReturnValue({
+      rest: {
+        issues: {
+          createComment: createCommentMock
+        }
+      }
+    })
+  }));
+
+describe('GithubActionAdapter', () => {
+  let adapter: any;
+  let mockHeadReport: AnalysisReport;
+  let mockBaseReport: AnalysisReport;
+  let mockValidation: ValidationResult;
+
+  beforeAll(async () => {
+    const { GithubActionAdapter } = await import('../src/adapters/github-action.js');
+    adapter = new GithubActionAdapter('fake-token');
+  });
+
+  beforeEach(() => {
+    jest.clearAllMocks();
+    
+    mockHeadReport = {
+      timestamp: new Date().toISOString(),
+      projectInfo: { path: '.', name: 'Test', frameworks: [], primaryLanguages: [], totalFiles: 10, totalLines: 100 },
+      score: {
+        overall: 80,
+        components: [],
+        breakdown: { modularity: 80, coupling: 80, cohesion: 80, layering: 80 },
+      },
+      antiPatterns: [
+        { name: 'God Class', severity: 'HIGH', location: 'file.ts', description: 'desc', suggestion: 'sugg' }
+      ],
+      layers: [],
+      dependencyGraph: { nodes: [], edges: [] },
+      suggestions: [],
+      diagram: { mermaid: '', type: 'component' }
+    };
+
+    mockBaseReport = JSON.parse(JSON.stringify(mockHeadReport));
+    mockBaseReport.score.overall = 85;
+
+    mockValidation = {
+      success: false,
+      violations: [
+        { level: 'error', rule: 'min_overall_score', message: 'Score too low', actual: 80, expected: 90 }
+      ]
+    };
+  });
+
+  it('should post comment with positive delta', async () => {
+    mockBaseReport.score.overall = 75; // improved by 5
+    await adapter.postComment(mockHeadReport, mockBaseReport);
+    
+    expect(createCommentMock).toHaveBeenCalledWith(expect.objectContaining({
+      issue_number: 42,
+      body: expect.stringContaining('📈 **+5** (Improved from 75)')
+    }));
+  });
+
+  it('should post comment with negative delta', async () => {
+    mockBaseReport.score.overall = 85; // dropped by 5
+    await adapter.postComment(mockHeadReport, mockBaseReport);
+    
+    expect(createCommentMock).toHaveBeenCalledWith(expect.objectContaining({
+      issue_number: 42,
+      body: expect.stringContaining('📉 **-5** (Regressed from 85)')
+    }));
+  });
+
+  it('should output validation errors in the comment', async () => {
+    await adapter.postComment(mockHeadReport, mockBaseReport, mockValidation);
+    
+    const callArgs = createCommentMock.mock.calls[0][0] as any;
+    expect(callArgs.body).toContain('❌ **Quality Gates Failed!**');
+    expect(callArgs.body).toContain('`min_overall_score`');
+  });
+
+  it('should list anti-patterns in the report', async () => {
+    await adapter.postComment(mockHeadReport, null);
+    
+    const callArgs = createCommentMock.mock.calls[0][0] as any;
+    expect(callArgs.body).toContain('### ⚠️ Anti-Patterns Detected');
+    expect(callArgs.body).toContain('God Class');
+  });
+});

package/tsconfig.json

@@ -1,24 +1,17 @@
 {
+  "extends": "../../tsconfig.base.json",
   "compilerOptions": {
-    "target": "ES2020",
-    "module": "ES2020",
-    "lib": ["ES2020"],
-    "moduleResolution": "bundler",
     "outDir": "./dist",
-    "rootDir": "./src",
-    "strict": true,
-    "esModuleInterop": true,
-    "skipLibCheck": true,
-    "forceConsistentCasingInFileNames": true,
-    "resolveJsonModule": true,
-    "declaration": true,
-    "declarationMap": true,
-    "sourceMap": true,
-    "noUnusedLocals": false,
-    "noUnusedParameters": false,
-    "noImplicitReturns": true,
-    "noFallthroughCasesInSwitch": true
+    "rootDir": "./"
   },
-  "include": ["src/**/*"],
-  "exclude": ["node_modules", "dist", "tests"]
+  "include": ["src/**/*", "tests/**/*"],
+  "exclude": ["node_modules", "dist"],
+  "references": [
+    {
+      "path": "../architect-core"
+    },
+    {
+      "path": "../architect-agents"
+    }
+  ]
 }

package/CONTRIBUTING.md

@@ -1,140 +0,0 @@
-# Contributing to Architect
-
-Thank you for considering a contribution to Architect! This document provides guidelines and instructions for contributing.
-
-## Code of Conduct
-
-- Be respectful and inclusive
-- Welcome people of all backgrounds and experience levels
-- Focus on constructive feedback
-- Assume good intent
-
-## Getting Started
-
-1. Fork the repository
-2. Clone your fork: `git clone https://github.com/yourusername/architect.git`
-3. Install dependencies: `npm install`
-4. Create a feature branch: `git checkout -b feature/your-feature-name`
-
-## Development
-
-### Build
-
-```bash
-npm run build
-```
-
-### Test
-
-```bash
-npm test
-npm run test:watch
-```
-
-### Linting
-
-```bash
-npm run lint
-```
-
-## Commit Guidelines
-
-- Use clear, descriptive commit messages
-- Reference issues when applicable: "Fixes #123"
-- Keep commits focused on a single change
-- Use present tense: "Add feature" not "Added feature"
-
-## Pull Request Process
-
-1. Update documentation for any new features
-2. Add or update tests for your changes
-3. Ensure all tests pass: `npm test`
-4. Ensure linting passes: `npm run lint`
-5. Write a clear PR description:
-   - What problem does this solve?
-   - How does it solve the problem?
-   - Are there any breaking changes?
-
-## Architecture Guidelines
-
-The codebase follows a modular architecture with clear separation of concerns:
-
-- **Scanner**: Project discovery and analysis
-- **Analyzer**: Dependency and layer analysis
-- **Anti-Pattern Detector**: Code quality issues
-- **Scorer**: Quantitative evaluation
-- **Diagram Generator**: Visualization
-- **Reporter**: Output formatting
-
-Maintain these boundaries when adding new features.
-
-## Adding New Anti-Patterns
-
-To add a new anti-pattern detector:
-
-1. Add detection logic to `src/anti-patterns.ts`
-2. Add unit tests in `tests/anti-patterns.test.ts`
-3. Update README.md with the new pattern
-4. Update sample report if needed
-
-Example:
-
-```typescript
-private detectNewPattern(node: FileNode): AntiPattern[] {
-  const patterns: AntiPattern[] = [];
-  // Detection logic
-  return patterns;
-}
-```
-
-## Reporting Bugs
-
-Use GitHub Issues with:
-
-- Clear title describing the bug
-- Steps to reproduce
-- Expected vs actual behavior
-- TypeScript/Node version
-- Operating system
-
-## Feature Requests
-
-Describe:
-
-- Problem statement (what is missing?)
-- Proposed solution
-- Alternative solutions considered
-- Examples or use cases
-
-## Documentation
-
-- Update README.md for user-facing changes
-- Add JSDoc comments to new functions
-- Include examples for new features
-- Keep comments current with code changes
-
-## Areas for Contribution
-
-- New anti-pattern detectors
-- Improved dependency graph analysis
-- Additional diagram types
-- Better framework detection
-- Performance optimizations
-- Test coverage expansion
-- Documentation improvements
-- Example projects
-
-## Questions?
-
-- Open a GitHub Discussion
-- Check existing issues
-- Read the documentation
-- Contact the maintainers
-
-## License
-
-By contributing, you agree that your contributions will be licensed under the MIT License.
-
----
-
-Thank you for helping make Architect better!

package/LICENSE

@@ -1,21 +0,0 @@
-MIT License
-
-Copyright (c) 2026 Camilo Girardelli, Girardelli Tecnologia
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all
-copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.

package/PROJECT_STRUCTURE.txt

@@ -1,168 +0,0 @@
-ARCHITECT - AI-Powered Architecture Analysis Plugin
-===================================================
-
-Complete GitHub Repository Structure
-
-REPOSITORY ROOT
-/sessions/stoic-keen-sagan/mnt/outputs/repos/architect/
-
-FILES CREATED:
-==============
-
-Configuration & Documentation:
-  - README.md (viral-quality, 200+ lines)
-  - LICENSE (MIT 2026, Camilo Girardelli)
-  - .gitignore (Node.js standard)
-  - CONTRIBUTING.md (contribution guidelines)
-  - .architect.json (default configuration)
-  - package.json (complete with scripts and deps)
-  - tsconfig.json (strict TypeScript)
-  - PROJECT_STRUCTURE.txt (this file)
-
-Source Code (src/ directory, 1,500+ lines):
-  - index.ts (40 lines) - Plugin entry point, command registration
-  - types.ts (80 lines) - All TypeScript interfaces
-  - config.ts (60 lines) - Configuration loader
-  - scanner.ts (150 lines) - ProjectScanner class
-  - analyzer.ts (200 lines) - ArchitectureAnalyzer class
-  - anti-patterns.ts (180 lines) - AntiPatternDetector class
-  - scorer.ts (130 lines) - ArchitectureScorer class
-  - diagram.ts (140 lines) - DiagramGenerator class
-  - reporter.ts (130 lines) - ReportGenerator class
-
-Tests (tests/ directory, 105 lines):
-  - scanner.test.ts (35 lines)
-  - anti-patterns.test.ts (40 lines)
-  - scorer.test.ts (30 lines)
-
-Examples:
-  - examples/sample-report.md (complete sample analysis output)
-
-ARCHITECTURE COMPONENTS:
-========================
-
-Scanner Agent (src/scanner.ts)
-  - Project directory traversal
-  - File type identification
-  - Line counting
-  - Framework detection (React, Angular, Spring Boot, Express, Django, etc.)
-  - File tree building with glob patterns
-
-Analyzer Agent (src/analyzer.ts)
-  - Import/dependency parsing (JS/TS/Python/Java)
-  - Dependency graph construction
-  - Layer detection (API/Service/Data/UI/Infrastructure)
-  - Module boundary identification
-
-Anti-Pattern Detector (src/anti-patterns.ts)
-  - God Class detection (500+ lines, 10+ methods)
-  - Circular Dependency detection (DFS algorithm)
-  - Leaky Abstraction detection (internal types exported)
-  - Feature Envy detection (external method usage ratio)
-  - Shotgun Surgery detection (change propagation)
-
-Scorer (src/scorer.ts)
-  - Modularity scoring (40% weight)
-  - Coupling analysis (25% weight)
-  - Cohesion evaluation (20% weight)
-  - Layering compliance (15% weight)
-  - 0-100 score calculation
-
-Diagram Generator (src/diagram.ts)
-  - Component diagram (Mermaid)
-  - Layer diagram (Mermaid)
-  - Dependency flow diagram (Mermaid)
-  - Color-coded by layer
-
-Reporter (src/reporter.ts)
-  - Markdown report generation
-  - Project summary
-  - Score sections
-  - Anti-patterns listing
-  - Layer visualization
-  - Refactoring suggestions
-  - Diagram embedding
-
-FEATURES INCLUDED:
-==================
-
-Architecture Commands:
-  - architect analyze [path] - Full analysis
-  - architect diagram [path] - Diagram only
-  - architect score [path] - Score only
-  - architect anti-patterns [path] - Anti-patterns only
-  - architect layers [path] - Layer distribution
-
-Export Formats:
-  - Mermaid diagrams
-  - JSON data
-  - Markdown reports
-
-Configuration:
-  - .architect.json with custom thresholds
-  - Ignore patterns
-  - Framework detection toggle
-  - Score weight customization
-
-Anti-Patterns Detected:
-  - God Class
-  - Circular Dependencies
-  - Leaky Abstractions
-  - Feature Envy
-  - Shotgun Surgery
-
-QUALITY METRICS:
-================
-
-Code Statistics:
-  - Total lines: 1,812 (src + tests)
-  - Source files: 9 modules
-  - Test files: 3 suites
-  - Type definitions: 15 interfaces
-  - Classes: 7
-
-Code Quality:
-  - 100% TypeScript with strict mode
-  - Comprehensive type safety
-  - Functional, well-documented code
-  - Real parsing logic (not stubs)
-  - Production-ready quality
-
-DEPENDENCIES:
-==============
-
-Core Dependencies:
-  - glob ^10.3.10 (file scanning)
-  - acorn ^8.11.0 (JS parsing)
-
-Development Dependencies:
-  - TypeScript ^5.3.0
-  - Jest ^29.7.0 (testing)
-  - ESLint ^8.55.0 (linting)
-  - ts-jest ^29.1.1 (TS test support)
-
-AUTHOR:
-=======
-
-Camilo Girardelli
-- IEEE Senior Member
-- Senior Software Architect
-- CTO at Girardelli Tecnologia
-- GitHub: @camilogivago
-- LinkedIn: Camilo Girardelli
-
-LICENSE: MIT 2026
-
-GETTING STARTED:
-================
-
-1. npm install
-2. npm run build
-3. npm test
-4. npm run dev (watch mode)
-
-Ready for:
-- Publication to npm as @girardelli/architect
-- Integration into Claude Code
-- Open source contribution
-- Enterprise use