@girardelli/architect 2.2.0 → 5.0.0

package/src/scanner.ts

@@ -1,7 +1,7 @@
 import { globSync } from 'glob';
-import { readFileSync, lstatSync } from 'fs';
-import { join, relative, extname } from 'path';
-import { FileNode, ProjectInfo, ArchitectConfig } from './types.js';
+import { readFileSync, lstatSync, existsSync } from 'fs';
+import { join, relative, extname, resolve } from 'path';
+import { FileNode, ProjectInfo, ArchitectConfig, WorkspaceInfo } from './types.js';
 
 export class ProjectScanner {
   private projectPath: string;
@@ -17,14 +17,19 @@ export class ProjectScanner {
     const files = this.scanDirectory();
     const fileTree = this.buildFileTree(files);
 
-    // Detect frameworks from scanned files AND parent package.json
-    const parentPackageJsons = this.findParentPackageJsons();
-    const allFilesForDetection = [...files, ...parentPackageJsons];
-    const frameworks = this.detectFrameworks(allFilesForDetection);
+    // Detect workspaces from root package.json
+    const workspaces = this.detectWorkspaces();
 
+    // Detect frameworks ONLY from root + workspace package.json files (never from node_modules)
+    const workspacePkgJsonPaths = [
+      join(this.projectPath, 'package.json'),
+      ...workspaces.map(ws => join(ws.path, 'package.json')),
+    ].filter(p => existsSync(p));
+
+    const frameworks = this.detectFrameworks(workspacePkgJsonPaths);
     const languages = this.detectLanguages(files);
     const totalLines = this.countTotalLines(files);
-    const projectName = this.resolveProjectName(parentPackageJsons);
+    const projectName = this.resolveProjectName(workspacePkgJsonPaths);
 
     return {
       path: this.projectPath,
@@ -34,31 +39,66 @@ export class ProjectScanner {
       totalLines,
       primaryLanguages: languages,
       fileTree,
+      workspaces: workspaces.length > 0 ? workspaces : undefined,
     };
   }
 
   /**
-   * Walk up directory tree to find package.json files for project name and framework detection
+   * Detect npm/yarn/pnpm workspaces from root package.json.
+   * Reads the "workspaces" field and resolves each workspace to its package.json.
    */
-  private findParentPackageJsons(): string[] {
-    const found: string[] = [];
-    let dir = this.projectPath;
-    const root = '/';
-    let depth = 0;
-
-    while (dir !== root && depth < 5) {
-      const pkgPath = join(dir, 'package.json');
-      try {
-        readFileSync(pkgPath, 'utf-8');
-        found.push(pkgPath);
-      } catch {
-        // no package.json here
+  private detectWorkspaces(): WorkspaceInfo[] {
+    const rootPkgPath = join(this.projectPath, 'package.json');
+    if (!existsSync(rootPkgPath)) return [];
+
+    try {
+      const rootPkg = JSON.parse(readFileSync(rootPkgPath, 'utf-8'));
+      let workspaceGlobs: string[] = [];
+
+      if (Array.isArray(rootPkg.workspaces)) {
+        workspaceGlobs = rootPkg.workspaces;
+      } else if (rootPkg.workspaces?.packages && Array.isArray(rootPkg.workspaces.packages)) {
+        workspaceGlobs = rootPkg.workspaces.packages;
+      }
+
+      if (workspaceGlobs.length === 0) return [];
+
+      const workspaces: WorkspaceInfo[] = [];
+
+      for (const pattern of workspaceGlobs) {
+        // Resolve glob patterns like "packages/*"
+        const dirs = globSync(pattern, {
+          cwd: this.projectPath,
+          absolute: true,
+        });
+
+        for (const dir of dirs) {
+          const pkgPath = join(dir, 'package.json');
+          if (!existsSync(pkgPath)) continue;
+
+          try {
+            const pkg = JSON.parse(readFileSync(pkgPath, 'utf-8'));
+            workspaces.push({
+              name: pkg.name || relative(this.projectPath, dir),
+              path: dir,
+              relativePath: relative(this.projectPath, dir),
+              description: pkg.description || '',
+              version: pkg.version || '0.0.0',
+              dependencies: pkg.dependencies || {},
+              devDependencies: pkg.devDependencies || {},
+              bin: pkg.bin || undefined,
+              main: pkg.main || undefined,
+            });
+          } catch {
+            // Skip unparseable package.json
+          }
+        }
       }
-      dir = join(dir, '..');
-      depth++;
-    }
 
-    return found;
+      return workspaces;
+    } catch {
+      return [];
+    }
   }
 
   /**
@@ -81,7 +121,6 @@ export class ProjectScanner {
 
   private scanDirectory(): string[] {
     const ignorePatterns = this.config.ignore || [];
-    const negatedPatterns = ignorePatterns.map((p) => `!**/${p}/**`);
 
     const files = globSync('**/*', {
       cwd: this.projectPath,
@@ -167,82 +206,89 @@ export class ProjectScanner {
     return root;
   }
 
-  private detectFrameworks(files: string[]): Set<string> {
+  /**
+   * Detect frameworks ONLY from specified package.json files.
+   * Never reads package.json from node_modules.
+   * No string-matching fallback — only structured dependency key detection.
+   */
+  private detectFrameworks(packageJsonPaths: string[]): Set<string> {
     const frameworks = new Set<string>();
 
-    for (const file of files) {
-      if (file.endsWith('package.json')) {
-        try {
-          const content = readFileSync(file, 'utf-8');
-          const parsed = JSON.parse(content);
-          const allDeps = {
-            ...parsed.dependencies,
-            ...parsed.devDependencies,
-          };
+    for (const file of packageJsonPaths) {
+      if (!file.endsWith('package.json')) continue;
 
-          // Detect from actual dependency keys
-          if (allDeps['@nestjs/core'] || allDeps['@nestjs/common']) frameworks.add('NestJS');
-          if (allDeps['react'] || allDeps['react-dom']) frameworks.add('React');
-          if (allDeps['@angular/core']) frameworks.add('Angular');
-          if (allDeps['vue'] || allDeps['@vue/core']) frameworks.add('Vue.js');
-          if (allDeps['express']) frameworks.add('Express.js');
-          if (allDeps['next']) frameworks.add('Next.js');
-          if (allDeps['fastify']) frameworks.add('Fastify');
-          if (allDeps['typeorm']) frameworks.add('TypeORM');
-          if (allDeps['prisma'] || allDeps['@prisma/client']) frameworks.add('Prisma');
-          if (allDeps['sequelize']) frameworks.add('Sequelize');
-          if (allDeps['mongoose']) frameworks.add('Mongoose');
-        } catch {
-          // Fallback: simple string matching
-          try {
-            const content = readFileSync(file, 'utf-8');
-            if (content.includes('@nestjs')) frameworks.add('NestJS');
-            if (content.includes('react')) frameworks.add('React');
-            if (content.includes('angular')) frameworks.add('Angular');
-            if (content.includes('vue')) frameworks.add('Vue.js');
-            if (content.includes('express')) frameworks.add('Express.js');
-            if (content.includes('next')) frameworks.add('Next.js');
-          } catch {
-            // skip
-          }
-        }
-      }
+      // Safety: skip any path that includes node_modules
+      if (file.includes('node_modules')) continue;
 
-      if (file.includes('pom.xml')) {
-        try {
-          const content = readFileSync(file, 'utf-8');
-          if (content.includes('spring-boot')) frameworks.add('Spring Boot');
-          if (content.includes('spring')) frameworks.add('Spring');
-        } catch {
-          // skip
-        }
+      try {
+        const content = readFileSync(file, 'utf-8');
+        const parsed = JSON.parse(content);
+        const allDeps = {
+          ...parsed.dependencies,
+          ...parsed.devDependencies,
+        };
+
+        // Detect from actual dependency keys — no string fallback
+        if (allDeps['@nestjs/core'] || allDeps['@nestjs/common']) frameworks.add('NestJS');
+        if (allDeps['react'] || allDeps['react-dom']) frameworks.add('React');
+        if (allDeps['@angular/core']) frameworks.add('Angular');
+        if (allDeps['vue'] || allDeps['@vue/core']) frameworks.add('Vue.js');
+        if (allDeps['express']) frameworks.add('Express.js');
+        if (allDeps['next']) frameworks.add('Next.js');
+        if (allDeps['fastify']) frameworks.add('Fastify');
+        if (allDeps['typeorm']) frameworks.add('TypeORM');
+        if (allDeps['prisma'] || allDeps['@prisma/client']) frameworks.add('Prisma');
+        if (allDeps['sequelize']) frameworks.add('Sequelize');
+        if (allDeps['mongoose']) frameworks.add('Mongoose');
+        if (allDeps['@modelcontextprotocol/sdk']) frameworks.add('MCP SDK');
+        if (allDeps['probot']) frameworks.add('Probot');
+        if (allDeps['hono']) frameworks.add('Hono');
+      } catch {
+        // Skip unparseable files — NO fallback string matching
       }
+    }
 
-      if (file.includes('requirements.txt')) {
-        try {
-          const content = readFileSync(file, 'utf-8');
-          if (content.includes('django')) frameworks.add('Django');
-          if (content.includes('flask')) frameworks.add('Flask');
-          if (content.includes('fastapi')) frameworks.add('FastAPI');
-        } catch {
-          // skip
-        }
+    // Check for pom.xml only at project root
+    const pomPath = join(this.projectPath, 'pom.xml');
+    if (existsSync(pomPath)) {
+      try {
+        const content = readFileSync(pomPath, 'utf-8');
+        if (content.includes('spring-boot')) frameworks.add('Spring Boot');
+        if (content.includes('spring') && !content.includes('spring-boot')) frameworks.add('Spring');
+      } catch {
+        // skip
       }
+    }
 
-      if (file.includes('Gemfile')) {
-        try {
-          const content = readFileSync(file, 'utf-8');
-          if (content.includes('rails')) frameworks.add('Ruby on Rails');
-        } catch {
-          // skip
-        }
+    // Check for requirements.txt only at project root
+    const reqPath = join(this.projectPath, 'requirements.txt');
+    if (existsSync(reqPath)) {
+      try {
+        const content = readFileSync(reqPath, 'utf-8');
+        if (content.includes('django')) frameworks.add('Django');
+        if (content.includes('flask')) frameworks.add('Flask');
+        if (content.includes('fastapi')) frameworks.add('FastAPI');
+      } catch {
+        // skip
       }
+    }
 
-      if (file.includes('go.mod')) {
-        frameworks.add('Go');
+    // Check for Gemfile only at project root
+    const gemPath = join(this.projectPath, 'Gemfile');
+    if (existsSync(gemPath)) {
+      try {
+        const content = readFileSync(gemPath, 'utf-8');
+        if (content.includes('rails')) frameworks.add('Ruby on Rails');
+      } catch {
+        // skip
       }
     }
 
+    // Check for go.mod only at project root
+    if (existsSync(join(this.projectPath, 'go.mod'))) {
+      frameworks.add('Go');
+    }
+
     return frameworks;
   }
 

package/src/scorer.ts

@@ -24,7 +24,7 @@ export class ArchitectureScorer {
     this.calculateModularity(edges, totalFiles);
     this.calculateCoupling(edges, totalFiles);
     this.calculateCohesion(edges);
-    this.calculateLayering(antiPatterns);
+    this.calculateLayering(antiPatterns, totalFiles);
 
     const components = [
       {
@@ -213,7 +213,7 @@ export class ArchitectureScorer {
     return fromTopLevel === toTopLevel;
   }
 
-  private calculateLayering(antiPatterns: AntiPattern[]): void {
+  private calculateLayering(antiPatterns: AntiPattern[], totalFiles?: number): void {
     const layeringViolations = antiPatterns.filter(
       (p) =>
         p.name === 'Leaky Abstraction' ||
@@ -223,16 +223,31 @@ export class ArchitectureScorer {
 
     if (layeringViolations === 0) {
       this.layering = 95;
-    } else if (layeringViolations === 1) {
-      this.layering = 85;
-    } else if (layeringViolations === 2) {
-      this.layering = 70;
-    } else if (layeringViolations === 3) {
-      this.layering = 55;
-    } else if (layeringViolations <= 5) {
-      this.layering = 40;
+      return;
+    }
+
+    // Use ratio-based scoring: violations per 100 files
+    // This makes scoring fair regardless of project size
+    const fileCount = Math.max(totalFiles || 50, 10);
+    const violationRatio = layeringViolations / fileCount;
+
+    if (violationRatio < 0.02) {
+      // < 2% — e.g. 1 violation in 50 files
+      this.layering = 90;
+    } else if (violationRatio < 0.05) {
+      // < 5% — e.g. 2-3 violations in 50 files
+      this.layering = 80;
+    } else if (violationRatio < 0.1) {
+      // < 10% — e.g. 5 violations in 50 files
+      this.layering = 65;
+    } else if (violationRatio < 0.2) {
+      // < 20% — significant issues
+      this.layering = 50;
+    } else if (violationRatio < 0.35) {
+      this.layering = 35;
     } else {
-      this.layering = 25;
+      // > 35% — severe layering problems
+      this.layering = 20;
     }
   }
 }

package/src/types.ts

@@ -52,6 +52,18 @@ export interface ArchitectureScore {
   };
 }
 
+export interface WorkspaceInfo {
+  name: string;
+  path: string;
+  relativePath: string;
+  description: string;
+  version: string;
+  dependencies: Record<string, string>;
+  devDependencies: Record<string, string>;
+  bin?: Record<string, string>;
+  main?: string;
+}
+
 export interface ProjectInfo {
   path: string;
   name: string;
@@ -60,6 +72,7 @@ export interface ProjectInfo {
   totalLines: number;
   primaryLanguages: string[];
   fileTree?: FileNode;
+  workspaces?: WorkspaceInfo[];
 }
 
 export interface AnalysisReport {
@@ -82,6 +95,16 @@ export interface AnalysisReport {
     mermaid: string;
     type: 'component' | 'layer' | 'dependency';
   };
+  projectSummary?: ProjectSummary;
+}
+
+export interface ProjectSummary {
+  description: string;
+  purpose: string;
+  modules: { name: string; files: number; description: string }[];
+  techStack: string[];
+  entryPoints: string[];
+  keywords: string[];
 }
 
 export interface ArchitectConfig {
@@ -104,6 +127,10 @@ export interface ArchitectConfig {
     cohesion?: number;
     layering?: number;
   };
+  monorepo?: {
+    enabled?: boolean;
+    treatPackagesAsModules?: boolean;
+  };
 }
 
 export interface ParsedImport {