@giamme/forge 0.10.0 → 0.11.0

package/ui/forge_ui/static/runmodel.js

@@ -113,7 +113,9 @@
     if (f.model && !list(run.models).some(m => alias(m) === f.model)) return false;
     if (f.ageDays && num(now) !== null && !(num(run.updated) !== null && run.updated >= now - f.ageDays * 86400)) return false;
     if (f.verdict) {
-      const v = run.final_review || run.verification_status || null;
+      // An outdated published review matches OUTDATED, not the verdict it gave.
+      const review = runReviewStatus(run);
+      const v = review != null ? review : (run.verification_status || null);
       if (f.verdict === 'none' ? v : v !== f.verdict) return false;
     }
     return true;
@@ -180,16 +182,116 @@
     if (statuses.some(s => s === 'PENDING' || s === 'PASS')) return 'PENDING';
     return 'BLOCKED';
   }
+  // How one final review reads as a stage. OUTDATED only once it is done and the reader says the
+  // integration branch has moved: a running review, and a review the reader still calls current, keep their verdict.
+  function finalStatus(fr) {
+    if (!fr || typeof fr !== 'object') return null;
+    if (fr.state === 'running') return 'RUNNING';
+    if (fr.state === 'infra') return 'INFRA';
+    if (fr.state === 'done' && fr.outdated === true) return 'OUTDATED';
+    return fr.verdict || 'UNKNOWN';
+  }
+  // RunSummary carries the published verdict as a string plus final_review_outdated. Same rule as finalStatus.
+  function runReviewStatus(summary) {
+    if (!summary) return null;
+    const v = summary.final_review;
+    if (v && typeof v === 'object') return finalStatus(v);
+    if (typeof v !== 'string' || !v) return null;
+    return summary.final_review_outdated === true ? 'OUTDATED' : v;
+  }
+  // The lamp and status word for a task. Accepting a merge does not change the recorded status
+  // or the run's counts: only the display says ACCEPTED, and only once the task has merged.
+  function taskStatus(t) {
+    if (!t) return 'PENDING';
+    if (t.status === 'MERGED' && t.accepted === true) return 'ACCEPTED';
+    return t.status || 'PENDING';
+  }
+  // Verdict column and the 2D graph's tick or cross. text is the words, status the lamp class,
+  // mark the cross (FAIL) or tick (PASS). An acceptance names FAIL or UNKNOWN and never invents a FAIL,
+  // and it draws no mark: the graph must not put a red cross on a task a human accepted.
+  function taskVerdict(t) {
+    if (taskStatus(t) === 'ACCEPTED') {
+      const over = t.accepted_over === 'FAIL' || t.accepted_over === 'UNKNOWN' ? t.accepted_over : null;
+      return { text: over ? over + ' · accepted' : 'accepted', status: 'accepted', mark: null };
+    }
+    const v = t && t.verdict ? String(t.verdict) : null;
+    return { text: v, status: v ? v.toLowerCase() : 'unknown', mark: v === 'PASS' || v === 'FAIL' ? v : null };
+  }
+  // One attempt in the history. The attempt that was accepted is ACCEPTED; every earlier attempt
+  // keeps the status it ended with. execStatus itself is unchanged, so a QA part still shows the
+  // reviewer's verdict and an execution detail does too.
+  function attemptStatus(task, attempt, raw) {
+    if (taskStatus(task) !== 'ACCEPTED') return raw;
+    const n = num(attempt), want = num(task.accepted_attempt);
+    if (n !== null && want !== null && n === want) return 'ACCEPTED';
+    return raw;
+  }
+  function shortTip(tip) {
+    if (tip === null || tip === undefined || tip === '') return '—';
+    return String(tip).slice(0, 7);
+  }
+  // "<verdict> at <tip7>; N tasks merged since: <ids>", ids cut after 5.
+  function reviewSinceLine(src) {
+    if (!src) return '';
+    const ids = list(src.merged_since).map(id => String(id));
+    const shown = ids.slice(0, 5), extra = ids.length - shown.length;
+    const names = shown.join(', ') + (extra > 0 ? ' +' + extra + ' more' : '');
+    const n = ids.length;
+    return `${src.verdict || 'UNKNOWN'} at ${shortTip(src.tip)}; ${n} ${n === 1 ? 'task' : 'tasks'} merged since` + (names ? ': ' + names : '');
+  }
+  // The newest final review that had started by t. Same pick stateAt has always made.
+  function reviewAt(run, t) {
+    const started = r => num(r && r.started) ?? num(r && r.at);
+    const fr = list(run && run.final_reviews).filter(r => r && (started(r) ?? Infinity) <= t);
+    return fr.sort((a, b) => (a.at || 0) - (b.at || 0)).pop() || null;
+  }
+  // When an outdated review starts to show as OUTDATED. The current flag is the truth; this only places it.
+  // First id in merged_since, else (that list is empty) the first merge at or after the review's `at`,
+  // else the review's end when no merge time is known. A current review (outdated false or null) has no moment.
+  function outdatedMoment(run, review) {
+    if (!review || review.outdated !== true) return null;
+    const merges = list(run && run.integration && run.integration.merged).filter(m => m && num(m.at) !== null);
+    const since = list(review.merged_since);
+    if (since.length) {
+      const times = merges.filter(m => m.id === since[0]).map(m => m.at);
+      if (times.length) return Math.min(...times);
+      return num(review.ended);
+    }
+    const at = num(review.at);
+    if (at !== null) {
+      const later = merges.filter(m => m.at >= at).map(m => m.at);
+      if (later.length) return Math.min(...later);
+    }
+    return num(review.ended);
+  }
+  // Status of one review at time t. Before it ends it is RUNNING. OUTDATED only at and after outdatedMoment,
+  // and only when the review is done and currently outdated, so the present matches finalStatus.
+  function finalAt(run, review, t) {
+    if (!review) return 'NONE';
+    if (review.state === 'running') return 'RUNNING';
+    const ended = num(review.ended);
+    const end = ended !== null ? ended : (review.state === 'done' || review.state === 'infra' ? num(review.at) : null);
+    if (end === null) return finalStatus(review) || 'RUNNING';
+    if (end > t) return 'RUNNING';
+    if (review.state === 'infra') return 'INFRA';
+    if (review.state === 'done' && review.outdated === true) {
+      const from = outdatedMoment(run, review);
+      if (from === null || t >= from) return 'OUTDATED';
+    }
+    return review.verdict || 'UNKNOWN';
+  }
   function finishState(run) {
     const fr = run.final_review, v = run.verification, ig = run.integration;
     const tasks = list(run.tasks), merged = tasks.filter(t => t.status === 'MERGED').length;
+    const frObj = fr && typeof fr === 'object' ? fr : null;
     return {
       integration: { status: integrationStatus(tasks.map(t => t.status)),
         merged, total: tasks.length, base: ig && ig.base || null, accepted: ig && ig.accepted || null },
       verification: { status: v && v.status ? String(v.status).toUpperCase() : 'PENDING', command: v && v.command || null, runs: list(v && v.runs).length },
-      final: { status: !fr ? (run.settings && run.settings.final_qa ? 'PENDING' : 'NONE') : fr.state === 'running' ? 'RUNNING' : fr.state === 'infra' ? 'INFRA' : fr.verdict || 'UNKNOWN',
-        requested: !!(fr || run.settings && run.settings.final_qa), spec: fr && fr.spec || run.settings && run.settings.final_qa || null, findings: fr && fr.findings || null,
-        count: list(run.final_reviews).length },
+      final: { status: !frObj ? (run.settings && run.settings.final_qa ? 'PENDING' : 'NONE') : finalStatus(frObj),
+        requested: !!(fr || run.settings && run.settings.final_qa), spec: frObj && frObj.spec || run.settings && run.settings.final_qa || null, findings: frObj && frObj.findings || null,
+        count: list(run.final_reviews).length,
+        verdict: frObj && frObj.verdict || null, tip: frObj && frObj.tip || null, merged_since: list(frObj && frObj.merged_since) },
     };
   }
   function planModel(run) {
@@ -221,6 +323,8 @@
     const put = (a, p) => { const k = a == null ? 'other' : String(a); if (!byAttempt.has(k)) byAttempt.set(k, []); byAttempt.get(k).push(p); };
     for (const e of execs) {
       if (e.role !== 'dwarf' && e.role !== 'qa') continue;
+      // The part keeps execStatus. The accepted attempt is relabelled by attemptStatus on the
+      // attempt itself; painting this part ACCEPTED would hide the reviewer's verdict.
       put(e.attempt, { id: e.id, kind: e.role, exec: e, status: execStatus(e), label: e.role === 'dwarf' ? 'DWARF' : 'QA', spec: e.model && e.model.spec || null, attempt: e.attempt });
     }
     for (const s of list(task && task.shadow)) {
@@ -359,11 +463,13 @@
         const start = num(e.started); if (start === null) continue;
         const kids = execs.filter(k => k !== e && (k.parent === e.id || e.synthetic || (tops.length === 1 && !k.parent && (k.role === 'dwarf' || k.role === 'qa'))));
         const row = rows.filter(r => r.attempt === e.attempt).pop();
-        const status = e.state === 'running' ? 'RUNNING' : row ? row.status : e.state === 'orphaned' ? 'INTERRUPTED' : t.status === 'MERGED' && e === tops[tops.length - 1] ? 'MERGED' : execStatus(e);
+        let status = e.state === 'running' ? 'RUNNING' : row ? row.status : e.state === 'orphaned' ? 'INTERRUPTED' : t.status === 'MERGED' && e === tops[tops.length - 1] ? 'MERGED' : execStatus(e);
+        if (e === tops[tops.length - 1] && t.status === 'MERGED') status = 'MERGED';
+        status = attemptStatus(t, e.attempt, status);
         const end = execEnd(e, now);
         const running = kids.find(k => k.state === 'running');
         items.push({ id: e.id, task: t.id, attempt: e.attempt, start, end: end !== null ? Math.max(end, start) : start, running: e.state === 'running',
-          status: e === tops[tops.length - 1] && t.status === 'MERGED' ? 'MERGED' : status, role: running ? running.role : null, phase: running ? running.phase : null,
+          status, role: running ? running.role : null, phase: running ? running.phase : null,
           segs: kids.filter(k => k.role === 'dwarf' || k.role === 'qa').map(k => ({ id: k.id, role: k.role, start: num(k.started), end: execEnd(k, now), status: execStatus(k) })).filter(s => s.start !== null) });
       }
     }
@@ -492,9 +598,8 @@
       }
       tasks[task.id] = { status, role };
     }
-    const fr = list(run && run.final_reviews).filter(r => (num(r.started) ?? num(r.at) ?? Infinity) <= t);
-    const last = fr.sort((a, b) => (a.at || 0) - (b.at || 0)).pop();
-    const final = !last ? 'NONE' : num(last.ended) !== null && last.ended <= t ? (last.verdict || 'UNKNOWN') : 'RUNNING';
+    const last = reviewAt(run, t);
+    const final = finalAt(run, last, t);
     const vs = list(run && run.timeline && run.timeline.verifications).filter(v => num(v.started) !== null && v.started <= t);
     const lv = vs.pop();
     const verification = !lv ? 'PENDING' : num(lv.ended) !== null && lv.ended <= t ? (lv.exit_code === 0 ? 'PASS' : 'FAIL') : 'RUNNING';
@@ -502,7 +607,15 @@
   }
   function timeRange(run, now) {
     const s = [], e = [];
-    for (const t of list(run && run.tasks)) for (const x of list(t.executions)) { if (num(x.started) !== null) s.push(x.started); const end = execEnd(x, now); if (end !== null) e.push(end); }
+    for (const t of list(run && run.tasks)) {
+      for (const x of list(t.executions)) { if (num(x.started) !== null) s.push(x.started); const end = execEnd(x, now); if (end !== null) e.push(end); }
+      // The merged marker is written after the attempt ends. Leave it out and the slider stops on the
+      // verdict while the current view already shows the review as OUTDATED.
+      if (num(t.merged_at) !== null) e.push(t.merged_at);
+    }
+    // Same marker, as integration.merged. That list is what outdatedMoment reads, and a run detail can carry it
+    // without the task's merged_at matching, so the range has to take it on its own.
+    for (const m of list(run && run.integration && run.integration.merged)) if (num(m && m.at) !== null) e.push(m.at);
     for (const r of list(run && run.final_reviews)) { const v = num(r.started) ?? num(r.at); if (v !== null) s.push(v); if (num(r.ended) !== null) e.push(r.ended); }
     for (const v of list(run && run.timeline && run.timeline.verifications)) { if (num(v.started) !== null) s.push(v.started); if (num(v.ended) !== null) e.push(v.ended); }
     if (!s.length) return null;
@@ -556,8 +669,9 @@
       if (r.kind === 'solo') continue;
       for (const t of list(r.task_statuses)) {
         if (!t || !t.id) continue;
-        out.push({ id: `task:${r.key}:${t.id}`, kind: 'task', key: r.key, task: t.id, label: t.title ? `${t.id} · ${t.title}` : t.id, sub: `${goal} · ${String(t.status || 'PENDING').toLowerCase()}`,
-          ids: [t.id], words: [r.run_id, basename(r.repo)].filter(Boolean), t: num(r.updated) || 0, status: t.status, subSearch: false,   // not found through its run's goal
+        const shown = taskStatus(t);
+        out.push({ id: `task:${r.key}:${t.id}`, kind: 'task', key: r.key, task: t.id, label: t.title ? `${t.id} · ${t.title}` : t.id, sub: `${goal} · ${String(shown).toLowerCase()}`,
+          ids: [t.id], words: [r.run_id, basename(r.repo)].filter(Boolean), t: num(r.updated) || 0, status: shown, subSearch: false,   // not found through its run's goal
           href: `#/runs/${encodeURIComponent(r.key)}/tasks/${encodeURIComponent(t.id)}` });
       }
     }
@@ -661,7 +775,8 @@
     return { pos, edges, cols, rows: next };
   }
 
-  return { liveNow, runState, execStatus, matchRun, filterOptions, atlasModel, columns, planModel, finishState, taskParts,
+  return { liveNow, runState, execStatus, matchRun, filterOptions, atlasModel, columns, planModel, finishState,
+    finalStatus, runReviewStatus, reviewSinceLine, reviewAt, taskStatus, taskVerdict, attemptStatus, taskParts,
     taskTimes, metricValue, overlap, projectSchedule, execModel, criticalPath, concurrency, stateAt, timeRange, events, lineage, structureKey, innerKey,
     fmtDur, alias, basename, weight, searchIndex, searchRank, statusEvents, fractalTree };
 });

package/ui/forge_ui/static/scene3d.js

@@ -89,12 +89,13 @@ export async function createStage(host, cb = {}) {
     el.col = col || E.statusColor(el.status);
     el.pulse = el.status === 'RUNNING';
   }
-  const PLAIN = new Set(['PENDING', 'NONE', 'UNKNOWN']);
+  const PLAIN = new Set(['PENDING', 'NONE', 'UNKNOWN', 'OUTDATED']);   // unlit: no glow and no tint
   function baseTargets(el) {
     const T = el.tgt, s = el.status, light = E.theme === 'light';
     T.lit = PLAIN.has(s) ? 0 : .32;
     T.tint = PLAIN.has(s) ? 0 : light ? .34 : .1;          // a pale panel shows a lit section by its colour: no glow to carry it
     T.vis = 1; T.op = 1; T.opB = 1;
+    // Not started yet. OUTDATED is a finished review that is no longer current, so it stays solid.
     if (s === 'PENDING' || s === 'NONE') { T.opB = .55; T.op = .8; }
     // parts are small: their status has to read from the colour of the whole piece
     if (el.kind === 'part' && !PLAIN.has(s)) { T.tint = light ? .5 : .32; T.lit = .55; }
@@ -166,7 +167,8 @@ export async function createStage(host, cb = {}) {
     const parts = [r.kind === 'solo' ? (Object.keys(c)[0] || 'solo') : `${merged}/${total} done`];
     if (running) parts.push(`${running} running`);
     if (bad) parts.push(`${bad} failed`);
-    if (r.final_review) parts.push(`review ${r.final_review}`);
+    const reviewStatus = RM.runReviewStatus(r);
+    if (reviewStatus) parts.push(`review ${reviewStatus}`);
     else if (r.verification_status) parts.push(`verify ${r.verification_status}`);
     return parts.join(' · ');
   }
@@ -191,7 +193,7 @@ export async function createStage(host, cb = {}) {
         cx.fillText(E.ellipsis(`${RM.basename(r.repo)} · ${r.run_id || ''}${r.kind === 'solo' ? ' · solo' : ''}`, Math.floor((w - 30) / (7 * E.CW))), 2 * s, 44 * s);
       }, 'cover', { x: x + 12, y: y + 8, z: h });
       leds(el, Math.min(60, m.tasks.length), x + 17, y + d - 14, h + .16, { step: 8, s: 2.4, perRow: Math.max(4, Math.floor((w - 30) / 8)) });
-      setLeds(el, m.tasks.map(t => t.status));
+      setLeds(el, m.tasks.map(t => RM.taskStatus(t)));
       display(el, e => runInfo(e.data.run), { w: w - 24, x: x + 12, y: y + d, z: h - 8 });
       halo(el);
     }
@@ -206,17 +208,28 @@ export async function createStage(host, cb = {}) {
       const el = EL.get('r:' + m.id); if (!el) continue;
       el.data.run = m.run; el.data.module = m;
       setStatus(el, STATE_STATUS[m.state]); halo(el);
-      setLeds(el, m.tasks.map(t => t.status));
-      const sig = JSON.stringify([m.run.goal, m.run.counts, m.run.final_review, m.run.verification_status]);
+      setLeds(el, m.tasks.map(t => RM.taskStatus(t)));
+      const sig = JSON.stringify([m.run.goal, m.run.counts, m.run.final_review, m.run.final_review_outdated, m.run.verification_status]);
       if (sig !== el.sig) { el.sig = sig; redraw(el); }
     }
     retarget();
   }
 
   /* ---------- plan: waves, tasks, the finish line ---------- */
-  function taskStatus(t) {
-    if (st.replay !== null && st.replayState) { const s = st.replayState.tasks[t.id]; return s ? s.status : 'PENDING'; }
-    return t.status || 'PENDING';
+  // During a replay the recorded status is what it was then; acceptance shows only once that status is MERGED.
+  function shownTask(t) {
+    if (t && st.replay !== null && st.replayState) {
+      const s = st.replayState.tasks[t.id];
+      return Object.assign({}, t, { status: s ? s.status : 'PENDING' });
+    }
+    return t;
+  }
+  function taskStatus(t) { return RM.taskStatus(shownTask(t)); }
+  function attemptLamps(t) {
+    const shown = shownTask(t);
+    const rows = list(t.attempts).map(a => RM.attemptStatus(shown, a.attempt, a.status));
+    if (st.replay === null && t.status === 'RUNNING') rows.push('RUNNING');
+    return rows;
   }
   function taskLine(el) {
     const t = el.data.task, s = el.status;
@@ -256,6 +269,7 @@ export async function createStage(host, cb = {}) {
     const tries = Math.max(1, list(t.attempts).length);
     leds(el, Math.min(20, tries), x + 17, y + d - 13, h + .16, { step: 9, s: 2.8 });
     el.ledCount = tries;
+    setLeds(el, attemptLamps(t).slice(-el.ledCount));
     display(el, taskLine, { w: w - 24, x: x + 12, y: y + d, z: h - 8 });
     // the Clef ring: how likely the first try was to pass, in the colour of what happened
     const p0 = t.clef && t.clef.first_pass && num(t.clef.first_pass.p);
@@ -276,9 +290,12 @@ export async function createStage(host, cb = {}) {
     const F = st.plan && st.plan.finish, run = st.run; if (!F) return {};
     if (id === 'f:integration') return { title: 'INTEGRATION', sub: `${F.integration.merged}/${F.integration.total} merged`, status: F.integration.status, line: F.integration.accepted ? 'at ' + String(F.integration.accepted).slice(0, 10) : 'into forge/' + (run.run_id || '…') + '-integration' };
     if (id === 'f:verification') return { title: 'VERIFICATION', sub: F.verification.command || 'no command recorded', status: F.verification.status, line: F.verification.runs ? `${F.verification.runs} run${F.verification.runs > 1 ? 's' : ''}` : 'not run yet' };
+    const status = finishStatus(id, { status: F.final.status });
+    const src = status === 'OUTDATED' && st.replay !== null ? (RM.reviewAt(run, st.replay) || F.final) : F.final;
     const f = F.final.findings;
-    return { title: 'FINAL REVIEW', sub: F.final.requested ? (F.final.spec || 'reviewer not chosen') : 'not requested', status: F.final.status, findings: f,
-      line: F.final.status === 'NONE' ? 'opt-in: forge review <plan>' : F.final.count > 1 ? `${F.final.count} reviews` : F.final.status };
+    const line = status === 'OUTDATED' ? RM.reviewSinceLine(src)
+      : F.final.status === 'NONE' ? 'opt-in: forge review <plan>' : F.final.count > 1 ? `${F.final.count} reviews` : status;
+    return { title: 'FINAL REVIEW', sub: F.final.requested ? (F.final.spec || 'reviewer not chosen') : 'not requested', status, findings: f, line };
   }
   function buildFinish(m, p, g) {
     const [x, y, w, d, h] = p;
@@ -308,7 +325,7 @@ export async function createStage(host, cb = {}) {
   }
   function finishLeds(el) {
     if (el.id === 'f:final') { const f = finishInfo(el.id).findings || {}; setLeds(el, ['P0', 'P1', 'P2', 'P3'].map(s => f[s] ? E.sevColor(s) : null)); }
-    else if (el.id === 'f:integration') setLeds(el, list(st.run.tasks).map(t => taskStatus(t) === 'MERGED' ? 'MERGED' : null));
+    else if (el.id === 'f:integration') setLeds(el, list(st.run.tasks).map(t => { const s = taskStatus(t); return s === 'MERGED' || s === 'ACCEPTED' ? s : null; }));
     else setLeds(el, list(st.run.verification && st.run.verification.runs).map(r => r.exit === 0 ? 'PASS' : 'FAIL'));
   }
   function buildPlan(g) {
@@ -954,7 +971,7 @@ export async function createStage(host, cb = {}) {
       if (c.tint > .001) el.M.body.color.lerp(TMP2.copy(col), c.tint * c.vis);
       if (el.tintMat) { el.tintMat.color.copy(col); el.tintMat.opacity = (c.tint * (E.theme === 'light' ? 1.45 : 1.1) + .08 * c.sel) * ob * gf * c.vis; }
       if (el.haloMat) el.haloMat.uniforms.opacity.value = (c.halo + (el.pulse ? .12 * pulseK : 0)) * gf * c.vis;
-      if (el.clef) el.clef.fgM.color.copy(E.statusColor(['MERGED', 'PASS'].includes(el.status) ? 'pass' : ['FAIL', 'ERROR', 'CONFLICT'].includes(el.status) ? 'fail' : 'pending'));
+      if (el.clef) el.clef.fgM.color.copy(E.statusColor(['MERGED', 'PASS', 'ACCEPTED'].includes(el.status) ? 'pass' : ['FAIL', 'ERROR', 'CONFLICT'].includes(el.status) ? 'fail' : 'pending'));
       if (el.inner) {
         const p = pr ? pr.p : 0, vis = p > .002;
         if (!vis && el.inner.visible) { E.release(el.inner); }
@@ -1239,6 +1256,7 @@ export async function createStage(host, cb = {}) {
     const lamps = { title: 'Lamps', rows: [
       { sw: { lamp: 'st-merged' }, label: 'merged · passed · accepted' }, { sw: { lamp: 'st-running' }, label: 'running · interrupted' },
       { sw: { lamp: 'st-fail' }, label: 'failed · conflict · infra · timeout' }, { sw: { lamp: 'st-pending' }, label: 'pending, not started' },
+      { sw: { lamp: 'st-outdated' }, label: 'outdated review' },
       { sw: { route: true }, label: st.view === 'atlas' ? 'chosen run' : 'chosen task' + (L.route ? ' and its route' : '') }] };
     if (st.view === 'atlas') {
       out.push({ title: 'Map', rows: [], note: 'Each block is a run, each district a repository. The lamps on a block are its tasks; the block stands taller the more tasks it has.' }, lamps);
@@ -1318,8 +1336,7 @@ export async function createStage(host, cb = {}) {
         if (el.kind === 'task') {
           const t = byId.get(el.data.task.id); if (!t) continue;
           el.data.task = t; setStatus(el, taskStatus(t)); halo(el);
-          const rows = list(t.attempts).map(a => a.status);
-          if (st.replay === null && t.status === 'RUNNING') rows.push('RUNNING');
+          const rows = attemptLamps(t);
           if (rows.length > el.ledCount) { /* more tries than lamps: the newest show */ }
           setLeds(el, rows.slice(-el.ledCount));
           const sig = JSON.stringify([t.status, t.findings, t.gate, list(t.shadow).map(s => s.agreement), t.dwarf, t.accepted_by, el.status]);
@@ -1385,7 +1402,7 @@ export async function createStage(host, cb = {}) {
       E.invalidate(100);                                    // marks a replay reaches drop in
       st.replayState = st.replay !== null ? RM.stateAt(st.run, st.replay) : null;
       for (const el of EL.values()) {
-        if (el.kind === 'task') setStatus(el, taskStatus(el.data.task));
+        if (el.kind === 'task') { setStatus(el, taskStatus(el.data.task)); setLeds(el, attemptLamps(el.data.task).slice(-el.ledCount)); }
         else if (el.kind === 'finish') setStatus(el, finishStatus(el.id, finishInfo(el.id)));
         else if (el.data && el.data.item) setStatus(el, st.replay !== null ? replayItemStatus(el.data.item) : el.data.item.status);
         else continue;

package/ui/forge_ui/static/style.css

@@ -91,13 +91,14 @@
 :root[data-theme=dark] { color-scheme: dark; }
 
 /* status: the lamp behind each forge state. Five lamps, one meaning each (--st; --st-lit on the 3D plate);
-   a hollow lamp is that lamp's family but not its plain case: passed without a merge, stopped, failed outside the code */
+   a hollow lamp is that lamp's family but not its plain case: passed without a merge, stopped, failed outside the code,
+   an outdated review */
 .st-merged, .st-pass, .st-accepted, .st-nochanges { --st: var(--lamp-green); --st-lit: var(--lit-green); }
 .st-running, .st-interrupted { --st: var(--lamp-amber); --st-lit: var(--lit-amber); }
-.st-pending, .st-none, .st-unknown, .st-invalidated { --st: var(--lamp-off); --st-lit: var(--lamp-off); }
+.st-pending, .st-none, .st-unknown, .st-invalidated, .st-outdated { --st: var(--lamp-off); --st-lit: var(--lamp-off); }
 .st-fail, .st-error, .st-conflict, .st-infra, .st-timeout, .st-blocked { --st: var(--lamp-red); --st-lit: var(--lit-red); }
 [class^="st-"], [class*=" st-"] { --st-fill: var(--st); --st-ring: var(--lamp-edge); }
-.st-accepted, .st-nochanges, .st-interrupted, .st-infra, .st-timeout, .st-blocked { --st-fill: transparent; --st-ring: var(--st); }
+.st-accepted, .st-nochanges, .st-interrupted, .st-infra, .st-timeout, .st-blocked, .st-outdated { --st-fill: transparent; --st-ring: var(--st); }
 /* review severity is a shape (P0 spike, P1 diamond, P2 cone, P3 pin) on a ramp of its own, never a status lamp */
 .sev-P0 { --sev: var(--sev-p0); --sev-shape: polygon(50% 0, 100% 100%, 0 100%); }
 .sev-P1 { --sev: var(--sev-p1); --sev-shape: polygon(50% 0, 100% 50%, 50% 100%, 0 50%); }
@@ -152,6 +153,7 @@ kbd { font-family: var(--mono); font-size: var(--t-xs); padding: 0 5px; border:
 .chip { display: inline-flex; align-items: center; gap: 5px; padding: 1px 7px 0 6px; border: 1px solid var(--rule); border-radius: var(--r-small); background: var(--key); color: var(--ink); white-space: nowrap;
   font-family: var(--font-plate); font-weight: 700; font-size: .857rem; letter-spacing: .05em; text-transform: uppercase; line-height: 1.5; font-variant-numeric: tabular-nums; }
 .chip::before { content: ''; width: 7px; height: 7px; border-radius: 50%; background: var(--st-fill, var(--lamp-off)); box-shadow: inset 0 0 0 1.5px var(--st-ring, transparent); flex: none; }
+a.chip, a.chip:hover { color: inherit; text-decoration: none; }
 .chips { display: flex; gap: var(--s-1); flex-wrap: wrap; }
 .sev-chip { display: inline-flex; align-items: center; gap: 6px; font-family: var(--mono); font-size: var(--t-xs); white-space: nowrap; }
 .sev-chip::before { content: ''; width: 9px; height: 9px; clip-path: var(--sev-shape, circle(30%)); background: var(--sev, var(--muted)); flex: none; }
@@ -683,6 +685,7 @@ th:hover .th-sort, .th-sort.on { color: var(--ink); }
 .fg-bar { fill: var(--st, var(--lamp-off)); }
 .fg-verdict { stroke: var(--lamp-red); }
 .fg-verdict.fg-pass { stroke: var(--st, var(--lamp-green)); }
+.fg-node.st-accepted .fg-box { fill: transparent; }
 .fg-empty { color: var(--muted); padding: var(--s-3) 0; }
 .gantt, .strip { display: block; font-family: var(--mono); }
 .gt-lane { fill: var(--module-2); }
@@ -693,6 +696,7 @@ th:hover .th-sort, .th-sort.on { color: var(--ink); }
 .gt-tick-label { fill: var(--muted); font-size: 10px; }
 .gt-item { cursor: pointer; }
 .gt-box { fill: var(--st, var(--lamp-off)); fill-opacity: .2; stroke: var(--st, var(--lamp-off)); stroke-width: 1.2; }
+.gt-item.st-accepted .gt-box { fill: transparent; }
 .gt-item:hover .gt-box, .gt-item:focus .gt-box { fill-opacity: .35; }
 .gt-item:focus { outline: none; }
 .gt-item.gt-sel .gt-box { stroke: var(--route); stroke-width: 2.5; }