@gi-tcg/gts-transpiler 0.6.0 → 0.6.2

package/dist/index.js

@@ -1646,7 +1646,7 @@ const LITERAL_FROM_ID_MAPPING_DATA = {
 	literalFromId: true
 };
 const DIRECT_ACTION_STUB_MAPPING_DATA = {
-	...DEFAULT_VOLAR_MAPPING_DATA,
+	semantic: true,
 	directActionStub: true
 };
 const VERIFICATION_ONLY_MAPPING_DATA = { verification: true };
@@ -1666,13 +1666,22 @@ function getPrintOptions(source, state) {
 		getLeadingComments: (node) => node.leadingComments,
 		getTrailingComments: (node) => node.trailingComments,
 		getMappingData: () => DEFAULT_VOLAR_MAPPING_DATA,
-		beforeWriteNode: ({ range, isUntouched, context }) => {
-			if (isUntouched || !range) return;
+		beforeWriteNode: ({ range, node, isUntouched, context }) => {
+			if (isUntouched || !range || node.type === "ImportDeclaration") return;
 			context.writeMapped("", range.start, range.start, VERIFICATION_ONLY_MAPPING_DATA);
 		},
-		afterWriteNode: ({ range, isUntouched, context }) => {
-			if (isUntouched || !range) return;
-			context.writeMapped("", range.end, range.end, VERIFICATION_ONLY_MAPPING_DATA);
+		afterWriteNode: ({ range, node, isUntouched, context }) => {
+			const [lastImportDecl, lastImportGenerated] = state.lastImportDeclaration ?? [];
+			if (node.type === "ImportDeclaration" && lastImportDecl === node) {
+				context.write("\n");
+				let sourceOffsetBaseBase = lastImportGenerated ? state.contentStartOffset : node.range?.[1] ?? 0;
+				const sourceOffset = sourceOffsetBaseBase + Math.max(0, context.source.slice(sourceOffsetBaseBase).search(/\n/));
+				context.createExtraMapping({
+					start: sourceOffset + 1,
+					end: sourceOffset + 1
+				}, context.generatedOffset, context.generatedOffset, DEFAULT_VOLAR_MAPPING_DATA);
+			} else if (isUntouched || !range) return;
+			else context.writeMapped("", range.end, range.end, VERIFICATION_ONLY_MAPPING_DATA);
 		},
 		printers: {
 			Identifier(node, context) {
@@ -1726,16 +1735,6 @@ function getPrintOptions(source, state) {
 					}, generatedStart, generatedEnd, VERIFICATION_ONLY_MAPPING_DATA);
 				}
 			},
-			ImportDeclaration(node, context) {
-				defaultPrinters.ImportDeclaration(node, context);
-				if (state.lastImportDeclarationIfGen === node) {
-					context.write("\n");
-					context.createExtraMapping({
-						start: state.contentStartOffset,
-						end: state.contentStartOffset + 1
-					}, context.generatedOffset, context.generatedOffset + 1, DEFAULT_VOLAR_MAPPING_DATA);
-				}
-			},
 			GTSAttributeNameHintStatement(node, context) {
 				context.writeNode(node.object);
 				context.write(".");
@@ -1847,7 +1846,7 @@ function transformForVolar(ast, option, sourceInfo) {
 		directActionStubRange: /* @__PURE__ */ new WeakMap(),
 		literalFromIdentifier: /* @__PURE__ */ new WeakSet(),
 		lastArgNodes: /* @__PURE__ */ new WeakSet(),
-		lastImportDeclarationIfGen: null,
+		lastImportDeclaration: null,
 		diagnosticsOnTopNodes: /* @__PURE__ */ new WeakSet(),
 		extraMappings: [],
 		contentStartOffset: getContentStartOffset(sourceInfo.content)
@@ -1863,9 +1862,16 @@ function transformForVolar(ast, option, sourceInfo) {
 			if (lastArg) state.lastArgNodes.add(lastArg);
 		},
 		ImportDeclaration(node, { state }) {
-			if (!state.sourceNodes.has(node)) state.lastImportDeclarationIfGen = node;
+			state.lastImportDeclaration = [node, !state.sourceNodes.has(node)];
 		}
 	});
+	walk(newAst, state, { Program(node, { state }) {
+		const lastImportDeclarationNode = state.lastImportDeclaration?.[0];
+		if (lastImportDeclarationNode) {
+			const index = node.body.indexOf(lastImportDeclarationNode);
+			if (index >= 0) node.body.splice(index + 1, 0, { type: "EmptyStatement" });
+		}
+	} });
 	let { code, mappings } = print$1(newAst, getPrintOptions(sourceInfo.content, state));
 	code = applyReplacements(state, code, mappings);
 	for (const extraMapping of state.extraMappings) {
@@ -1878,12 +1884,6 @@ function transformForVolar(ast, option, sourceInfo) {
 			data: VERIFICATION_ONLY_MAPPING_DATA
 		});
 	}
-	walk(newAst, null, { ImportDeclaration(node) {
-		if (!node.range) return;
-		const endOffset = node.range[1];
-		const mappingEndsWithThisImport = mappings.find((m) => m.sourceOffsets[0] + m.lengths[0] === endOffset);
-		if (mappingEndsWithThisImport?.lengths[0]) mappingEndsWithThisImport.lengths[0] += 1;
-	} });
 	return {
 		code,
 		mappings

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gi-tcg/gts-transpiler",
-  "version": "0.6.0",
+  "version": "0.6.2",
   "repository": {
     "type": "git",
     "url": "https://github.com/piovium/gts.git"

package/src/transform/volar/index.ts

@@ -46,7 +46,7 @@ export function transformForVolar(
     directActionStubRange: new WeakMap(),
     literalFromIdentifier: new WeakSet(),
     lastArgNodes: new WeakSet(),
-    lastImportDeclarationIfGen: null,
+    lastImportDeclaration: null,
     diagnosticsOnTopNodes: new WeakSet(),
     extraMappings: [],
     contentStartOffset: getContentStartOffset(sourceInfo.content),
@@ -61,7 +61,7 @@ export function transformForVolar(
     },
   });
   const newAst = walk(ast as AST.Node, state, gtsToTypingsWalker);
-  // mark lastArgNodes
+  // mark lastArgNodes and lastImportDeclaration
   walk(newAst as AST.Node, state, {
     CallExpression(node, { state }) {
       const lastArg = node.arguments.at(-1);
@@ -70,11 +70,22 @@ export function transformForVolar(
       }
     },
     ImportDeclaration(node, { state }) {
-      if (!state.sourceNodes.has(node)) {
-        state.lastImportDeclarationIfGen = node;
+      state.lastImportDeclaration = [node, !state.sourceNodes.has(node)];
+    },
+  });
+  walk(newAst, state, {
+    Program(node, { state }) {
+      const lastImportDeclarationNode = state.lastImportDeclaration?.[0];
+      // break continuous gap between last import declaration and its next node
+      if (lastImportDeclarationNode) {
+        const index = node.body.indexOf(lastImportDeclarationNode);
+        if (index >= 0) {
+          node.body.splice(index + 1, 0, { type: "EmptyStatement" });
+        }
       }
     },
   });
+
   const printOptions = getPrintOptions(sourceInfo.content, state);
   let { code, mappings } = print(newAst, printOptions);
   code = applyReplacements(state, code, mappings);
@@ -88,20 +99,6 @@ export function transformForVolar(
       data: VERIFICATION_ONLY_MAPPING_DATA,
     });
   }
-  walk(newAst, null, {
-    ImportDeclaration(node) {
-      if (!node.range) {
-        return;
-      }
-      const endOffset = node.range[1];
-      const mappingEndsWithThisImport = mappings.find(
-        (m) => m.sourceOffsets[0] + m.lengths[0] === endOffset,
-      );
-      if (mappingEndsWithThisImport?.lengths[0]) {
-        mappingEndsWithThisImport.lengths[0] += 1; // include the newline after the import
-      }
-    },
-  });
   return {
     code,
     mappings,

package/src/transform/volar/mappings.ts

@@ -30,7 +30,7 @@ export const LITERAL_FROM_ID_MAPPING_DATA: CodeInformation = {
   literalFromId: true,
 }
 export const DIRECT_ACTION_STUB_MAPPING_DATA: CodeInformation = {
-  ...DEFAULT_VOLAR_MAPPING_DATA,
+  semantic: true,
   directActionStub: true,
 }
 export const VERIFICATION_ONLY_MAPPING_DATA: CodeInformation = {

package/src/transform/volar/printer.ts

@@ -20,7 +20,10 @@ import {
   LITERAL_FROM_ID_MAPPING_DATA,
   VERIFICATION_ONLY_MAPPING_DATA,
 } from "./mappings.ts";
-import type { TypingTranspileState, GTSAttributeNameHintStatement } from "./walker.ts";
+import type {
+  TypingTranspileState,
+  GTSAttributeNameHintStatement,
+} from "./walker.ts";
 
 export function getPrintOptions(
   source: string,
@@ -37,23 +40,61 @@ export function getPrintOptions(
       }
       return state.sourceNodes.has(node as Node);
     },
+    
     printCommentsOnUntouchedNodes: true,
     getLeadingComments: (node) => (node as Node).leadingComments,
     getTrailingComments: (node) => (node as Node).trailingComments,
     getMappingData: () => DEFAULT_VOLAR_MAPPING_DATA,
     // Add a 0-length mapping before and after each touched node with verification only,
     // so that error squiggles start/ends at those positions can be reflected.
-    beforeWriteNode: ({ range, isUntouched, context }) => {
-      if (isUntouched || !range) {
+    beforeWriteNode: ({ range, node, isUntouched, context }) => {
+      if (isUntouched || !range || node.type === "ImportDeclaration") {
+        // Don't do that for ImportDeclaration -- it mess up auto-import insertion point
         return;
       }
-      context.writeMapped("", range.start, range.start, VERIFICATION_ONLY_MAPPING_DATA);
+      context.writeMapped(
+        "",
+        range.start,
+        range.start,
+        VERIFICATION_ONLY_MAPPING_DATA,
+      );
     },
-    afterWriteNode: ({ range, isUntouched, context }) => {
-      if (isUntouched || !range) {
+    afterWriteNode: ({ range, node, isUntouched, context }) => {
+      const [lastImportDecl, lastImportGenerated] =
+        state.lastImportDeclaration ?? [];
+      if (node.type === "ImportDeclaration" && lastImportDecl === node) {
+        // If the last import declaration is a generated one, because of we ensured that
+        // the generated import declarations are always unsorted, so TSServer will set the
+        // auto-insertion point next to this last import declaration.
+        // Add a mapping to that position (a written newline character) to the top-of-file,
+        // after skipping hashbang and leading comments.
+        context.write("\n");
+        let sourceOffsetBaseBase = lastImportGenerated
+          ? state.contentStartOffset
+          : (node.range?.[1] ?? 0);
+        const sourceOffset =
+          sourceOffsetBaseBase +
+          Math.max(0, context.source.slice(sourceOffsetBaseBase).search(/\n/));
+        // These +1s below is magic and I don't know why, but it works.
+        context.createExtraMapping(
+          {
+            start: sourceOffset + 1,
+            end: sourceOffset + 1,
+          },
+          context.generatedOffset,
+          context.generatedOffset,
+          DEFAULT_VOLAR_MAPPING_DATA,
+        );
+      } else if (isUntouched || !range) {
         return;
+      } else {
+        context.writeMapped(
+          "",
+          range.end,
+          range.end,
+          VERIFICATION_ONLY_MAPPING_DATA,
+        );
       }
-      context.writeMapped("", range.end, range.end, VERIFICATION_ONLY_MAPPING_DATA);
     },
     printers: {
       // 1) Make the print of dummy identifier print nothing.
@@ -115,7 +156,9 @@ export function getPrintOptions(
             node.range[1],
             ATTRIBUTE_NAME_MAPPING_DATA,
           );
-        } else if ((directActionStubRange = state.directActionStubRange.get(node))) {
+        } else if (
+          (directActionStubRange = state.directActionStubRange.get(node))
+        ) {
           // For direct action stubs, add mappings from this expression statement line to the
           // start of original direct action start position. Add `directActionStub` data
           // for recognizing them in language service plugin.
@@ -124,7 +167,7 @@ export function getPrintOptions(
             directActionStubRange.start,
             directActionStubRange.start + 1,
             DIRECT_ACTION_STUB_MAPPING_DATA,
-          )
+          );
         } else {
           defaultPrinters.Literal(node, context);
         }
@@ -168,37 +211,17 @@ export function getPrintOptions(
           );
         }
       },
-      // If the last import declaration is a generated one, because of we ensured that
-      // the generated import declarations are always unsorted, so TSServer will set the
-      // auto-insertion point next to this last import declaration.
-      // Add a mapping to that position (a written newline character) to the top-of-file,
-      // after skipping hashbang and leading comments.
-      // NOTE: since the insertion derived from here won't add additional newline *before*
-      // the inserted text, so here is a difference behavior from standard TSServer and our
-      // language server. We'd try our best.
-      ImportDeclaration(node, context) {
-        defaultPrinters.ImportDeclaration(node, context);
-        if (state.lastImportDeclarationIfGen === node) {
-          context.write("\n");
-          context.createExtraMapping(
-            {
-              start: state.contentStartOffset,
-              end: state.contentStartOffset + 1,
-            },
-            context.generatedOffset,
-            context.generatedOffset + 1,
-            DEFAULT_VOLAR_MAPPING_DATA,
-          );
-        }
-      },
       // @ts-expect-error This is a custom node type that don't have typing.
       // @see `GTSAttributeNameHintStatement`
-      GTSAttributeNameHintStatement(node: GTSAttributeNameHintStatement, context: PrinterContext<CodeInformation>) {
+      GTSAttributeNameHintStatement(
+        node: GTSAttributeNameHintStatement,
+        context: PrinterContext<CodeInformation>,
+      ) {
         context.writeNode(node.object as EspolarAST.Node);
         context.write(".");
         context.writeSource(node.whiteSpaceStart, node.whiteSpaceEnd);
         context.write(";");
-      }
+      },
     },
     // Enable triggering signature completion
     experimentalGetLeftParenSourceRange: (node) => {

package/src/transform/volar/walker.ts

@@ -76,10 +76,10 @@ export interface TypingTranspileState extends TranspileState {
   /** Nodes that are last arguments of a CallExpression */
   lastArgNodes: WeakSet<Node>;
   /**
-   * The last import declaration, record if it is a generated one.
-   * This declaration marks the TS auto-import insertion point.
+   * The last import declaration and whether it is a generated one.
+   * This declaration marks the TS auto-import insertion point if it's generated.
    */
-  lastImportDeclarationIfGen: ImportDeclaration | null;
+  lastImportDeclaration: [node: ImportDeclaration, generated: boolean] | null;
   /** Nodes that have a diagnostic mappings to the top of the file */
   diagnosticsOnTopNodes: WeakSet<Node>;
   /** Extra mappings, the generated range will be found by the needle after replacement */