@ghyper9023/pi-dev-workflow 0.2.0 → 0.3.0

package/extensions/dev-prompts.ts

@@ -24,6 +24,7 @@
  */
 
 import type { ExtensionAPI, ExtensionCommandContext } from "@earendil-works/pi-coding-agent";
+import { runGrillPhase, runPRDPhase, type AgentDef, type GrillOptions } from "./grill-me-agent";
 
 // ── Helpers ──────────────────────────────────────────────────
 
@@ -135,7 +136,7 @@ function assembleDocPrompt(f: DocFields): string {
 	}
 	lines.push("**任务**：");
 	lines.push("1. 提取核心要点，按逻辑结构重组（概述 → 快速开始 → 详细说明 → 常见问题）。");
-	lines.push(`2. 添加至少 2 个真实可运行的示例（使用 ${wrap(f.language)} 语法高亮）。`);
+	lines.push(`2. 添加至少 1 个真实可运行的示例（使用 ${wrap(f.language)} 语法高亮）。`);
 	lines.push("3. 如存在争议点，列出不同观点并注明\"无共识\"。");
 	if (!isEmpty(f.existingMaterial)) {
 		lines.push(`**已有材料**：${f.existingMaterial!.trim()}`);
@@ -161,7 +162,7 @@ function assembleRefactorPrompt(f: RefactorFields): string {
 	lines.push("");
 	lines.push(`**背景**：当前代码存在 ${wrap(f.problems)}。`);
 	lines.push("**任务**：");
-	lines.push("1. 识别 3 个主要问题。");
+	lines.push("1. 识别主要问题。");
 	lines.push("2. 提出重构方案，说明改动前后差异。");
 	lines.push("3. 输出重构后的完整版本。");
 	lines.push("**硬性约束**：");
@@ -350,8 +351,215 @@ function assembleComparePrompt(f: CompareFields): string {
 	return lines.join("\n");
 }
 
+// ── Specialized Agent Definitions for Grill ─────────────────
+
+/** Bug fix root cause analysis & reproduction review. */
+const FIX_GRILL_AGENT_DEF: AgentDef = {
+	name: "fix-grill-agent",
+	description: "Bug fix review agent — challenges the developer on understanding the bug root cause",
+	tools: ["read", "bash"],
+	systemPrompt: [
+		"You are an expert debugger reviewing a bug fix plan. Interview the developer relentlessly.",
+		"",
+		"## Rules",
+		"- For EACH question, provide recommended answer OPTIONS (a/b/c format)",
+		"- Focus on: reproduction steps, environment conditions, input variations, error messages, logs, attempted fixes",
+		"- Push for precise root cause identification — ask 'why' at least 3 levels deep",
+		"- Check if the developer has considered: edge cases in inputs, race conditions, state leakage, timeout, memory",
+		"- Verify the proposed fix addresses the root cause, not just the symptom",
+		"- If the codebase has logs/metrics available, suggest checking specific patterns",
+		"- Stress-test regression risk: could the fix break other parts of the system?",
+		"- Explore the codebase (use read/bash tools) when a question can be answered by looking at existing code",
+		"",
+		"## Output format",
+		"Output ALL questions in ONE JSON response. No preamble or explanation.",
+		'Only output the JSON object: { "questions": [{ "id": 1, "question": "...", "options": ["..."] }] }',
+		"",
+		"## Quantity",
+		"Ask 5-15 questions — enough to thoroughly understand the root cause before committing to a fix.",
+		"",
+		"## Language",
+		"Questions and options should be in the same language as the bug report (default: Chinese).",
+	].join("\n"),
+	timeoutMs: 300_000,
+};
+
+/** Document outline & structure review. */
+const DOC_GRILL_AGENT_DEF: AgentDef = {
+	name: "doc-grill-agent",
+	description: "Documentation review agent — reviews document outline before writing",
+	tools: ["read", "bash"],
+	systemPrompt: [
+		"You are an expert technical writer reviewing a documentation plan. Interview the developer.",
+		"",
+		"## Rules",
+		"- For EACH question, provide recommended answer OPTIONS (a/b/c format)",
+		"- Focus on: target audience level, document structure, what examples to include, what NOT to cover",
+		"- Check if the proposed outline covers: overview → quick start → detailed usage → FAQ/troubleshooting",
+		"- Ask about existing documentation that should be linked or consolidated",
+		"- Clarify terminology preferences and API naming conventions",
+		"- Identify potential gaps: error handling, security considerations, performance notes, deprecation notices",
+		"- Explore the codebase (use read/bash tools) to see existing docs for consistency",
+		"",
+		"## Output format",
+		"Output ALL questions in ONE JSON response. No preamble or explanation.",
+		'Only output the JSON object: { "questions": [{ "id": 1, "question": "...", "options": ["..."] }] }',
+		"",
+		"## Quantity",
+		"Ask 3-10 questions — enough to define the scope and structure.",
+		"",
+		"## Language",
+		"Questions and options should be in the same language as the documentation request (default: Chinese).",
+	].join("\n"),
+	timeoutMs: 300_000,
+};
+
+/** Refactoring plan review. */
+const REFACTOR_GRILL_AGENT_DEF: AgentDef = {
+	name: "refactor-grill-agent",
+	description: "Refactoring review agent — reviews refactoring plan before implementation",
+	tools: ["read", "bash"],
+	systemPrompt: [
+		"You are an expert software architect reviewing a refactoring plan. Interview the developer.",
+		"",
+		"## Rules",
+		"- For EACH question, provide recommended answer OPTIONS (a/b/c format)",
+		"- Focus on: module boundaries, API compatibility, dependency inversion, test strategy, migration steps",
+		"- Verify that behavior is preserved — no hidden logic changes disguised as refactoring",
+		"- Ask about: interface contracts, error handling behavior, logging behavior, side effects",
+		"- Check for risk: what's the rollback plan? Can we refactor incrementally?",
+		"- Ask about test coverage: are existing tests sufficient to catch regressions?",
+		"- Explore the codebase (use read/bash tools) to understand current module coupling",
+		"- Identify potential performance impact of the refactoring",
+		"- Check if there are circular dependency issues that should be addressed",
+		"",
+		"## Output format",
+		"Output ALL questions in ONE JSON response. No preamble or explanation.",
+		'Only output the JSON object: { "questions": [{ "id": 1, "question": "...", "options": ["..."] }] }',
+		"",
+		"## Quantity",
+		"Ask 5-15 questions — thorough enough to catch hidden coupling issues.",
+		"",
+		"## Language",
+		"Questions and options should be in the same language as the refactoring request (default: Chinese).",
+	].join("\n"),
+	timeoutMs: 300_000,
+};
+
+/** Test plan coverage review. */
+const TEST_GRILL_AGENT_DEF: AgentDef = {
+	name: "test-grill-agent",
+	description: "Test plan review agent — reviews test coverage and approach before writing tests",
+	tools: ["read", "bash"],
+	systemPrompt: [
+		"You are an expert QA engineer reviewing a test plan. Interview the developer.",
+		"",
+		"## Rules",
+		"- For EACH question, provide recommended answer OPTIONS (a/b/c format)",
+		"- Focus on: coverage dimensions, edge cases not yet considered, mocking strategy, test isolation",
+		"- Ask about: null/empty inputs, timeouts, idempotency, retry logic, success/failure paths",
+		"- Check if the developer has considered: 4xx/5xx HTTP responses, concurrent access, partial failures",
+		"- Ask about testing infrastructure: how to run tests, CI integration, test data management",
+		"- Verify testability: are dependencies injected? Can we mock external services?",
+		"- Explore the codebase (use read/bash tools) to understand existing test patterns",
+		"- Ask about coverage thresholds and whether branch coverage is needed",
+		"",
+		"## Output format",
+		"Output ALL questions in ONE JSON response. No preamble or explanation.",
+		'Only output the JSON object: { "questions": [{ "id": 1, "question": "...", "options": ["..."] }] }',
+		"",
+		"## Quantity",
+		"Ask 5-12 questions — enough to define a thorough test strategy.",
+		"",
+		"## Language",
+		"Questions and options should be in the same language as the test request (default: Chinese).",
+	].join("\n"),
+	timeoutMs: 300_000,
+};
+
+/** Performance optimization plan review. */
+const PERF_GRILL_AGENT_DEF: AgentDef = {
+	name: "perf-grill-agent",
+	description: "Performance review agent — reviews optimization approach and benchmarking strategy",
+	tools: ["read", "bash"],
+	systemPrompt: [
+		"You are an expert performance engineer reviewing an optimization plan. Interview the developer.",
+		"",
+		"## Rules",
+		"- For EACH question, provide recommended answer OPTIONS (a/b/c format)",
+		"- Focus on: benchmarking methodology, measurement tools, baseline metrics, optimization approaches",
+		"- Verify the bottleneck identification: is it really the bottleneck? What's the evidence?",
+		"- Ask about: existing profiling data, hot paths, memory vs CPU trade-offs",
+		"- Check if simpler solutions exist (e.g., caching before algorithm rewrite)",
+		"- Ask about regression risk: could the optimization introduce correctness issues?",
+		"- Explore the codebase (use read/bash tools) to understand current implementation",
+		"- Ask about monitoring: how will we measure the improvement in production?",
+		"- Challenge assumptions: is this optimization premature? What's the user-facing impact?",
+		"",
+		"## Output format",
+		"Output ALL questions in ONE JSON response. No preamble or explanation.",
+		'Only output the JSON object: { "questions": [{ "id": 1, "question": "...", "options": ["..."] }] }',
+		"",
+		"## Quantity",
+		"Ask 5-12 questions — enough to validate the approach before implementation.",
+		"",
+		"## Language",
+		"Questions and options should be in the same language as the optimization request (default: Chinese).",
+	].join("\n"),
+	timeoutMs: 300_000,
+};
+
 // ── Command runner ───────────────────────────────────────────
 
+/**
+ * Run a wizard with an optional Grill phase:
+ * Wizard → Assemble → (Grill?) → Send
+ */
+async function runWizardWithGrill(
+	ctx: ExtensionCommandContext,
+	pi: ExtensionAPI,
+	type: string,
+	label: string,
+	questions: Array<{ label: string; placeholder: string; key: string }>,
+	assembler: (answers: Record<string, string>) => string,
+	grillOptions?: GrillOptions,
+): Promise<void> {
+	ctx.ui.notify(`📋 /dev-${type} — ${label}，请逐项填写以下信息（留空跳过对应段落，Esc 取消）`, "info");
+
+	const answers: Record<string, string> = {};
+	for (const q of questions) {
+		const val = await ask(ctx, q.label, q.placeholder);
+		if (val === undefined) {
+			ctx.ui.notify("❌ 已取消", "warning");
+			return;
+		}
+		answers[q.key] = val;
+	}
+
+	const basePrompt = assembler(answers);
+
+	// ── Grill phase (if agentDef provided) ────────────────────
+	let finalPrompt = basePrompt;
+	if (grillOptions) {
+		const grillResult = await runGrillPhase(basePrompt, ctx, {
+			agentDef: grillOptions.agentDef,
+			title: grillOptions.title,
+			description: grillOptions.description,
+			questionTitle: grillOptions.questionTitle,
+			loaderLabel: grillOptions.loaderLabel,
+		});
+		if (grillResult.cancelled) {
+			ctx.ui.notify("❌ 操作已取消", "warning");
+			return;
+		}
+		finalPrompt = grillResult.enhancedPrompt;
+	}
+
+	ctx.ui.notify(`✅ 提示词已组装完成，正在发送给主代理...`, "success");
+	pi.sendUserMessage(finalPrompt);
+	ctx.ui.notify(`📝 /dev-${type} 提示词已投递，主代理正在处理`, "info");
+}
+
 /**
  * Run a wizard: ask questions, assemble prompt, send to agent.
  * @param ctx     Command context
@@ -414,7 +622,7 @@ const FIX_QUESTIONS = [
 ];
 
 const DOC_QUESTIONS = [
-	{ label: "模块/API 名称", placeholder: "如 AuthService, REST API v2...", key: "moduleName" },
+	{ label: "模块/API/doc 名称", placeholder: "如 AuthService, REST API v2...", key: "moduleName" },
 	{ label: "目标受众", placeholder: "如 小白 / 前端开发者 / 架构师", key: "audience" },
 	{ label: "关键信息点", placeholder: "他们需要了解如何使用认证接口", key: "keyInfo" },
 	{ label: "示例语言", placeholder: "如 TypeScript, Python, curl...", key: "language" },
@@ -482,64 +690,150 @@ const COMPARE_QUESTIONS = [
 export default function (pi: ExtensionAPI) {
 	// ── /dev-feat ──────────────────────────────────────────────
 	pi.registerCommand("dev-feat", {
-		description: "(prompt wizard) 新功能/创意生成 — 交互填写后发送优化提示词给主代理",
-		handler: async (args, ctx) => {
-			await runWizard(ctx, pi, "feat", "新功能/创意生成", FEAT_QUESTIONS, assembleFeatPrompt);
+		description: "(prompt wizard) 新功能/创意生成 — 支持设计评审 (Grill) + PRD 生成",
+		handler: async (_args, ctx) => {
+			// ── Phase 1: Wizard ──────────────────────────────────
+			ctx.ui.notify("📋 /dev-feat — 新功能/创意生成，请逐项填写以下信息（留空跳过对应段落，Esc 取消）", "info");
+
+			const answers: Record<string, string> = {};
+			for (const q of FEAT_QUESTIONS) {
+				const val = await ask(ctx, q.label, q.placeholder);
+				if (val === undefined) {
+					ctx.ui.notify("❌ 已取消", "warning");
+					return;
+				}
+				answers[q.key] = val;
+			}
+
+			// ── Phase 2: Assemble base prompt ───────────────────
+			const basePrompt = assembleFeatPrompt(answers as FeatFields);
+			ctx.ui.notify(`✅ 基本信息已收集，共 ${FEAT_QUESTIONS.length} 项`, "success");
+
+			// ── Phase 3: Grill (设计评审) ───────────────────────
+			const grillResult = await runGrillPhase(basePrompt, ctx);
+			if (grillResult.cancelled) {
+				ctx.ui.notify("❌ 操作已取消", "warning");
+				return;
+			}
+			const finalPrompt = grillResult.enhancedPrompt;
+
+			// ── Phase 4: Send to main agent ─────────────────────
+			ctx.ui.notify(`✅ 提示词已组装完成，正在发送给主代理...`, "success");
+			pi.sendUserMessage(finalPrompt);
+			ctx.ui.notify(`📝 /dev-feat 提示词已投递，主代理正在处理`, "info");
+
+			// ── Phase 5: Wait for agent to finish ───────────────
+			await ctx.waitForIdle();
+
+			// ── Phase 6: PRD generation ─────────────────────────
+			const moduleHint = (answers as FeatFields).module || "feature";
+			const grillContext = finalPrompt;
+			await runPRDPhase(grillContext, moduleHint, pi, ctx);
 		},
 	});
 
 	// ── /dev-fix ───────────────────────────────────────────────
 	pi.registerCommand("dev-fix", {
-		description: "(prompt wizard) 问题排查/错误修正 — 交互填写后发送优化提示词给主代理",
-		handler: async (args, ctx) => {
-			await runWizard(ctx, pi, "fix", "问题排查/错误修正", FIX_QUESTIONS, assembleFixPrompt);
+		description: "(prompt wizard) 问题排查/错误修正 — 支持根因分析评审 (Grill)",
+		handler: async (_args, ctx) => {
+			await runWizardWithGrill(
+				ctx, pi, "fix", "问题排查/错误修正",
+				FIX_QUESTIONS, assembleFixPrompt,
+				{
+					agentDef: FIX_GRILL_AGENT_DEF,
+					title: "🐛 Bug 根因分析评审",
+					description: "是否进入 Bug 根因分析评审 (Grill) 模式？\nAI 会从复现条件、根因推理、修复方案、回归风险等维度挑战你的理解。",
+					questionTitle: "Bug 根因分析",
+					loaderLabel: "🧠 AI 正在分析代码并生成根因评审问题...",
+				},
+			);
 		},
 	});
 
 	// ── /dev-doc ───────────────────────────────────────────────
 	pi.registerCommand("dev-doc", {
-		description: "(prompt wizard) 文档生成/总结 — 交互填写后发送优化提示词给主代理",
-		handler: async (args, ctx) => {
-			await runWizard(ctx, pi, "doc", "文档生成/总结", DOC_QUESTIONS, assembleDocPrompt);
+		description: "(prompt wizard) 文档生成/总结 — 支持大纲评审 (Grill)",
+		handler: async (_args, ctx) => {
+			await runWizardWithGrill(
+				ctx, pi, "doc", "文档生成/总结",
+				DOC_QUESTIONS, assembleDocPrompt,
+				{
+					agentDef: DOC_GRILL_AGENT_DEF,
+					title: "📄 文档大纲评审",
+					description: "是否进入文档大纲评审 (Grill) 模式？\nAI 会从受众定位、结构安排、示例选择等维度审视你的文档计划。",
+					questionTitle: "文档大纲评审",
+					loaderLabel: "🧠 AI 正在分析并生成文档大纲评审问题...",
+				},
+			);
 		},
 	});
 
 	// ── /dev-refactor ──────────────────────────────────────────
 	pi.registerCommand("dev-refactor", {
-		description: "(prompt wizard) 重构/优化现有结构 — 交互填写后发送优化提示词给主代理",
-		handler: async (args, ctx) => {
-			await runWizard(ctx, pi, "refactor", "重构/优化", REFACTOR_QUESTIONS, assembleRefactorPrompt);
+		description: "(prompt wizard) 重构/优化现有结构 — 支持重构计划评审 (Grill)",
+		handler: async (_args, ctx) => {
+			await runWizardWithGrill(
+				ctx, pi, "refactor", "重构/优化",
+				REFACTOR_QUESTIONS, assembleRefactorPrompt,
+				{
+					agentDef: REFACTOR_GRILL_AGENT_DEF,
+					title: "🔧 重构方案评审",
+					description: "是否进入重构方案评审 (Grill) 模式？\nAI 会从模块边界、API 兼容性、测试策略、迁移风险等维度审视你的重构计划。",
+					questionTitle: "重构方案评审",
+					loaderLabel: "🧠 AI 正在分析代码并生成重构评审问题...",
+				},
+			);
 		},
 	});
 
 	// ── /dev-test ──────────────────────────────────────────────
 	pi.registerCommand("dev-test", {
-		description: "(prompt wizard) 测试用例生成 — 交互填写后发送优化提示词给主代理",
-		handler: async (args, ctx) => {
-			await runWizard(ctx, pi, "test", "测试用例/评估", TEST_QUESTIONS, assembleTestPrompt);
+		description: "(prompt wizard) 测试用例生成 — 支持测试计划评审 (Grill)",
+		handler: async (_args, ctx) => {
+			await runWizardWithGrill(
+				ctx, pi, "test", "测试用例/评估",
+				TEST_QUESTIONS, assembleTestPrompt,
+				{
+					agentDef: TEST_GRILL_AGENT_DEF,
+					title: "🧪 测试计划评审",
+					description: "是否进入测试计划评审 (Grill) 模式？\nAI 会从覆盖维度、边界条件、模拟策略等角度审视你的测试方案。",
+					questionTitle: "测试计划评审",
+					loaderLabel: "🧠 AI 正在分析并生成测试评审问题...",
+				},
+			);
 		},
 	});
 
 	// ── /dev-chore ─────────────────────────────────────────────
 	pi.registerCommand("dev-chore", {
 		description: "(prompt wizard) 日常维护/杂项自动化 — 交互填写后发送优化提示词给主代理",
-		handler: async (args, ctx) => {
+		handler: async (_args, ctx) => {
 			await runWizard(ctx, pi, "chore", "日常维护/自动化", CHORE_QUESTIONS, assembleChorePrompt);
 		},
 	});
 
 	// ── /dev-perf ──────────────────────────────────────────────
 	pi.registerCommand("dev-perf", {
-		description: "(prompt wizard) 性能优化 — 交互填写后发送优化提示词给主代理",
-		handler: async (args, ctx) => {
-			await runWizard(ctx, pi, "perf", "性能优化", PERF_QUESTIONS, assemblePerfPrompt);
+		description: "(prompt wizard) 性能优化 — 支持优化方案评审 (Grill)",
+		handler: async (_args, ctx) => {
+			await runWizardWithGrill(
+				ctx, pi, "perf", "性能优化",
+				PERF_QUESTIONS, assemblePerfPrompt,
+				{
+					agentDef: PERF_GRILL_AGENT_DEF,
+					title: "⚡ 性能优化方案评审",
+					description: "是否进入性能优化方案评审 (Grill) 模式？\nAI 会从基准测试方法、优化方向、回归风险等维度审视你的方案。",
+					questionTitle: "性能优化方案评审",
+					loaderLabel: "🧠 AI 正在分析并生成性能优化评审问题...",
+				},
+			);
 		},
 	});
 
 	// ── /dev-style ─────────────────────────────────────────────
 	pi.registerCommand("dev-style", {
 		description: "(prompt wizard) 风格/格式调整 — 交互填写后发送优化提示词给主代理",
-		handler: async (args, ctx) => {
+		handler: async (_args, ctx) => {
 			await runWizard(ctx, pi, "style", "风格/格式调整", STYLE_QUESTIONS, assembleStylePrompt);
 		},
 	});
@@ -547,7 +841,7 @@ export default function (pi: ExtensionAPI) {
 	// ── /dev-security ──────────────────────────────────────────
 	pi.registerCommand("dev-security", {
 		description: "(prompt wizard) 安全审查 — 交互填写后发送优化提示词给主代理",
-		handler: async (args, ctx) => {
+		handler: async (_args, ctx) => {
 			await runWizard(ctx, pi, "security", "安全审查", SECURITY_QUESTIONS, assembleSecurityPrompt);
 		},
 	});
@@ -555,7 +849,7 @@ export default function (pi: ExtensionAPI) {
 	// ── /dev-explain ───────────────────────────────────────────
 	pi.registerCommand("dev-explain", {
 		description: "(prompt wizard) 概念解释 — 交互填写后发送优化提示词给主代理",
-		handler: async (args, ctx) => {
+		handler: async (_args, ctx) => {
 			await runWizard(ctx, pi, "explain", "概念解释", EXPLAIN_QUESTIONS, assembleExplainPrompt);
 		},
 	});
@@ -563,7 +857,7 @@ export default function (pi: ExtensionAPI) {
 	// ── /dev-compare ───────────────────────────────────────────
 	pi.registerCommand("dev-compare", {
 		description: "(prompt wizard) 对比评估 — 交互填写后发送优化提示词给主代理",
-		handler: async (args, ctx) => {
+		handler: async (_args, ctx) => {
 			await runWizard(ctx, pi, "compare", "对比评估", COMPARE_QUESTIONS, assembleComparePrompt);
 		},
 	});

package/extensions/git-commands.ts

@@ -47,11 +47,14 @@ function parseGitOutput(output: string): GitSummary {
 	}
 
 	// Parse <summary>...</summary>
-	const summaryMatch = output.match(/<summary>([\s\S]*?)<\/summary>/);
+	// Anchor to start of line (^ with m flag) to avoid matching a nested
+	// <summary> tag inside <details> content before the real top-level summary.
+	const summaryMatch = output.match(/^<summary>([\s\S]*?)<\/summary>/m);
 	if (summaryMatch) result.summary = summaryMatch[1].trim();
 
 	// Parse <details>...</details> → extract each line
-	const detailsMatch = output.match(/<details>([\s\S]*?)<\/details>/);
+	// Anchor to start of line to avoid matching nested <details> inside content.
+	const detailsMatch = output.match(/^<details>([\s\S]*?)<\/details>/m);
 	if (detailsMatch) {
 		const lines = detailsMatch[1]
 			.split("\n")