@gholl-studio/pier-connector 0.2.3 → 0.2.5

package/package.json

@@ -1,7 +1,7 @@
 {
     "name": "@gholl-studio/pier-connector",
     "author": "gholl",
-    "version": "0.2.3",
+    "version": "0.2.5",
     "description": "OpenClaw plugin that connects to the Pier job marketplace. Automatically fetches, executes, and reports distributed tasks for rewards.",
     "type": "module",
     "main": "src/index.js",

package/src/index.js

@@ -598,8 +598,8 @@ export default function register(api) {
                             durable_name: durableName,
                             filter_subject: msgSubject,
                             deliver_policy: DeliverPolicy.New, // Reverted to New to stop message storms (BUG-27)
-                            ack_policy: AckPolicy.Explicit,
-                            ack_wait: 30000, 
+                            ack_policy: AckPolicy.Explicit, // Explicit ACK is crucial for deduplication
+                            ack_wait: 1000 * 60 * 60, // 1 hour ACK wait to allow for long processing (BUG-30)
                         });
                         const consumer = await js.consumers.get(streamName, cInfo.name);
 
@@ -609,16 +609,23 @@ export default function register(api) {
                         (async () => {
                             logger.info(`[pier-connector] 👂 Monitoring chat subject ${msgSubject} (Durable: ${durableName})`);
 
-                            let isProcessing = false;
+                            const processedMessages = new Set();
+
                             for await (const msg of iter) {
                                 try {
                                     const rawMsg = new TextDecoder().decode(msg.data);
                                     let msgPayload;
                                     try {
                                         msgPayload = JSON.parse(rawMsg);
-                                    } catch (e) { 
+                                    } catch (e) {
+                                        msg.ack();
+                                        continue;
+                                    }
+
+                                    // Deduplication (prevents loops if NATS redelivers)
+                                    if (msgPayload.id && processedMessages.has(msgPayload.id)) {
                                         msg.ack();
-                                        continue; 
+                                        continue;
                                     }
 
                                     // Ignore my own messages
@@ -632,8 +639,8 @@ export default function register(api) {
                                         continue;
                                     }
 
-                                    // Send read receipt back
-                                    if (js && msgPayload.id) {
+                                    // Send read receipt back (ONLY for actual messages from users, BUG-31)
+                                    if (js && msgPayload.id && !msgPayload.type && msgPayload.sender_id !== config.nodeId) {
                                         try {
                                             const replySubject = `jobs.job.${jobId}.msg`;
                                             await js.publish(replySubject, new TextEncoder().encode(JSON.stringify({
@@ -641,9 +648,8 @@ export default function register(api) {
                                                 msg_id: msgPayload.id,
                                                 reader_id: config.nodeId
                                             })));
-                                            logger.debug(`[pier-connector] 👁️ Sent read receipt for message ${msgPayload.id}`);
                                         } catch (err) {
-                                            logger.error(`[pier-connector] Failed to send read receipt: ${err.message}`);
+                                            // Silently ignore receipt failures
                                         }
                                     }
 
@@ -651,40 +657,37 @@ export default function register(api) {
                                     const senderCore = msgPayload.sender_id;
 
                                     if (!content) {
-                                        logger.warn(`[pier-connector] ⚠️ Skipping message from ${senderCore} for ${jobId}: Empty content`);
                                         msg.ack();
                                         continue;
                                     }
 
-                                    if (isProcessing) {
-                                        logger.warn(`[pier-connector] ⏳ Throttling: Agent already processing for job ${jobId}`);
-                                        msg.nak();
-                                        continue;
-                                    }
-
                                     logger.info(`[pier-connector] 📥 Incoming chat: [${jobId}] sender=${senderCore} "${truncate(content, 40)}"`);
                                     
+                                    if (msgPayload.id) processedMessages.add(msgPayload.id);
+                                    
+                                    // ACK IMMEDIATELY to prevent NATS 30s timeout (BUG-27/30)
+                                    msg.ack();
+
                                     activeNodeJobs.set(jobId, {
                                         pierJobId: jobId,
                                         isRealtimeMsg: true
                                     });
 
-                                    // Trigger agent
-                                    try {
-                                        isProcessing = true;
-                                        await receiveIncoming({
-                                            accountId: config.accountId || 'default',
-                                            senderId: `pier:${senderCore}`,
-                                            text: content,
-                                        }, jobId);
-                                    } finally {
-                                        isProcessing = false;
-                                    }
-                                    
-                                    msg.ack();
+                                    // Trigger agent (Asynchronously to NOT block the loop)
+                                    (async () => {
+                                        try {
+                                            logger.info(`[pier-connector] 🧠 Triggering agent for job ${jobId}...`);
+                                            await receiveIncoming({
+                                                accountId: config.accountId || 'default',
+                                                senderId: `pier:${senderCore}`,
+                                                text: content,
+                                            }, jobId);
+                                        } catch (err) {
+                                            logger.error(`[pier-connector] Agent execution error: ${err.message}`);
+                                        }
+                                    })();
                                 } catch (err) {
                                     logger.error(`[pier-connector] Chat message processing error for ${jobId}: ${err.message}`);
-                                    msg.nak(); 
                                 }
                             }
                         })().catch(err => {