@ghilteras/opencode-agent-memory 0.4.0 → 0.4.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ghilteras/opencode-agent-memory",
-  "version": "0.4.0",
+  "version": "0.4.1",
   "description": "Letta-style editable memory blocks + journal for OpenCode (maintained fork of opencode-agent-memory).",
   "author": "Angelo Pantano <ghilteras@protonmail.com>",
   "license": "MIT",

package/src/embeddings.ts

@@ -25,6 +25,10 @@ async function getPipeline(cacheDir?: string) {
   return pipelinePromise;
 }
 
+export async function warmupEmbedder(cacheDir?: string): Promise<void> {
+  await getPipeline(cacheDir);
+}
+
 export async function generateEmbedding(
   text: string,
   cacheDir?: string,

package/src/frontmatter.ts

@@ -1,7 +1,7 @@
 import * as fs from "node:fs/promises";
 import * as path from "node:path";
 
-import yaml from "js-yaml";
+import * as yaml from "js-yaml";
 
 export function splitFrontmatter(text: string): {
   frontmatterText: string | undefined;

package/src/journal.test.ts

@@ -401,6 +401,9 @@ describe("journal store", () => {
       body: "unique-stale-dim-content",
     });
 
+    // First search: caches the entry with the correct mock embedding.
+    await store.search({ text: "unique-stale-dim-content" });
+
     // Simulate a v2 embedding with a WRONG dimension (e.g. from a 768d model).
     // Search must not throw: it should skip the embedding and fall back to
     // text matching for this entry.
@@ -424,6 +427,64 @@ describe("journal store", () => {
     // No throw above is the assertion: mismatched dimension degrades to text.
   });
 
+  test("sidecar rewrite after cache warm is picked up by second search", async () => {
+    tmpDir = await mkTmpDir();
+    const store = createJournalStore(tmpDir);
+
+    const entry = await store.write({
+      title: "Sidecar invalidation",
+      body: "unique-sidecar-invalidation-content",
+    });
+
+    // First search: caches the entry + correct sidecar fingerprint.
+    const r1 = await store.search({ text: "unique-sidecar-invalidation-content" });
+    expect(r1.entries.some((e) => e.title === "Sidecar invalidation")).toBe(true);
+
+    // Rewrite the sidecar with a wrong-dimension embedding (simulating
+    // sidecar regeneration without touching the .md).
+    const embeddingFile = entry.filePath.replace(/\.md$/, ".embedding");
+    await fs.writeFile(
+      embeddingFile,
+      JSON.stringify({
+        v: 2,
+        model: "some-768d-model",
+        dimension: 768,
+        vector: Array.from({ length: 768 }, () => 0.1),
+      }),
+      "utf-8",
+    );
+
+    // Second search must invalidate the cache (sidecar mtime changed) and
+    // pick up the stale-dimension embedding, falling back to text match.
+    const r2 = await store.search({ text: "unique-sidecar-invalidation-content" });
+    expect(r2.entries.some((e) => e.title === "Sidecar invalidation")).toBe(true);
+  });
+
+  test("sidecar deleted between searches falls back to text match", async () => {
+    tmpDir = await mkTmpDir();
+    const store = createJournalStore(tmpDir);
+
+    const entry = await store.write({
+      title: "Sidecar deleted entry",
+      body: "unique-sidecar-deleted-content",
+    });
+
+    // First search: caches the entry + sidecar fingerprint.
+    const r1 = await store.search({ text: "unique-sidecar-deleted-content" });
+    expect(r1.entries.some((e) => e.title === "Sidecar deleted entry")).toBe(true);
+
+    // Delete the sidecar file.
+    const embeddingFile = entry.filePath.replace(/\.md$/, ".embedding");
+    await fs.unlink(embeddingFile);
+
+    // Second search: cache miss (sidecar gone), falls back to text match
+    // (score 0.5) rather than using the stale cached embedding.
+    const r2 = await store.search({ text: "unique-sidecar-deleted-content" });
+    const found = r2.entries.find((e) => e.title === "Sidecar deleted entry");
+    expect(found).toBeDefined();
+    // Score is 0.5 (text fallback), not a cosine score
+  });
+
   test("search skips corrupt v2 embedding (empty vector) without throwing", async () => {
     tmpDir = await mkTmpDir();
     const store = createJournalStore(tmpDir);

package/src/journal.ts

@@ -2,7 +2,7 @@ import * as fs from "node:fs/promises";
 import * as os from "node:os";
 import * as path from "node:path";
 
-import yaml from "js-yaml";
+import * as yaml from "js-yaml";
 import { z } from "zod";
 
 import { cosineSimilarity, EMBEDDING_DIMENSION, embeddingModelName, generateEmbedding } from "./embeddings";
@@ -122,6 +122,15 @@ type ParsedEmbedding =
   | { vector: number[]; model: string; dimension: number }
   | undefined;
 
+type CachedEntry = {
+  entryMtimeMs: number;
+  entrySize: number;
+  embMtimeMs: number;
+  embSize: number;
+  entry: JournalEntry;
+  embedding: ParsedEmbedding;
+};
+
 async function loadEmbedding(entryPath: string): Promise<ParsedEmbedding> {
   const ePath = embeddingPath(entryPath);
   try {
@@ -197,6 +206,11 @@ export function createJournalStore(configDir?: string, cacheDir?: string): Journ
     "journal",
   );
 
+  // Per-store cache: each store instance owns its entries, so stores with
+  // different (including nested or ephemeral) journal directories never
+  // interfere and no foreign keys can accumulate.
+  const entryCache = new Map<string, CachedEntry>();
+
   return {
     async write(entry) {
       await fs.mkdir(journalDir, { recursive: true });
@@ -288,6 +302,12 @@ export function createJournalStore(configDir?: string, cacheDir?: string): Journ
         return { entries: [], total: 0, allTags: [] };
       }
 
+      // Prune cache entries for files that no longer exist
+      const alive = new Set(files.map((f) => path.join(journalDir, f)));
+      for (const key of entryCache.keys()) {
+        if (!alive.has(key)) entryCache.delete(key);
+      }
+
       // If a text query is provided, try semantic search first
       let queryEmbedding: number[] | undefined;
       if (query.text) {
@@ -301,14 +321,46 @@ export function createJournalStore(configDir?: string, cacheDir?: string): Journ
       // Collect all tags across every entry (before filtering)
       const tagSet = new Set<string>();
 
-      for (const file of files) {
+      const indexed = await Promise.all(files.map(async (file) => {
         const filePath = path.join(journalDir, file);
-        let entry: JournalEntry;
         try {
-          entry = await readEntryFile(filePath);
+          const ePath = embeddingPath(filePath);
+          const [entryStat, embStat] = await Promise.all([
+            fs.stat(filePath),
+            fs.stat(ePath).catch(() => ({ mtimeMs: -1, size: -1 } as const)),
+          ]);
+          const cached = entryCache.get(filePath);
+          if (
+            cached &&
+            cached.entryMtimeMs === entryStat.mtimeMs &&
+            cached.entrySize === entryStat.size &&
+            cached.embMtimeMs === embStat.mtimeMs &&
+            cached.embSize === embStat.size
+          ) {
+            return cached;
+          }
+          const [entry, embedding] = await Promise.all([
+            readEntryFile(filePath),
+            loadEmbedding(filePath),
+          ]);
+          const value: CachedEntry = {
+            entryMtimeMs: entryStat.mtimeMs,
+            entrySize: entryStat.size,
+            embMtimeMs: embStat.mtimeMs,
+            embSize: embStat.size,
+            entry,
+            embedding,
+          };
+          entryCache.set(filePath, value);
+          return value;
         } catch {
-          continue;
+          return undefined;
         }
+      }));
+
+      for (const cached of indexed) {
+        if (!cached) continue;
+        const { entry } = cached;
 
         // Collect tags before applying filters
         for (const tag of entry.tags) {
@@ -333,7 +385,7 @@ export function createJournalStore(configDir?: string, cacheDir?: string): Journ
         if (query.text) {
           if (queryEmbedding) {
             // Semantic search
-            const storedEmbedding = await loadEmbedding(filePath);
+            const storedEmbedding = cached.embedding;
             if (storedEmbedding) {
               // Hard gate: dimension must match, or the embedding is stale
               // (different model) and cannot be compared with cosine.

package/src/memory.ts

@@ -2,7 +2,7 @@ import * as fs from "node:fs/promises";
 import * as os from "node:os";
 import * as path from "node:path";
 
-import yaml from "js-yaml";
+import * as yaml from "js-yaml";
 import { z } from "zod";
 
 import { atomicWriteFile, buildFrontmatterDocument, splitFrontmatter } from "./frontmatter";

package/src/plugin.ts

@@ -16,6 +16,7 @@ import {
   MemorySet,
 } from "./tools";
 import type { JournalContext } from "./tools";
+import { warmupEmbedder } from "./embeddings";
 
 export const MemoryPlugin: Plugin = async ({ directory }) => {
   const store = createMemoryStore(directory);
@@ -37,6 +38,9 @@ export const MemoryPlugin: Plugin = async ({ directory }) => {
 
   if (journalEnabled) {
     const journalStore = createJournalStore(undefined, config.cacheDir);
+    // Warmup the embedder in the background; pass configured cacheDir so the
+    // first-init-wins singleton caches to the correct directory.
+    void warmupEmbedder(config.cacheDir).catch(() => {});
     journalTools = {
       journal_write: JournalWrite(journalStore, journalCtx),
       journal_read: JournalRead(journalStore),