@getvitops/cli 8.3.0-alpha.4 → 8.3.0-alpha.5

package/CHANGELOG.md

@@ -1,5 +1,34 @@
 # @getvitops/cli
 
+## 8.3.0-alpha.5
+
+### Minor Changes
+
+- 6b5ea17: **Leaner scaffolded `AGENTS.md`, and skills named by scope.** The EmDash template's `AGENTS.md` went from 212 to about 70 lines and the static one from 141 to about 50: only always-true rules stay (source of truth, generated CSS, branches, `vp`/`vpr`, where to look), and task-specific guidance moved into skills loaded when the task matches.
+
+  - **Breaking, `@getvitops/skills`: skills are renamed by scope.** `custom-blocks` → `emdash-custom-blocks`, `content-and-deploys` → `emdash-content-and-deploys`, `contact-form` → `emdash-contact-form`, `csp` → `vitops-csp`, `see-the-page` → `vitops-see-the-page`, `ads` → `vitops-ads`. `emdash-*` skills only apply to an EmDash site; `vitops-*` apply anywhere, and both prefixes are reserved for toolkit skills. New: `emdash-building-pages` (blocks, nesting, page opener, widget areas, escape hatches, layout primitives, `site.chrome`) and `vitops-consent` (split out of `vitops-design-system`, whose description and body now cover styling and tokens only). Existing sites: run `vp install` so `skills experimental_sync` relinks, and replace the per-skill `.agents/skills/<name>` / `.claude/skills/<name>` lines in `.gitignore` with `.agents/skills/vitops-*`, `.agents/skills/emdash-*` and the same two under `.claude/skills/`. A site's own skill must not use those prefixes.
+  - **`vitops agents sync`:** the block lists only skills that apply (a project without `emdash` in its dependencies gets no `emdash-*` ones, and they are not linked), summaries are cut at a clause rather than with an ellipsis, the pointer says `vp exec vitops docs`, and the version stamp is gone so the file no longer changes on every CLI bump.
+  - **`@getvitops/create`:** both templates ship the trimmed `AGENTS.md`; the project-naming steps moved into the `setup` skill and EmDash 1.x behaviours, legal-page replacement and the audit prerequisites into `emdash-content-and-deploys`. Existing sites: nothing to change beyond the skill rename; delete the sections you no longer need.
+
+- bb61a35: **Call tracking numbers: show an ad visitor a number that attributes the phone call.** Two additive config blocks, no CSS, no breaking change — all formats unaffected.
+
+  - **`site.ads.google.callTracking`** — Google Ads _website call conversions_. `{ label, number, cache? }` makes the consent-gated Google tag fetch a Google forwarding number (Canada supported) and swap it in for visitors who arrived from a Google ad. Google replaces text only, so the capture script also rewrites the matching `tel:` href. Needs `pixelId` and `site.tracking.enabled`; rejected on any other platform (only Google can put a number on the website — Microsoft's exist only inside the ad, in the US/UK/AU).
+  - **`site.tracking.phoneNumbers`** — per-platform numbers for every other platform: the real `number`, `sources` keyed by `site.ads` platform (plus `default-paid`), and an informational `provider`. You provision the numbers with a call-tracking service (Twilio, CallRail, …). The landing URL decides first, then the `_ac` cookie, so a visitor who declines `marketing` sees a tracking number on the landing page only. An organic visitor is never swapped, and the server-rendered HTML always carries the real number.
+  - The `tel:` tap beacon now carries which number was shown (`phoneSource`), and the conversion notification says so.
+  - `vitops ads lint` flags a call-tracking provider that is not in `site.legal.privacyPolicy.processors`, and notes that `callTracking` plus `conversionLabel.call` can count one call twice (make one secondary in Google Ads).
+  - `@getvitops/utils/tracking` exports the pure `selectPhoneNumber()` and helpers; the capture script mirrors it and `tracking.test.ts` pins the two.
+  - `@getvitops/skills` gains a **`vitops-ads`** skill (overview plus a `call-tracking.md` topic). The templates gitignore synced skills by prefix (`vitops-*`, `emdash-*`), so it needs no `.gitignore` line of its own.
+
+  `@getvitops/core`, `@getvitops/vite` and `@getvitops/emdash` — no consumer-facing change in these packages.
+
+### Patch Changes
+
+- Updated dependencies [785b8b3]
+- Updated dependencies [bb61a35]
+- Updated dependencies [4d94c8b]
+  - @getvitops/utils@8.3.0-alpha.5
+  - @getvitops/generator@8.3.0-alpha.5
+
 ## 8.3.0-alpha.4
 
 ### Minor Changes

package/dist/cli.mjs

@@ -1714,11 +1714,13 @@ async function cmdAdsLint(argv) {
 	const a = parse$1(argv, SITE_OPTS);
 	const cfg = await siteConfig(a);
 	const properties = toAdProperties(cfg, void 0);
-	if (properties.length === 0) {
+	const phones = cfg.site.tracking?.phoneNumbers;
+	if (properties.length === 0 && !phones) {
 		console.log("· no site.ads properties — nothing to check");
 		return;
 	}
 	const findings = [];
+	const notes = [];
 	const trackingOn = cfg.site.tracking?.enabled === true;
 	for (const p of properties) {
 		const platform = AD_PLATFORMS[p.provider];
@@ -1734,6 +1736,14 @@ async function cmdAdsLint(argv) {
 			if (configuredNoId.length) findings.push(`google: reporting is "server" but conversionActionId.${configuredNoId.join(", .")} is not set — ${configuredNoId.length === 1 ? "that action" : "those actions"} still fire client-side, not a failure but not what "server" asked for either`);
 		}
 	}
+	if (phones) {
+		const declared = (cfg.site.legal?.privacyPolicy?.processors ?? []).map((p) => p.name.toLowerCase());
+		if (!phones.provider) findings.push("site.tracking.phoneNumbers has no provider — state which call-tracking service holds these numbers (twilio, callrail, …) so the privacy policy can name it");
+		else if (!declared.some((n) => n.includes(phones.provider.toLowerCase()))) findings.push(`site.tracking.phoneNumbers.provider "${phones.provider}" records callers' numbers but is not in site.legal.privacyPolicy.processors — the generated privacy policy will not name it`);
+	}
+	const google = properties.find((p) => p.provider === "google" && p.enabled !== false);
+	if (google?.callTracking && normalizeConversionLabels(google.conversionLabel).call) notes.push("google: callTracking and conversionLabel.call are both set — one call can count twice. In Google Ads, make one of the two conversion actions secondary.");
+	for (const n of notes) console.warn(`! ${n}`);
 	if (findings.length === 0) {
 		console.log(`✓ ${properties.length} ad propert${properties.length === 1 ? "y" : "ies"} check out`);
 		return;
@@ -3655,6 +3665,20 @@ function linkSkill(linkPath, targetDir) {
 }
 const AGENTS_START = "<!-- vitops:start -->";
 const AGENTS_END = "<!-- vitops:end -->";
+/** Whether the project depends on EmDash: the `emdash-*` skills only make sense there. */
+function isEmdashSite(cwd) {
+	try {
+		const pkg = JSON.parse(readFileSync(resolve(cwd, "package.json"), "utf8"));
+		return Boolean({
+			...pkg.dependencies,
+			...pkg.devDependencies
+		}["emdash"]);
+	} catch {
+		return false;
+	}
+}
+/** Skill names carry their scope: `emdash-*` needs an EmDash site, `vitops-*` and the rest apply anywhere. */
+const appliesTo = (skill, emdash) => emdash || !skill.startsWith("emdash-");
 /** A frontmatter `description`, whether a plain line or a folded (`>-`) scalar. */
 function descriptionOf(skillMd) {
 	const fm = /^---\n([\s\S]*?)\n---/.exec(skillMd)?.[1] ?? "";
@@ -3667,10 +3691,15 @@ function descriptionOf(skillMd) {
 * One short line saying when to load a skill: its "Use when/for/before …" sentence if it has one
 * (that is the part that answers "is this the one?"), else its first sentence.
 */
-function skillSummary(skillMd, max = 90) {
+function skillSummary(skillMd, max = 120) {
 	const description = descriptionOf(skillMd);
 	const line = /\bUse (?:when|for|before|ONLY)\b[^.]*/.exec(description)?.[0] ?? description.split(/(?<=[.!?])\s/)[0] ?? description;
-	return line.length > max ? `${line.slice(0, max - 1).trimEnd()}…` : line;
+	if (line.length <= max) return line;
+	const head = line.slice(0, max);
+	const cut = Math.max(head.lastIndexOf(", "), head.lastIndexOf(" or "), head.lastIndexOf(" — "));
+	let out = cut > max / 2 ? head.slice(0, cut) : head.slice(0, head.lastIndexOf(" "));
+	if ((out.match(/\(/g) ?? []).length > (out.match(/\)/g) ?? []).length) out = out.slice(0, out.lastIndexOf("("));
+	return out.replace(/[\s,;:—-]+$/, "");
 }
 /**
 * The skills that belong in the block: those under `.agents/skills` that are links into an installed
@@ -3680,8 +3709,10 @@ function skillSummary(skillMd, max = 90) {
 function discoverBlockSkills(cwd) {
 	const dir = resolve(cwd, ".agents", "skills");
 	if (!existsSync(dir)) return [];
+	const emdash = isEmdashSite(cwd);
 	const out = [];
 	for (const name of readdirSync(dir).sort()) {
+		if (!appliesTo(name, emdash)) continue;
 		const link = join(dir, name);
 		const skillFile = join(link, "SKILL.md");
 		if (!lstatSync(link).isSymbolicLink() || !existsSync(skillFile)) continue;
@@ -3701,6 +3732,7 @@ function discoverBlockSkills(cwd) {
 */
 function linkPackagedSkills(cwd) {
 	const warnings = [];
+	const emdash = isEmdashSite(cwd);
 	let dir = resolve(cwd);
 	const { root } = parse(dir);
 	for (;;) {
@@ -3708,7 +3740,7 @@ function linkPackagedSkills(cwd) {
 		if (existsSync(skills)) {
 			for (const name of readdirSync(skills)) {
 				const target = join(skills, name);
-				if (!existsSync(join(target, "SKILL.md"))) continue;
+				if (!existsSync(join(target, "SKILL.md")) || !appliesTo(name, emdash)) continue;
 				for (const base of [".agents", ".claude"]) {
 					const warn = linkSkill(resolve(cwd, base, "skills", name), target);
 					if (warn) warnings.push(warn);
@@ -3733,8 +3765,7 @@ function renderAgentsBlock(opts) {
 		"",
 		...opts.skills.map((s) => `- [${s.name}](${s.path})${s.summary ? ` — ${s.summary}` : ""}`),
 		...opts.skills.length ? [""] : [],
-		"Reference, rendered from this project: `vitops docs <topic>` (no topic lists them).",
-		`<!-- managed by \`vitops agents sync\` · @getvitops/cli@${opts.version} — edit outside this block -->`,
+		"Reference, rendered from this project: `vp exec vitops docs [topic]` (no topic lists them).",
 		AGENTS_END
 	].join("\n");
 }
@@ -5212,13 +5243,6 @@ async function cmdReviews(argv) {
 	}
 	if (failed) process.exit(1);
 }
-function cliVersion() {
-	try {
-		return JSON.parse(readFileSync(new URL("../package.json", import.meta.url), "utf8")).version ?? "0.0.0";
-	} catch {
-		return "0.0.0";
-	}
-}
 function generatorAssetsDir() {
 	const pkg = createRequire(import.meta.url).resolve("@getvitops/generator/package.json");
 	return join(dirname(pkg), "assets");
@@ -5496,8 +5520,7 @@ function cmdAgents(rawArgv) {
 	}
 	const block = legacyBlock ?? renderAgentsBlock({
 		config: inputRel,
-		skills: discoverBlockSkills(process.cwd()),
-		version: cliVersion()
+		skills: discoverBlockSkills(process.cwd())
 	});
 	const outPath = resolve(values.out);
 	const existing = existsSync(outPath) ? readFileSync(outPath, "utf8") : void 0;