@getpipher/armory-todo 0.2.0 → 0.3.1

package/src/panel-data.ts

@@ -4,27 +4,21 @@
 
 import type { SelectItem, SettingItem } from "@earendil-works/pi-tui";
 import type { Todo } from "./todo-store.ts";
+import type { DoneItem } from "./archive.ts";
 import type { ArchiveSummary } from "./archive.ts";
 import type { TodoConfig } from "./config.ts";
 
-/** Format a todo as a SelectList item: "[id] (prio)⏵ (project) text…".
- *  The project tag is placed BEFORE the text so it's always visible (not
- *  clipped at the right edge). The text is truncated to a readable summary
- *  (first ~80 chars) so long running-log todos don't blow out the row width.
- *  The full text is still accessible via the "Edit text" action in the panel. */
+/** Format a todo as a SelectList item: "[id] (prio)⏵ (project) • title".
+ *  title is already ≤120 chars (enforced at write time), so no truncation is
+ *  needed. The • marker shows when notes is non-empty (signals "open the
+ *  detail view / use `todo get` for context"). */
 export function todoToItem(t: Todo): SelectItem {
   const pin = t.status === "in_progress" ? " ⏵" : "";
   const proj = t.project ? ` (${t.project})` : "";
-  const prefix = `[${t.id}] (${t.priority})${pin}${proj}`;
-  const maxText = 80;
-  let text = t.text;
-  if (text.length > maxText) {
-    const firstLine = text.split("\n")[0]!;
-    text = firstLine.length > maxText ? firstLine.slice(0, maxText - 1) + "…" : firstLine + "…";
-  }
+  const dot = t.notes.trim() ? " •" : "";
   return {
     value: t.id,
-    label: `${prefix} ${text}`,
+    label: `[${t.id}] (${t.priority})${pin}${proj}${dot} ${t.title}`,
   };
 }
 
@@ -50,7 +44,7 @@ export function actionsForTodo(t: Todo): { label: string; action: string }[] {
   if (t.status === "done" || t.status === "cancelled") {
     actions.push({ label: "Restore (from archive)", action: "restore" });
   }
-  actions.push({ label: "Edit text", action: "edit" });
+  actions.push({ label: "Edit title", action: "edit" });
   actions.push({ label: "Delete (cancel)", action: "delete" });
   return actions;
 }
@@ -67,4 +61,21 @@ export function configToSettingItems(cfg: TodoConfig): SettingItem[] {
     { id: "archiveMax", label: "Archive max", currentValue: String(cfg.health.archiveMax), values: ["100", "200", "500"], description: "Bloat flag when archive exceeds this." },
     { id: "archiveOldDays", label: "Archive old (days)", currentValue: String(cfg.health.archiveOldDays), values: ["90", "180", "365"], description: "Bloat flag when archive items older than this." },
   ];
-}
+}
+
+/** Format a done todo (live or archived) as a SelectList item with a
+ *  location tag: "[live Nd]" or "[archived YYYY-MM-DD]". */
+export function todoDoneItem(d: DoneItem): SelectItem {
+  const proj = d.project ? ` (${d.project})` : "";
+  const loc = d.location === "archive" && d.archivedAt
+    ? ` [archived ${d.archivedAt.slice(0, 10)}]`
+    : ` [live ${d.closedAt ? Math.floor((Date.now() - Date.parse(d.closedAt)) / 86400_000) : 0}d]`;
+  return { value: d.id, label: `[${d.id}] (done)${proj}${loc} ${d.title}` };
+}
+
+/** Actions for a done todo: View detail always; Restore only if archived. */
+export function actionsForDoneTodo(d: DoneItem): { label: string; action: string }[] {
+  const acts: { label: string; action: string }[] = [{ label: "View detail", action: "view" }];
+  if (d.location === "archive") acts.push({ label: "Restore (from archive)", action: "restore" });
+  return acts;
+}

package/src/panel.ts

@@ -21,13 +21,13 @@ import {
   type Theme,
 } from "@earendil-works/pi-tui";
 import { listTodos, parkTodo, completeTodo, deleteTodo, updateTodo, type Todo, type Status } from "./todo-store.ts";
-import { restoreTodo, archiveSummary, listArchived } from "./archive.ts";
+import { restoreTodo, archiveSummary, listArchived, listDoneUnified } from "./archive.ts";
 import { loadConfig, saveConfig, type TodoConfig } from "./config.ts";
 import { healthReport } from "./health.ts";
-import { todoToItem, archiveSummaryToItems, actionsForTodo, configToSettingItems } from "./panel-data.ts";
+import { todoToItem, archiveSummaryToItems, actionsForTodo, configToSettingItems, todoDoneItem, actionsForDoneTodo } from "./panel-data.ts";
 
-export type Box = "active" | "parked" | "archive" | "config";
-const BOXES: Box[] = ["active", "parked", "archive", "config"];
+export type Box = "active" | "parked" | "done" | "archive" | "config";
+const BOXES: Box[] = ["active", "parked", "done", "archive", "config"];
 
 export interface TodoPanelOpts {
   theme: Theme;
@@ -47,6 +47,8 @@ export class TodoPanel extends Container {
   private editMode = false;
   private editInput: Input | null = null;
   private editId = "";
+  private detailMode = false;
+  private detailId = "";
   private settingsList: SettingsList | null = null;
   private config: TodoConfig;
   private healthFlags: string[] = [];
@@ -105,6 +107,20 @@ export class TodoPanel extends Container {
     } else if (this.actionMode && this.actionList) {
       this.addChild(new Text(this.theme.fg("accent", "  Action:"), 0, 0));
       this.addChild(this.actionList);
+    } else if (this.detailMode) {
+      const all = listTodos({ status: "all", limit: 200 });
+      const t = all.find((x) => x.id === this.detailId);
+      if (!t) { this.detailMode = false; this.renderShell(); return; }
+      const proj = t.project || "no project";
+      const tags = t.tags.length ? t.tags.join(" ") : "(none)";
+      const notesText = t.notes || "(empty)";
+      this.addChild(new Text(this.theme.fg("accent", "  " + t.title), 0, 0));
+      this.addChild(new Text(this.theme.fg("muted", "  (" + t.priority + "/" + t.status + ") - " + proj + " - #" + tags), 0, 0));
+      this.addChild(new Spacer(1));
+      this.addChild(new Text(this.theme.fg("dim", "  notes:"), 0, 0));
+      this.addChild(new Text("  " + notesText, 0, 0));
+      this.addChild(new Spacer(1));
+      this.addChild(new Text(this.theme.fg("dim", "  notes: read-only - todo update <id> notes=... to edit"), 0, 0));
     } else if (this.currentBox === "config") {
       this.renderConfigBox();
     } else {
@@ -126,6 +142,9 @@ export class TodoPanel extends Container {
     } else if (this.currentBox === "parked") {
       const todos = listTodos({ status: "parked", text: filter || undefined, limit: 50 });
       this.setSelectItems(todos.map(todoToItem));
+    } else if (this.currentBox === "done") {
+      const items = listDoneUnified({ text: filter || undefined, limit: 50 });
+      this.setSelectItems(items.map(todoDoneItem));
     } else if (this.currentBox === "archive") {
       if (!filter) {
         const s = archiveSummary();
@@ -173,13 +192,20 @@ export class TodoPanel extends Container {
   }
 
   private openActionSubmenu(id: string): void {
-    const all = listTodos({ status: "all", limit: 200 });
-    const todo = all.find((t) => t.id === id);
-    if (!todo) {
-      this.onNotify("Todo not found in the live store (archive restore: use the archive box).", "info");
-      return;
+    let acts: { label: string; action: string }[];
+    if (this.currentBox === "done") {
+      const d = listDoneUnified({}).find((x) => x.id === id);
+      if (!d) { this.onNotify("Done todo not found.", "info"); return; }
+      acts = actionsForDoneTodo(d);
+    } else {
+      const all = listTodos({ status: "all", limit: 200 });
+      const todo = all.find((t) => t.id === id);
+      if (!todo) {
+        this.onNotify("Todo not found in the live store (archive restore: use the archive box).", "info");
+        return;
+      }
+      acts = [{ label: "View detail", action: "view" }, ...actionsForTodo(todo)];
     }
-    const acts = actionsForTodo(todo);
     const items: SelectItem[] = acts.map((a) => ({ value: a.action, label: a.label }));
     this.actionList = new SelectList(items, 8, {
       selectedPrefix: (s) => this.theme.fg("accent", s),
@@ -194,9 +220,23 @@ export class TodoPanel extends Container {
     this.renderShell();
   }
 
+  private viewDetail(id: string): void {
+    const all = listTodos({ status: "all", limit: 200 });
+    const t = all.find((x) => x.id === id);
+    if (!t) { this.onNotify("Todo not found.", "info"); return; }
+    this.detailId = id;
+    this.detailMode = true;
+    this.actionMode = false;
+    this.actionList = null;
+    this.editMode = false;
+    this.editInput = null;
+    this.renderShell();
+  }
+
   private async executeAction(id: string, action: string): Promise<void> {
     try {
       switch (action) {
+        case "view": this.viewDetail(id); return;
         case "complete": completeTodo(id); this.onNotify(`Completed ${id}`); break;
         case "park": parkTodo(id); this.onNotify(`Parked ${id}`); break;
         case "open": updateTodo(id, { status: "open" as Status }); this.onNotify(`Re-activated ${id}`); break;
@@ -207,9 +247,12 @@ export class TodoPanel extends Container {
           const t = all.find((x) => x.id === id);
           this.editId = id;
           this.editInput = new Input();
-          this.editInput.setValue(t?.text ?? "");
+          this.editInput.setValue(t?.title ?? "");
           this.editInput.onSubmit = (value) => {
-            if (value.trim()) { updateTodo(id, { text: value.trim() }); this.onNotify(`Edited ${id}`); }
+            if (value.trim()) {
+              try { updateTodo(id, { title: value.trim() }); this.onNotify(`Edited ${id}`); }
+              catch (err) { this.onNotify((err as Error).message, "error"); }
+            }
             this.exitEditMode();
           };
           this.editInput.onEscape = () => this.exitEditMode();
@@ -221,7 +264,7 @@ export class TodoPanel extends Container {
         }
       }
     } catch (err) {
-      this.onNotify(`Error: ${(err as Error).message}`, "error");
+      this.onNotify((err as Error).message, "error");
     }
     this.actionMode = false;
     this.actionList = null;
@@ -308,6 +351,17 @@ export class TodoPanel extends Container {
       this.invalidate();
       return;
     }
+    if (this.detailMode) {
+      if (matchesKey(data, "escape") || matchesKey(data, "esc") || matchesKey(data, "enter") || matchesKey(data, "return")) {
+        this.detailMode = false;
+        this.detailId = "";
+        this.refreshList();
+        this.renderShell();
+        return;
+      }
+      this.invalidate();
+      return;
+    }
     if (this.actionMode && this.actionList) {
       if (matchesKey(data, "escape") || matchesKey(data, "esc")) {
         this.actionMode = false;

package/src/todo-store.ts

@@ -18,7 +18,7 @@ import {
 } from "node:fs";
 import { dirname } from "node:path";
 import { getLivePath, getTodoDir, getLegacyPath } from "./paths.ts";
-import { migrateIfNeeded } from "./migrate.ts";
+import { migrateIfNeeded, migrateV2ToV3 } from "./migrate.ts";
 
 export type Priority = "low" | "med" | "high" | "critical";
 export type Status = "open" | "in_progress" | "parked" | "done" | "cancelled";
@@ -31,7 +31,8 @@ const STATUS_SET = new Set(STATUSES);
 
 export interface Todo {
   id: string;
-  text: string;
+  title: string;       // ≤120 chars, non-empty, trimmed
+  notes: string;       // any length, may be ""
   project: string;
   tags: string[];
   priority: Priority;
@@ -43,13 +44,14 @@ export interface Todo {
 }
 
 export interface Store {
-  version: 2;
+  version: 3;
   updatedAt: string;
   todos: Todo[];
 }
 
 export interface AddInput {
-  text: string;
+  title: string;
+  notes?: string;
   project?: string;
   tags?: string[];
   priority?: Priority;
@@ -57,7 +59,8 @@ export interface AddInput {
 }
 
 export interface UpdateInput {
-  text?: string;
+  title?: string;
+  notes?: string;
   project?: string;
   tags?: string[];
   priority?: Priority;
@@ -86,8 +89,19 @@ function genId(): string {
   return "td-" + Date.now().toString(36) + Math.random().toString(36).slice(2, 8);
 }
 
+const TITLE_MAX = 120;  // must match the constant in migrate.ts
+
+function normalizeTitle(raw: string): string {
+  const t = raw.trim();
+  if (!t) throw new TodoError("title is required");
+  if (t.length > TITLE_MAX) {
+    throw new TodoError(`title must be ≤${TITLE_MAX} chars (got ${t.length}); move detail into notes`);
+  }
+  return t;
+}
+
 function emptyStore(): Store {
-  return { version: 2, updatedAt: now(), todos: [] };
+  return { version: 3, updatedAt: now(), todos: [] };
 }
 
 export function getStorePath(): string {
@@ -105,14 +119,18 @@ export function loadStore(): Store {
   if (!existsSync(path)) return emptyStore();
   try {
     const raw = readFileSync(path, "utf8");
-    const parsed = JSON.parse(raw) as Store;
+    let parsed = JSON.parse(raw) as Store;
     if (!parsed || typeof parsed !== "object" || !Array.isArray(parsed.todos)) {
       throw new Error("invalid store shape");
     }
-    if (parsed.version !== 2) {
-      // v1 → v2: accept it (the migration moved the file), just bump the version in memory.
-      // The data shape is otherwise identical; parked status is new but old todos won't have it.
-      parsed.version = 2;
+    if (parsed.version === 2) {
+      // v2 → v3: curated map + fallback, persist once so migration runs a single time.
+      const migrated = migrateV2ToV3(parsed as any) as unknown as Store;
+      saveStore(migrated);
+      return migrated;
+    }
+    if (parsed.version !== 3) {
+      throw new Error("invalid store shape");
     }
     return parsed;
   } catch {
@@ -160,13 +178,14 @@ function findOrFail(store: Store, id: string): Todo {
 }
 
 export function addTodo(input: AddInput): Todo {
-  const text = (input.text ?? "").trim();
-  if (!text) throw new TodoError("text is required");
+  const title = normalizeTitle(input.title);
   if (input.priority) assertPriority(input.priority);
+  const notes = (input.notes ?? "").trim();
   const store = loadStore();
   const todo: Todo = {
     id: genId(),
-    text,
+    title,
+    notes,
     project: (input.project ?? "").trim(),
     tags: (input.tags ?? []).map((t) => t.trim()).filter(Boolean),
     priority: input.priority ?? "med",
@@ -195,7 +214,7 @@ export function listTodos(filter: ListFilter = {}): Todo[] {
   if (filter.tag) out = out.filter((t) => t.tags.includes(filter.tag as string));
   if (filter.text) {
     const q = filter.text.toLowerCase();
-    out = out.filter((t) => t.text.toLowerCase().includes(q));
+    out = out.filter((t) => t.title.toLowerCase().includes(q) || t.notes.toLowerCase().includes(q));
   }
   if (filter.since) out = out.filter((t) => t.createdAt >= (filter.since as string));
   if (filter.before) out = out.filter((t) => t.createdAt < (filter.before as string));
@@ -218,11 +237,8 @@ export function listTodos(filter: ListFilter = {}): Todo[] {
 export function updateTodo(id: string, patch: UpdateInput): Todo {
   const store = loadStore();
   const todo = findOrFail(store, id);
-  if (patch.text !== undefined) {
-    const text = patch.text.trim();
-    if (!text) throw new TodoError("text must not be empty");
-    todo.text = text;
-  }
+  if (patch.title !== undefined) todo.title = normalizeTitle(patch.title);
+  if (patch.notes !== undefined) todo.notes = patch.notes.trim();
   if (patch.project !== undefined) todo.project = patch.project.trim();
   if (patch.tags !== undefined) todo.tags = patch.tags.map((t) => t.trim()).filter(Boolean);
   if (patch.priority !== undefined) {
@@ -242,6 +258,11 @@ export function updateTodo(id: string, patch: UpdateInput): Todo {
   return todo;
 }
 
+export function getTodo(id: string): Todo {
+  const store = loadStore();
+  return findOrFail(store, id);
+}
+
 export function completeTodo(id: string): Todo {
   return updateTodo(id, { status: "done" });
 }
@@ -272,7 +293,8 @@ export function renderOpenBlock(max = 15): string {
   const lines = shown.map((t) => {
     const tag = t.project ? ` (${t.project})` : "";
     const pin = t.status === "in_progress" ? " ⏵" : "";
-    return `- [${t.id}] (${t.priority})${pin} ${t.text}${tag}`;
+    const dot = t.notes.trim() ? " •" : "";
+    return `- [${t.id}] (${t.priority})${pin}${dot} ${t.title}${tag}`;
   });
   const overflow = todos.length > max ? `\n- … +${todos.length - max} more (use \`todo list\`)` : "";
   return `## Open TODOs (${todos.length})\n${lines.join("\n")}${overflow}\n`;