@getnote/cli 1.5.6 → 1.5.7

package/README.md

@@ -35,13 +35,14 @@ getnote auth login
 
 或者从 [Releases](https://github.com/iswalle/getnote-cli/releases) 下载对应平台的二进制文件，放到 `$PATH` 里。
 
-**Windows 用户**：推荐直接从 [Releases](https://github.com/iswalle/getnote-cli/releases) 下载 `.exe` 文件，放到 PATH 里。用 `npm install -g` 安装时，如果遇到 `Expand-Archive` 相关报错，可尝试：
+**pnpm 10+ 用户**：pnpm 默认会拦截依赖包的构建脚本。请在工作区的 `pnpm-workspace.yaml` 中允许 `@getnote/cli` 运行安装脚本：
 
-```bash
-npm install -g @getnote/cli --ignore-scripts
+```yaml
+allowBuilds:
+  '@getnote/cli': true
 ```
 
-然后手动从 Releases 下载对应平台的二进制文件。
+然后重新执行 `pnpm install`。也可以直接从 [Releases](https://github.com/iswalle/getnote-cli/releases) 下载对应平台的二进制文件并放入 `$PATH`。
 
 ---
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@getnote/cli",
-  "version": "1.5.6",
+  "version": "1.5.7",
   "description": "CLI tool for 得到大脑（Get笔记） — manage notes and knowledge bases from the terminal",
   "keywords": [
     "getnote",
@@ -19,7 +19,8 @@
     "gnote": "./bin/getnote.js"
   },
   "scripts": {
-    "postinstall": "node scripts/postinstall.js"
+    "postinstall": "node scripts/postinstall.js",
+    "test": "node --test scripts/postinstall.test.js"
   },
   "files": [
     "bin/getnote.js",

package/scripts/postinstall.js

@@ -37,6 +37,45 @@ function getDownloadURL(platform) {
   return `https://github.com/${REPO}/releases/download/v${VERSION}/${asset}`;
 }
 
+function getWindowsExtractArgs(archivePath, destinationPath) {
+  return [
+    '-NoProfile',
+    '-Command',
+    '& { Expand-Archive -LiteralPath $args[0] -DestinationPath $args[1] -Force }',
+    archivePath,
+    destinationPath,
+  ];
+}
+
+async function installArchive({
+  platform,
+  binDir,
+  binaryName,
+  binaryPath,
+  url,
+  tmpFile,
+  downloadFn = download,
+  verifyChecksumFn = verifyChecksum,
+  runFn = run,
+  chmodFn = fs.chmodSync,
+  unlinkFn = fs.unlinkSync,
+}) {
+  try {
+    await downloadFn(url, tmpFile);
+    await verifyChecksumFn(url, path.basename(url), tmpFile);
+    if (platform.platform === 'windows') {
+      runFn('powershell', getWindowsExtractArgs(tmpFile, binDir));
+    } else {
+      runFn('tar', ['-xzf', tmpFile, '-C', binDir, binaryName]);
+    }
+
+    chmodFn(binaryPath, 0o755);
+    console.log(`getnote installed at ${binaryPath}`);
+  } finally {
+    try { unlinkFn(tmpFile); } catch (_) {}
+  }
+}
+
 async function main() {
   const platform = getPlatform();
   const binDir = path.join(__dirname, '..', 'bin');
@@ -63,24 +102,7 @@ async function main() {
 
   fs.mkdirSync(binDir, { recursive: true });
 
-  try {
-    await download(url, tmpFile);
-    await verifyChecksum(url, path.basename(url), tmpFile);
-    if (platform.platform === 'windows') {
-      run('powershell', ['-NoProfile', '-Command', 'Expand-Archive -LiteralPath $args[0] -DestinationPath $args[1] -Force', tmpFile, binDir]);
-    } else {
-      run('tar', ['-xzf', tmpFile, '-C', binDir, binaryName]);
-    }
-
-    fs.chmodSync(binaryPath, 0o755);
-    console.log(`getnote installed at ${binaryPath}`);
-
-  } catch (err) {
-    console.error('Failed to install getnote:', err.message);
-    process.exit(1);
-  } finally {
-    try { fs.unlinkSync(tmpFile); } catch (_) {}
-  }
+  await installArchive({ platform, binDir, binaryName, binaryPath, url, tmpFile });
 }
 
 function run(command, args) {
@@ -128,7 +150,11 @@ async function verifyChecksum(assetURL, assetName, archivePath) {
   }
 }
 
-main().catch(err => {
-  console.error('Failed to install getnote:', err.message);
-  process.exit(1);
-});
+if (require.main === module) {
+  main().catch(err => {
+    console.error('Failed to install getnote:', err.message);
+    process.exitCode = 1;
+  });
+}
+
+module.exports = { getWindowsExtractArgs, installArchive };

package/scripts/postinstall.test.js

@@ -0,0 +1,37 @@
+'use strict';
+
+const assert = require('node:assert/strict');
+const test = require('node:test');
+
+const { getWindowsExtractArgs, installArchive } = require('./postinstall');
+
+test('Windows extraction invokes Expand-Archive inside a script block', () => {
+  assert.deepEqual(getWindowsExtractArgs('C:\\Temp\\getnote.zip', 'C:\\Program Files\\getnote'), [
+    '-NoProfile',
+    '-Command',
+    '& { Expand-Archive -LiteralPath $args[0] -DestinationPath $args[1] -Force }',
+    'C:\\Temp\\getnote.zip',
+    'C:\\Program Files\\getnote',
+  ]);
+});
+
+test('temporary archive is removed when installation fails', async () => {
+  const removed = [];
+  await assert.rejects(
+    installArchive({
+      platform: { platform: 'windows', arch: 'amd64' },
+      binDir: 'C:\\getnote\\bin',
+      binaryName: 'getnote.exe',
+      binaryPath: 'C:\\getnote\\bin\\getnote.exe',
+      url: 'https://example.invalid/getnote.zip',
+      tmpFile: 'C:\\Temp\\getnote-download.zip',
+      downloadFn: async () => { throw new Error('download failed'); },
+      verifyChecksumFn: async () => {},
+      runFn: () => {},
+      chmodFn: () => {},
+      unlinkFn: file => removed.push(file),
+    }),
+    /download failed/,
+  );
+  assert.deepEqual(removed, ['C:\\Temp\\getnote-download.zip']);
+});