@getmicdrop/svelte-components 5.8.1 → 5.8.2
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dist/calendar/AboutShow/AboutShow.svelte +172 -172
- package/dist/calendar/Calendar/MiniMonthCalendar.svelte +782 -782
- package/dist/calendar/FAQs/FAQs.svelte +75 -75
- package/dist/calendar/MonthSwitcher/MonthSwitcher.svelte +126 -126
- package/dist/calendar/OrderSummary/OrderSummary.svelte +367 -367
- package/dist/calendar/PublicCard/PublicCard.svelte +134 -134
- package/dist/calendar/ShowCard/ShowCard.svelte +157 -157
- package/dist/calendar/ShowTimeCard/ShowTimeCard.svelte +61 -61
- package/dist/components/Heading.svelte +60 -58
- package/dist/components/Heading.svelte.d.ts +1 -0
- package/dist/components/Heading.svelte.d.ts.map +1 -1
- package/dist/components/Layout/AppShell.svelte +104 -104
- package/dist/components/Layout/ContentSection.svelte +80 -80
- package/dist/components/Layout/Grid.svelte +4 -4
- package/dist/components/Layout/Heading.svelte +81 -81
- package/dist/components/Layout/PageContainer.svelte +69 -69
- package/dist/components/Layout/Responsive.svelte +75 -75
- package/dist/components/Layout/Section.svelte +80 -80
- package/dist/components/Layout/ShowOnDesktop.svelte +37 -37
- package/dist/components/Layout/ShowOnMobile.svelte +37 -37
- package/dist/components/Layout/Sidebar.svelte +108 -108
- package/dist/components/Layout/Stack.spec.js +1 -1
- package/dist/components/Layout/Stack.svelte +6 -6
- package/dist/components/Layout/Text.svelte +87 -87
- package/dist/components/Layout/TwoColumn.svelte +108 -108
- package/dist/components/Text.svelte +53 -53
- package/dist/constants/validation.js +91 -91
- package/dist/constants/validation.spec.js +64 -64
- package/dist/datetime/__tests__/format.test.js +1 -1
- package/dist/datetime/__tests__/parse.test.js +1 -1
- package/dist/datetime/__tests__/timezone.test.js +1 -1
- package/dist/datetime/parse.js +1 -1
- package/dist/forms/createFormStore.svelte.js +1 -0
- package/dist/index.js +50 -50
- package/dist/patterns/data/DataGrid.svelte +45 -45
- package/dist/patterns/data/DataList.svelte +24 -24
- package/dist/patterns/data/DataTable.svelte +36 -36
- package/dist/patterns/forms/FormActions.spec.js +95 -95
- package/dist/patterns/forms/FormActions.stories.svelte +97 -97
- package/dist/patterns/forms/FormActions.svelte +46 -46
- package/dist/patterns/forms/FormGrid.svelte +33 -33
- package/dist/patterns/forms/FormSection.svelte +32 -32
- package/dist/patterns/forms/FormValidationSummary.stories.svelte +83 -83
- package/dist/patterns/forms/FormValidationSummary.svelte +74 -74
- package/dist/patterns/layout/Sidebar.svelte +39 -39
- package/dist/patterns/layout/index.js +29 -29
- package/dist/patterns/navigation/BottomNav.stories.svelte +117 -117
- package/dist/patterns/navigation/BottomNav.svelte +74 -74
- package/dist/patterns/navigation/Header.stories.svelte +77 -77
- package/dist/patterns/navigation/Header.svelte +193 -193
- package/dist/patterns/page/PageHeader.svelte +18 -18
- package/dist/patterns/page/PageLayout.svelte +40 -40
- package/dist/patterns/page/PageLoader.spec.js +57 -57
- package/dist/patterns/page/PageLoader.stories.svelte +137 -137
- package/dist/patterns/page/PageLoader.svelte +24 -24
- package/dist/patterns/page/SectionHeader.svelte +29 -29
- package/dist/presets/badges.js +112 -112
- package/dist/presets/buttons.js +76 -76
- package/dist/presets/index.js +9 -9
- package/dist/primitives/Accordion/Accordion.stories.svelte +75 -75
- package/dist/primitives/Accordion/Accordion.svelte +42 -42
- package/dist/primitives/Accordion/AccordionItem.svelte +95 -95
- package/dist/primitives/Alert/Alert.spec.js +173 -173
- package/dist/primitives/Alert/Alert.stories.svelte +88 -88
- package/dist/primitives/Alert/Alert.svelte +27 -27
- package/dist/primitives/Avatar/Avatar.stories.svelte +94 -94
- package/dist/primitives/Avatar/Avatar.svelte +66 -66
- package/dist/primitives/Badges/Badge.spec.js +144 -144
- package/dist/primitives/Badges/Badge.stories.svelte +86 -86
- package/dist/primitives/Badges/Badge.svelte +79 -79
- package/dist/primitives/BottomSheet/BottomSheet.spec.js +136 -136
- package/dist/primitives/BottomSheet/BottomSheet.stories.svelte +83 -83
- package/dist/primitives/BottomSheet/BottomSheet.svelte +100 -100
- package/dist/primitives/Breadcrumb/Breadcrumb.spec.js +122 -122
- package/dist/primitives/Breadcrumb/Breadcrumb.stories.svelte +23 -23
- package/dist/primitives/Breadcrumb/Breadcrumb.svelte +89 -89
- package/dist/primitives/Button/Button.spec.js +223 -223
- package/dist/primitives/Button/Button.stories.svelte +76 -76
- package/dist/primitives/Button/Button.svelte +270 -270
- package/dist/primitives/Button/ButtonSaveDemo.spec.js +146 -146
- package/dist/primitives/Button/ButtonSaveDemo.svelte +25 -25
- package/dist/primitives/Button/ButtonVariantShowcase.svelte +129 -129
- package/dist/primitives/Card.spec.js +49 -49
- package/dist/primitives/Card.stories.svelte +22 -22
- package/dist/primitives/Card.svelte +28 -28
- package/dist/primitives/Checkbox/Checkbox.stories.svelte +84 -84
- package/dist/primitives/Checkbox/Checkbox.svelte +88 -88
- package/dist/primitives/DarkModeToggle.spec.js +390 -390
- package/dist/primitives/DarkModeToggle.stories.svelte +57 -57
- package/dist/primitives/DarkModeToggle.svelte +136 -136
- package/dist/primitives/Drawer/Drawer.stories.svelte +80 -80
- package/dist/primitives/Drawer/Drawer.svelte +120 -120
- package/dist/primitives/Dropdown/Dropdown.stories.svelte +137 -137
- package/dist/primitives/Dropdown/Dropdown.svelte +14 -14
- package/dist/primitives/Dropdown/DropdownDivider.svelte +9 -9
- package/dist/primitives/Dropdown/DropdownItem.svelte +80 -80
- package/dist/primitives/Helper/Helper.svelte +33 -33
- package/dist/primitives/Icons/ArrowLeft.svelte +8 -8
- package/dist/primitives/Icons/ArrowRight.svelte +8 -8
- package/dist/primitives/Icons/Availability.svelte +14 -14
- package/dist/primitives/Icons/Back.svelte +14 -14
- package/dist/primitives/Icons/CheckCircle.svelte +6 -6
- package/dist/primitives/Icons/CheckCircleOutline.svelte +15 -15
- package/dist/primitives/Icons/ChevronLeft.svelte +4 -4
- package/dist/primitives/Icons/ChevronRight.svelte +4 -4
- package/dist/primitives/Icons/Copy.svelte +15 -15
- package/dist/primitives/Icons/Cross.svelte +5 -5
- package/dist/primitives/Icons/DownArrow.svelte +8 -8
- package/dist/primitives/Icons/ErrorCircle.svelte +6 -6
- package/dist/primitives/Icons/FacebookIcon.svelte +2 -2
- package/dist/primitives/Icons/Home.svelte +15 -15
- package/dist/primitives/Icons/Icon.spec.js +169 -169
- package/dist/primitives/Icons/Icon.stories.svelte +100 -100
- package/dist/primitives/Icons/Icon.svelte +52 -52
- package/dist/primitives/Icons/IconGallery.stories.svelte +235 -235
- package/dist/primitives/Icons/Info.svelte +7 -7
- package/dist/primitives/Icons/InstagramIcon.svelte +4 -4
- package/dist/primitives/Icons/LogoInstagram.svelte +2 -2
- package/dist/primitives/Icons/Message.svelte +15 -15
- package/dist/primitives/Icons/MoonIcon.svelte +5 -5
- package/dist/primitives/Icons/More.svelte +21 -21
- package/dist/primitives/Icons/MoreHori.spec.js +61 -61
- package/dist/primitives/Icons/MoreHori.svelte +22 -22
- package/dist/primitives/Icons/Notification.svelte +14 -14
- package/dist/primitives/Icons/Payment.svelte +14 -14
- package/dist/primitives/Icons/Profile.svelte +21 -21
- package/dist/primitives/Icons/Reload.svelte +29 -29
- package/dist/primitives/Icons/Shows.svelte +21 -21
- package/dist/primitives/Icons/Signout.svelte +21 -21
- package/dist/primitives/Icons/SunIcon.svelte +8 -8
- package/dist/primitives/Icons/TiktokIcon.svelte +2 -2
- package/dist/primitives/Icons/TwitterIcon.svelte +2 -2
- package/dist/primitives/Icons/WarningIcon.spec.js +18 -18
- package/dist/primitives/Icons/WarningIcon.svelte +5 -5
- package/dist/primitives/Input/Input.spec.js +573 -573
- package/dist/primitives/Input/Input.stories.svelte +139 -139
- package/dist/primitives/Input/Select.spec.js +212 -212
- package/dist/primitives/Input/Select.stories.svelte +112 -112
- package/dist/primitives/Input/Select.svelte +128 -128
- package/dist/primitives/Input/Textarea.stories.svelte +137 -137
- package/dist/primitives/Input/Textarea.svelte +35 -35
- package/dist/primitives/Label/Label.svelte +37 -37
- package/dist/primitives/Modal/Modal.spec.js +99 -99
- package/dist/primitives/Modal/Modal.stories.svelte +86 -86
- package/dist/primitives/Pagination/Pagination.stories.svelte +76 -76
- package/dist/primitives/Pagination/Pagination.svelte +261 -261
- package/dist/primitives/Radio/Radio.stories.svelte +80 -80
- package/dist/primitives/Radio/Radio.svelte +67 -67
- package/dist/primitives/Skeleton/CardPlaceholder.svelte +87 -87
- package/dist/primitives/Skeleton/ImagePlaceholder.svelte +59 -59
- package/dist/primitives/Skeleton/ListPlaceholder.svelte +76 -76
- package/dist/primitives/Skeleton/Skeleton.stories.svelte +151 -151
- package/dist/primitives/Skeleton/Skeleton.svelte +26 -26
- package/dist/primitives/Spinner/Spinner.spec.js +71 -71
- package/dist/primitives/Spinner/Spinner.stories.svelte +29 -29
- package/dist/primitives/Spinner/Spinner.svelte +20 -20
- package/dist/primitives/Tabs/TabItem.svelte +49 -49
- package/dist/primitives/Tabs/Tabs.stories.svelte +112 -112
- package/dist/primitives/Tabs/Tabs.svelte +123 -123
- package/dist/primitives/Toggle.spec.js +143 -143
- package/dist/primitives/Toggle.stories.svelte +92 -92
- package/dist/primitives/Tooltip/Tooltip.svelte +83 -83
- package/dist/primitives/Typography/Typography.svelte +53 -53
- package/dist/primitives/ValidationError.spec.js +103 -103
- package/dist/primitives/ValidationError.stories.svelte +69 -69
- package/dist/primitives/ValidationError.svelte +29 -29
- package/dist/primitives/index.js +91 -91
- package/dist/recipes/CropImage/CropImage.spec.js +208 -208
- package/dist/recipes/CropImage/CropImage.stories.svelte +104 -104
- package/dist/recipes/CropImage/CropImage.svelte +238 -238
- package/dist/recipes/ImageUploader/ImageUploader.stories.svelte +125 -125
- package/dist/recipes/ImageUploader/ImageUploader.svelte +804 -804
- package/dist/recipes/Toaster/Toaster.stories.svelte +62 -62
- package/dist/recipes/feedback/EmptyState/EmptyState.svelte +1 -1
- package/dist/recipes/feedback/ErrorDisplay.spec.js +69 -69
- package/dist/recipes/feedback/ErrorDisplay.stories.svelte +101 -101
- package/dist/recipes/feedback/ErrorDisplay.svelte +1 -1
- package/dist/recipes/feedback/StatusIndicator/StatusIndicator.spec.js +133 -133
- package/dist/recipes/feedback/StatusIndicator/StatusIndicator.svelte +157 -157
- package/dist/recipes/fields/CheckboxField.svelte +85 -85
- package/dist/recipes/fields/FormField.svelte +58 -58
- package/dist/recipes/fields/RadioGroup.svelte +95 -95
- package/dist/recipes/fields/SelectField.svelte +80 -80
- package/dist/recipes/fields/TextareaField.svelte +97 -97
- package/dist/recipes/fields/ToggleField.svelte +60 -60
- package/dist/recipes/fields/index.js +7 -7
- package/dist/recipes/inputs/MultiSelect.spec.js +258 -258
- package/dist/recipes/inputs/MultiSelect.stories.svelte +133 -133
- package/dist/recipes/inputs/OTPInput.spec.js +251 -251
- package/dist/recipes/inputs/OTPInput.stories.svelte +162 -162
- package/dist/recipes/inputs/OTPInput.svelte +29 -29
- package/dist/recipes/inputs/PasswordInput.svelte +22 -22
- package/dist/recipes/inputs/PasswordStrengthIndicator/PasswordStrengthIndicator.svelte +117 -117
- package/dist/recipes/inputs/PlaceAutocomplete/PlaceAutocomplete.stories.svelte +123 -123
- package/dist/recipes/inputs/Search.svelte +37 -37
- package/dist/recipes/inputs/SelectDropdown.svelte +57 -57
- package/dist/recipes/modals/AlertModal.svelte +130 -130
- package/dist/recipes/modals/ConfirmationModal.spec.js +206 -206
- package/dist/recipes/modals/ConfirmationModal.stories.svelte +119 -119
- package/dist/recipes/modals/ConfirmationModal.svelte +152 -152
- package/dist/recipes/modals/InputModal.svelte +182 -182
- package/dist/recipes/modals/ModalStateManager.spec.js +100 -100
- package/dist/recipes/modals/ModalStateManager.svelte +77 -77
- package/dist/recipes/modals/ModalTestWrapper.svelte +65 -65
- package/dist/recipes/modals/StatusModal.svelte +206 -206
- package/dist/services/EventService.js +75 -75
- package/dist/services/EventService.spec.js +217 -217
- package/dist/services/ShowService.spec.js +345 -345
- package/dist/stores/toaster.js +13 -13
- package/dist/stories/ButtonAuditReview.stories.svelte +14 -14
- package/dist/stories/ButtonAuditReview.svelte +427 -427
- package/dist/stories/PatternsGallery.stories.svelte +19 -19
- package/dist/stories/PatternsGallery.svelte +206 -206
- package/dist/stories/PrimitivesGallery.stories.svelte +19 -19
- package/dist/stories/PrimitivesGallery.svelte +725 -725
- package/dist/stories/RecipesGallery.stories.svelte +19 -19
- package/dist/stories/RecipesGallery.svelte +271 -271
- package/dist/stories/button-audit-manifest.json +11186 -11186
- package/dist/tailwind/preset.cjs +82 -82
- package/dist/telemetry.js +405 -405
- package/dist/telemetry.spec.js +1169 -1169
- package/dist/tokens/tokens.css +87 -87
- package/dist/tokens/typography-base.css +163 -163
- package/dist/tokens/utilities.css +353 -0
- package/dist/utils/apiConfig.spec.js +219 -219
- package/dist/utils/transitions.js +62 -62
- package/dist/utils/utils.js +354 -354
- package/package.json +296 -295
|
@@ -1,427 +1,427 @@
|
|
|
1
|
-
<script>
|
|
2
|
-
import Button from '../primitives/Button/Button.svelte';
|
|
3
|
-
|
|
4
|
-
// Valid variants in the Button component
|
|
5
|
-
// Note: Both legacy names (default, alternative, etc.) and semantic aliases (blue-solid, gray-outline) work
|
|
6
|
-
const validVariants = [
|
|
7
|
-
{ name: 'default', alias: 'blue-solid', description: 'Primary solid blue', usage: 'Main CTAs, Save, Submit' },
|
|
8
|
-
{ name: 'alternative', alias: 'gray-outline', description: 'Gray outline', usage: 'Cancel, Secondary actions' },
|
|
9
|
-
{ name: 'outline', alias: 'blue-outline', description: 'Blue outline', usage: 'Secondary CTAs' },
|
|
10
|
-
{ name: 'red', alias: 'red-solid', description: 'Solid red danger', usage: 'Delete, destructive actions' },
|
|
11
|
-
{ name: 'red-outline', alias: null, description: 'Red outline', usage: 'Less prominent danger' },
|
|
12
|
-
{ name: 'ghost', alias: 'gray-text', description: 'Gray text, no border', usage: 'Tertiary actions' },
|
|
13
|
-
{ name: 'ghost-red', alias: 'red-text', description: 'Red text, no border', usage: 'Tertiary danger, Remove' },
|
|
14
|
-
{ name: 'icon', alias: null, description: 'Icon-only button', usage: 'Toolbar icons, close buttons' },
|
|
15
|
-
{ name: 'toggle', alias: null, description: 'Toggle button', usage: 'View switchers' },
|
|
16
|
-
{ name: 'menu-item', alias: null, description: 'Dropdown menu item', usage: 'Menu items, search results' },
|
|
17
|
-
{ name: 'menu-item-danger', alias: null, description: 'Red menu item', usage: 'Delete in menus' },
|
|
18
|
-
{ name: 'link', alias: null, description: 'Blue text link', usage: 'Inline text links' },
|
|
19
|
-
{ name: 'card', alias: null, description: 'Selectable card', usage: 'List selections' },
|
|
20
|
-
{ name: 'search-result', alias: null, description: 'Search result item', usage: 'Search dropdowns' },
|
|
21
|
-
{ name: 'nav', alias: null, description: 'Navigation item', usage: 'Bottom nav bars' },
|
|
22
|
-
];
|
|
23
|
-
|
|
24
|
-
// Recent fixes - December 30, 2024
|
|
25
|
-
const recentFixes = [
|
|
26
|
-
{
|
|
27
|
-
date: '2024-12-30',
|
|
28
|
-
description: 'Lineup page buttons',
|
|
29
|
-
fixes: [
|
|
30
|
-
'Changed + Add button to use Carbon Add icon with text-white',
|
|
31
|
-
'Changed + New spot button to use Carbon Add icon with text-white',
|
|
32
|
-
'Made + New spot blue-solid, + Add blue-solid',
|
|
33
|
-
'Removed 3-dot menus from lineup table (kept in roster)',
|
|
34
|
-
'Fixed icon sizes from w-4 h-4 to w-3 h-3 mr-1',
|
|
35
|
-
]
|
|
36
|
-
},
|
|
37
|
-
{
|
|
38
|
-
date: '2024-12-30',
|
|
39
|
-
description: 'Edit spot modal performer search',
|
|
40
|
-
fixes: [
|
|
41
|
-
'Added variant="menu-item" to performer search result buttons',
|
|
42
|
-
'Previously had no variant, defaulting to solid blue background',
|
|
43
|
-
]
|
|
44
|
-
},
|
|
45
|
-
{
|
|
46
|
-
date: '2024-12-30',
|
|
47
|
-
description: 'Actions dropdown in LineupSection',
|
|
48
|
-
fixes: [
|
|
49
|
-
'Fixed dropdown not opening - changed from triggeredBy to bind:open',
|
|
50
|
-
'Added actionsDropdownOpen state with $state(false)',
|
|
51
|
-
'Changed placement to bottom-end',
|
|
52
|
-
]
|
|
53
|
-
},
|
|
54
|
-
{
|
|
55
|
-
date: '2024-12-30',
|
|
56
|
-
description: 'Batch invalid variant fixes',
|
|
57
|
-
fixes: [
|
|
58
|
-
'alternative → gray-outline (across ~120 files)',
|
|
59
|
-
'default → blue-solid',
|
|
60
|
-
'ghost → gray-text',
|
|
61
|
-
'primary → blue-solid',
|
|
62
|
-
'outline → blue-outline',
|
|
63
|
-
'link → gray-text',
|
|
64
|
-
'green-solid → blue-solid',
|
|
65
|
-
]
|
|
66
|
-
},
|
|
67
|
-
];
|
|
68
|
-
|
|
69
|
-
// Buttons WITHOUT variant that need review (default to solid blue)
|
|
70
|
-
// Accurate count using multi-line tag parsing (260 total production buttons)
|
|
71
|
-
const buttonsWithoutVariant = [
|
|
72
|
-
// High priority - 5+ buttons
|
|
73
|
-
{ file: 'routes/a/profile/venue/add/+page.svelte', count: 8, context: 'Add venue form' },
|
|
74
|
-
{ file: 'routes/superuser/templates/sms/+page.svelte', count: 7, context: 'SMS template editor' },
|
|
75
|
-
{ file: 'routes/superuser/+page.svelte', count: 6, context: 'Superuser admin' },
|
|
76
|
-
{ file: 'lib/components/onboarding/VenueFaqModals.svelte', count: 6, context: 'Onboarding FAQ modals' },
|
|
77
|
-
{ file: 'routes/a/venues/[venueID]/roster/+page.svelte', count: 5, context: 'Venue roster' },
|
|
78
|
-
{ file: 'routes/a/venues/[venueID]/+page.svelte', count: 5, context: 'Venue page' },
|
|
79
|
-
{ file: 'routes/a/venues/[venueID]/[eventID]/tracking/+page.svelte', count: 5, context: 'Event tracking' },
|
|
80
|
-
{ file: 'routes/a/events/_components/CollectionForm.svelte', count: 5, context: 'Event collection form' },
|
|
81
|
-
{ file: 'components/PromoCode/PromoCode.svelte', count: 5, context: 'Promo code actions' },
|
|
82
|
-
|
|
83
|
-
// Medium priority - 4 buttons
|
|
84
|
-
{ file: 'routes/a/venues/[venueID]/[eventID]/tickets/+page.svelte', count: 4, context: 'Event tickets' },
|
|
85
|
-
{ file: 'routes/a/venues/_components/availsSettings.svelte', count: 4, context: 'Availability settings' },
|
|
86
|
-
{ file: 'routes/a/team/_components/TeamTabContent.svelte', count: 4, context: 'Team tab' },
|
|
87
|
-
{ file: 'lib/components/venues/VenueDisclaimersSection.svelte', count: 4, context: 'Venue disclaimers' },
|
|
88
|
-
{ file: 'components/IndividualPerformerTable/IndividualPerformerTableUnified.svelte', count: 4, context: 'Performer table' },
|
|
89
|
-
{ file: 'components/DateRangePicker/DateRangePicker.svelte', count: 4, context: 'Date range picker' },
|
|
90
|
-
{ file: 'components/DateRangeAndDate.svelte', count: 4, context: 'Date range' },
|
|
91
|
-
{ file: 'components/AllPerformerTable/AllPerformerTableUnified.svelte', count: 4, context: 'All performers table' },
|
|
92
|
-
|
|
93
|
-
// 3 buttons each
|
|
94
|
-
{ file: 'routes/superuser/templates/email/+page.svelte', count: 3, context: 'Email template editor' },
|
|
95
|
-
{ file: 'routes/superuser/+layout.svelte', count: 3, context: 'Superuser layout' },
|
|
96
|
-
{ file: 'routes/a/widgets/+page.svelte', count: 3, context: 'Widget management' },
|
|
97
|
-
{ file: 'routes/a/venues/[venueID]/[eventID]/schedule/+page.svelte', count: 3, context: 'Event schedule' },
|
|
98
|
-
{ file: 'components/FileDropzone/FileDropzone.svelte', count: 3, context: 'File upload' },
|
|
99
|
-
{ file: 'components/Events/Tickets/OrderSummary.svelte', count: 3, context: 'Order summary' },
|
|
100
|
-
{ file: 'components/DateTimePicker/DateTimePicker.svelte', count: 3, context: 'Date/time picker' },
|
|
101
|
-
{ file: 'components/DatePicker/ArrowsDatePicker.svelte', count: 3, context: 'Date picker arrows' },
|
|
102
|
-
{ file: 'components/CropImage/CropImage.svelte', count: 3, context: 'Image cropper' },
|
|
103
|
-
{ file: 'components/Calendar/QuarterView.svelte', count: 3, context: 'Calendar navigation' },
|
|
104
|
-
|
|
105
|
-
// Remaining ~100 files with 1-2 buttons each
|
|
106
|
-
{ file: '~100 other files (1-2 buttons each)', count: 142, context: 'Various actions across codebase' },
|
|
107
|
-
];
|
|
108
|
-
|
|
109
|
-
// Accurate count using multi-line tag parsing
|
|
110
|
-
const totalWithoutVariant = 260;
|
|
111
|
-
|
|
112
|
-
// Visual examples of buttons that need review
|
|
113
|
-
// These show CURRENT rendering (no variant = default/blue-solid) vs RECOMMENDED variant
|
|
114
|
-
const visualExamples = [
|
|
115
|
-
{
|
|
116
|
-
category: 'Tertiary Actions (Edit, View, Details)',
|
|
117
|
-
description: 'Text-only actions that should not compete with primary CTAs',
|
|
118
|
-
examples: [
|
|
119
|
-
{ label: 'Edit', location: 'Cards/LeftCard.svelte', current: undefined, recommended: 'ghost' },
|
|
120
|
-
{ label: 'View Details', location: 'Various card components', current: undefined, recommended: 'ghost' },
|
|
121
|
-
{ label: 'Show More', location: 'Lists and tables', current: undefined, recommended: 'ghost' },
|
|
122
|
-
]
|
|
123
|
-
},
|
|
124
|
-
{
|
|
125
|
-
category: 'Cancel / Dismiss Buttons',
|
|
126
|
-
description: 'Secondary actions that close modals or cancel operations',
|
|
127
|
-
examples: [
|
|
128
|
-
{ label: 'Cancel', location: 'Forms and modals', current: undefined, recommended: 'alternative' },
|
|
129
|
-
{ label: 'Close', location: 'Modal headers', current: undefined, recommended: 'alternative' },
|
|
130
|
-
{ label: 'Dismiss', location: 'Notifications', current: undefined, recommended: 'alternative' },
|
|
131
|
-
]
|
|
132
|
-
},
|
|
133
|
-
{
|
|
134
|
-
category: 'Dropdown / Menu Items',
|
|
135
|
-
description: 'Items in dropdown menus and search results',
|
|
136
|
-
examples: [
|
|
137
|
-
{ label: 'Select Option', location: 'Various dropdowns', current: undefined, recommended: 'menu-item' },
|
|
138
|
-
{ label: 'Search Result', location: 'Search dropdowns', current: undefined, recommended: 'search-result' },
|
|
139
|
-
{ label: 'Delete Item', location: 'Dropdown danger actions', current: undefined, recommended: 'menu-item-danger' },
|
|
140
|
-
]
|
|
141
|
-
},
|
|
142
|
-
{
|
|
143
|
-
category: 'Icon-Only Buttons',
|
|
144
|
-
description: 'Buttons with only icons (close X, calendar, etc)',
|
|
145
|
-
examples: [
|
|
146
|
-
{ label: 'X', location: 'TimePicker.svelte (calendar)', current: undefined, recommended: 'icon' },
|
|
147
|
-
{ label: 'X', location: 'Modal close buttons', current: undefined, recommended: 'icon' },
|
|
148
|
-
{ label: '...', location: 'More options buttons', current: undefined, recommended: 'icon' },
|
|
149
|
-
]
|
|
150
|
-
},
|
|
151
|
-
{
|
|
152
|
-
category: 'Primary CTAs (Correct as default)',
|
|
153
|
-
description: 'These buttons are correctly using the default (blue-solid)',
|
|
154
|
-
examples: [
|
|
155
|
-
{ label: 'Save', location: 'Form submissions', current: undefined, recommended: 'default', correct: true },
|
|
156
|
-
{ label: 'Add', location: 'Cards/LeftCard.svelte', current: undefined, recommended: 'default', correct: true },
|
|
157
|
-
{ label: 'Submit', location: 'Contact forms', current: undefined, recommended: 'default', correct: true },
|
|
158
|
-
]
|
|
159
|
-
},
|
|
160
|
-
];
|
|
161
|
-
</script>
|
|
162
|
-
|
|
163
|
-
<div class="p-6 max-w-7xl mx-auto space-y-8">
|
|
164
|
-
<div class="text-center mb-8">
|
|
165
|
-
<h1 class="text-3xl font-bold text-gray-900 mb-2">Button Audit Review</h1>
|
|
166
|
-
<p class="text-gray-600">Last updated: December 30, 2024</p>
|
|
167
|
-
</div>
|
|
168
|
-
|
|
169
|
-
<!-- Summary Cards -->
|
|
170
|
-
<div class="grid grid-cols-3 gap-6 mb-8">
|
|
171
|
-
<div class="p-6 bg-yellow-50 border-2 border-yellow-400 rounded-lg text-center">
|
|
172
|
-
<div class="text-4xl font-bold text-yellow-600">{totalWithoutVariant}</div>
|
|
173
|
-
<div class="text-sm text-gray-600 mt-2">Buttons Without Variant</div>
|
|
174
|
-
<span class="inline-block mt-2 px-3 py-1 text-xs rounded-full bg-yellow-200 text-yellow-800">Needs Review</span>
|
|
175
|
-
</div>
|
|
176
|
-
<div class="p-6 bg-green-50 border-2 border-green-400 rounded-lg text-center">
|
|
177
|
-
<div class="text-4xl font-bold text-green-600">{recentFixes.length}</div>
|
|
178
|
-
<div class="text-sm text-gray-600 mt-2">Recent Fix Sessions</div>
|
|
179
|
-
<span class="inline-block mt-2 px-3 py-1 text-xs rounded-full bg-green-200 text-green-800">Today</span>
|
|
180
|
-
</div>
|
|
181
|
-
<div class="p-6 bg-blue-50 border-2 border-blue-400 rounded-lg text-center">
|
|
182
|
-
<div class="text-4xl font-bold text-blue-600">{validVariants.length}</div>
|
|
183
|
-
<div class="text-sm text-gray-600 mt-2">Valid Variants</div>
|
|
184
|
-
<span class="inline-block mt-2 px-3 py-1 text-xs rounded-full bg-blue-200 text-blue-800">Reference</span>
|
|
185
|
-
</div>
|
|
186
|
-
</div>
|
|
187
|
-
|
|
188
|
-
<!-- Buttons Without Variant -->
|
|
189
|
-
<section class="border-2 border-yellow-400 rounded-lg p-6 bg-yellow-50">
|
|
190
|
-
<h2 class="text-xl font-bold text-yellow-700 mb-4 flex items-center gap-2">
|
|
191
|
-
<span class="text-2xl">⚠</span> Buttons Without Variant (Default to blue-solid)
|
|
192
|
-
</h2>
|
|
193
|
-
<p class="text-gray-600 mb-4">
|
|
194
|
-
These buttons have no <code class="bg-white px-2 py-0.5 rounded text-sm">variant</code> prop and render as solid blue by default.
|
|
195
|
-
Review each to determine if blue-solid is correct or if another variant should be used.
|
|
196
|
-
</p>
|
|
197
|
-
|
|
198
|
-
<div class="overflow-x-auto bg-white rounded-lg">
|
|
199
|
-
<table class="w-full text-sm">
|
|
200
|
-
<thead class="bg-gray-100">
|
|
201
|
-
<tr>
|
|
202
|
-
<th class="px-4 py-3 text-left font-medium">File</th>
|
|
203
|
-
<th class="px-4 py-3 text-center font-medium">Count</th>
|
|
204
|
-
<th class="px-4 py-3 text-left font-medium">Context</th>
|
|
205
|
-
<th class="px-4 py-3 text-center font-medium">Status</th>
|
|
206
|
-
</tr>
|
|
207
|
-
</thead>
|
|
208
|
-
<tbody>
|
|
209
|
-
{#each buttonsWithoutVariant as item}
|
|
210
|
-
<tr class="border-b border-gray-200">
|
|
211
|
-
<td class="px-4 py-3">
|
|
212
|
-
<code class="text-xs bg-yellow-100 text-yellow-800 px-2 py-1 rounded">
|
|
213
|
-
{item.file}
|
|
214
|
-
</code>
|
|
215
|
-
</td>
|
|
216
|
-
<td class="px-4 py-3 text-center font-medium">{item.count}</td>
|
|
217
|
-
<td class="px-4 py-3 text-gray-600">{item.context}</td>
|
|
218
|
-
<td class="px-4 py-3 text-center">
|
|
219
|
-
<span class="px-2 py-1 text-xs rounded-full bg-yellow-200 text-yellow-800">Review</span>
|
|
220
|
-
</td>
|
|
221
|
-
</tr>
|
|
222
|
-
{/each}
|
|
223
|
-
</tbody>
|
|
224
|
-
</table>
|
|
225
|
-
</div>
|
|
226
|
-
|
|
227
|
-
<div class="mt-4 p-4 bg-yellow-100 rounded-lg">
|
|
228
|
-
<p class="text-sm text-yellow-800">
|
|
229
|
-
<strong>Total: ~{totalWithoutVariant} buttons</strong> across the codebase need variant review.
|
|
230
|
-
Many may be intentionally blue-solid (CTAs), but others may need gray-outline, menu-item, or icon variants.
|
|
231
|
-
</p>
|
|
232
|
-
</div>
|
|
233
|
-
</section>
|
|
234
|
-
|
|
235
|
-
<!-- Visual Examples: Current vs Recommended -->
|
|
236
|
-
<section class="border-2 border-orange-400 rounded-lg p-6 bg-orange-50">
|
|
237
|
-
<h2 class="text-xl font-bold text-orange-700 mb-4 flex items-center gap-2">
|
|
238
|
-
<span class="text-2xl">👁</span> Visual Comparison: Current vs Recommended
|
|
239
|
-
</h2>
|
|
240
|
-
<p class="text-gray-600 mb-6">
|
|
241
|
-
These examples show how buttons WITHOUT a variant currently render (blue-solid default) versus how they SHOULD render with the correct variant.
|
|
242
|
-
</p>
|
|
243
|
-
|
|
244
|
-
<div class="space-y-8">
|
|
245
|
-
{#each visualExamples as category}
|
|
246
|
-
<div class="bg-white rounded-lg p-5 border border-orange-200">
|
|
247
|
-
<div class="flex items-center gap-3 mb-2">
|
|
248
|
-
<h3 class="font-bold text-gray-900">{category.category}</h3>
|
|
249
|
-
{#if category.examples[0]?.correct}
|
|
250
|
-
<span class="px-2 py-0.5 text-xs rounded-full bg-green-100 text-green-700">Correct</span>
|
|
251
|
-
{:else}
|
|
252
|
-
<span class="px-2 py-0.5 text-xs rounded-full bg-red-100 text-red-700">Needs Fix</span>
|
|
253
|
-
{/if}
|
|
254
|
-
</div>
|
|
255
|
-
<p class="text-sm text-gray-500 mb-4">{category.description}</p>
|
|
256
|
-
|
|
257
|
-
<div class="grid grid-cols-1 md:grid-cols-3 gap-4">
|
|
258
|
-
{#each category.examples as example}
|
|
259
|
-
<div class="border border-gray-200 rounded-lg p-4 bg-gray-50">
|
|
260
|
-
<div class="text-xs text-gray-500 mb-3 font-mono truncate" title={example.location}>
|
|
261
|
-
{example.location}
|
|
262
|
-
</div>
|
|
263
|
-
|
|
264
|
-
<div class="space-y-3">
|
|
265
|
-
<!-- Current (no variant) -->
|
|
266
|
-
<div>
|
|
267
|
-
<div class="text-xs text-red-600 font-medium mb-1">Current (no variant):</div>
|
|
268
|
-
<Button size="sm">{example.label}</Button>
|
|
269
|
-
</div>
|
|
270
|
-
|
|
271
|
-
<!-- Arrow -->
|
|
272
|
-
<div class="text-center text-gray-400">↓</div>
|
|
273
|
-
|
|
274
|
-
<!-- Recommended -->
|
|
275
|
-
<div>
|
|
276
|
-
<div class="text-xs text-green-600 font-medium mb-1">
|
|
277
|
-
Recommended: <code class="bg-green-100 px-1 rounded">{example.recommended}</code>
|
|
278
|
-
</div>
|
|
279
|
-
<Button variant={example.recommended} size="sm">{example.label}</Button>
|
|
280
|
-
</div>
|
|
281
|
-
</div>
|
|
282
|
-
</div>
|
|
283
|
-
{/each}
|
|
284
|
-
</div>
|
|
285
|
-
</div>
|
|
286
|
-
{/each}
|
|
287
|
-
</div>
|
|
288
|
-
|
|
289
|
-
<div class="mt-6 p-4 bg-orange-100 rounded-lg">
|
|
290
|
-
<p class="text-sm text-orange-800">
|
|
291
|
-
<strong>Key insight:</strong> Buttons without variant all render as solid blue (left), making it hard to distinguish
|
|
292
|
-
primary actions from secondary ones. Adding proper variants (right) creates visual hierarchy.
|
|
293
|
-
</p>
|
|
294
|
-
</div>
|
|
295
|
-
</section>
|
|
296
|
-
|
|
297
|
-
<!-- Recent Fixes -->
|
|
298
|
-
<section class="border-2 border-green-400 rounded-lg p-6 bg-green-50">
|
|
299
|
-
<h2 class="text-xl font-bold text-green-700 mb-4 flex items-center gap-2">
|
|
300
|
-
<span class="text-2xl">✓</span> Recent Fixes (December 30, 2024)
|
|
301
|
-
</h2>
|
|
302
|
-
|
|
303
|
-
<div class="space-y-6">
|
|
304
|
-
{#each recentFixes as fix}
|
|
305
|
-
<div class="bg-white rounded-lg p-4 border-l-4 border-green-500">
|
|
306
|
-
<h3 class="font-semibold text-gray-900 mb-2">{fix.description}</h3>
|
|
307
|
-
<ul class="text-sm text-gray-600 space-y-1">
|
|
308
|
-
{#each fix.fixes as item}
|
|
309
|
-
<li class="flex items-start gap-2">
|
|
310
|
-
<span class="text-green-500 mt-0.5">✓</span>
|
|
311
|
-
{item}
|
|
312
|
-
</li>
|
|
313
|
-
{/each}
|
|
314
|
-
</ul>
|
|
315
|
-
</div>
|
|
316
|
-
{/each}
|
|
317
|
-
</div>
|
|
318
|
-
</section>
|
|
319
|
-
|
|
320
|
-
<!-- Valid Variants Reference -->
|
|
321
|
-
<section class="border rounded-lg p-6 bg-white">
|
|
322
|
-
<h2 class="text-xl font-bold text-gray-900 mb-4 flex items-center gap-2">
|
|
323
|
-
<span class="text-blue-600">ℹ</span> Valid Variants Reference
|
|
324
|
-
</h2>
|
|
325
|
-
|
|
326
|
-
<div class="grid grid-cols-2 md:grid-cols-3 lg:grid-cols-4 gap-4">
|
|
327
|
-
{#each validVariants as v}
|
|
328
|
-
<div class="border border-gray-200 rounded-lg p-4">
|
|
329
|
-
<div class="flex items-center gap-2 mb-3">
|
|
330
|
-
<Button variant={v.name} size="sm">{v.name}</Button>
|
|
331
|
-
</div>
|
|
332
|
-
<code class="text-xs bg-gray-100 px-2 py-1 rounded block mb-1">
|
|
333
|
-
variant="{v.name}"
|
|
334
|
-
</code>
|
|
335
|
-
{#if v.alias}
|
|
336
|
-
<code class="text-xs bg-blue-50 text-blue-700 px-2 py-1 rounded block mb-2">
|
|
337
|
-
or: "{v.alias}"
|
|
338
|
-
</code>
|
|
339
|
-
{/if}
|
|
340
|
-
<p class="text-xs text-gray-500">{v.usage}</p>
|
|
341
|
-
</div>
|
|
342
|
-
{/each}
|
|
343
|
-
</div>
|
|
344
|
-
</section>
|
|
345
|
-
|
|
346
|
-
<!-- Decision Guide -->
|
|
347
|
-
<section class="border-2 border-blue-400 rounded-lg p-6 bg-blue-50">
|
|
348
|
-
<h2 class="text-xl font-bold text-blue-700 mb-4">Button Variant Decision Guide</h2>
|
|
349
|
-
|
|
350
|
-
<div class="grid grid-cols-2 gap-6">
|
|
351
|
-
<div class="bg-white rounded-lg p-4">
|
|
352
|
-
<h3 class="font-semibold text-gray-900 mb-3">When to use each variant</h3>
|
|
353
|
-
<ul class="space-y-2 text-sm">
|
|
354
|
-
<li class="flex items-start gap-2">
|
|
355
|
-
<code class="bg-blue-100 text-blue-800 px-1 rounded text-xs shrink-0">default</code>
|
|
356
|
-
<span class="text-gray-600">Primary CTAs: Save, Submit, + New</span>
|
|
357
|
-
</li>
|
|
358
|
-
<li class="flex items-start gap-2">
|
|
359
|
-
<code class="bg-blue-100 text-blue-800 px-1 rounded text-xs shrink-0">outline</code>
|
|
360
|
-
<span class="text-gray-600">Secondary CTAs: Invite, Export</span>
|
|
361
|
-
</li>
|
|
362
|
-
<li class="flex items-start gap-2">
|
|
363
|
-
<code class="bg-gray-100 text-gray-800 px-1 rounded text-xs shrink-0">alternative</code>
|
|
364
|
-
<span class="text-gray-600">Cancel, Close, Filter, Actions triggers</span>
|
|
365
|
-
</li>
|
|
366
|
-
<li class="flex items-start gap-2">
|
|
367
|
-
<code class="bg-red-100 text-red-800 px-1 rounded text-xs shrink-0">red</code>
|
|
368
|
-
<span class="text-gray-600">Delete confirmations, destructive actions</span>
|
|
369
|
-
</li>
|
|
370
|
-
<li class="flex items-start gap-2">
|
|
371
|
-
<code class="bg-gray-100 text-gray-800 px-1 rounded text-xs shrink-0">ghost</code>
|
|
372
|
-
<span class="text-gray-600">Tertiary actions: Edit, View, Show more</span>
|
|
373
|
-
</li>
|
|
374
|
-
<li class="flex items-start gap-2">
|
|
375
|
-
<code class="bg-gray-100 text-gray-800 px-1 rounded text-xs shrink-0">menu-item</code>
|
|
376
|
-
<span class="text-gray-600">Dropdown items, list selections</span>
|
|
377
|
-
</li>
|
|
378
|
-
<li class="flex items-start gap-2">
|
|
379
|
-
<code class="bg-gray-100 text-gray-800 px-1 rounded text-xs shrink-0">icon</code>
|
|
380
|
-
<span class="text-gray-600">Close buttons, drag handles</span>
|
|
381
|
-
</li>
|
|
382
|
-
</ul>
|
|
383
|
-
</div>
|
|
384
|
-
|
|
385
|
-
<div class="bg-white rounded-lg p-4">
|
|
386
|
-
<h3 class="font-semibold text-gray-900 mb-3">Common mistakes</h3>
|
|
387
|
-
<ul class="space-y-2 text-sm text-gray-600">
|
|
388
|
-
<li class="flex items-start gap-2">
|
|
389
|
-
<span class="text-red-500">✗</span>
|
|
390
|
-
<span>No variant on dropdown items → defaults to solid blue</span>
|
|
391
|
-
</li>
|
|
392
|
-
<li class="flex items-start gap-2">
|
|
393
|
-
<span class="text-red-500">✗</span>
|
|
394
|
-
<span>No variant on Cancel → should be alternative</span>
|
|
395
|
-
</li>
|
|
396
|
-
<li class="flex items-start gap-2">
|
|
397
|
-
<span class="text-red-500">✗</span>
|
|
398
|
-
<span>No variant on close/X buttons → should be icon</span>
|
|
399
|
-
</li>
|
|
400
|
-
<li class="flex items-start gap-2">
|
|
401
|
-
<span class="text-red-500">✗</span>
|
|
402
|
-
<span>Invalid variant names fall back to default (solid blue)</span>
|
|
403
|
-
</li>
|
|
404
|
-
</ul>
|
|
405
|
-
|
|
406
|
-
<div class="mt-4 p-3 bg-blue-100 rounded-lg">
|
|
407
|
-
<p class="text-xs text-blue-800">
|
|
408
|
-
<strong>Tip:</strong> When in doubt, use alternative for secondary actions
|
|
409
|
-
and default only for the primary action.
|
|
410
|
-
</p>
|
|
411
|
-
</div>
|
|
412
|
-
</div>
|
|
413
|
-
</div>
|
|
414
|
-
</section>
|
|
415
|
-
|
|
416
|
-
<!-- How to Find Issues -->
|
|
417
|
-
<section class="border rounded-lg p-6 bg-gray-50">
|
|
418
|
-
<h2 class="text-xl font-bold text-gray-900 mb-4">How to Find Buttons Without Variant</h2>
|
|
419
|
-
|
|
420
|
-
<div class="bg-white rounded-lg p-4">
|
|
421
|
-
<p class="text-sm text-gray-600 mb-2">Run this command in micdrop-frontend:</p>
|
|
422
|
-
<code class="block bg-gray-900 text-green-400 p-3 rounded text-xs overflow-x-auto">
|
|
423
|
-
grep -rn "<Button" --include="*.svelte" src | grep -v "variant="
|
|
424
|
-
</code>
|
|
425
|
-
</div>
|
|
426
|
-
</section>
|
|
427
|
-
</div>
|
|
1
|
+
<script>
|
|
2
|
+
import Button from '../primitives/Button/Button.svelte';
|
|
3
|
+
|
|
4
|
+
// Valid variants in the Button component
|
|
5
|
+
// Note: Both legacy names (default, alternative, etc.) and semantic aliases (blue-solid, gray-outline) work
|
|
6
|
+
const validVariants = [
|
|
7
|
+
{ name: 'default', alias: 'blue-solid', description: 'Primary solid blue', usage: 'Main CTAs, Save, Submit' },
|
|
8
|
+
{ name: 'alternative', alias: 'gray-outline', description: 'Gray outline', usage: 'Cancel, Secondary actions' },
|
|
9
|
+
{ name: 'outline', alias: 'blue-outline', description: 'Blue outline', usage: 'Secondary CTAs' },
|
|
10
|
+
{ name: 'red', alias: 'red-solid', description: 'Solid red danger', usage: 'Delete, destructive actions' },
|
|
11
|
+
{ name: 'red-outline', alias: null, description: 'Red outline', usage: 'Less prominent danger' },
|
|
12
|
+
{ name: 'ghost', alias: 'gray-text', description: 'Gray text, no border', usage: 'Tertiary actions' },
|
|
13
|
+
{ name: 'ghost-red', alias: 'red-text', description: 'Red text, no border', usage: 'Tertiary danger, Remove' },
|
|
14
|
+
{ name: 'icon', alias: null, description: 'Icon-only button', usage: 'Toolbar icons, close buttons' },
|
|
15
|
+
{ name: 'toggle', alias: null, description: 'Toggle button', usage: 'View switchers' },
|
|
16
|
+
{ name: 'menu-item', alias: null, description: 'Dropdown menu item', usage: 'Menu items, search results' },
|
|
17
|
+
{ name: 'menu-item-danger', alias: null, description: 'Red menu item', usage: 'Delete in menus' },
|
|
18
|
+
{ name: 'link', alias: null, description: 'Blue text link', usage: 'Inline text links' },
|
|
19
|
+
{ name: 'card', alias: null, description: 'Selectable card', usage: 'List selections' },
|
|
20
|
+
{ name: 'search-result', alias: null, description: 'Search result item', usage: 'Search dropdowns' },
|
|
21
|
+
{ name: 'nav', alias: null, description: 'Navigation item', usage: 'Bottom nav bars' },
|
|
22
|
+
];
|
|
23
|
+
|
|
24
|
+
// Recent fixes - December 30, 2024
|
|
25
|
+
const recentFixes = [
|
|
26
|
+
{
|
|
27
|
+
date: '2024-12-30',
|
|
28
|
+
description: 'Lineup page buttons',
|
|
29
|
+
fixes: [
|
|
30
|
+
'Changed + Add button to use Carbon Add icon with text-white',
|
|
31
|
+
'Changed + New spot button to use Carbon Add icon with text-white',
|
|
32
|
+
'Made + New spot blue-solid, + Add blue-solid',
|
|
33
|
+
'Removed 3-dot menus from lineup table (kept in roster)',
|
|
34
|
+
'Fixed icon sizes from w-4 h-4 to w-3 h-3 mr-1',
|
|
35
|
+
]
|
|
36
|
+
},
|
|
37
|
+
{
|
|
38
|
+
date: '2024-12-30',
|
|
39
|
+
description: 'Edit spot modal performer search',
|
|
40
|
+
fixes: [
|
|
41
|
+
'Added variant="menu-item" to performer search result buttons',
|
|
42
|
+
'Previously had no variant, defaulting to solid blue background',
|
|
43
|
+
]
|
|
44
|
+
},
|
|
45
|
+
{
|
|
46
|
+
date: '2024-12-30',
|
|
47
|
+
description: 'Actions dropdown in LineupSection',
|
|
48
|
+
fixes: [
|
|
49
|
+
'Fixed dropdown not opening - changed from triggeredBy to bind:open',
|
|
50
|
+
'Added actionsDropdownOpen state with $state(false)',
|
|
51
|
+
'Changed placement to bottom-end',
|
|
52
|
+
]
|
|
53
|
+
},
|
|
54
|
+
{
|
|
55
|
+
date: '2024-12-30',
|
|
56
|
+
description: 'Batch invalid variant fixes',
|
|
57
|
+
fixes: [
|
|
58
|
+
'alternative → gray-outline (across ~120 files)',
|
|
59
|
+
'default → blue-solid',
|
|
60
|
+
'ghost → gray-text',
|
|
61
|
+
'primary → blue-solid',
|
|
62
|
+
'outline → blue-outline',
|
|
63
|
+
'link → gray-text',
|
|
64
|
+
'green-solid → blue-solid',
|
|
65
|
+
]
|
|
66
|
+
},
|
|
67
|
+
];
|
|
68
|
+
|
|
69
|
+
// Buttons WITHOUT variant that need review (default to solid blue)
|
|
70
|
+
// Accurate count using multi-line tag parsing (260 total production buttons)
|
|
71
|
+
const buttonsWithoutVariant = [
|
|
72
|
+
// High priority - 5+ buttons
|
|
73
|
+
{ file: 'routes/a/profile/venue/add/+page.svelte', count: 8, context: 'Add venue form' },
|
|
74
|
+
{ file: 'routes/superuser/templates/sms/+page.svelte', count: 7, context: 'SMS template editor' },
|
|
75
|
+
{ file: 'routes/superuser/+page.svelte', count: 6, context: 'Superuser admin' },
|
|
76
|
+
{ file: 'lib/components/onboarding/VenueFaqModals.svelte', count: 6, context: 'Onboarding FAQ modals' },
|
|
77
|
+
{ file: 'routes/a/venues/[venueID]/roster/+page.svelte', count: 5, context: 'Venue roster' },
|
|
78
|
+
{ file: 'routes/a/venues/[venueID]/+page.svelte', count: 5, context: 'Venue page' },
|
|
79
|
+
{ file: 'routes/a/venues/[venueID]/[eventID]/tracking/+page.svelte', count: 5, context: 'Event tracking' },
|
|
80
|
+
{ file: 'routes/a/events/_components/CollectionForm.svelte', count: 5, context: 'Event collection form' },
|
|
81
|
+
{ file: 'components/PromoCode/PromoCode.svelte', count: 5, context: 'Promo code actions' },
|
|
82
|
+
|
|
83
|
+
// Medium priority - 4 buttons
|
|
84
|
+
{ file: 'routes/a/venues/[venueID]/[eventID]/tickets/+page.svelte', count: 4, context: 'Event tickets' },
|
|
85
|
+
{ file: 'routes/a/venues/_components/availsSettings.svelte', count: 4, context: 'Availability settings' },
|
|
86
|
+
{ file: 'routes/a/team/_components/TeamTabContent.svelte', count: 4, context: 'Team tab' },
|
|
87
|
+
{ file: 'lib/components/venues/VenueDisclaimersSection.svelte', count: 4, context: 'Venue disclaimers' },
|
|
88
|
+
{ file: 'components/IndividualPerformerTable/IndividualPerformerTableUnified.svelte', count: 4, context: 'Performer table' },
|
|
89
|
+
{ file: 'components/DateRangePicker/DateRangePicker.svelte', count: 4, context: 'Date range picker' },
|
|
90
|
+
{ file: 'components/DateRangeAndDate.svelte', count: 4, context: 'Date range' },
|
|
91
|
+
{ file: 'components/AllPerformerTable/AllPerformerTableUnified.svelte', count: 4, context: 'All performers table' },
|
|
92
|
+
|
|
93
|
+
// 3 buttons each
|
|
94
|
+
{ file: 'routes/superuser/templates/email/+page.svelte', count: 3, context: 'Email template editor' },
|
|
95
|
+
{ file: 'routes/superuser/+layout.svelte', count: 3, context: 'Superuser layout' },
|
|
96
|
+
{ file: 'routes/a/widgets/+page.svelte', count: 3, context: 'Widget management' },
|
|
97
|
+
{ file: 'routes/a/venues/[venueID]/[eventID]/schedule/+page.svelte', count: 3, context: 'Event schedule' },
|
|
98
|
+
{ file: 'components/FileDropzone/FileDropzone.svelte', count: 3, context: 'File upload' },
|
|
99
|
+
{ file: 'components/Events/Tickets/OrderSummary.svelte', count: 3, context: 'Order summary' },
|
|
100
|
+
{ file: 'components/DateTimePicker/DateTimePicker.svelte', count: 3, context: 'Date/time picker' },
|
|
101
|
+
{ file: 'components/DatePicker/ArrowsDatePicker.svelte', count: 3, context: 'Date picker arrows' },
|
|
102
|
+
{ file: 'components/CropImage/CropImage.svelte', count: 3, context: 'Image cropper' },
|
|
103
|
+
{ file: 'components/Calendar/QuarterView.svelte', count: 3, context: 'Calendar navigation' },
|
|
104
|
+
|
|
105
|
+
// Remaining ~100 files with 1-2 buttons each
|
|
106
|
+
{ file: '~100 other files (1-2 buttons each)', count: 142, context: 'Various actions across codebase' },
|
|
107
|
+
];
|
|
108
|
+
|
|
109
|
+
// Accurate count using multi-line tag parsing
|
|
110
|
+
const totalWithoutVariant = 260;
|
|
111
|
+
|
|
112
|
+
// Visual examples of buttons that need review
|
|
113
|
+
// These show CURRENT rendering (no variant = default/blue-solid) vs RECOMMENDED variant
|
|
114
|
+
const visualExamples = [
|
|
115
|
+
{
|
|
116
|
+
category: 'Tertiary Actions (Edit, View, Details)',
|
|
117
|
+
description: 'Text-only actions that should not compete with primary CTAs',
|
|
118
|
+
examples: [
|
|
119
|
+
{ label: 'Edit', location: 'Cards/LeftCard.svelte', current: undefined, recommended: 'ghost' },
|
|
120
|
+
{ label: 'View Details', location: 'Various card components', current: undefined, recommended: 'ghost' },
|
|
121
|
+
{ label: 'Show More', location: 'Lists and tables', current: undefined, recommended: 'ghost' },
|
|
122
|
+
]
|
|
123
|
+
},
|
|
124
|
+
{
|
|
125
|
+
category: 'Cancel / Dismiss Buttons',
|
|
126
|
+
description: 'Secondary actions that close modals or cancel operations',
|
|
127
|
+
examples: [
|
|
128
|
+
{ label: 'Cancel', location: 'Forms and modals', current: undefined, recommended: 'alternative' },
|
|
129
|
+
{ label: 'Close', location: 'Modal headers', current: undefined, recommended: 'alternative' },
|
|
130
|
+
{ label: 'Dismiss', location: 'Notifications', current: undefined, recommended: 'alternative' },
|
|
131
|
+
]
|
|
132
|
+
},
|
|
133
|
+
{
|
|
134
|
+
category: 'Dropdown / Menu Items',
|
|
135
|
+
description: 'Items in dropdown menus and search results',
|
|
136
|
+
examples: [
|
|
137
|
+
{ label: 'Select Option', location: 'Various dropdowns', current: undefined, recommended: 'menu-item' },
|
|
138
|
+
{ label: 'Search Result', location: 'Search dropdowns', current: undefined, recommended: 'search-result' },
|
|
139
|
+
{ label: 'Delete Item', location: 'Dropdown danger actions', current: undefined, recommended: 'menu-item-danger' },
|
|
140
|
+
]
|
|
141
|
+
},
|
|
142
|
+
{
|
|
143
|
+
category: 'Icon-Only Buttons',
|
|
144
|
+
description: 'Buttons with only icons (close X, calendar, etc)',
|
|
145
|
+
examples: [
|
|
146
|
+
{ label: 'X', location: 'TimePicker.svelte (calendar)', current: undefined, recommended: 'icon' },
|
|
147
|
+
{ label: 'X', location: 'Modal close buttons', current: undefined, recommended: 'icon' },
|
|
148
|
+
{ label: '...', location: 'More options buttons', current: undefined, recommended: 'icon' },
|
|
149
|
+
]
|
|
150
|
+
},
|
|
151
|
+
{
|
|
152
|
+
category: 'Primary CTAs (Correct as default)',
|
|
153
|
+
description: 'These buttons are correctly using the default (blue-solid)',
|
|
154
|
+
examples: [
|
|
155
|
+
{ label: 'Save', location: 'Form submissions', current: undefined, recommended: 'default', correct: true },
|
|
156
|
+
{ label: 'Add', location: 'Cards/LeftCard.svelte', current: undefined, recommended: 'default', correct: true },
|
|
157
|
+
{ label: 'Submit', location: 'Contact forms', current: undefined, recommended: 'default', correct: true },
|
|
158
|
+
]
|
|
159
|
+
},
|
|
160
|
+
];
|
|
161
|
+
</script>
|
|
162
|
+
|
|
163
|
+
<div class="p-6 max-w-7xl mx-auto space-y-8">
|
|
164
|
+
<div class="text-center mb-8">
|
|
165
|
+
<h1 class="text-3xl font-bold text-gray-900 mb-2">Button Audit Review</h1>
|
|
166
|
+
<p class="text-gray-600">Last updated: December 30, 2024</p>
|
|
167
|
+
</div>
|
|
168
|
+
|
|
169
|
+
<!-- Summary Cards -->
|
|
170
|
+
<div class="grid grid-cols-3 gap-6 mb-8">
|
|
171
|
+
<div class="p-6 bg-yellow-50 border-2 border-yellow-400 rounded-lg text-center">
|
|
172
|
+
<div class="text-4xl font-bold text-yellow-600">{totalWithoutVariant}</div>
|
|
173
|
+
<div class="text-sm text-gray-600 mt-2">Buttons Without Variant</div>
|
|
174
|
+
<span class="inline-block mt-2 px-3 py-1 text-xs rounded-full bg-yellow-200 text-yellow-800">Needs Review</span>
|
|
175
|
+
</div>
|
|
176
|
+
<div class="p-6 bg-green-50 border-2 border-green-400 rounded-lg text-center">
|
|
177
|
+
<div class="text-4xl font-bold text-green-600">{recentFixes.length}</div>
|
|
178
|
+
<div class="text-sm text-gray-600 mt-2">Recent Fix Sessions</div>
|
|
179
|
+
<span class="inline-block mt-2 px-3 py-1 text-xs rounded-full bg-green-200 text-green-800">Today</span>
|
|
180
|
+
</div>
|
|
181
|
+
<div class="p-6 bg-blue-50 border-2 border-blue-400 rounded-lg text-center">
|
|
182
|
+
<div class="text-4xl font-bold text-blue-600">{validVariants.length}</div>
|
|
183
|
+
<div class="text-sm text-gray-600 mt-2">Valid Variants</div>
|
|
184
|
+
<span class="inline-block mt-2 px-3 py-1 text-xs rounded-full bg-blue-200 text-blue-800">Reference</span>
|
|
185
|
+
</div>
|
|
186
|
+
</div>
|
|
187
|
+
|
|
188
|
+
<!-- Buttons Without Variant -->
|
|
189
|
+
<section class="border-2 border-yellow-400 rounded-lg p-6 bg-yellow-50">
|
|
190
|
+
<h2 class="text-xl font-bold text-yellow-700 mb-4 flex items-center gap-2">
|
|
191
|
+
<span class="text-2xl">⚠</span> Buttons Without Variant (Default to blue-solid)
|
|
192
|
+
</h2>
|
|
193
|
+
<p class="text-gray-600 mb-4">
|
|
194
|
+
These buttons have no <code class="bg-white px-2 py-0.5 rounded text-sm">variant</code> prop and render as solid blue by default.
|
|
195
|
+
Review each to determine if blue-solid is correct or if another variant should be used.
|
|
196
|
+
</p>
|
|
197
|
+
|
|
198
|
+
<div class="overflow-x-auto bg-white rounded-lg">
|
|
199
|
+
<table class="w-full text-sm">
|
|
200
|
+
<thead class="bg-gray-100">
|
|
201
|
+
<tr>
|
|
202
|
+
<th class="px-4 py-3 text-left font-medium">File</th>
|
|
203
|
+
<th class="px-4 py-3 text-center font-medium">Count</th>
|
|
204
|
+
<th class="px-4 py-3 text-left font-medium">Context</th>
|
|
205
|
+
<th class="px-4 py-3 text-center font-medium">Status</th>
|
|
206
|
+
</tr>
|
|
207
|
+
</thead>
|
|
208
|
+
<tbody>
|
|
209
|
+
{#each buttonsWithoutVariant as item}
|
|
210
|
+
<tr class="border-b border-gray-200">
|
|
211
|
+
<td class="px-4 py-3">
|
|
212
|
+
<code class="text-xs bg-yellow-100 text-yellow-800 px-2 py-1 rounded">
|
|
213
|
+
{item.file}
|
|
214
|
+
</code>
|
|
215
|
+
</td>
|
|
216
|
+
<td class="px-4 py-3 text-center font-medium">{item.count}</td>
|
|
217
|
+
<td class="px-4 py-3 text-gray-600">{item.context}</td>
|
|
218
|
+
<td class="px-4 py-3 text-center">
|
|
219
|
+
<span class="px-2 py-1 text-xs rounded-full bg-yellow-200 text-yellow-800">Review</span>
|
|
220
|
+
</td>
|
|
221
|
+
</tr>
|
|
222
|
+
{/each}
|
|
223
|
+
</tbody>
|
|
224
|
+
</table>
|
|
225
|
+
</div>
|
|
226
|
+
|
|
227
|
+
<div class="mt-4 p-4 bg-yellow-100 rounded-lg">
|
|
228
|
+
<p class="text-sm text-yellow-800">
|
|
229
|
+
<strong>Total: ~{totalWithoutVariant} buttons</strong> across the codebase need variant review.
|
|
230
|
+
Many may be intentionally blue-solid (CTAs), but others may need gray-outline, menu-item, or icon variants.
|
|
231
|
+
</p>
|
|
232
|
+
</div>
|
|
233
|
+
</section>
|
|
234
|
+
|
|
235
|
+
<!-- Visual Examples: Current vs Recommended -->
|
|
236
|
+
<section class="border-2 border-orange-400 rounded-lg p-6 bg-orange-50">
|
|
237
|
+
<h2 class="text-xl font-bold text-orange-700 mb-4 flex items-center gap-2">
|
|
238
|
+
<span class="text-2xl">👁</span> Visual Comparison: Current vs Recommended
|
|
239
|
+
</h2>
|
|
240
|
+
<p class="text-gray-600 mb-6">
|
|
241
|
+
These examples show how buttons WITHOUT a variant currently render (blue-solid default) versus how they SHOULD render with the correct variant.
|
|
242
|
+
</p>
|
|
243
|
+
|
|
244
|
+
<div class="space-y-8">
|
|
245
|
+
{#each visualExamples as category}
|
|
246
|
+
<div class="bg-white rounded-lg p-5 border border-orange-200">
|
|
247
|
+
<div class="flex items-center gap-3 mb-2">
|
|
248
|
+
<h3 class="font-bold text-gray-900">{category.category}</h3>
|
|
249
|
+
{#if category.examples[0]?.correct}
|
|
250
|
+
<span class="px-2 py-0.5 text-xs rounded-full bg-green-100 text-green-700">Correct</span>
|
|
251
|
+
{:else}
|
|
252
|
+
<span class="px-2 py-0.5 text-xs rounded-full bg-red-100 text-red-700">Needs Fix</span>
|
|
253
|
+
{/if}
|
|
254
|
+
</div>
|
|
255
|
+
<p class="text-sm text-gray-500 mb-4">{category.description}</p>
|
|
256
|
+
|
|
257
|
+
<div class="grid grid-cols-1 md:grid-cols-3 gap-4">
|
|
258
|
+
{#each category.examples as example}
|
|
259
|
+
<div class="border border-gray-200 rounded-lg p-4 bg-gray-50">
|
|
260
|
+
<div class="text-xs text-gray-500 mb-3 font-mono truncate" title={example.location}>
|
|
261
|
+
{example.location}
|
|
262
|
+
</div>
|
|
263
|
+
|
|
264
|
+
<div class="space-y-3">
|
|
265
|
+
<!-- Current (no variant) -->
|
|
266
|
+
<div>
|
|
267
|
+
<div class="text-xs text-red-600 font-medium mb-1">Current (no variant):</div>
|
|
268
|
+
<Button size="sm">{example.label}</Button>
|
|
269
|
+
</div>
|
|
270
|
+
|
|
271
|
+
<!-- Arrow -->
|
|
272
|
+
<div class="text-center text-gray-400">↓</div>
|
|
273
|
+
|
|
274
|
+
<!-- Recommended -->
|
|
275
|
+
<div>
|
|
276
|
+
<div class="text-xs text-green-600 font-medium mb-1">
|
|
277
|
+
Recommended: <code class="bg-green-100 px-1 rounded">{example.recommended}</code>
|
|
278
|
+
</div>
|
|
279
|
+
<Button variant={example.recommended} size="sm">{example.label}</Button>
|
|
280
|
+
</div>
|
|
281
|
+
</div>
|
|
282
|
+
</div>
|
|
283
|
+
{/each}
|
|
284
|
+
</div>
|
|
285
|
+
</div>
|
|
286
|
+
{/each}
|
|
287
|
+
</div>
|
|
288
|
+
|
|
289
|
+
<div class="mt-6 p-4 bg-orange-100 rounded-lg">
|
|
290
|
+
<p class="text-sm text-orange-800">
|
|
291
|
+
<strong>Key insight:</strong> Buttons without variant all render as solid blue (left), making it hard to distinguish
|
|
292
|
+
primary actions from secondary ones. Adding proper variants (right) creates visual hierarchy.
|
|
293
|
+
</p>
|
|
294
|
+
</div>
|
|
295
|
+
</section>
|
|
296
|
+
|
|
297
|
+
<!-- Recent Fixes -->
|
|
298
|
+
<section class="border-2 border-green-400 rounded-lg p-6 bg-green-50">
|
|
299
|
+
<h2 class="text-xl font-bold text-green-700 mb-4 flex items-center gap-2">
|
|
300
|
+
<span class="text-2xl">✓</span> Recent Fixes (December 30, 2024)
|
|
301
|
+
</h2>
|
|
302
|
+
|
|
303
|
+
<div class="space-y-6">
|
|
304
|
+
{#each recentFixes as fix}
|
|
305
|
+
<div class="bg-white rounded-lg p-4 border-l-4 border-green-500">
|
|
306
|
+
<h3 class="font-semibold text-gray-900 mb-2">{fix.description}</h3>
|
|
307
|
+
<ul class="text-sm text-gray-600 space-y-1">
|
|
308
|
+
{#each fix.fixes as item}
|
|
309
|
+
<li class="flex items-start gap-2">
|
|
310
|
+
<span class="text-green-500 mt-0.5">✓</span>
|
|
311
|
+
{item}
|
|
312
|
+
</li>
|
|
313
|
+
{/each}
|
|
314
|
+
</ul>
|
|
315
|
+
</div>
|
|
316
|
+
{/each}
|
|
317
|
+
</div>
|
|
318
|
+
</section>
|
|
319
|
+
|
|
320
|
+
<!-- Valid Variants Reference -->
|
|
321
|
+
<section class="border rounded-lg p-6 bg-white">
|
|
322
|
+
<h2 class="text-xl font-bold text-gray-900 mb-4 flex items-center gap-2">
|
|
323
|
+
<span class="text-blue-600">ℹ</span> Valid Variants Reference
|
|
324
|
+
</h2>
|
|
325
|
+
|
|
326
|
+
<div class="grid grid-cols-2 md:grid-cols-3 lg:grid-cols-4 gap-4">
|
|
327
|
+
{#each validVariants as v}
|
|
328
|
+
<div class="border border-gray-200 rounded-lg p-4">
|
|
329
|
+
<div class="flex items-center gap-2 mb-3">
|
|
330
|
+
<Button variant={v.name} size="sm">{v.name}</Button>
|
|
331
|
+
</div>
|
|
332
|
+
<code class="text-xs bg-gray-100 px-2 py-1 rounded block mb-1">
|
|
333
|
+
variant="{v.name}"
|
|
334
|
+
</code>
|
|
335
|
+
{#if v.alias}
|
|
336
|
+
<code class="text-xs bg-blue-50 text-blue-700 px-2 py-1 rounded block mb-2">
|
|
337
|
+
or: "{v.alias}"
|
|
338
|
+
</code>
|
|
339
|
+
{/if}
|
|
340
|
+
<p class="text-xs text-gray-500">{v.usage}</p>
|
|
341
|
+
</div>
|
|
342
|
+
{/each}
|
|
343
|
+
</div>
|
|
344
|
+
</section>
|
|
345
|
+
|
|
346
|
+
<!-- Decision Guide -->
|
|
347
|
+
<section class="border-2 border-blue-400 rounded-lg p-6 bg-blue-50">
|
|
348
|
+
<h2 class="text-xl font-bold text-blue-700 mb-4">Button Variant Decision Guide</h2>
|
|
349
|
+
|
|
350
|
+
<div class="grid grid-cols-2 gap-6">
|
|
351
|
+
<div class="bg-white rounded-lg p-4">
|
|
352
|
+
<h3 class="font-semibold text-gray-900 mb-3">When to use each variant</h3>
|
|
353
|
+
<ul class="space-y-2 text-sm">
|
|
354
|
+
<li class="flex items-start gap-2">
|
|
355
|
+
<code class="bg-blue-100 text-blue-800 px-1 rounded text-xs shrink-0">default</code>
|
|
356
|
+
<span class="text-gray-600">Primary CTAs: Save, Submit, + New</span>
|
|
357
|
+
</li>
|
|
358
|
+
<li class="flex items-start gap-2">
|
|
359
|
+
<code class="bg-blue-100 text-blue-800 px-1 rounded text-xs shrink-0">outline</code>
|
|
360
|
+
<span class="text-gray-600">Secondary CTAs: Invite, Export</span>
|
|
361
|
+
</li>
|
|
362
|
+
<li class="flex items-start gap-2">
|
|
363
|
+
<code class="bg-gray-100 text-gray-800 px-1 rounded text-xs shrink-0">alternative</code>
|
|
364
|
+
<span class="text-gray-600">Cancel, Close, Filter, Actions triggers</span>
|
|
365
|
+
</li>
|
|
366
|
+
<li class="flex items-start gap-2">
|
|
367
|
+
<code class="bg-red-100 text-red-800 px-1 rounded text-xs shrink-0">red</code>
|
|
368
|
+
<span class="text-gray-600">Delete confirmations, destructive actions</span>
|
|
369
|
+
</li>
|
|
370
|
+
<li class="flex items-start gap-2">
|
|
371
|
+
<code class="bg-gray-100 text-gray-800 px-1 rounded text-xs shrink-0">ghost</code>
|
|
372
|
+
<span class="text-gray-600">Tertiary actions: Edit, View, Show more</span>
|
|
373
|
+
</li>
|
|
374
|
+
<li class="flex items-start gap-2">
|
|
375
|
+
<code class="bg-gray-100 text-gray-800 px-1 rounded text-xs shrink-0">menu-item</code>
|
|
376
|
+
<span class="text-gray-600">Dropdown items, list selections</span>
|
|
377
|
+
</li>
|
|
378
|
+
<li class="flex items-start gap-2">
|
|
379
|
+
<code class="bg-gray-100 text-gray-800 px-1 rounded text-xs shrink-0">icon</code>
|
|
380
|
+
<span class="text-gray-600">Close buttons, drag handles</span>
|
|
381
|
+
</li>
|
|
382
|
+
</ul>
|
|
383
|
+
</div>
|
|
384
|
+
|
|
385
|
+
<div class="bg-white rounded-lg p-4">
|
|
386
|
+
<h3 class="font-semibold text-gray-900 mb-3">Common mistakes</h3>
|
|
387
|
+
<ul class="space-y-2 text-sm text-gray-600">
|
|
388
|
+
<li class="flex items-start gap-2">
|
|
389
|
+
<span class="text-red-500">✗</span>
|
|
390
|
+
<span>No variant on dropdown items → defaults to solid blue</span>
|
|
391
|
+
</li>
|
|
392
|
+
<li class="flex items-start gap-2">
|
|
393
|
+
<span class="text-red-500">✗</span>
|
|
394
|
+
<span>No variant on Cancel → should be alternative</span>
|
|
395
|
+
</li>
|
|
396
|
+
<li class="flex items-start gap-2">
|
|
397
|
+
<span class="text-red-500">✗</span>
|
|
398
|
+
<span>No variant on close/X buttons → should be icon</span>
|
|
399
|
+
</li>
|
|
400
|
+
<li class="flex items-start gap-2">
|
|
401
|
+
<span class="text-red-500">✗</span>
|
|
402
|
+
<span>Invalid variant names fall back to default (solid blue)</span>
|
|
403
|
+
</li>
|
|
404
|
+
</ul>
|
|
405
|
+
|
|
406
|
+
<div class="mt-4 p-3 bg-blue-100 rounded-lg">
|
|
407
|
+
<p class="text-xs text-blue-800">
|
|
408
|
+
<strong>Tip:</strong> When in doubt, use alternative for secondary actions
|
|
409
|
+
and default only for the primary action.
|
|
410
|
+
</p>
|
|
411
|
+
</div>
|
|
412
|
+
</div>
|
|
413
|
+
</div>
|
|
414
|
+
</section>
|
|
415
|
+
|
|
416
|
+
<!-- How to Find Issues -->
|
|
417
|
+
<section class="border rounded-lg p-6 bg-gray-50">
|
|
418
|
+
<h2 class="text-xl font-bold text-gray-900 mb-4">How to Find Buttons Without Variant</h2>
|
|
419
|
+
|
|
420
|
+
<div class="bg-white rounded-lg p-4">
|
|
421
|
+
<p class="text-sm text-gray-600 mb-2">Run this command in micdrop-frontend:</p>
|
|
422
|
+
<code class="block bg-gray-900 text-green-400 p-3 rounded text-xs overflow-x-auto">
|
|
423
|
+
grep -rn "<Button" --include="*.svelte" src | grep -v "variant="
|
|
424
|
+
</code>
|
|
425
|
+
</div>
|
|
426
|
+
</section>
|
|
427
|
+
</div>
|