@getjones/test-infra 2.7.13 → 2.7.14

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@getjones/test-infra",
-  "version": "2.7.13",
+  "version": "2.7.14",
   "description": "Providing internal and openapi interface",
   "main": "src/index.js",
   "scripts": {

package/src/saas/internal-api/compliance/api/overrideGap/override.gap.service.js

@@ -25,7 +25,7 @@ const getOverrideGapModel = (
 	record,
 	policyName,
 	attributeName,
-	waiverReason,
+	reason,
 	remarks,
 	{
 		userId,
@@ -35,19 +35,19 @@ const getOverrideGapModel = (
 	userId = userId || env.getSystemUserIdentity(credentials.superUser).id;
 	userRole = userRole || userTypes.ICS;
 
-	const waiveModel = new OverrideGapModel({
+	const overrideGapModel = new OverrideGapModel({
 		contractorId: record.id,
 		auditId,
-		waiverReason,
+		reason,
 		remarks,
 		userId,
 		userRole
 	});
 
-	return waiveModel;
+	return overrideGapModel;
 };
 
-const getWaiveModelByGap = (
+const getOverrideGapModelByGap = (
 	record,
 	policyName,
 	gap,
@@ -96,14 +96,14 @@ const getPolicyAuditIdFromRecord = (record, policyName, attributeName) => {
 
 // PRIVATE METHOD - please refer to waiveAllGaps / acceptAllGaps according to your needs
 const overrideAllGaps = async (record, context, { reason = OVERRIDE_GAP_REASONS.BUSINESS_DECISION, note = 'WAIVED AUTOMATICALLY' } = {}) => {
-	const allWaivablePolicies = auditUtil.getAllWaivablePolicies(record, context);
+	const allOverriddenPolicies = auditUtil.getAllOverriddenGapPolicies(record, context);
 
-	for (const waivable of allWaivablePolicies) {
-		const overrideGapModel = getOverrideGapModel(record, waivable.policyName, waivable.attributeName, reason, note);
-		const waiveResponse = await overrideGap({ overrideGapModel, context });
+	for (const policy of allOverriddenPolicies) {
+		const overrideGapModel = getOverrideGapModel(record, policy.policyName, policy.attributeName, reason, note);
+		const overrideGapResponse = await overrideGap({ overrideGapModel, context });
 
-		if (waiveResponse.status !== httpResponseStatusCodes.OK) {
-			throw Error(`Failed to waive ${waivable.policyName} - ${waivable.attributeName} for ${record.company}`);
+		if (overrideGapResponse.status !== httpResponseStatusCodes.OK) {
+			throw Error(`Failed to override gap ${policy.policyName} - ${policy.attributeName} for ${record.company}`);
 		}
 	}
 };
@@ -127,7 +127,7 @@ module.exports = {
 	waiveAllGaps,
 	getOverrideGapModel,
 	getRetractModel,
-	getWaiveModelByGap,
+	getOverrideGapModelByGap,
 	overrideGap,
 	retractOverride
 };

package/src/saas/internal-api/compliance/models/overrideGap/override.gap.model.js

@@ -1,10 +1,10 @@
 class OverrideGapModel {
 	constructor({
-		contractorId, auditId, waiverReason, remarks, userId, userRole
+		contractorId, auditId, reason, remarks, userId, userRole
 	}) {
 		this.auditorContractorId = auditId;
 		this.contractorId = contractorId;
-		this.waiverReason = waiverReason;
+		this.reason = reason;
 		this.remarks = remarks || '';
 		this.userId = userId;
 		this.userRole = userRole;

package/src/saas/internal-api/compliance/utils/auditUtil.js

@@ -22,10 +22,6 @@ const getAttributeKey = attribute => {
 	return specialAttributes[attribute] || attribute;
 };
 
-const getWaiveReason = reason => {
-	return waiveReasons[reason] || reason;
-};
-
 const getAttributeNameByGap = function(record, policyName, gap) {
 	const policy = record.reviewbyAuditor.find(contractorCoverage =>
 		contractorCoverage.insuranceName === policyName);
@@ -43,8 +39,8 @@ const getAttributeNameByGap = function(record, policyName, gap) {
 	return attribute.limitname;
 };
 
-const getAllWaivablePolicies = function(record) {
-	const waivable = [];
+const getAllOverriddenGapPolicies = function(record) {
+	const overridden = [];
 
 	const policies = record.reviewbyAuditor;
 	for (const policy of policies) {
@@ -55,7 +51,7 @@ const getAllWaivablePolicies = function(record) {
 
 		for (const error of errorList) {
 			if (error.warningStatus === 'POLICYERROR' && error.errorStatus === 'notIgnored') {
-				waivable.push({
+				overridden.push({
 					policyName: policyName,
 					attributeName: error.limitname
 				});
@@ -63,7 +59,7 @@ const getAllWaivablePolicies = function(record) {
 		}
 	}
 
-	return waivable;
+	return overridden;
 };
 
 const getPolicyId = (policyName, requirement) => {
@@ -176,8 +172,7 @@ module.exports = {
 	createAuditEntity,
 	getAttributeKey,
 	getAttributeNameByGap,
-	getWaiveReason,
-	getAllWaivablePolicies
+	getAllOverriddenGapPolicies
 };
 
 const certificateEndorsmentsList = [
@@ -214,9 +209,3 @@ const specialAttributes = {
 		'Umbrella': 'UMoccur'
 	}
 };
-
-const waiveReasons = {
-	'No Exposure': OVERRIDE_GAP_REASONS.NO_EXPOSURE,
-	'Business Decision': OVERRIDE_GAP_REASONS.BUSINESS_DECISION,
-	'Executive Approval': OVERRIDE_GAP_REASONS.EXECUTIVE_APPROVAL
-};