@getik-public/cli 1.1.0 → 1.2.1

package/CHANGELOG.md

@@ -1,3 +1,11 @@
+### v1.2.1
+Fixed typo on versionCode extraction.
+
+
+### v1.2.0
+FEATURE: Generate `versionCode` from `versionName`, so no longer needed to maintain `versionCode` in `package.json` file, only `version` needs to be updated.
+
+
 ### v1.1.0
 FEATURE: read versions from package.json and apply to android or ios project for that specific environment
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@getik-public/cli",
-  "version": "1.1.0",
+  "version": "1.2.1",
   "publishConfig": {
     "access": "public"
   },

package/src/mobile-build.js

@@ -65,20 +65,29 @@ async function applyPatchersForExternalNpmPackages() {
 }
 
 
-function readVersionsFromPackageJson(options) {
+function readVersionsFromPackageJson() {
   console.log('Checking versions in package.json file...');
   const packageJsonBuffer = fs.readFileSync(path.join(process.cwd(), 'package.json'));
   const packageJson = JSON.parse(packageJsonBuffer);
 
-  const environment = (options.environment.split('Debug')[0]);
-  const capitalizedEnvironment = (environment.charAt(0).toUpperCase() + environment.slice(1));
-
   const versionName = packageJson.version;
-  const versionCode = packageJson['versionCode' + capitalizedEnvironment];
 
-  if (!versionName || !versionCode) {
-    throw new Error(`Missing properties in "package.json". Make sure you have defined next properties: "version", "versionCode${capitalizedEnvironment}".`);
+  if (!versionName) {
+    throw new Error(`Missing properties in "package.json". Make sure you have defined next properties: "version".`);
+  }
+  const splitVersion = versionName.split('.');
+  const x = parseInt(splitVersion[0], 10);
+  const y = parseInt(splitVersion[1], 10);
+  const z = parseInt(splitVersion[2], 10);
+
+  if (y > 99 || z > 99) {
+    throw new Error(`Second and last number in versionName can't be bigger than 99.`);
   }
+
+  const yTransformed = (y < 10) ? `0${y}` : y;
+  const zTransformed = (z < 10) ? `0${z}` : z;
+  const versionCode = `${x}${yTransformed}${zTransformed}`;
+
   console.log(`Extracted versions: versionName = ${versionName}, versionCode = ${versionCode}.`);
 
   return {
@@ -360,7 +369,7 @@ export const mobileBuild = () => {
       console.log('INPUT OPTIONS: ', options);
       const cliCommands = createCliCommands(options);
 
-      const versions = readVersionsFromPackageJson(options);
+      const versions = readVersionsFromPackageJson();
       if (options.platform === 'android') {
         checkKeystorePropertiesFile();
         applyVersionForAndroid(versions);