@gethmy/mcp 2.5.0 → 2.5.1

package/src/__tests__/integration-memory-system.test.ts

@@ -1,321 +0,0 @@
-/**
- * Integration tests for the Intelligent Agent Memory System.
- *
- * These tests exercise the MCP tools end-to-end via the Harmony API.
- * Prerequisites:
- *   1. `supabase db push` (migration applied)
- *   2. MCP server configured with valid API key
- *   3. Active workspace and project set
- *
- * Run with: bun test packages/mcp-server/src/__tests__/integration-memory-system.test.ts
- *
- * These tests create real entities and clean them up afterwards.
- * If a test fails mid-way, you may need to manually delete leftover entities.
- */
-
-import { afterAll, describe, expect, test } from "bun:test";
-import { getClient } from "../api-client.js";
-import {
-  getActiveProjectId,
-  getActiveWorkspaceId,
-  isConfigured,
-  loadConfig,
-} from "../config.js";
-
-// Track entities created during tests for cleanup
-const createdEntityIds: string[] = [];
-
-// Skip all tests if MCP server isn't configured
-const configured = (() => {
-  try {
-    loadConfig();
-    return isConfigured() && !!getActiveWorkspaceId();
-  } catch {
-    return false;
-  }
-})();
-
-// Check if the tier migration has been applied by testing a create
-const migrationApplied = await (async () => {
-  if (!configured) return false;
-  try {
-    const client = getClient();
-    const result = await client.createMemoryEntity({
-      workspace_id: getActiveWorkspaceId()!,
-      project_id: getActiveProjectId() || undefined,
-      type: "context",
-      scope: getActiveProjectId() ? "project" : "workspace",
-      memory_tier: "draft",
-      title: "[TEST] Migration check - delete me",
-      content: "Checking if memory_tier column exists.",
-      agent_identifier: "test-runner",
-    });
-    const entity = result.entity as Record<string, unknown>;
-    const hasTier = entity.memory_tier === "draft";
-    // Clean up probe entity
-    if (entity.id) {
-      await client.deleteMemoryEntity(entity.id as string).catch(() => {});
-    }
-    return hasTier;
-  } catch {
-    return false;
-  }
-})();
-
-const describeIf = configured ? describe : describe.skip;
-const describeIfMigrated =
-  configured && migrationApplied ? describe : describe.skip;
-
-// Cleanup: delete all test entities
-afterAll(async () => {
-  if (!configured || createdEntityIds.length === 0) return;
-  const client = getClient();
-  for (const id of createdEntityIds) {
-    try {
-      await client.deleteMemoryEntity(id);
-    } catch {
-      // Entity may already be deleted
-    }
-  }
-});
-
-describeIfMigrated("Memory Tier System (integration)", () => {
-  test("create entity with explicit tier", async () => {
-    const client = getClient();
-    const workspaceId = getActiveWorkspaceId()!;
-    const projectId = getActiveProjectId() || undefined;
-
-    const result = await client.createMemoryEntity({
-      workspace_id: workspaceId,
-      project_id: projectId,
-      type: "context",
-      scope: projectId ? "project" : "workspace",
-      memory_tier: "draft",
-      title: "[TEST] Draft memory tier test",
-      content: "This is a test draft memory.",
-      tags: ["test", "integration"],
-      agent_identifier: "test-runner",
-    });
-
-    const entity = result.entity as Record<string, unknown>;
-    expect(entity.id).toBeTruthy();
-    expect(entity.memory_tier).toBe("draft");
-    createdEntityIds.push(entity.id as string);
-  });
-
-  test("create entity with default tier based on type", async () => {
-    const client = getClient();
-    const workspaceId = getActiveWorkspaceId()!;
-    const projectId = getActiveProjectId() || undefined;
-
-    // 'lesson' type should default to 'episode' tier
-    const result = await client.createMemoryEntity({
-      workspace_id: workspaceId,
-      project_id: projectId,
-      type: "lesson",
-      scope: projectId ? "project" : "workspace",
-      title: "[TEST] Lesson tier default",
-      content: "Testing that lessons default to episode tier.",
-      tags: ["test", "integration"],
-      agent_identifier: "test-runner",
-    });
-
-    const entity = result.entity as Record<string, unknown>;
-    expect(entity.id).toBeTruthy();
-    expect(entity.memory_tier).toBe("episode");
-    createdEntityIds.push(entity.id as string);
-  });
-
-  test("create pattern defaults to reference tier", async () => {
-    const client = getClient();
-    const workspaceId = getActiveWorkspaceId()!;
-    const projectId = getActiveProjectId() || undefined;
-
-    const result = await client.createMemoryEntity({
-      workspace_id: workspaceId,
-      project_id: projectId,
-      type: "pattern",
-      scope: projectId ? "project" : "workspace",
-      title: "[TEST] Pattern tier default",
-      content: "Testing that patterns default to reference tier.",
-      tags: ["test", "integration"],
-      agent_identifier: "test-runner",
-    });
-
-    const entity = result.entity as Record<string, unknown>;
-    expect(entity.memory_tier).toBe("reference");
-    createdEntityIds.push(entity.id as string);
-  });
-
-  test("update entity tier via promote", async () => {
-    const client = getClient();
-    const workspaceId = getActiveWorkspaceId()!;
-    const projectId = getActiveProjectId() || undefined;
-
-    // Create a draft
-    const createResult = await client.createMemoryEntity({
-      workspace_id: workspaceId,
-      project_id: projectId,
-      type: "context",
-      scope: projectId ? "project" : "workspace",
-      memory_tier: "draft",
-      title: "[TEST] Promotion test draft",
-      content: "Draft that will be promoted.",
-      tags: ["test", "integration"],
-      agent_identifier: "test-runner",
-    });
-
-    const entityId = (createResult.entity as Record<string, unknown>)
-      .id as string;
-    createdEntityIds.push(entityId);
-
-    // Promote to episode
-    const updateResult = await client.updateMemoryEntity(entityId, {
-      memory_tier: "episode",
-      metadata: {
-        promoted_from_tier: "draft",
-        promotion_reason: "test promotion",
-        promoted_at: new Date().toISOString(),
-      },
-    });
-
-    const updated = updateResult.entity as Record<string, unknown>;
-    expect(updated.memory_tier).toBe("episode");
-  });
-});
-
-describeIf("Context Assembly (integration)", () => {
-  test("search returns entities with tier info", async () => {
-    const client = getClient();
-    const workspaceId = getActiveWorkspaceId()!;
-    const projectId = getActiveProjectId() || undefined;
-
-    // Create a searchable entity
-    const createResult = await client.createMemoryEntity({
-      workspace_id: workspaceId,
-      project_id: projectId,
-      type: "solution",
-      scope: projectId ? "project" : "workspace",
-      memory_tier: "reference",
-      title: "[TEST] Unique search term xyzzy42",
-      content: "A solution for testing context assembly search.",
-      confidence: 0.95,
-      tags: ["test", "context-assembly"],
-      agent_identifier: "test-runner",
-    });
-
-    const entityId = (createResult.entity as Record<string, unknown>)
-      .id as string;
-    createdEntityIds.push(entityId);
-
-    // Search for it
-    const searchResult = await client.searchMemoryEntities(
-      workspaceId,
-      "xyzzy42",
-      { project_id: projectId, limit: 5 },
-    );
-
-    expect(searchResult.entities.length).toBeGreaterThan(0);
-    const found = searchResult.entities.find(
-      (e: unknown) => (e as Record<string, unknown>).id === entityId,
-    );
-    expect(found).toBeTruthy();
-    expect((found as Record<string, unknown>).memory_tier).toBe("reference");
-  });
-});
-
-describeIf("Graph Walk (integration)", () => {
-  test("create entities with relations and traverse", async () => {
-    const client = getClient();
-    const workspaceId = getActiveWorkspaceId()!;
-    const projectId = getActiveProjectId() || undefined;
-    const scope = projectId ? "project" : "workspace";
-
-    // Create two related entities
-    const errorResult = await client.createMemoryEntity({
-      workspace_id: workspaceId,
-      project_id: projectId,
-      type: "error",
-      scope,
-      memory_tier: "reference",
-      title: "[TEST] Graph walk error",
-      content: "An error for graph walk testing.",
-      tags: ["test", "graph-walk"],
-      agent_identifier: "test-runner",
-    });
-    const errorId = (errorResult.entity as Record<string, unknown>)
-      .id as string;
-    createdEntityIds.push(errorId);
-
-    const solutionResult = await client.createMemoryEntity({
-      workspace_id: workspaceId,
-      project_id: projectId,
-      type: "solution",
-      scope,
-      memory_tier: "reference",
-      title: "[TEST] Graph walk solution",
-      content: "A solution for graph walk testing.",
-      tags: ["test", "graph-walk"],
-      agent_identifier: "test-runner",
-    });
-    const solutionId = (solutionResult.entity as Record<string, unknown>)
-      .id as string;
-    createdEntityIds.push(solutionId);
-
-    // Create relation
-    const relResult = await client.createMemoryRelation({
-      source_id: errorId,
-      target_id: solutionId,
-      relation_type: "resolved_by",
-      confidence: 1.0,
-    });
-    expect((relResult.relation as Record<string, unknown>).id).toBeTruthy();
-
-    // Verify relations via getRelatedEntities
-    const related = await client.getRelatedEntities(errorId);
-    expect(related.outgoing.length).toBeGreaterThan(0);
-
-    // API returns relations with embedded target entity, not flat target_id
-    const outRel = related.outgoing.find((r: unknown) => {
-      const rel = r as Record<string, unknown>;
-      const target = rel.target as Record<string, unknown> | undefined;
-      return target?.id === solutionId || rel.target_id === solutionId;
-    });
-    expect(outRel).toBeTruthy();
-  });
-});
-
-describeIf("Vault Index with Tiers (integration)", () => {
-  test("vault index includes tier information", async () => {
-    const client = getClient();
-    const workspaceId = getActiveWorkspaceId()!;
-    const projectId = getActiveProjectId() || undefined;
-
-    let result: { entities: unknown[]; count: number };
-    try {
-      result = await client.getVaultIndex({
-        workspace_id: workspaceId,
-        project_id: projectId,
-        limit: 10,
-      });
-    } catch (e) {
-      // Endpoint may not be deployed yet - skip gracefully
-      const msg = e instanceof Error ? e.message : String(e);
-      if (msg.includes("Unknown endpoint")) {
-        console.log("Skipping: vault index endpoint not deployed yet");
-        return;
-      }
-      throw e;
-    }
-
-    expect(result.entities).toBeDefined();
-    // If there are entities, check they have tier info
-    if (result.entities.length > 0) {
-      const first = result.entities[0] as Record<string, unknown>;
-      // memory_tier might be present if migration is applied
-      if (first.memory_tier !== undefined) {
-        expect(["draft", "episode", "reference"]).toContain(first.memory_tier);
-      }
-    }
-  });
-});

package/src/__tests__/mcp-integration.test.ts

@@ -1,141 +0,0 @@
-/**
- * In-process MCP integration smoke. Card #182.
- *
- * Wires a real Server through `registerHandlers` and a real Client over an
- * InMemoryTransport pair. Asserts JSON-RPC wire format end-to-end:
- *
- *   - listTools returns every TOOLS row.
- *   - callTool dispatches and returns content.
- *   - listResources / readResource roundtrip.
- *   - unknown tool name surfaces as MCP-level error.
- *
- * This is the only place we exercise the SDK's transport + JSON-RPC layer.
- * The dispatch unit tests in tool-dispatch.test.ts cover handler logic with
- * a fake Server; this file confirms nothing breaks at the wire boundary.
- *
- * Run with: bun test packages/mcp-server/src/__tests__/mcp-integration.test.ts
- */
-
-import { afterAll, beforeAll, describe, expect, test } from "bun:test";
-import { Client } from "@modelcontextprotocol/sdk/client/index.js";
-import { InMemoryTransport } from "@modelcontextprotocol/sdk/inMemory.js";
-import { Server } from "@modelcontextprotocol/sdk/server/index.js";
-
-import {
-  RESOURCES,
-  registerHandlers,
-  TOOLS,
-  type ToolDeps,
-} from "../server.js";
-
-const TOOL_COUNT = Object.keys(TOOLS).length;
-
-function makeDeps(): ToolDeps {
-  return {
-    getClient: () => ({}) as never,
-    isConfigured: () => true,
-    getActiveProjectId: () => "11111111-1111-1111-1111-111111111111",
-    getActiveWorkspaceId: () => "22222222-2222-2222-2222-222222222222",
-    setActiveProject: () => {},
-    setActiveWorkspace: () => {},
-    getApiUrl: () => "http://localhost",
-    getMemoryDir: () => null,
-    getUserEmail: () => null,
-    saveConfig: () => {},
-    resetClient: () => {},
-  };
-}
-
-describe("MCP integration — in-process Client ↔ Server", () => {
-  let client: Client;
-  let server: Server;
-
-  beforeAll(async () => {
-    const [clientTransport, serverTransport] =
-      InMemoryTransport.createLinkedPair();
-
-    server = new Server(
-      { name: "harmony-test", version: "0.0.0" },
-      { capabilities: { tools: {}, resources: {} } },
-    );
-    registerHandlers(server, makeDeps());
-    await server.connect(serverTransport);
-
-    client = new Client(
-      { name: "harmony-test-client", version: "0.0.0" },
-      { capabilities: {} },
-    );
-    await client.connect(clientTransport);
-  });
-
-  afterAll(async () => {
-    await client.close();
-    await server.close();
-  });
-
-  test("listTools delivers every registered tool", async () => {
-    const result = await client.listTools();
-    expect(result.tools.length).toBe(TOOL_COUNT);
-    for (const tool of result.tools) {
-      expect(typeof tool.name).toBe("string");
-      expect(typeof tool.description).toBe("string");
-      expect(tool.inputSchema).toMatchObject({ type: "object" });
-    }
-  });
-
-  test("callTool routes harmony_get_context end-to-end", async () => {
-    const result = await client.callTool({
-      name: "harmony_get_context",
-      arguments: {},
-    });
-
-    expect(result.isError).toBeUndefined();
-    const content = result.content as Array<{ type: string; text: string }>;
-    expect(content[0].type).toBe("text");
-    const payload = JSON.parse(content[0].text);
-    expect(payload.success).toBe(true);
-    expect(payload.context.activeWorkspaceId).toBe(
-      "22222222-2222-2222-2222-222222222222",
-    );
-    expect(payload.context.activeProjectId).toBe(
-      "11111111-1111-1111-1111-111111111111",
-    );
-  });
-
-  test("callTool with unknown name returns isError content", async () => {
-    const result = await client.callTool({
-      name: "harmony_does_not_exist",
-      arguments: {},
-    });
-    expect(result.isError).toBe(true);
-    const content = result.content as Array<{ type: string; text: string }>;
-    expect(content[0].text.toLowerCase()).toContain("error");
-  });
-
-  test("listResources delivers RESOURCES", async () => {
-    const result = await client.listResources();
-    expect(result.resources.length).toBe(RESOURCES.length);
-    expect(result.resources[0].uri).toBe(RESOURCES[0].uri);
-  });
-
-  test("readResource serves harmony://context", async () => {
-    const result = await client.readResource({ uri: "harmony://context" });
-    const contents = result.contents as Array<{
-      uri: string;
-      mimeType?: string;
-      text?: string;
-    }>;
-    expect(contents[0].uri).toBe("harmony://context");
-    expect(contents[0].mimeType).toBe("application/json");
-    const parsed = JSON.parse(contents[0].text ?? "{}");
-    expect(parsed).toHaveProperty("configured");
-    expect(parsed).toHaveProperty("activeWorkspaceId");
-    expect(parsed).toHaveProperty("activeProjectId");
-  });
-
-  test("readResource on unknown URI surfaces JSON-RPC error", async () => {
-    await expect(
-      client.readResource({ uri: "harmony://unknown" }),
-    ).rejects.toThrow(/Unknown resource/);
-  });
-});

package/src/__tests__/memory-floor.test.ts

@@ -1,126 +0,0 @@
-import { describe, expect, test } from "bun:test";
-import { validateMemoryQuality } from "../memory-floor.js";
-
-const ok = (
-  overrides: Partial<Parameters<typeof validateMemoryQuality>[0]> = {},
-) => ({
-  title: "AnnotatedTextarea auto-grow deps must include open state",
-  content:
-    "When the parent prop changes from closed to open, the auto-grow effect must re-measure. Without the dep, the textarea stays at the cached height and clips multi-line input.",
-  type: "pattern",
-  scope: "project",
-  ...overrides,
-});
-
-describe("Memory Utility Floor (plan §4.5.1)", () => {
-  test("accepts a real engineering lesson", () => {
-    expect(validateMemoryQuality(ok())).toBeNull();
-  });
-
-  test("rejects comma-separated tag concatenation", () => {
-    const r = validateMemoryQuality(
-      ok({
-        title: "Consolidated procedure: procedure, add, user",
-        content:
-          "Consolidated from 5 procedure memories: foo bar baz qux many words.",
-      }),
-    );
-    expect(r?.rule).toBe("tag-concat");
-  });
-
-  test("rejects slash-separated tag concatenation", () => {
-    const r = validateMemoryQuality(
-      ok({
-        title: "Procedure: Procedure / Card / Mobile / Native",
-        content:
-          "3 related procedure entities consolidated. Original titles list goes here.",
-      }),
-    );
-    expect(r?.rule).toBe("tag-concat-slash");
-  });
-
-  test("rejects frequency-meta titles", () => {
-    const r = validateMemoryQuality(
-      ok({
-        title: "Pattern: recurring procedure (17 instances)",
-        content: "Recurring pattern: procedure entities appearing 19 times.",
-      }),
-    );
-    expect(r?.rule).toBe("frequency-meta");
-  });
-
-  test("rejects bare type prefix with empty content after colon", () => {
-    const r = validateMemoryQuality(
-      ok({
-        title: "Memory:",
-        content:
-          "Not enough substance here for any kind of memory entry value.",
-      }),
-    );
-    expect(r?.rule).toBe("bare-type-prefix");
-  });
-
-  test("rejects self-referential operational notes", () => {
-    const r = validateMemoryQuality(
-      ok({
-        title: "Auto-consolidation produces tautological clusters on tags",
-        content:
-          "The consolidation pipeline clusters entities by tag overlap, but doesn't distinguish content-bearing tags from structural pipeline tags.",
-        type: "lesson",
-      }),
-    );
-    expect(r?.rule).toBe("self-referential");
-  });
-
-  test("rejects content that's too short", () => {
-    const r = validateMemoryQuality(
-      ok({
-        title: "AnnotatedTextarea auto-grow deps fix",
-        content: "Short.",
-      }),
-    );
-    expect(r?.rule).toBe("length-floor");
-  });
-
-  test("rejects under-specific titles", () => {
-    const r = validateMemoryQuality(
-      ok({
-        title: "fix the bug",
-        content:
-          "There is a bug somewhere and it should be fixed at some point in the future.",
-      }),
-    );
-    expect(r?.rule).toBe("specificity-floor");
-  });
-
-  test("rejects Agent Profile dumps", () => {
-    const r = validateMemoryQuality({
-      title: "Agent Profile: claude-code",
-      content:
-        "## claude-code Performance Profile - Total sessions: 183 - Completed: 180 (98%)",
-      type: "agent",
-    });
-    expect(r?.rule).toBe("operational-data-ban");
-  });
-
-  test("session-scope memories bypass the Floor entirely", () => {
-    const r = validateMemoryQuality({
-      title: "user wants Q3 revenue rolled up by team",
-      content: "x",
-      type: "context",
-      scope: "session:abc123",
-    });
-    expect(r).toBeNull();
-  });
-
-  test("doc-source memories bypass title checks but not length", () => {
-    const r = validateMemoryQuality({
-      title: "## API Routes",
-      content:
-        "Section heading from CLAUDE.md auto-import. Long enough body content here ok.",
-      type: "context",
-      source_trust: "document",
-    });
-    expect(r).toBeNull();
-  });
-});