@gethmy/agent 1.14.2 → 1.14.4

package/dist/cli.js

@@ -5851,6 +5851,11 @@ async function runTransition(client, card, plan, opts = {}) {
     await withRetry("endSession", shortId, () => client.endAgentSession(card.id, plan.endSession), attempts, backoffMs);
     log.info(TAG22, `#${shortId} session ended (${plan.endSession.status})`);
   }
+  if (plan.assignAgent !== undefined) {
+    const assignedAgentId = plan.assignAgent;
+    await withRetry("assignAgent", shortId, () => client.updateCard(card.id, { assignedAgentId }), attempts, backoffMs);
+    log.info(TAG22, assignedAgentId ? `#${shortId} assigned → agent ${assignedAgentId}` : `#${shortId} unassigned`);
+  }
   if (opts.store && opts.runId) {
     try {
       await opts.store.heartbeat(opts.runId);
@@ -6986,7 +6991,8 @@ async function advanceStageOnGate(card, stage, stageIndex, def, evaluation, deps
   });
   await runTransition(deps.client, card, {
     move: { columnName: toColumn },
-    addLabels: [{ name: AGENT_LABEL }]
+    addLabels: [{ name: AGENT_LABEL }],
+    ...isAgentRunnableOwner(next.stage.owner) ? { assignAgent: deps.agentId } : {}
   }, { store: deps.stateStore, runId: deps.runId });
   deps.stateStore.recordOutcome(card.id, "success").catch(() => {});
   log.info(TAG28, `#${card.short_id} advanced "${stage.name}" → "${next.stage.name}" (column "${toColumn}")`);
@@ -7015,7 +7021,11 @@ async function handleGateUnmet(card, stage, summary, deps) {
   try {
     await deps.client.addComment(card.id, `Stage gate unmet — re-running "${stage.name}". ${summary}.`, { commentType: "progress" });
   } catch {}
-  await runTransition(deps.client, card, { move: { columnName: toColumn }, addLabels: [{ name: AGENT_LABEL }] }, { store: deps.stateStore, runId: deps.runId });
+  await runTransition(deps.client, card, {
+    move: { columnName: toColumn },
+    addLabels: [{ name: AGENT_LABEL }],
+    ...isAgentRunnableOwner(stage.owner) ? { assignAgent: deps.agentId } : {}
+  }, { store: deps.stateStore, runId: deps.runId });
   log.info(TAG28, `#${card.short_id} gate unmet for "${stage.name}" — requeued to "${toColumn}" for re-run (attempt ${attempts}/${deps.maxAttempts})`);
   return { kind: "requeued_gate_unmet", toColumn };
 }
@@ -7078,6 +7088,9 @@ function buildStagePreamble(stage) {
     }
   }
   lines.push("Do only this stage's work. When the stage's handoff is met, end your session — advancement to the next stage is handled by the board.");
+  if (normalizeGateSpec(stage.gate)?.kind === "review_passed") {
+    lines.push("", "**This stage's gate is `review_passed` — your deliverable is a review verdict, not a prose handoff.** Do NOT end the session until you have actually reviewed the change and emitted EXACTLY one JSON block as the LAST thing you output (nothing after it):", "```json", REVIEW_VERDICT_SCHEMA, "```", "Decision rules:", REVIEW_DECISION_RULES, "The board reads this verdict to decide advancement: `approved` advances the card, `rejected` sends it back. A missing or unparseable verdict blocks the card. Do NOT modify any code — this is a read-only review.");
+  }
   return lines.filter(Boolean).join(`
 `);
 }
@@ -7115,12 +7128,14 @@ class Worker {
   timedOut = false;
   verificationFailed = false;
   held = false;
+  completionStarted = false;
   sessionId = null;
   runId = null;
   cliSessionId = null;
   lastDrainedSeq = 0;
   runCostCents = 0;
   runTurns = 0;
+  lastRunText = "";
   constructor(id, config, client, agentId, onDone, workspaceId, projectId, stateStore, onCardCompleted, onApiError) {
     this.config = config;
     this.client = client;
@@ -7186,8 +7201,10 @@ class Worker {
     this.timedOut = false;
     this.verificationFailed = false;
     this.held = false;
+    this.completionStarted = false;
     this.runCostCents = 0;
     this.runTurns = 0;
+    this.lastRunText = "";
     this.cliSessionId = null;
     this.lastDrainedSeq = 0;
     this.cardId = card.id;
@@ -7325,6 +7342,7 @@ class Worker {
         progressPercent: 75
       });
       this.state = "completing";
+      this.completionStarted = true;
       await this.recordPhase("completing");
       let stageGateEvaluation = null;
       const stageRun = stageCtx.kind === "run" ? stageCtx : null;
@@ -7639,6 +7657,10 @@ class Worker {
         log.info(this.tag, `Stage "${stage.name}" gate "${gate.kind}" is advisory — skipping enforcement`);
         return null;
       }
+      const review = gate.kind === "review_passed" ? parseReviewOutput(this.lastRunText) : undefined;
+      if (review) {
+        log.info(this.tag, `Review-gated stage "${stage.name}" verdict: ${review.verdict} (${review.findings.length} finding(s))`);
+      }
       const registry = buildGateCollectorRegistry({
         build: {
           worktreePath,
@@ -7649,7 +7671,8 @@ class Worker {
           worktreePath,
           artifactType: stage.artifact_type
         },
-        checklist: { subtasks, cardDone: card.done ?? false }
+        checklist: { subtasks, cardDone: card.done ?? false },
+        ...review ? { review } : {}
       });
       const context = {
         cardId: card.id,
@@ -7676,6 +7699,7 @@ class Worker {
       return await advanceStageOnGate(card, stage, stageIndex, def, evaluation, {
         client: this.client,
         stateStore: this.stateStore,
+        agentId: this.agentId,
         maxAttempts: this.config.budget.maxAttemptsPerCard,
         fallbackColumn: this.config.pickupColumns[0] ?? "To Do",
         sink: this.cliRunner,
@@ -7778,7 +7802,7 @@ class Worker {
         sigtermTimeoutMs: CANCEL_SIGTERM_TIMEOUT2
       });
     }
-    if (this.cardId && !this.timedOut) {
+    if (this.cardId && !this.timedOut && !this.completionStarted) {
       try {
         const stats = this.lastSessionStats ?? this.progressTracker?.stats;
         await this.client.endAgentSession(this.cardId, {
@@ -7986,6 +8010,9 @@ class Worker {
           });
         }
       }
+      parser.on("text", (content) => {
+        this.lastRunText += content;
+      });
       parser.on("parse_error", (msg) => {
         log.debug(this.tag, `Stream parse error (non-fatal): ${msg}`);
         runLog?.stream.write(`
@@ -8079,6 +8106,10 @@ class Worker {
     try {
       for await (const ev of stream) {
         this.progressTracker?.ingest(ev);
+        if (ev.kind === "assistant_text") {
+          this.lastRunText += `${ev.payload.text}
+`;
+        }
         if (ev.source === "agent")
           this.cliRunner?.record(ev);
         if (ev.kind === "error") {
@@ -8166,6 +8197,8 @@ var init_worker = __esm(() => {
   init_process_group();
   init_progress_tracker();
   init_prompt();
+  init_review_completion();
+  init_review_knowledge();
   init_run_log();
   init_sdk_agent_runner();
   init_stage_advance();

package/dist/index.js

@@ -5850,6 +5850,11 @@ async function runTransition(client, card, plan, opts = {}) {
     await withRetry("endSession", shortId, () => client.endAgentSession(card.id, plan.endSession), attempts, backoffMs);
     log.info(TAG22, `#${shortId} session ended (${plan.endSession.status})`);
   }
+  if (plan.assignAgent !== undefined) {
+    const assignedAgentId = plan.assignAgent;
+    await withRetry("assignAgent", shortId, () => client.updateCard(card.id, { assignedAgentId }), attempts, backoffMs);
+    log.info(TAG22, assignedAgentId ? `#${shortId} assigned → agent ${assignedAgentId}` : `#${shortId} unassigned`);
+  }
   if (opts.store && opts.runId) {
     try {
       await opts.store.heartbeat(opts.runId);
@@ -6985,7 +6990,8 @@ async function advanceStageOnGate(card, stage, stageIndex, def, evaluation, deps
   });
   await runTransition(deps.client, card, {
     move: { columnName: toColumn },
-    addLabels: [{ name: AGENT_LABEL }]
+    addLabels: [{ name: AGENT_LABEL }],
+    ...isAgentRunnableOwner(next.stage.owner) ? { assignAgent: deps.agentId } : {}
   }, { store: deps.stateStore, runId: deps.runId });
   deps.stateStore.recordOutcome(card.id, "success").catch(() => {});
   log.info(TAG28, `#${card.short_id} advanced "${stage.name}" → "${next.stage.name}" (column "${toColumn}")`);
@@ -7014,7 +7020,11 @@ async function handleGateUnmet(card, stage, summary, deps) {
   try {
     await deps.client.addComment(card.id, `Stage gate unmet — re-running "${stage.name}". ${summary}.`, { commentType: "progress" });
   } catch {}
-  await runTransition(deps.client, card, { move: { columnName: toColumn }, addLabels: [{ name: AGENT_LABEL }] }, { store: deps.stateStore, runId: deps.runId });
+  await runTransition(deps.client, card, {
+    move: { columnName: toColumn },
+    addLabels: [{ name: AGENT_LABEL }],
+    ...isAgentRunnableOwner(stage.owner) ? { assignAgent: deps.agentId } : {}
+  }, { store: deps.stateStore, runId: deps.runId });
   log.info(TAG28, `#${card.short_id} gate unmet for "${stage.name}" — requeued to "${toColumn}" for re-run (attempt ${attempts}/${deps.maxAttempts})`);
   return { kind: "requeued_gate_unmet", toColumn };
 }
@@ -7077,6 +7087,9 @@ function buildStagePreamble(stage) {
     }
   }
   lines.push("Do only this stage's work. When the stage's handoff is met, end your session — advancement to the next stage is handled by the board.");
+  if (normalizeGateSpec(stage.gate)?.kind === "review_passed") {
+    lines.push("", "**This stage's gate is `review_passed` — your deliverable is a review verdict, not a prose handoff.** Do NOT end the session until you have actually reviewed the change and emitted EXACTLY one JSON block as the LAST thing you output (nothing after it):", "```json", REVIEW_VERDICT_SCHEMA, "```", "Decision rules:", REVIEW_DECISION_RULES, "The board reads this verdict to decide advancement: `approved` advances the card, `rejected` sends it back. A missing or unparseable verdict blocks the card. Do NOT modify any code — this is a read-only review.");
+  }
   return lines.filter(Boolean).join(`
 `);
 }
@@ -7114,12 +7127,14 @@ class Worker {
   timedOut = false;
   verificationFailed = false;
   held = false;
+  completionStarted = false;
   sessionId = null;
   runId = null;
   cliSessionId = null;
   lastDrainedSeq = 0;
   runCostCents = 0;
   runTurns = 0;
+  lastRunText = "";
   constructor(id, config, client, agentId, onDone, workspaceId, projectId, stateStore, onCardCompleted, onApiError) {
     this.config = config;
     this.client = client;
@@ -7185,8 +7200,10 @@ class Worker {
     this.timedOut = false;
     this.verificationFailed = false;
     this.held = false;
+    this.completionStarted = false;
     this.runCostCents = 0;
     this.runTurns = 0;
+    this.lastRunText = "";
     this.cliSessionId = null;
     this.lastDrainedSeq = 0;
     this.cardId = card.id;
@@ -7324,6 +7341,7 @@ class Worker {
         progressPercent: 75
       });
       this.state = "completing";
+      this.completionStarted = true;
       await this.recordPhase("completing");
       let stageGateEvaluation = null;
       const stageRun = stageCtx.kind === "run" ? stageCtx : null;
@@ -7638,6 +7656,10 @@ class Worker {
         log.info(this.tag, `Stage "${stage.name}" gate "${gate.kind}" is advisory — skipping enforcement`);
         return null;
       }
+      const review = gate.kind === "review_passed" ? parseReviewOutput(this.lastRunText) : undefined;
+      if (review) {
+        log.info(this.tag, `Review-gated stage "${stage.name}" verdict: ${review.verdict} (${review.findings.length} finding(s))`);
+      }
       const registry = buildGateCollectorRegistry({
         build: {
           worktreePath,
@@ -7648,7 +7670,8 @@ class Worker {
           worktreePath,
           artifactType: stage.artifact_type
         },
-        checklist: { subtasks, cardDone: card.done ?? false }
+        checklist: { subtasks, cardDone: card.done ?? false },
+        ...review ? { review } : {}
       });
       const context = {
         cardId: card.id,
@@ -7675,6 +7698,7 @@ class Worker {
       return await advanceStageOnGate(card, stage, stageIndex, def, evaluation, {
         client: this.client,
         stateStore: this.stateStore,
+        agentId: this.agentId,
         maxAttempts: this.config.budget.maxAttemptsPerCard,
         fallbackColumn: this.config.pickupColumns[0] ?? "To Do",
         sink: this.cliRunner,
@@ -7777,7 +7801,7 @@ class Worker {
         sigtermTimeoutMs: CANCEL_SIGTERM_TIMEOUT2
       });
     }
-    if (this.cardId && !this.timedOut) {
+    if (this.cardId && !this.timedOut && !this.completionStarted) {
       try {
         const stats = this.lastSessionStats ?? this.progressTracker?.stats;
         await this.client.endAgentSession(this.cardId, {
@@ -7985,6 +8009,9 @@ class Worker {
           });
         }
       }
+      parser.on("text", (content) => {
+        this.lastRunText += content;
+      });
       parser.on("parse_error", (msg) => {
         log.debug(this.tag, `Stream parse error (non-fatal): ${msg}`);
         runLog?.stream.write(`
@@ -8078,6 +8105,10 @@ class Worker {
     try {
       for await (const ev of stream) {
         this.progressTracker?.ingest(ev);
+        if (ev.kind === "assistant_text") {
+          this.lastRunText += `${ev.payload.text}
+`;
+        }
         if (ev.source === "agent")
           this.cliRunner?.record(ev);
         if (ev.kind === "error") {
@@ -8165,6 +8196,8 @@ var init_worker = __esm(() => {
   init_process_group();
   init_progress_tracker();
   init_prompt();
+  init_review_completion();
+  init_review_knowledge();
   init_run_log();
   init_sdk_agent_runner();
   init_stage_advance();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gethmy/agent",
-  "version": "1.14.2",
+  "version": "1.14.4",
   "description": "Push-based agent daemon for Harmony — watches board assignments and spawns Claude CLI workers",
   "type": "module",
   "main": "dist/index.js",