@getflip/swirl-components 0.78.1 → 0.80.0

package/dist/collection/collection-manifest.json

@@ -197,6 +197,7 @@
     "./components/swirl-lightbox/swirl-lightbox.js",
     "./components/swirl-list/swirl-list.js",
     "./components/swirl-menu-item/swirl-menu-item.js",
+    "./components/swirl-popover-trigger/swirl-popover-trigger.js",
     "./components/swirl-option-list/swirl-option-list.js",
     "./components/swirl-option-list-section/swirl-option-list-section.js",
     "./components/swirl-pdf-reader/swirl-pdf-reader.js",

package/dist/collection/components/swirl-button/swirl-button.js

@@ -9,8 +9,10 @@ export class SwirlButton {
     };
     this.disabled = undefined;
     this.download = undefined;
+    this.swirlAriaControls = undefined;
     this.swirlAriaDescribedby = undefined;
     this.swirlAriaExpanded = undefined;
+    this.swirlAriaHaspopup = undefined;
     this.swirlAriaLabel = undefined;
     this.form = undefined;
     this.hideLabel = undefined;
@@ -64,7 +66,7 @@ export class SwirlButton {
       "button--pill": this.pill,
     });
     const Tag = isLink ? "a" : "button";
-    return (h(Host, { style: { pointerEvents: this.disabled ? "none" : "" } }, h(Tag, { "aria-describedby": this.swirlAriaDescribedby, "aria-disabled": this.disabled && !isLink ? "true" : undefined, "aria-expanded": this.swirlAriaExpanded, "aria-label": ariaLabel, class: className, disabled: isLink ? undefined : this.disabled, download: isLink ? undefined : this.download, form: isLink ? undefined : this.form, href: this.href, name: isLink ? undefined : this.name, target: isLink ? this.target : undefined, type: isLink ? undefined : this.type, value: isLink ? undefined : this.value }, this.icon && (h("span", { class: "button__icon", innerHTML: this.icon, ref: (el) => (this.iconEl = el) })), !hideLabel && h("span", { class: "button__label" }, this.label))));
+    return (h(Host, { style: { pointerEvents: this.disabled ? "none" : "" } }, h(Tag, { "aria-controls": this.swirlAriaControls, "aria-describedby": this.swirlAriaDescribedby, "aria-disabled": this.disabled && !isLink ? "true" : undefined, "aria-expanded": this.swirlAriaExpanded, "aria-haspopup": this.swirlAriaHaspopup, "aria-label": ariaLabel, class: className, disabled: isLink ? undefined : this.disabled, download: isLink ? undefined : this.download, form: isLink ? undefined : this.form, href: this.href, name: isLink ? undefined : this.name, target: isLink ? this.target : undefined, type: isLink ? undefined : this.type, value: isLink ? undefined : this.value }, this.icon && (h("span", { class: "button__icon", innerHTML: this.icon, ref: (el) => (this.iconEl = el) })), !hideLabel && h("span", { class: "button__label" }, this.label))));
   }
   static get is() { return "swirl-button"; }
   static get encapsulation() { return "scoped"; }
@@ -114,6 +116,23 @@ export class SwirlButton {
         "attribute": "download",
         "reflect": false
       },
+      "swirlAriaControls": {
+        "type": "string",
+        "mutable": false,
+        "complexType": {
+          "original": "string",
+          "resolved": "string",
+          "references": {}
+        },
+        "required": false,
+        "optional": true,
+        "docs": {
+          "tags": [],
+          "text": ""
+        },
+        "attribute": "swirl-aria-controls",
+        "reflect": false
+      },
       "swirlAriaDescribedby": {
         "type": "string",
         "mutable": false,
@@ -148,6 +167,23 @@ export class SwirlButton {
         "attribute": "swirl-aria-expanded",
         "reflect": false
       },
+      "swirlAriaHaspopup": {
+        "type": "string",
+        "mutable": false,
+        "complexType": {
+          "original": "string",
+          "resolved": "string",
+          "references": {}
+        },
+        "required": false,
+        "optional": true,
+        "docs": {
+          "tags": [],
+          "text": ""
+        },
+        "attribute": "swirl-aria-haspopup",
+        "reflect": false
+      },
       "swirlAriaLabel": {
         "type": "string",
         "mutable": false,

package/dist/collection/components/swirl-date-input/swirl-date-input.js

@@ -103,7 +103,7 @@ export class SwirlDateInput {
     const className = classnames("date-input", {
       "date-input--inline": this.inline,
     });
-    return (h(Host, null, h("div", { class: className }, h("input", { "aria-describedby": this.swirlAriaDescribedby, "aria-disabled": this.disabled ? "true" : undefined, "aria-invalid": ariaInvalid, autoFocus: this.autoFocus, class: "date-input__input", disabled: this.disabled, id: this.id, onClick: this.onClick, onFocus: this.onFocus, onInput: this.onInput, placeholder: this.placeholder, required: this.required, type: "text", value: displayValue }), h("button", { "aria-label": this.datePickerTriggerLabel, class: "date-input__date-picker-button", disabled: this.disabled, id: `${this.id}-trigger`, type: "button" }, h("swirl-icon-today", { size: this.iconSize }))), !this.disabled && (h("swirl-popover", { animation: "scale-in-y", label: this.datePickerLabel, placement: "bottom-end", popoverId: `popover-${this.id}`, ref: (el) => (this.pickerPopover = el), trigger: `${this.id}-trigger` }, h("swirl-date-picker", { labels: this.labels, locale: this.locale, onValueChange: this.onPickDate, value: dateValue })))));
+    return (h(Host, null, h("div", { class: className }, h("input", { "aria-describedby": this.swirlAriaDescribedby, "aria-disabled": this.disabled ? "true" : undefined, "aria-invalid": ariaInvalid, autoFocus: this.autoFocus, class: "date-input__input", disabled: this.disabled, id: this.id, onClick: this.onClick, onFocus: this.onFocus, onInput: this.onInput, placeholder: this.placeholder, required: this.required, type: "text", value: displayValue }), h("swirl-popover-trigger", { popover: `popover-${this.id}` }, h("button", { "aria-label": this.datePickerTriggerLabel, class: "date-input__date-picker-button", disabled: this.disabled, type: "button" }, h("swirl-icon-today", { size: this.iconSize })))), !this.disabled && (h("swirl-popover", { animation: "scale-in-y", id: `popover-${this.id}`, label: this.datePickerLabel, placement: "bottom-end", ref: (el) => (this.pickerPopover = el) }, h("swirl-date-picker", { labels: this.labels, locale: this.locale, onValueChange: this.onPickDate, value: dateValue })))));
   }
   static get is() { return "swirl-date-input"; }
   static get encapsulation() { return "scoped"; }

package/dist/collection/components/swirl-date-input/swirl-date-input.spec.js

@@ -17,11 +17,13 @@ describe("swirl-date-input", () => {
       <swirl-date-input>
         <div class="date-input">
           <input class="date-input__input" id="swirl-date-input-0" placeholder="yyyy-mm-dd" type="text">
-          <button aria-label="Open date picker" class="date-input__date-picker-button" id="swirl-date-input-0-trigger" type="button">
-            <swirl-icon-today size="24"></swirl-icon-today>
-          </button>
+          <swirl-popover-trigger popover="popover-swirl-date-input-0">
+          <button aria-label="Open date picker" class="date-input__date-picker-button" type="button">
+              <swirl-icon-today size="24"></swirl-icon-today>
+            </button>
+          </swirl-popover-trigger>
         </div>
-        <swirl-popover animation="scale-in-y" label="Date picker" placement="bottom-end" popoverid="popover-swirl-date-input-0" trigger="swirl-date-input-0-trigger">
+        <swirl-popover animation="scale-in-y" id="popover-swirl-date-input-0" label="Date picker" placement="bottom-end">
           <swirl-date-picker locale="en-US"></swirl-date-picker>
         </swirl-popover>
       </swirl-date-input>

package/dist/collection/components/swirl-lightbox/swirl-lightbox.js

@@ -226,7 +226,7 @@ export class SwirlLightbox {
     const className = classnames("lightbox", {
       "lightbox--closing": this.closing,
     });
-    return (h(Host, null, h("section", { "aria-hidden": "true", "aria-label": this.label, class: className, id: "lightbox", onMouseDown: this.onPointerDown, onMouseMove: this.onPointerMove, onMouseOut: this.onPointerUp, onMouseUp: this.onPointerUp, onKeyDown: this.onKeyDown, onTouchEnd: this.onPointerUp, onTouchMove: this.onPointerMove, onTouchStart: this.onPointerDown, ref: (el) => (this.modalEl = el) }, h("div", { class: "lightbox__body", role: "document" }, h("header", { class: "lightbox__header" }, h("button", { "aria-label": this.closeButtonLabel, class: "lightbox__close-button", onClick: this.onCloseButtonClick }, h("swirl-icon-close", null)), h("button", { "aria-label": this.menuTriggerLabel, class: "lightbox__menu-button", id: "slide-menu-trigger" }, h("swirl-icon-more-vertikal", null))), h("div", { "aria-roledescription": "carousel", class: "lightbox__content", role: "group" }, h("div", { "aria-atomic": "false", "aria-live": "polite", class: "lightbox__slides" }, h("slot", { onSlotchange: this.registerSlides }))), h("div", { class: "lightbox__controls" }, h("button", { "aria-label": this.previousSlideButtonLabel, class: "lightbox__previous-slide-button", disabled: this.activeSlideIndex === 0, onClick: this.onPreviousSlideClick }, h("swirl-icon-arrow-left", null)), h("button", { "aria-label": this.nextSlideButtonLabel, class: "lightbox__next-slide-button", disabled: this.activeSlideIndex === this.slides.length - 1, onClick: this.onNextSlideClick }, h("swirl-icon-arrow-right", null))), showPagination && (h("span", { class: "lightbox__pagination" }, h("span", { "aria-current": "page" }, this.activeSlideIndex + 1), " /", " ", this.slides.length))), h("swirl-popover", { animation: "scale-in-y", disableScrollLock: true, label: this.menuLabel, placement: "bottom-end", popoverId: "slide-menu", ref: (el) => (this.menu = el), trigger: "slide-menu-trigger" }, h("swirl-stack", null, h("div", { class: "lightbox__meta" }, currentThumbnailUrl && (h("div", { class: "lightbox__thumbnail" }, h("swirl-thumbnail", { alt: "", src: currentThumbnailUrl }))), h("div", { class: "lightbox__file-info" }, h("swirl-text", { truncate: true, weight: "semibold" }, currentFileName), h("swirl-text", { color: "subdued", size: "sm", truncate: true }, currentFileType))), h("swirl-separator", null), h("swirl-action-list", null, h("swirl-action-list-item", { icon: "<swirl-icon-download></swirl-icon-download>", label: this.downloadButtonLabel, onClick: this.onDownloadButtonClick }), h("slot", { name: "menu-items" })))))));
+    return (h(Host, null, h("section", { "aria-hidden": "true", "aria-label": this.label, class: className, id: "lightbox", onMouseDown: this.onPointerDown, onMouseMove: this.onPointerMove, onMouseOut: this.onPointerUp, onMouseUp: this.onPointerUp, onKeyDown: this.onKeyDown, onTouchEnd: this.onPointerUp, onTouchMove: this.onPointerMove, onTouchStart: this.onPointerDown, ref: (el) => (this.modalEl = el) }, h("div", { class: "lightbox__body", role: "document" }, h("header", { class: "lightbox__header" }, h("button", { "aria-label": this.closeButtonLabel, class: "lightbox__close-button", onClick: this.onCloseButtonClick }, h("swirl-icon-close", null)), h("swirl-popover-trigger", { popover: this.menu }, h("button", { "aria-label": this.menuTriggerLabel, class: "lightbox__menu-button" }, h("swirl-icon-more-vertikal", null)))), h("div", { "aria-roledescription": "carousel", class: "lightbox__content", role: "group" }, h("div", { "aria-atomic": "false", "aria-live": "polite", class: "lightbox__slides" }, h("slot", { onSlotchange: this.registerSlides }))), h("div", { class: "lightbox__controls" }, h("button", { "aria-label": this.previousSlideButtonLabel, class: "lightbox__previous-slide-button", disabled: this.activeSlideIndex === 0, onClick: this.onPreviousSlideClick }, h("swirl-icon-arrow-left", null)), h("button", { "aria-label": this.nextSlideButtonLabel, class: "lightbox__next-slide-button", disabled: this.activeSlideIndex === this.slides.length - 1, onClick: this.onNextSlideClick }, h("swirl-icon-arrow-right", null))), showPagination && (h("span", { class: "lightbox__pagination" }, h("span", { "aria-current": "page" }, this.activeSlideIndex + 1), " /", " ", this.slides.length))), h("swirl-popover", { animation: "scale-in-y", disableScrollLock: true, id: "slide-menu", label: this.menuLabel, placement: "bottom-end", ref: (el) => (this.menu = el) }, h("swirl-stack", null, h("div", { class: "lightbox__meta" }, currentThumbnailUrl && (h("div", { class: "lightbox__thumbnail" }, h("swirl-thumbnail", { alt: "", src: currentThumbnailUrl }))), h("div", { class: "lightbox__file-info" }, h("swirl-text", { truncate: true, weight: "semibold" }, currentFileName), h("swirl-text", { color: "subdued", size: "sm", truncate: true }, currentFileType))), h("swirl-separator", null), h("swirl-action-list", null, h("swirl-action-list-item", { icon: "<swirl-icon-download></swirl-icon-download>", label: this.downloadButtonLabel, onClick: this.onDownloadButtonClick }), h("slot", { name: "menu-items" })))))));
   }
   static get is() { return "swirl-lightbox"; }
   static get encapsulation() { return "shadow"; }

package/dist/collection/components/swirl-lightbox/swirl-lightbox.spec.js

@@ -28,9 +28,11 @@ describe("swirl-lightbox", () => {
                 <button aria-label="Close" class="lightbox__close-button">
                   <swirl-icon-close></swirl-icon-close>
                 </button>
-                <button aria-label="Open slide menu" class="lightbox__menu-button" id="slide-menu-trigger">
-                  <swirl-icon-more-vertikal></swirl-icon-more-vertikal>
-                </button>
+                <swirl-popover-trigger>
+                  <button aria-label="Open slide menu" class="lightbox__menu-button">
+                    <swirl-icon-more-vertikal></swirl-icon-more-vertikal>
+                  </button>
+                </swirl-popover-trigger>
               </header>
               <div aria-roledescription="carousel" class="lightbox__content" role="group">
                 <div aria-atomic="false" aria-live="polite" class="lightbox__slides">
@@ -49,7 +51,7 @@ describe("swirl-lightbox", () => {
                 <span aria-current="page">1</span> / 2
               </span>
             </div>
-            <swirl-popover animation="scale-in-y" disablescrolllock="" label="Slide options" placement="bottom-end" popoverid="slide-menu" trigger="slide-menu-trigger">
+            <swirl-popover animation="scale-in-y" disablescrolllock="" id="slide-menu" label="Slide options" placement="bottom-end">
               <swirl-stack>
                 <div class="lightbox__meta">
                   <div class="lightbox__file-info">

package/dist/collection/components/swirl-menu/swirl-menu.spec.js

@@ -3,6 +3,7 @@ import { SwirlButton } from "../swirl-button/swirl-button";
 import { SwirlMenuItem } from "../swirl-menu-item/swirl-menu-item";
 import { SwirlPopover } from "../swirl-popover/swirl-popover";
 import { SwirlMenu } from "./swirl-menu";
+import { SwirlPopoverTrigger } from "../swirl-popover-trigger/swirl-popover-trigger";
 global.DocumentFragment = class DocumentFragment extends Node {
 };
 global.ShadowRoot = class ShadowRoot extends DocumentFragment {
@@ -14,8 +15,10 @@ global.MutationObserver = class {
 };
 const template = `
   <div>
-    <swirl-button id="trigger" label="Trigger"></swirl-button>
-    <swirl-popover label="Menu" trigger="trigger">
+    <swirl-popover-trigger popover="menu">
+      <swirl-button label="Trigger"></swirl-button>
+    </swirl-popover-trigger>
+    <swirl-popover label="Menu" id="menu">
       <swirl-menu label="Menu">
         <swirl-menu-item label="Item 1"></swirl-menu-item>
         <swirl-menu-item label="Item 2">
@@ -44,19 +47,28 @@ describe("swirl-menu", () => {
   });
   it("renders", async () => {
     const page = await newSpecPage({
-      components: [SwirlButton, SwirlPopover, SwirlMenu, SwirlMenuItem],
+      components: [
+        SwirlButton,
+        SwirlPopover,
+        SwirlPopoverTrigger,
+        SwirlMenu,
+        SwirlMenuItem,
+      ],
       html: template,
     });
     expect(page.body.children[0]).toMatchInlineSnapshot(`
       <div>
-        <swirl-button id="trigger" label="Trigger">
-          <button aria-controls="undefined" aria-expanded="false" aria-haspopup="dialog" class="button button--icon-position-start button--intent-default button--size-m button--variant-ghost" type="button">
-            <span class="button__label">
-              Trigger
-            </span>
-          </button>
-        </swirl-button>
-        <swirl-popover label="Menu" trigger="trigger">
+        <swirl-popover-trigger popover="menu">
+          <!---->
+          <swirl-button label="Trigger" swirl-aria-controls="menu" swirl-aria-expanded="false" swirl-aria-haspopup="dialog">
+            <button aria-controls="menu" aria-expanded="false" aria-haspopup="dialog" class="button button--icon-position-start button--intent-default button--size-m button--variant-ghost" type="button">
+              <span class="button__label">
+                Trigger
+              </span>
+            </button>
+          </swirl-button>
+        </swirl-popover-trigger>
+        <swirl-popover id="menu" label="Menu">
           <mock:shadow-root>
             <div class="popover popover--animation-scale-in-xy popover--inactive popover--placement-undefined">
               <div aria-hidden="true" aria-label="Menu" class="popover__content" part="popover__content" role="dialog" tabindex="-1">
@@ -169,7 +181,13 @@ describe("swirl-menu", () => {
   });
   it("starts as active if root menu", async () => {
     const page = await newSpecPage({
-      components: [SwirlButton, SwirlPopover, SwirlMenu, SwirlMenuItem],
+      components: [
+        SwirlButton,
+        SwirlPopover,
+        SwirlPopoverTrigger,
+        SwirlMenu,
+        SwirlMenuItem,
+      ],
       html: template,
     });
     const menu = page.body.querySelector("swirl-menu");
@@ -178,12 +196,18 @@ describe("swirl-menu", () => {
   });
   it("fires done event", async () => {
     const page = await newSpecPage({
-      components: [SwirlButton, SwirlPopover, SwirlMenu, SwirlMenuItem],
+      components: [
+        SwirlButton,
+        SwirlPopover,
+        SwirlPopoverTrigger,
+        SwirlMenu,
+        SwirlMenuItem,
+      ],
       html: template,
     });
     const spy = jest.fn();
     const menu = page.body.querySelector("swirl-menu");
-    const trigger = page.body.querySelector("#trigger");
+    const trigger = page.body.querySelector("swirl-popover-trigger");
     menu.addEventListener("done", spy);
     trigger.click();
     const doneButton = Array.from(menu.shadowRoot.querySelectorAll("swirl-button")).find((button) => button.innerText === "Done");

package/dist/collection/components/swirl-menu/swirl-menu.stories.js

@@ -12,45 +12,47 @@ export default {
 };
 const Template = (args) => {
   const container = document.createElement("div");
-  const trigger = document.createElement("swirl-button");
+  const trigger = document.createElement("swirl-popover-trigger");
   const popover = document.createElement("swirl-popover");
   const element = generateStoryElement("swirl-menu", args);
-  trigger.id = "trigger";
-  trigger.label = "Open menu";
+  trigger.popover = "menu-popover";
+  trigger.innerHTML = `
+    <swirl-button label="Open menu"></swirl-button>
+  `;
   popover.fullscreenBottomSheet = true;
+  popover.id = "menu-popover";
   popover.label = "Menu popover";
-  popover.popoverId = "menu-popover";
   popover.trigger = "trigger";
   element.innerHTML = `
-    <swirl-menu-item icon="<swirl-icon-copy></swirl-icon-copy>" label="Duplicate"></swirl-menu-item>
-    <swirl-menu-item icon="<swirl-icon-delete></swirl-icon-delete>" intent="critical" label="Delete"></swirl-menu-item>
-    <swirl-menu-item icon="<swirl-icon-ai></swirl-icon-ai>" label="AI features">
-      <swirl-menu label="AI features">
-        <swirl-menu-item label="Generate summary"></swirl-menu-item>
-        <swirl-menu-item label="Simplify"></swirl-menu-item>
-        <swirl-menu-item disabled label="Check spelling"></swirl-menu-item>
-      </swirl-menu>
-    </swirl-menu-item>
-    <swirl-menu-item icon="<swirl-icon-edit></swirl-icon-edit>" label="Colors">
-      <swirl-menu label="Colors menu" selection">
-        <swirl-menu-item label="Text color">
-          <swirl-menu label="Text color menu" value="blue" variant="selection">
-            <swirl-menu-item label="Red" value="red"></swirl-menu-item>
-            <swirl-menu-item label="Blue" value="blue"></swirl-menu-item>
-            <swirl-menu-item label="Green" value="green"></swirl-menu-item>
-          </swirl-menu>
-        </swirl-menu-item>
-        <swirl-menu-item label="Background color">
-          <swirl-menu label="Background color menu" variant="selection">
-            <swirl-menu-item label="Light" value="light"></swirl-menu-item>
-            <swirl-menu-item label="Dark" value="dark"></swirl-menu-item>
-          </swirl-menu>
-        </swirl-menu-item>
-      </swirl-menu>
-    </swirl-menu-item>
-  `;
-  popover.append(element);
-  container.append(trigger, popover);
+      <swirl-menu-item icon="<swirl-icon-copy></swirl-icon-copy>" label="Duplicate"></swirl-menu-item>
+      <swirl-menu-item icon="<swirl-icon-delete></swirl-icon-delete>" intent="critical" label="Delete"></swirl-menu-item>
+      <swirl-menu-item icon="<swirl-icon-ai></swirl-icon-ai>" label="AI features">
+        <swirl-menu label="AI features">
+          <swirl-menu-item label="Generate summary"></swirl-menu-item>
+          <swirl-menu-item label="Simplify"></swirl-menu-item>
+          <swirl-menu-item disabled label="Check spelling"></swirl-menu-item>
+        </swirl-menu>
+      </swirl-menu-item>
+      <swirl-menu-item icon="<swirl-icon-edit></swirl-icon-edit>" label="Colors">
+        <swirl-menu label="Colors menu" selection">
+          <swirl-menu-item label="Text color">
+            <swirl-menu label="Text color menu" value="blue" variant="selection">
+              <swirl-menu-item label="Red" value="red"></swirl-menu-item>
+              <swirl-menu-item label="Blue" value="blue"></swirl-menu-item>
+              <swirl-menu-item label="Green" value="green"></swirl-menu-item>
+            </swirl-menu>
+          </swirl-menu-item>
+          <swirl-menu-item label="Background color">
+            <swirl-menu label="Background color menu" variant="selection">
+              <swirl-menu-item label="Light" value="light"></swirl-menu-item>
+              <swirl-menu-item label="Dark" value="dark"></swirl-menu-item>
+            </swirl-menu>
+          </swirl-menu-item>
+        </swirl-menu>
+      </swirl-menu-item>
+    `;
+  popover.append("\n    ", element, "\n  ");
+  container.append("\n  ", trigger, "\n  ", popover, "\n");
   return container;
 };
 export const SwirlMenu = Template.bind({});

package/dist/collection/components/swirl-pdf-reader/swirl-pdf-reader.js

@@ -162,12 +162,12 @@ export class SwirlPdfReader {
       "pdf-reader--closing": this.closing,
       "pdf-reader--show-thumbnails": this.showThumbnails,
     });
-    return (h(Host, null, h("section", { "aria-hidden": "true", "aria-label": this.label, class: className, id: "pdf-reader", onKeyDown: this.onKeyDown, ref: (el) => (this.modalEl = el) }, h("div", { class: "pdf-reader__body", role: "document" }, h("header", { class: "pdf-reader__header" }, h("span", { class: "pdf-reader__header-left" }, h("swirl-button", { class: "pdf-reader__close-button", hideLabel: true, icon: "<swirl-icon-close></swirl-icon-close>", label: this.closeButtonLabel, onClick: this.onCloseButtonClick }), h("span", { class: "pdf-reader__label" }, this.label)), h("span", { class: "pdf-reader__header-center" }, h("span", { class: "pdf-reader__zoom-button-container" }, h("swirl-button", { class: "pdf-reader__zoom-button", disabled: this.zoom === this.zoomSteps[0], hideLabel: true, icon: "<swirl-icon-remove></swirl-icon-remove>", label: this.zoomOutButtonLabel, onClick: this.onZoomOutButtonClick }), h("swirl-button", { class: "pdf-reader__zoom-button", disabled: this.zoom === this.zoomSteps[this.zoomSteps.length - 1], hideLabel: true, icon: "<swirl-icon-add></swirl-icon-add>", label: this.zoomInButtonLabel, onClick: this.onZoomInButtonClick })), h("span", { class: "pdf-reader__zoom-select-container" }, h("select", { "aria-label": this.zoomSelectLabel, class: "pdf-reader__zoom-select", name: "zoom-select", id: "zoom-select", onChange: this.onZoomChange }, h("option", { selected: this.zoom === "auto", value: "auto" }, this.autoZoomLabel), this.zoomSteps.map((zoom) => (h("option", { key: zoom, selected: this.zoom === zoom, value: zoom }, zoom * 100, "%")))), h("swirl-icon-expand-more", { class: "pdf-reader__zoom-select-icon" }))), h("span", { class: "pdf-reader__header-right" }, h("swirl-button", { class: "pdf-reader__menu-button", hideLabel: true, icon: "<swirl-icon-more-vertikal></swirl-icon-more-vertikal>", id: "menu-trigger", label: this.menuTriggerLabel })), h("span", { class: "pdf-reader__floating-tools" }, h("button", { "aria-label": this.sideBySideButtonLabel, class: "pdf-reader__floating-tool-button", onClick: this.toggleViewMode, type: "button" }, h("swirl-icon-menu-book", null)), h("button", { "aria-controls": "thumbnails", "aria-expanded": String(Boolean(this.showThumbnails)), "aria-label": this.thumbnailsButtonLabel, class: "pdf-reader__floating-tool-button", onClick: this.toggleThumbnals, type: "button" }, h("swirl-icon-file-copy", null)))), h("div", { class: "pdf-reader__content" }, h("nav", { "aria-label": this.thumbnailsLabel, class: "pdf-reader__thumbnails", id: "thumbnails" }, this.thumbnails.map((thumbnail, index) => {
+    return (h(Host, null, h("section", { "aria-hidden": "true", "aria-label": this.label, class: className, id: "pdf-reader", onKeyDown: this.onKeyDown, ref: (el) => (this.modalEl = el) }, h("div", { class: "pdf-reader__body", role: "document" }, h("header", { class: "pdf-reader__header" }, h("span", { class: "pdf-reader__header-left" }, h("swirl-button", { class: "pdf-reader__close-button", hideLabel: true, icon: "<swirl-icon-close></swirl-icon-close>", label: this.closeButtonLabel, onClick: this.onCloseButtonClick }), h("span", { class: "pdf-reader__label" }, this.label)), h("span", { class: "pdf-reader__header-center" }, h("span", { class: "pdf-reader__zoom-button-container" }, h("swirl-button", { class: "pdf-reader__zoom-button", disabled: this.zoom === this.zoomSteps[0], hideLabel: true, icon: "<swirl-icon-remove></swirl-icon-remove>", label: this.zoomOutButtonLabel, onClick: this.onZoomOutButtonClick }), h("swirl-button", { class: "pdf-reader__zoom-button", disabled: this.zoom === this.zoomSteps[this.zoomSteps.length - 1], hideLabel: true, icon: "<swirl-icon-add></swirl-icon-add>", label: this.zoomInButtonLabel, onClick: this.onZoomInButtonClick })), h("span", { class: "pdf-reader__zoom-select-container" }, h("select", { "aria-label": this.zoomSelectLabel, class: "pdf-reader__zoom-select", name: "zoom-select", id: "zoom-select", onChange: this.onZoomChange }, h("option", { selected: this.zoom === "auto", value: "auto" }, this.autoZoomLabel), this.zoomSteps.map((zoom) => (h("option", { key: zoom, selected: this.zoom === zoom, value: zoom }, zoom * 100, "%")))), h("swirl-icon-expand-more", { class: "pdf-reader__zoom-select-icon" }))), h("span", { class: "pdf-reader__header-right" }, h("swirl-popover-trigger", { popover: this.menu }, h("swirl-button", { class: "pdf-reader__menu-button", hideLabel: true, icon: "<swirl-icon-more-vertikal></swirl-icon-more-vertikal>", label: this.menuTriggerLabel }))), h("span", { class: "pdf-reader__floating-tools" }, h("button", { "aria-label": this.sideBySideButtonLabel, class: "pdf-reader__floating-tool-button", onClick: this.toggleViewMode, type: "button" }, h("swirl-icon-menu-book", null)), h("button", { "aria-controls": "thumbnails", "aria-expanded": String(Boolean(this.showThumbnails)), "aria-label": this.thumbnailsButtonLabel, class: "pdf-reader__floating-tool-button", onClick: this.toggleThumbnals, type: "button" }, h("swirl-icon-file-copy", null)))), h("div", { class: "pdf-reader__content" }, h("nav", { "aria-label": this.thumbnailsLabel, class: "pdf-reader__thumbnails", id: "thumbnails" }, this.thumbnails.map((thumbnail, index) => {
       const thumbnailClassName = classnames("pdf-reader__thumbnail", {
         "pdf-reader__thumbnail--active": this.visiblePages[0] === index + 1,
       });
       return (h("button", { "aria-label": `${this.thumbnailButtonLabel} ${index + 1}`, class: thumbnailClassName, onClick: this.onThumbnailClick(index), type: "button" }, h("img", { src: thumbnail.toDataURL("image/png"), alt: "" })));
-    })), h("swirl-file-viewer", { active: this.active, class: "pdf-reader__viewer", file: this.file, onActivate: this.onActivate, onVisiblePagesChange: this.onVisiblePagesChange, ref: (el) => (this.viewer = el), type: "application/pdf", viewMode: this.viewMode, zoom: this.zoom }), h("div", { class: "pdf-reader__mobile-zoom-controls" }, h("button", { "aria-label": this.autoZoomLabel, class: "pdf-reader__mobile-zoom-button", onClick: this.onZoomAutoButtonClick, type: "button" }, this.zoom === "auto" ? (h("swirl-icon-fullscreen-exit", null)) : (h("swirl-icon-fullscreen", null))), h("button", { "aria-label": this.zoomInButtonLabel, class: "pdf-reader__mobile-zoom-button", disabled: this.zoom === this.zoomSteps[this.zoomSteps.length - 1], onClick: this.onZoomInButtonClick, type: "button" }, h("swirl-icon-add", null)), h("button", { "aria-label": this.zoomOutButtonLabel, class: "pdf-reader__mobile-zoom-button", disabled: this.zoom === this.zoomSteps[0], onClick: this.onZoomOutButtonClick, type: "button" }, h("swirl-icon-remove", null))))), h("swirl-popover", { animation: "scale-in-y", disableScrollLock: true, label: this.menuLabel, placement: "bottom-end", popoverId: "menu", ref: (el) => (this.menu = el), trigger: "menu-trigger" }, h("swirl-stack", null, h("div", { class: "pdf-reader__meta" }, h("div", { class: "pdf-reader__file-icon" }, h("svg", { fill: "none", height: "36", viewBox: "0 0 24 36", width: "24" }, h("path", { d: "M7.01755 21.6V15.192H8.39455C8.64655 15.192 8.86855 15.225 9.06055 15.291C9.25255 15.357 9.42655 15.474 9.58255 15.642C9.73855 15.81 9.84655 16.008 9.90655 16.236C9.96655 16.458 9.99655 16.761 9.99655 17.145C9.99655 17.433 9.97855 17.676 9.94255 17.874C9.91255 18.072 9.84355 18.258 9.73555 18.432C9.60955 18.642 9.44155 18.807 9.23155 18.927C9.02155 19.041 8.74555 19.098 8.40355 19.098H7.93555V21.6H7.01755ZM7.93555 16.056V18.234H8.37655C8.56255 18.234 8.70655 18.207 8.80855 18.153C8.91055 18.099 8.98555 18.024 9.03355 17.928C9.08155 17.838 9.10855 17.727 9.11455 17.595C9.12655 17.463 9.13255 17.316 9.13255 17.154C9.13255 17.004 9.12955 16.863 9.12355 16.731C9.11755 16.593 9.09055 16.473 9.04255 16.371C8.99455 16.269 8.92255 16.191 8.82655 16.137C8.73055 16.083 8.59255 16.056 8.41255 16.056H7.93555Z", fill: "white" }), h("path", { d: "M10.6826 21.6V15.192H12.0416C12.5696 15.192 12.9686 15.336 13.2386 15.624C13.5146 15.912 13.6526 16.32 13.6526 16.848V19.845C13.6526 20.445 13.5056 20.889 13.2116 21.177C12.9236 21.459 12.5066 21.6 11.9606 21.6H10.6826ZM11.6006 16.056V20.736H12.0236C12.2816 20.736 12.4646 20.673 12.5726 20.547C12.6806 20.415 12.7346 20.211 12.7346 19.935V16.848C12.7346 16.596 12.6836 16.401 12.5816 16.263C12.4796 16.125 12.2936 16.056 12.0236 16.056H11.6006Z", fill: "white" }), h("path", { d: "M14.5146 21.6V15.192H17.2506V16.056H15.4326V18H17.0166V18.864H15.4326V21.6H14.5146Z", fill: "white" }), h("path", { d: "M3.59961 9.00001C3.59961 8.0059 4.4055 7.20001 5.39961 7.20001H14.854C15.3314 7.20001 15.7893 7.38965 16.1268 7.72722L19.8724 11.4728C20.21 11.8104 20.3996 12.2682 20.3996 12.7456V27C20.3996 27.9941 19.5937 28.8 18.5996 28.8H5.39961C4.4055 28.8 3.59961 27.9941 3.59961 27V9.00001Z", fill: "#FF574D" }), h("path", { d: "M15.5996 7.36166V10.2C15.5996 11.1941 16.4055 12 17.3996 12H20.2379C20.3237 12.1884 20.3768 12.3913 20.3937 12.6H17.3996C16.0785 12.6 15.0067 11.5325 14.9996 10.213L14.9996 7.20587C15.2083 7.2228 15.4112 7.27593 15.5996 7.36166Z", fill: "white" }), h("path", { d: "M7.01755 21.6V15.192H8.39455C8.64655 15.192 8.86855 15.225 9.06055 15.291C9.25255 15.357 9.42655 15.474 9.58255 15.642C9.73855 15.81 9.84655 16.008 9.90655 16.236C9.96655 16.458 9.99655 16.761 9.99655 17.145C9.99655 17.433 9.97855 17.676 9.94255 17.874C9.91255 18.072 9.84355 18.258 9.73555 18.432C9.60955 18.642 9.44155 18.807 9.23155 18.927C9.02155 19.041 8.74555 19.098 8.40355 19.098H7.93555V21.6H7.01755ZM7.93555 16.056V18.234H8.37655C8.56255 18.234 8.70655 18.207 8.80855 18.153C8.91055 18.099 8.98555 18.024 9.03355 17.928C9.08155 17.838 9.10855 17.727 9.11455 17.595C9.12655 17.463 9.13255 17.316 9.13255 17.154C9.13255 17.004 9.12955 16.863 9.12355 16.731C9.11755 16.593 9.09055 16.473 9.04255 16.371C8.99455 16.269 8.92255 16.191 8.82655 16.137C8.73055 16.083 8.59255 16.056 8.41255 16.056H7.93555Z", fill: "white" }), h("path", { d: "M10.6826 21.6V15.192H12.0416C12.5696 15.192 12.9686 15.336 13.2386 15.624C13.5146 15.912 13.6526 16.32 13.6526 16.848V19.845C13.6526 20.445 13.5056 20.889 13.2116 21.177C12.9236 21.459 12.5066 21.6 11.9606 21.6H10.6826ZM11.6006 16.056V20.736H12.0236C12.2816 20.736 12.4646 20.673 12.5726 20.547C12.6806 20.415 12.7346 20.211 12.7346 19.935V16.848C12.7346 16.596 12.6836 16.401 12.5816 16.263C12.4796 16.125 12.2936 16.056 12.0236 16.056H11.6006Z", fill: "white" }), h("path", { d: "M14.5146 21.6V15.192H17.2506V16.056H15.4326V18H17.0166V18.864H15.4326V21.6H14.5146Z", fill: "white" }))), h("div", { class: "pdf-reader__file-info" }, h("swirl-text", { truncate: true, weight: "semibold" }, this.label), h("swirl-text", { color: "subdued", size: "sm", truncate: true }, this.fileTypeLabel))), h("swirl-separator", null), h("swirl-action-list", null, h("swirl-action-list-item", { class: "pdf-reader__print-button", icon: "<swirl-icon-print></swirl-icon-print>", label: this.printButtonLabel, onClick: this.onPrintButtonClick }), h("swirl-action-list-item", { class: "pdf-reader__download-button", disabled: this.downloading, icon: !this.downloading
+    })), h("swirl-file-viewer", { active: this.active, class: "pdf-reader__viewer", file: this.file, onActivate: this.onActivate, onVisiblePagesChange: this.onVisiblePagesChange, ref: (el) => (this.viewer = el), type: "application/pdf", viewMode: this.viewMode, zoom: this.zoom }), h("div", { class: "pdf-reader__mobile-zoom-controls" }, h("button", { "aria-label": this.autoZoomLabel, class: "pdf-reader__mobile-zoom-button", onClick: this.onZoomAutoButtonClick, type: "button" }, this.zoom === "auto" ? (h("swirl-icon-fullscreen-exit", null)) : (h("swirl-icon-fullscreen", null))), h("button", { "aria-label": this.zoomInButtonLabel, class: "pdf-reader__mobile-zoom-button", disabled: this.zoom === this.zoomSteps[this.zoomSteps.length - 1], onClick: this.onZoomInButtonClick, type: "button" }, h("swirl-icon-add", null)), h("button", { "aria-label": this.zoomOutButtonLabel, class: "pdf-reader__mobile-zoom-button", disabled: this.zoom === this.zoomSteps[0], onClick: this.onZoomOutButtonClick, type: "button" }, h("swirl-icon-remove", null))))), h("swirl-popover", { animation: "scale-in-y", disableScrollLock: true, id: "menu", label: this.menuLabel, placement: "bottom-end", ref: (el) => (this.menu = el) }, h("swirl-stack", null, h("div", { class: "pdf-reader__meta" }, h("div", { class: "pdf-reader__file-icon" }, h("svg", { fill: "none", height: "36", viewBox: "0 0 24 36", width: "24" }, h("path", { d: "M7.01755 21.6V15.192H8.39455C8.64655 15.192 8.86855 15.225 9.06055 15.291C9.25255 15.357 9.42655 15.474 9.58255 15.642C9.73855 15.81 9.84655 16.008 9.90655 16.236C9.96655 16.458 9.99655 16.761 9.99655 17.145C9.99655 17.433 9.97855 17.676 9.94255 17.874C9.91255 18.072 9.84355 18.258 9.73555 18.432C9.60955 18.642 9.44155 18.807 9.23155 18.927C9.02155 19.041 8.74555 19.098 8.40355 19.098H7.93555V21.6H7.01755ZM7.93555 16.056V18.234H8.37655C8.56255 18.234 8.70655 18.207 8.80855 18.153C8.91055 18.099 8.98555 18.024 9.03355 17.928C9.08155 17.838 9.10855 17.727 9.11455 17.595C9.12655 17.463 9.13255 17.316 9.13255 17.154C9.13255 17.004 9.12955 16.863 9.12355 16.731C9.11755 16.593 9.09055 16.473 9.04255 16.371C8.99455 16.269 8.92255 16.191 8.82655 16.137C8.73055 16.083 8.59255 16.056 8.41255 16.056H7.93555Z", fill: "white" }), h("path", { d: "M10.6826 21.6V15.192H12.0416C12.5696 15.192 12.9686 15.336 13.2386 15.624C13.5146 15.912 13.6526 16.32 13.6526 16.848V19.845C13.6526 20.445 13.5056 20.889 13.2116 21.177C12.9236 21.459 12.5066 21.6 11.9606 21.6H10.6826ZM11.6006 16.056V20.736H12.0236C12.2816 20.736 12.4646 20.673 12.5726 20.547C12.6806 20.415 12.7346 20.211 12.7346 19.935V16.848C12.7346 16.596 12.6836 16.401 12.5816 16.263C12.4796 16.125 12.2936 16.056 12.0236 16.056H11.6006Z", fill: "white" }), h("path", { d: "M14.5146 21.6V15.192H17.2506V16.056H15.4326V18H17.0166V18.864H15.4326V21.6H14.5146Z", fill: "white" }), h("path", { d: "M3.59961 9.00001C3.59961 8.0059 4.4055 7.20001 5.39961 7.20001H14.854C15.3314 7.20001 15.7893 7.38965 16.1268 7.72722L19.8724 11.4728C20.21 11.8104 20.3996 12.2682 20.3996 12.7456V27C20.3996 27.9941 19.5937 28.8 18.5996 28.8H5.39961C4.4055 28.8 3.59961 27.9941 3.59961 27V9.00001Z", fill: "#FF574D" }), h("path", { d: "M15.5996 7.36166V10.2C15.5996 11.1941 16.4055 12 17.3996 12H20.2379C20.3237 12.1884 20.3768 12.3913 20.3937 12.6H17.3996C16.0785 12.6 15.0067 11.5325 14.9996 10.213L14.9996 7.20587C15.2083 7.2228 15.4112 7.27593 15.5996 7.36166Z", fill: "white" }), h("path", { d: "M7.01755 21.6V15.192H8.39455C8.64655 15.192 8.86855 15.225 9.06055 15.291C9.25255 15.357 9.42655 15.474 9.58255 15.642C9.73855 15.81 9.84655 16.008 9.90655 16.236C9.96655 16.458 9.99655 16.761 9.99655 17.145C9.99655 17.433 9.97855 17.676 9.94255 17.874C9.91255 18.072 9.84355 18.258 9.73555 18.432C9.60955 18.642 9.44155 18.807 9.23155 18.927C9.02155 19.041 8.74555 19.098 8.40355 19.098H7.93555V21.6H7.01755ZM7.93555 16.056V18.234H8.37655C8.56255 18.234 8.70655 18.207 8.80855 18.153C8.91055 18.099 8.98555 18.024 9.03355 17.928C9.08155 17.838 9.10855 17.727 9.11455 17.595C9.12655 17.463 9.13255 17.316 9.13255 17.154C9.13255 17.004 9.12955 16.863 9.12355 16.731C9.11755 16.593 9.09055 16.473 9.04255 16.371C8.99455 16.269 8.92255 16.191 8.82655 16.137C8.73055 16.083 8.59255 16.056 8.41255 16.056H7.93555Z", fill: "white" }), h("path", { d: "M10.6826 21.6V15.192H12.0416C12.5696 15.192 12.9686 15.336 13.2386 15.624C13.5146 15.912 13.6526 16.32 13.6526 16.848V19.845C13.6526 20.445 13.5056 20.889 13.2116 21.177C12.9236 21.459 12.5066 21.6 11.9606 21.6H10.6826ZM11.6006 16.056V20.736H12.0236C12.2816 20.736 12.4646 20.673 12.5726 20.547C12.6806 20.415 12.7346 20.211 12.7346 19.935V16.848C12.7346 16.596 12.6836 16.401 12.5816 16.263C12.4796 16.125 12.2936 16.056 12.0236 16.056H11.6006Z", fill: "white" }), h("path", { d: "M14.5146 21.6V15.192H17.2506V16.056H15.4326V18H17.0166V18.864H15.4326V21.6H14.5146Z", fill: "white" }))), h("div", { class: "pdf-reader__file-info" }, h("swirl-text", { truncate: true, weight: "semibold" }, this.label), h("swirl-text", { color: "subdued", size: "sm", truncate: true }, this.fileTypeLabel))), h("swirl-separator", null), h("swirl-action-list", null, h("swirl-action-list-item", { class: "pdf-reader__print-button", icon: "<swirl-icon-print></swirl-icon-print>", label: this.printButtonLabel, onClick: this.onPrintButtonClick }), h("swirl-action-list-item", { class: "pdf-reader__download-button", disabled: this.downloading, icon: !this.downloading
         ? "<swirl-icon-download></swirl-icon-download>"
         : '<swirl-spinner size="xs"></swirl-spinner>', label: this.downloadButtonLabel, onClick: this.onDownloadButtonClick }), h("slot", { name: "menu-items" })))))));
   }

package/dist/collection/components/swirl-pdf-reader/swirl-pdf-reader.spec.js

@@ -48,7 +48,9 @@ describe("swirl-pdf-reader", () => {
                   </span>
                 </span>
                 <span class="pdf-reader__header-right">
-                  <swirl-button class="pdf-reader__menu-button" hidelabel="" icon="<swirl-icon-more-vertikal></swirl-icon-more-vertikal>" id="menu-trigger" label="Open file menu"></swirl-button>
+                  <swirl-popover-trigger>
+                    <swirl-button class="pdf-reader__menu-button" hidelabel="" icon="<swirl-icon-more-vertikal></swirl-icon-more-vertikal>" label="Open file menu"></swirl-button>
+                  </swirl-popover-trigger>
                 </span>
                 <span class="pdf-reader__floating-tools">
                   <button aria-label="Toggle side by side view" class="pdf-reader__floating-tool-button" type="button">
@@ -75,7 +77,7 @@ describe("swirl-pdf-reader", () => {
                 </div>
               </div>
             </div>
-            <swirl-popover animation="scale-in-y" disablescrolllock="" label="File menu" placement="bottom-end" popoverid="menu" trigger="menu-trigger">
+            <swirl-popover animation="scale-in-y" disablescrolllock="" id="menu" label="File menu" placement="bottom-end">
               <swirl-stack>
                 <div class="pdf-reader__meta">
                   <div class="pdf-reader__file-icon">

package/dist/collection/components/swirl-popover/swirl-popover.js

@@ -54,8 +54,8 @@ export class SwirlPopover {
     this.label = undefined;
     this.maxHeight = "22rem";
     this.offset = 8;
-    this.placement = "bottom-start";
     this.popoverId = undefined;
+    this.placement = "bottom-start";
     this.trigger = undefined;
     this.triggerContainer = undefined;
     this.useContainerWidth = undefined;
@@ -65,13 +65,16 @@ export class SwirlPopover {
   }
   componentDidLoad() {
     this.connectTrigger();
-    this.updateFocusableChildren();
     this.updateTriggerAttributes();
+    if (Boolean(this.trigger)) {
+      console.warn('[Swirl] The "trigger" prop of swirl-popover is deprecated and will be removed with the next major release. Please use the swirl-popover-trigger component instead. https://swirl-storybook.flip-app.dev/?path=/docs/components-swirlpopovertrigger--docs');
+    }
   }
   disconnectedCallback() {
     this.unlockBodyScroll();
   }
   onWindowFocusIn(event) {
+    var _a;
     if (!this.active) {
       return;
     }
@@ -82,7 +85,7 @@ export class SwirlPopover {
     const popoverLostFocus = !this.el.contains(target) &&
       !this.el.contains(activeElement) &&
       target !== this.triggerEl &&
-      !this.triggerEl.contains(target) &&
+      !((_a = this.triggerEl) === null || _a === void 0 ? void 0 : _a.contains(target)) &&
       (!isSafari ||
         (isSafari &&
           !this.el.contains(relatedTarget || target) &&
@@ -102,7 +105,7 @@ export class SwirlPopover {
       .some((el) => Boolean(el) && el instanceof Node
       ? this.el.contains(el)
       : false);
-    const clickedTrigger = event.target === this.triggerEl;
+    const clickedTrigger = target === this.triggerEl;
     if (!clickedChild && !clickedShadowChild && !clickedTrigger) {
       this.close();
     }
@@ -133,19 +136,20 @@ export class SwirlPopover {
    * Open the popover.
    * @returns
    */
-  async open() {
-    if (this.active) {
+  async open(triggerEl) {
+    this.triggerEl = triggerEl || this.triggerEl;
+    if (this.active || !Boolean(this.triggerEl)) {
       return;
     }
     this.adjustWidth();
     this.active = true;
-    this.updateFocusableChildren();
     this.updateTriggerAttributes();
+    const focusableChildren = this.getFocusableChildren();
     requestAnimationFrame(async () => {
       await this.reposition();
       this.popoverOpen.emit({ position: this.position });
-      if (this.focusableChildren.length > 0) {
-        this.focusableChildren[0].focus();
+      if (focusableChildren.length > 0) {
+        focusableChildren[0].focus();
       }
       else {
         this.contentContainer.focus();
@@ -153,12 +157,16 @@ export class SwirlPopover {
       if (this.disableAutoUpdate) {
         this.disableAutoUpdate();
       }
-      this.disableAutoUpdate = autoUpdate(this.triggerEl, this.contentContainer, this.reposition);
+      this.disableAutoUpdate = autoUpdate(this.triggerEl, this.contentContainer, () => this.reposition());
       this.scrollContainer.scrollTop = 0;
       this.lockBodyScroll();
     });
   }
   connectTrigger() {
+    if (!Boolean(this.trigger)) {
+      this.triggerEl = undefined;
+      return;
+    }
     this.triggerEl =
       typeof this.trigger === "string"
         ? querySelectorAllDeep(this.triggerContainer || document.body, `#${this.trigger}`)[0]
@@ -171,10 +179,10 @@ export class SwirlPopover {
     });
   }
   getNativeTriggerElement() {
-    var _a, _b, _c;
-    return this.triggerEl.tagName.startsWith("SWIRL-")
-      ? (((_a = this.triggerEl) === null || _a === void 0 ? void 0 : _a.children[0]) ||
-        ((_c = (_b = this.triggerEl) === null || _b === void 0 ? void 0 : _b.shadowRoot) === null || _c === void 0 ? void 0 : _c.children[0]) ||
+    var _a, _b, _c, _d;
+    return ((_a = this.triggerEl) === null || _a === void 0 ? void 0 : _a.tagName.startsWith("SWIRL-"))
+      ? (((_b = this.triggerEl) === null || _b === void 0 ? void 0 : _b.children[0]) ||
+        ((_d = (_c = this.triggerEl) === null || _c === void 0 ? void 0 : _c.shadowRoot) === null || _d === void 0 ? void 0 : _d.children[0]) ||
         this.triggerEl)
       : this.triggerEl;
   }
@@ -183,12 +191,12 @@ export class SwirlPopover {
       return;
     }
     const nativeTriggerEl = this.getNativeTriggerElement();
-    nativeTriggerEl.setAttribute("aria-controls", this.popoverId);
+    nativeTriggerEl.setAttribute("aria-controls", this.el.id);
     nativeTriggerEl.setAttribute("aria-expanded", String(this.active));
     nativeTriggerEl.setAttribute("aria-haspopup", "dialog");
   }
-  updateFocusableChildren() {
-    this.focusableChildren = querySelectorAllDeep(this.el, '[role="menuitem"], [role="listbox"]');
+  getFocusableChildren() {
+    return querySelectorAllDeep(this.el, '[role="menuitem"], [role="listbox"]');
   }
   adjustWidth() {
     let useContainerWidth = this.useContainerWidth;
@@ -235,7 +243,7 @@ export class SwirlPopover {
       "popover--fullscreen-bottom-sheet": this.fullscreenBottomSheet,
       "popover--inactive": !this.active,
     });
-    return (h(Host, { id: this.popoverId }, h("div", { class: className, onKeyDown: this.onKeydown }, h("div", { "aria-hidden": !this.active ? "true" : "false", "aria-label": this.label, class: "popover__content", part: "popover__content", role: "dialog", ref: (el) => (this.contentContainer = el), style: {
+    return (h(Host, null, h("div", { class: className, onKeyDown: this.onKeydown }, h("div", { "aria-hidden": !this.active ? "true" : "false", "aria-label": this.label, class: "popover__content", id: this.popoverId, part: "popover__content", role: "dialog", ref: (el) => (this.contentContainer = el), style: {
         top: Boolean(this.position) ? `${(_b = this.position) === null || _b === void 0 ? void 0 : _b.y}px` : "",
         left: Boolean(this.position) ? `${(_c = this.position) === null || _c === void 0 ? void 0 : _c.x}px` : "",
       }, tabindex: "-1" }, h("span", { class: "popover__handle" }), h("div", { class: "popover__scroll-container", ref: (el) => (this.scrollContainer = el), style: {
@@ -386,6 +394,23 @@ export class SwirlPopover {
         "reflect": false,
         "defaultValue": "8"
       },
+      "popoverId": {
+        "type": "string",
+        "mutable": false,
+        "complexType": {
+          "original": "string",
+          "resolved": "string",
+          "references": {}
+        },
+        "required": false,
+        "optional": true,
+        "docs": {
+          "tags": [],
+          "text": ""
+        },
+        "attribute": "popover-id",
+        "reflect": false
+      },
       "placement": {
         "type": "string",
         "mutable": false,
@@ -409,23 +434,6 @@ export class SwirlPopover {
         "reflect": false,
         "defaultValue": "\"bottom-start\""
       },
-      "popoverId": {
-        "type": "string",
-        "mutable": false,
-        "complexType": {
-          "original": "string",
-          "resolved": "string",
-          "references": {}
-        },
-        "required": true,
-        "optional": false,
-        "docs": {
-          "tags": [],
-          "text": ""
-        },
-        "attribute": "popover-id",
-        "reflect": false
-      },
       "trigger": {
         "type": "string",
         "mutable": false,
@@ -438,8 +446,8 @@ export class SwirlPopover {
             }
           }
         },
-        "required": true,
-        "optional": false,
+        "required": false,
+        "optional": true,
         "docs": {
           "tags": [],
           "text": ""
@@ -553,11 +561,17 @@ export class SwirlPopover {
       },
       "open": {
         "complexType": {
-          "signature": "() => Promise<void>",
-          "parameters": [],
+          "signature": "(triggerEl?: HTMLElement) => Promise<void>",
+          "parameters": [{
+              "tags": [],
+              "text": ""
+            }],
           "references": {
             "Promise": {
               "location": "global"
+            },
+            "HTMLElement": {
+              "location": "global"
             }
           },
           "return": "Promise<void>"