@geraldmaron/construct 1.0.23 → 1.0.24

package/README.md

@@ -269,7 +269,6 @@ construct/
 ├── commands         Command prompt assets
 ├── config
 ├── dashboard
-├── db
 ├── deploy
 ├── docs             Architecture notes, runbooks, and documentation contract
 ├── examples
@@ -282,7 +281,6 @@ construct/
 ├── rules            Coding and quality standards
 ├── schemas
 ├── scripts
-├── services
 ├── skills           Reusable domain knowledge files
 ├── specialists
 ├── templates

package/bin/construct

@@ -67,9 +67,7 @@ import { readCostLog, summarizeCostData, formatCostReport, clearCostLog } from '
 import { readEfficiencyLog, summarizeEfficiencyData, formatEfficiencyReport } from '../lib/efficiency.mjs';
 import { resolveColors } from '../lib/term-format.mjs';
 import { buildHybridSearchResultsAsync } from '../lib/storage/hybrid-query.mjs';
-import { createSqlClient, closeSqlClient, readVectorConfig } from '../lib/storage/backend.mjs';
-import { describeVectorStore } from '../lib/storage/vector-store.mjs';
-import { describeSqlStore } from '../lib/storage/sql-store.mjs';
+import { createSqlClient, closeSqlClient } from '../lib/storage/backend.mjs';
 import { syncFileStateToSql } from '../lib/storage/sync.mjs';
 import { deleteIngestedArtifacts, getStorageStatus, inferProjectName, resetStorage } from '../lib/storage/admin.mjs';
 import { runPressureRelease } from '../lib/runtime-pressure.mjs';
@@ -822,35 +820,10 @@ async function cmdDoctor() {
     const researchLintResults = lintResearchRepo({ rootDir: process.cwd() });
     add('Research artifacts meet minimum evidence structure', researchLintResults.every((entry) => entry.errors.length === 0), true);
 
-    const sqlConfig = describeSqlStore(process.env);
-    const sqlClient = createSqlClient(process.env);
-    // Track SQL reachability so the schema-migration check can cascade correctly
-    // rather than emitting a redundant second warning for the same offline server.
-    let sqlReachable = false;
-    if (sqlConfig.configured && sqlClient) {
-      try {
-        await sqlClient`select 1 as ok`;
-        sqlReachable = true;
-        add('SQL backend reachable', true);
-      } catch {
-        // In solo mode the local vector index is the active storage path, so an
-        // unreachable Postgres is expected unless the user has started it. Emit a
-        // contextual message rather than a bare ⚠ so the fix is obvious.
-        const { getDeploymentMode } = await import('../lib/deployment-mode.mjs');
-        const mode = getDeploymentMode(process.env) ?? 'solo';
-        const hint = mode === 'solo'
-          ? ' (solo mode — run `construct dev` to start Postgres)'
-          : ' — check DATABASE_URL and that the server is running';
-        add(`SQL backend unreachable${hint}`, false, true);
-      } finally {
-        await closeSqlClient(sqlClient);
-      }
-    } else {
-      add('SQL backend configured', sqlConfig.fallbackAvailable, true);
-    }
-
-    const vectorConfig = describeVectorStore(process.env);
-    add('Vector backend configured', Boolean(vectorConfig.endpoint || vectorConfig.indexPath || vectorConfig.mode === 'file'));
+    const { VectorClient } = await import('../lib/storage/vector-client.mjs');
+    const vectorClient = new VectorClient({ env: process.env });
+    const vectorOk = await vectorClient.isHealthy();
+    add('Vector backend (LanceDB) reachable', vectorOk);
 
     const { regenerateDocs } = await import('../lib/auto-docs.mjs');
     const { changed: stale } = await regenerateDocs({ rootDir: ROOT_DIR, check: true });
@@ -979,35 +952,6 @@ async function cmdDoctor() {
       add('Observation size', false, true);
     }
 
-    // Only run the schema migration check when SQL is both configured AND
-    // currently reachable. If the SQL check above already failed (sqlReachable
-    // is false) this check will also fail with the same ECONNREFUSED and would
-    // produce a redundant second warning about the same offline server.
-    if (sqlConfig.configured && sqlReachable) {
-      try {
-        const migClient = createSqlClient(process.env);
-        if (migClient) {
-          const { describeMigrations } = await import('../lib/storage/migrations.mjs');
-          const m = await describeMigrations(migClient);
-          await closeSqlClient(migClient);
-          const ok = !!m.ok && m.drift.length === 0;
-          let label = 'Schema migrations applied + no drift';
-          if (!ok && m.drift && m.drift.length > 0) {
-            const repairable = m.drift.filter((d) => d.idempotent).length;
-            const notRepairable = m.drift.length - repairable;
-            if (notRepairable === 0) {
-              label = `Schema migrations: ${m.drift.length} drifted (all idempotent — run \`construct storage repair-migrations --yes\`)`;
-            } else {
-              label = `Schema migrations: ${m.drift.length} drifted (${notRepairable} non-idempotent — write a new migration file)`;
-            }
-          }
-          add(label, ok, true);
-        }
-      } catch {
-        add('Schema migrations applied + no drift', false, true);
-      }
-    }
-
     try {
       const { detectBeadsDrift } = await import('../lib/beads/drift.mjs');
       const drift = detectBeadsDrift();
@@ -1037,24 +981,6 @@ async function cmdDoctor() {
       add('cm available', false, true);
     }
 
-    try {
-      const dockerCli = spawnSync(process.platform === 'win32' ? 'where' : 'which', ['docker'], { stdio: 'pipe' });
-      let dockerOk = false;
-      let dockerNote = 'Docker not installed (optional — managed Postgres needs it)';
-      if (dockerCli.status === 0) {
-        const dockerInfo = spawnSync('docker', ['info'], { stdio: 'pipe' });
-        if (dockerInfo.status === 0) {
-          dockerOk = true;
-          dockerNote = 'Docker daemon reachable';
-        } else {
-          dockerNote = 'Docker CLI installed but daemon not reachable — run `construct up` on macOS to auto-start, or start Docker manually';
-        }
-      }
-      add(dockerOk ? 'Docker daemon reachable' : `Docker daemon reachable (${dockerNote})`, dockerOk, true);
-    } catch {
-      add('Docker daemon reachable', false, true);
-    }
-
     try {
       const failuresPath = path.join(HOME, '.cx', 'hook-failures.jsonl');
       if (fs.existsSync(failuresPath)) {
@@ -1569,49 +1495,11 @@ async function cmdStorage(args) {
     println(`Reconciled observations: re-embedded ${result.reembedded} of ${result.checked} (model ${result.model}).`);
     return;
   }
-  if (action === 'migrations') {
-    const { describeMigrations } = await import('../lib/storage/migrations.mjs');
-    const sqlClient = createSqlClient(process.env);
-    if (!sqlClient) { errorln('No DATABASE_URL configured.'); process.exit(1); }
-    try {
-      const report = await describeMigrations(sqlClient);
-      println(JSON.stringify(report, null, 2));
-      if (report.drift?.length > 0) process.exit(2);
-    } finally {
-      await closeSqlClient(sqlClient);
-    }
-    return;
-  }
-  if (action === 'repair-migrations') {
-    const confirm = rest.includes('--yes');
-    if (!confirm) {
-      errorln('This re-applies drifted migrations (idempotent only) and updates their recorded SHA.');
-      errorln('Destructive migrations (DROP / TRUNCATE / ALTER…DROP / DELETE) are refused.');
-      errorln('Re-run with --yes to proceed.');
-      process.exit(1);
-    }
-    const { runMigrations } = await import('../lib/storage/migrations.mjs');
-    const sqlClient = createSqlClient(process.env);
-    if (!sqlClient) { errorln('No DATABASE_URL configured.'); process.exit(1); }
-    try {
-      const result = await runMigrations(sqlClient, { repair: true });
-      println(JSON.stringify({
-        applied: result.applied,
-        repaired: result.repaired,
-        skipped: result.skipped,
-        drift: result.drift,
-      }, null, 2));
-      if (result.drift.length > 0) {
-        errorln('');
-        errorln('Refused to repair non-idempotent migrations:');
-        for (const d of result.drift) errorln(`  ${d.filename}`);
-        process.exit(2);
-      }
-      info(`Repaired ${result.repaired.length} migration(s); applied ${result.applied.length} new.`);
-    } finally {
-      await closeSqlClient(sqlClient);
-    }
-    return;
+  if (action === 'migrations' || action === 'repair-migrations') {
+    // Postgres schema migrations were removed with the SQL backend; LanceDB
+    // tables are created on demand and need no migration runner.
+    errorln('construct storage ' + action + ' is no longer supported: Postgres was removed.');
+    process.exit(1);
   }
   if (action === 'sync') {
     const result = await syncFileStateToSql(process.cwd(), { env: process.env, project: inferProjectName(process.cwd()) });
@@ -3543,6 +3431,7 @@ async function cmdOrchestrate(args) {
       host: flag('--host'),
       hostModel: flag('--host-model'),
       hostProvider: flag('--host-provider'),
+      workerBackend: flag('--worker-backend'),
       fileCount: Number(flag('--file-count') || 0),
       moduleCount: Number(flag('--module-count') || 0),
     };
@@ -4566,99 +4455,10 @@ async function cmdLintContracts() {
 }
 
 async function cmdBackup(args) {
-  const sub = args[0];
-
-  if (!sub || sub === 'create') {
-    const includeSecrets = args.includes('--include-secrets');
-    const noPrune = args.includes('--no-prune');
-    const keepArg = args.find((a) => a.startsWith('--keep='));
-    const keep = keepArg
-      ? Number(keepArg.split('=')[1])
-      : Number(process.env.CONSTRUCT_BACKUP_RETAIN || 10);
-    const { createBackup, pruneBackups } = await import('../lib/storage/backup.mjs');
-    println('Creating backup…');
-    try {
-      const result = await createBackup({ includeSecrets });
-      ok(`Backup created: ${result.path}`);
-      println(`  Contents: ${result.manifest.contents.join(', ') || '(empty)'}`);
-      if (!includeSecrets) println('  Secrets redacted. Use --include-secrets to include them.');
-      if (!noPrune) {
-        const pruned = pruneBackups({ keep });
-        if (pruned.removed.length) {
-          println(`  Auto-pruned ${pruned.removed.length} old backup(s); kept ${pruned.kept}.`);
-        }
-      }
-    } catch (err) {
-      errorln(`Backup failed: ${err.message}`);
-      process.exit(1);
-    }
-    return;
-  }
-
-  if (sub === 'prune') {
-    const keepArg = args.find((a) => a.startsWith('--keep='));
-    const keep = keepArg
-      ? Number(keepArg.split('=')[1])
-      : Number(process.env.CONSTRUCT_BACKUP_RETAIN || 10);
-    const { pruneBackups } = await import('../lib/storage/backup.mjs');
-    const result = pruneBackups({ keep });
-    if (result.removed.length === 0) {
-      println(`Nothing to prune (have ${result.kept}, keeping ${keep}).`);
-    } else {
-      ok(`Pruned ${result.removed.length} backup(s); kept ${result.kept}.`);
-      for (const r of result.removed) println(`  removed ${r}`);
-    }
-    return;
-  }
-
-  if (sub === 'verify') {
-    const archivePath = args[1];
-    if (!archivePath) { errorln('Usage: construct backup verify <archive>'); process.exit(1); }
-    const { verifyBackup } = await import('../lib/storage/backup.mjs');
-    const result = await verifyBackup(archivePath);
-    if (result.ok) {
-      ok('Backup verified — all checksums match.');
-    } else {
-      errorln(`Backup verification failed:\n  ${result.errors.join('\n  ')}`);
-      process.exit(1);
-    }
-    return;
-  }
-
-  if (sub === 'restore') {
-    const archivePath = args[1];
-    const yes = args.includes('--yes');
-    if (!archivePath) { errorln('Usage: construct backup restore <archive> [--yes]'); process.exit(1); }
-    if (!yes) {
-      println(`About to restore from: ${archivePath}`);
-      println('This will overwrite observations, sessions, config.env, and registry.json.');
-      println('Press Ctrl+C to cancel, or re-run with --yes to proceed.');
-      await new Promise((r) => setTimeout(r, 3000));
-    }
-    const { restoreBackup } = await import('../lib/storage/backup.mjs');
-    const result = await restoreBackup(archivePath, { yes });
-    if (result.ok) {
-      ok(`Restored: ${result.restored.join(', ')}`);
-    } else {
-      if (result.restored.length) println(`Partially restored: ${result.restored.join(', ')}`);
-      errorln(`Errors:\n  ${result.errors.join('\n  ')}`);
-      process.exit(1);
-    }
-    return;
-  }
-
-  if (sub === 'list') {
-    const { listBackups } = await import('../lib/storage/backup.mjs');
-    const backups = listBackups();
-    if (!backups.length) { println('No backups found.'); return; }
-    for (const b of backups) {
-      const mb = (b.size / 1024 / 1024).toFixed(1);
-      println(`  ${b.name}  (${mb} MB)  ${b.mtime.toISOString().slice(0, 19)}`);
-    }
-    return;
-  }
-
-  errorln(`Unknown backup subcommand: ${sub}. Available: create, verify, restore, list, prune`);
+  // Postgres-era backups were removed with the SQL backend (lib/storage/backup.mjs).
+  // State is now Git-backed (.cx/) plus the local LanceDB index under .cx/lancedb.
+  void args;
+  errorln('construct backup is no longer supported: Postgres was removed. Commit .cx/ for Git-backed state; the LanceDB index lives under .cx/lancedb.');
   process.exit(1);
 }
 

package/lib/embed/inbox.mjs

@@ -241,7 +241,7 @@ function inferFileClassification(filePath) {
  * Summary = first non-empty line of extracted text (≤120 chars).
  * Content = first 1500 chars of extracted text for RAG searchability.
  */
-function recordInboxObservation(rootDir, { sourcePath, outputPath, characters, extractedText, category, knowledgeSubdir }) {
+async function recordInboxObservation(rootDir, { sourcePath, outputPath, characters, extractedText, category, knowledgeSubdir }) {
   const lines = (extractedText ?? '').split('\n').map((l) => l.trim()).filter(Boolean);
   const firstLine = (lines[0] ?? '').slice(0, 120);
   const filename = sourcePath.split('/').pop();
@@ -251,7 +251,10 @@ function recordInboxObservation(rootDir, { sourcePath, outputPath, characters, e
   const content = (extractedText ?? '').slice(0, 1500);
   const tags = ['inbox', 'ingested-doc', category, `knowledge:${knowledgeSubdir}`];
 
-  addObservation(rootDir, {
+  // Await the write so callers (poll) know ingestion is complete. Fire-and-
+  // forget here let the LanceDB write outlive poll() and race the caller's
+  // teardown, surfacing as "ENOTEMPTY: directory not empty" on .cx cleanup.
+  await addObservation(rootDir, {
     role: 'construct',
     category,
     summary,
@@ -414,7 +417,7 @@ export class InboxWatcher {
             const droppedInfo = fileResult.droppedInfo ?? [];
             writeExtractionWarning({ sourcePath: candidate.path, droppedInfo });
 
-            recordInboxObservation(this.#rootDir, {
+            await recordInboxObservation(this.#rootDir, {
               sourcePath: candidate.path,
               outputPath: fileResult.outputPath,
               characters: fileResult.characters,