@geoql/doctor-core 1.4.0 → 1.5.0

package/README.md

@@ -21,7 +21,7 @@ It also owns the pieces the CLIs surface: the config loader (`doctor.config.ts`
 npm i @geoql/doctor-core
 ```
 
-Published on [npm](https://www.npmjs.com/package/@geoql/doctor-core) and [JSR](https://jsr.io/@geoql/doctor-core) at `v0.1.0` with provenance. ESM-only. `knip` and `oxlint` are peer dependencies (the dead-code and script passes shell out to them).
+Published on [npm](https://www.npmjs.com/package/@geoql/doctor-core) and [JSR](https://jsr.io/@geoql/doctor-core) with provenance. ESM-only. `knip` and `oxlint` are peer dependencies (the dead-code and script passes shell out to them).
 
 ## API
 

package/dist/index.js

@@ -337,7 +337,7 @@ async function buildKnipConfig(projectInfo, doctorConfig) {
 			"!**/knip.config.mjs"
 		],
 		ignoreFiles: [...doctorConfig.exclude, "knip.config.mjs"],
-		ignoreDependencies: [...new Set([
+		ignoreDependencies: [.../* @__PURE__ */ new Set([
 			"vite-plus",
 			"@geoql/vue-doctor",
 			"@geoql/nuxt-doctor",
@@ -808,9 +808,10 @@ const RULE_ID$17 = "nuxt-doctor/nitro/compatibilityDate-set";
 function checkCompatibilityDateSet(projectInfo, nuxtConfig) {
 	if (projectInfo.packageJsonPath === null) return [];
 	if (nuxtConfig?.compatibilityDate !== void 0) return [];
+	const file = projectInfo.nuxtConfigPath ?? projectInfo.packageJsonPath;
 	return [{
 		ruleId: RULE_ID$17,
-		file: projectInfo.nuxtConfigPath ?? projectInfo.packageJsonPath,
+		file,
 		line: 1,
 		column: 1,
 		severity: "error",
@@ -824,9 +825,10 @@ const RULE_ID$16 = "nuxt-doctor/seo/lang-on-html";
 function checkLangOnHtml(projectInfo, nuxtConfig) {
 	if (projectInfo.packageJsonPath === null) return [];
 	if (nuxtConfig?.htmlLang !== void 0) return [];
+	const file = projectInfo.nuxtConfigPath ?? projectInfo.packageJsonPath;
 	return [{
 		ruleId: RULE_ID$16,
-		file: projectInfo.nuxtConfigPath ?? projectInfo.packageJsonPath,
+		file,
 		line: 1,
 		column: 1,
 		severity: "warn",
@@ -837,7 +839,7 @@ function checkLangOnHtml(projectInfo, nuxtConfig) {
 //#endregion
 //#region src/nuxt/post-checks/nitro-cloudflare-preset.ts
 const RULE_ID$15 = "nuxt-doctor/cloudflare/nitro-cloudflare-preset";
-const CLOUDFLARE_PRESETS = new Set([
+const CLOUDFLARE_PRESETS = /* @__PURE__ */ new Set([
 	"cloudflare-pages",
 	"cloudflare-module",
 	"cloudflare"
@@ -847,9 +849,10 @@ function checkNitroCloudflarePreset(projectInfo) {
 	if (!projectInfo.hasWranglerConfig) return [];
 	if (projectInfo.nitroPreset === null) return [];
 	if (CLOUDFLARE_PRESETS.has(projectInfo.nitroPreset)) return [];
+	const file = projectInfo.nuxtConfigPath ?? projectInfo.packageJsonPath;
 	return [{
 		ruleId: RULE_ID$15,
-		file: projectInfo.nuxtConfigPath ?? projectInfo.packageJsonPath,
+		file,
 		line: 1,
 		column: 1,
 		severity: "warn",
@@ -860,7 +863,7 @@ function checkNitroCloudflarePreset(projectInfo) {
 //#endregion
 //#region src/nuxt/post-checks/no-modules-incompatible-with-nuxt-4.ts
 const RULE_ID$14 = "nuxt-doctor/modules-deps/no-modules-incompatible-with-nuxt-4";
-const INCOMPATIBLE_MODULES = new Set([
+const INCOMPATIBLE_MODULES = /* @__PURE__ */ new Set([
 	"@nuxtjs/composition-api",
 	"@nuxt/bridge",
 	"nuxt-property-decorator"
@@ -884,7 +887,7 @@ async function checkNoModulesIncompatibleWithNuxt4(projectInfo) {
 //#endregion
 //#region src/nuxt/post-checks/no-node-only-modules.ts
 const RULE_ID$13 = "nuxt-doctor/cloudflare/no-node-only-modules";
-const NODE_ONLY_MODULES = new Set(["fs-extra", "sharp"]);
+const NODE_ONLY_MODULES = /* @__PURE__ */ new Set(["fs-extra", "sharp"]);
 async function checkNoNodeOnlyModules(projectInfo) {
 	if (projectInfo.packageJsonPath === null) return [];
 	if (!projectInfo.hasWranglerConfig) return [];
@@ -1030,7 +1033,7 @@ async function checkOgImageViaSatori(projectInfo) {
 	if (!projectInfo.hasWranglerConfig) return [];
 	const deps = await readDeps(projectInfo.packageJsonPath);
 	if (deps === null) return [];
-	const installed = new Set([...Object.keys(deps.dependencies), ...Object.keys(deps.devDependencies)]);
+	const installed = /* @__PURE__ */ new Set([...Object.keys(deps.dependencies), ...Object.keys(deps.devDependencies)]);
 	if (OG_IMAGE_MODULES.some((name) => installed.has(name))) return [];
 	return [{
 		ruleId: RULE_ID$10,
@@ -1049,9 +1052,10 @@ function checkPresetDefinedForDeployTarget(projectInfo) {
 	if (projectInfo.packageJsonPath === null) return [];
 	if (!projectInfo.hasWranglerConfig) return [];
 	if (projectInfo.nitroPreset !== null) return [];
+	const file = projectInfo.nuxtConfigPath ?? projectInfo.packageJsonPath;
 	return [{
 		ruleId: RULE_ID$9,
-		file: projectInfo.nuxtConfigPath ?? projectInfo.packageJsonPath,
+		file,
 		line: 1,
 		column: 1,
 		severity: "warn",
@@ -1080,7 +1084,7 @@ async function checkRecommendedModulesInstalled(projectInfo) {
 	if (projectInfo.packageJsonPath === null) return [];
 	const deps = await readDeps(projectInfo.packageJsonPath);
 	if (deps === null) return [];
-	const installed = new Set([...Object.keys(deps.dependencies), ...Object.keys(deps.devDependencies)]);
+	const installed = /* @__PURE__ */ new Set([...Object.keys(deps.dependencies), ...Object.keys(deps.devDependencies)]);
 	return RECOMMENDED_GROUPS.filter((group) => !group.candidates.some((name) => installed.has(name))).map((group, index) => ({
 		ruleId: RULE_ID$8,
 		file: projectInfo.packageJsonPath,
@@ -1591,9 +1595,10 @@ const NUXT_PLUGIN_RULES = {
 	"nuxt-doctor/server-routes/createError-on-failure": "warn",
 	"nuxt-doctor/hydration/no-document-in-setup": "error",
 	"nuxt-doctor/hydration/clientOnly-for-browser-apis": "error",
+	"nuxt-doctor/hydration/no-browser-global-in-computed": "error",
 	"nuxt-doctor/security/no-user-input-in-fetch-url": "warn"
 };
-const VUE_OXLINT_RULE_IDS = new Set([
+const VUE_OXLINT_RULE_IDS = /* @__PURE__ */ new Set([
 	"vue/no-export-in-script-setup",
 	"vue/require-typed-ref",
 	"vue/no-arrow-functions-in-watch",
@@ -1626,9 +1631,12 @@ const VUE_OXLINT_RULE_IDS = new Set([
 	"vue-doctor/reactivity/prefer-shallowRef-for-large-data",
 	"vue-doctor/reactivity/prefer-readonly-for-injected",
 	"vue-doctor/reactivity/no-fresh-deps-in-watch",
+	"vue-doctor/reactivity/no-stale-timer-ref",
+	"vue-doctor/reactivity/effect-listener-cleanup-mismatch",
 	"vue-doctor/composition/prefer-script-setup-for-new-files",
 	"vue-doctor/composition/defineProps-typed",
 	"vue-doctor/composition/no-pinia-store-in-setup",
+	"vue-doctor/composition/no-prop-callback-in-setup",
 	"vue-doctor/performance/prefer-defineAsyncComponent-on-route",
 	"vue-doctor/performance/prefer-module-scope-static-value",
 	"vue-doctor/performance/prefer-module-scope-pure-function",
@@ -1641,7 +1649,7 @@ const VUE_OXLINT_RULE_IDS = new Set([
 const NUXT_OXLINT_RULE_IDS = new Set(Object.keys(NUXT_PLUGIN_RULES));
 function oxlintRuleAllowlist(framework) {
 	if (framework !== "nuxt") return VUE_OXLINT_RULE_IDS;
-	return new Set([...VUE_OXLINT_RULE_IDS, ...NUXT_OXLINT_RULE_IDS]);
+	return /* @__PURE__ */ new Set([...VUE_OXLINT_RULE_IDS, ...NUXT_OXLINT_RULE_IDS]);
 }
 function toOxlintSeverity(s) {
 	if (s === "error") return "error";
@@ -2158,6 +2166,20 @@ const RULE_REGISTRY = [
 		source: "doctor",
 		recommended: true
 	},
+	{
+		id: "vue-doctor/reactivity/no-stale-timer-ref",
+		severity: "warn",
+		category: "reactivity",
+		source: "doctor",
+		recommended: true
+	},
+	{
+		id: "vue-doctor/reactivity/effect-listener-cleanup-mismatch",
+		severity: "warn",
+		category: "reactivity",
+		source: "doctor",
+		recommended: true
+	},
 	{
 		id: "vue-doctor/composition/prefer-script-setup-for-new-files",
 		severity: "warn",
@@ -2179,6 +2201,13 @@ const RULE_REGISTRY = [
 		source: "doctor",
 		recommended: true
 	},
+	{
+		id: "vue-doctor/composition/no-prop-callback-in-setup",
+		severity: "warn",
+		category: "composition",
+		source: "doctor",
+		recommended: true
+	},
 	{
 		id: "vue-doctor/performance/prefer-defineAsyncComponent-on-route",
 		severity: "info",
@@ -2536,6 +2565,13 @@ const RULE_REGISTRY = [
 		source: "doctor",
 		recommended: true
 	},
+	{
+		id: "nuxt-doctor/hydration/no-browser-global-in-computed",
+		severity: "error",
+		category: "hydration",
+		source: "doctor",
+		recommended: true
+	},
 	{
 		id: "nuxt-doctor/hydration/clientOnly-for-browser-apis",
 		severity: "error",
@@ -2833,7 +2869,7 @@ async function parseSfcDescriptor(absPath) {
 const RULE_ID$5 = "vue-doctor/sfc/no-mixed-options-and-composition-api";
 const MESSAGE$5 = "Mixed Options API in a <script setup> SFC. Move data/methods/computed/watch/lifecycle into <script setup> Composition API; keep <script> only for options like name/inheritAttrs. See https://vuejs.org/api/sfc-script-setup.html#usage-alongside-normal-script";
 const RECOMMENDATION$5 = "Move this option into the <script setup> block using the Composition API, or keep <script> only for options-only config such as name or inheritAttrs.";
-const DISALLOWED = new Set([
+const DISALLOWED = /* @__PURE__ */ new Set([
 	"data",
 	"methods",
 	"computed",
@@ -3014,7 +3050,7 @@ function check$20(ctx) {
 const RULE_ID$3 = "nuxt-doctor/seo/og-image-defined";
 const MESSAGE$3 = "Page uses SEO meta but has no og:image property. Open Graph images improve social sharing previews. Add an og:image value or install @nuxtjs/og-image for automatic OG images.";
 const RECOMMENDATION$3 = "Add ogImage: \"/path/to/image.png\" to useSeoMeta / useHead, or install @nuxtjs/og-image.";
-const SEO_PRIMITIVES$1 = new Set(["useSeoMeta", "useHead"]);
+const SEO_PRIMITIVES$1 = /* @__PURE__ */ new Set(["useSeoMeta", "useHead"]);
 function isSeoWrapperName$1(name) {
 	if (SEO_PRIMITIVES$1.has(name)) return false;
 	return /^use[a-z]*seo/i.test(name);
@@ -3080,7 +3116,7 @@ function check$19(ctx) {
 const RULE_ID$2 = "nuxt-doctor/seo/useSeoMeta-on-public-page";
 const MESSAGE$2 = "Public page component is missing SEO metadata. Add useSeoMeta, useHead, or definePageMeta with a title so search engines can index it properly.";
 const RECOMMENDATION$2 = "Call useSeoMeta({ title: \"...\" }) in<script setup> to define page title and meta tags for search engines and social previews.";
-const SEO_PRIMITIVES = new Set([
+const SEO_PRIMITIVES = /* @__PURE__ */ new Set([
 	"useSeoMeta",
 	"useHead",
 	"definePageMeta"
@@ -3273,7 +3309,7 @@ function ruleNoSharedKeyAcrossPages(pages) {
 	}
 	return diags;
 }
-const BROWSER_GLOBALS = new Set([
+const BROWSER_GLOBALS = /* @__PURE__ */ new Set([
 	"window",
 	"document",
 	"navigator",
@@ -3317,7 +3353,7 @@ function ruleSsrSafeOnMountedOnlyForClient(pages) {
 	}
 	return diags;
 }
-const CLIENT_SAFE_WRAPPERS = new Set([
+const CLIENT_SAFE_WRAPPERS = /* @__PURE__ */ new Set([
 	"onMounted",
 	"watchEffect",
 	"watch"
@@ -3753,7 +3789,7 @@ function check$8(ctx) {
 //#endregion
 //#region src/template/rules/no-javascript-uri.ts
 const NODE_ATTRIBUTE$1 = 6;
-const URI_SINKS = new Set([
+const URI_SINKS = /* @__PURE__ */ new Set([
 	"href",
 	"src",
 	"srcset",
@@ -3986,7 +4022,7 @@ function check$2(ctx) {
 }
 //#endregion
 //#region src/template/rules/no-missing-alt.ts
-const IMAGE_TAGS = new Set([
+const IMAGE_TAGS = /* @__PURE__ */ new Set([
 	"img",
 	"NuxtImg",
 	"nuxt-img"
@@ -4614,7 +4650,8 @@ async function loadDoctorConfig(rootDir, explicitPathOrOptions) {
 		source = "flag";
 		configFile = resolve(rootDir, explicitPath);
 	} else if (result._configFile) {
-		source = SOURCE_MAP[extname(result._configFile).slice(1)];
+		const ext = extname(result._configFile).slice(1);
+		source = SOURCE_MAP[ext];
 		configFile = result._configFile;
 	} else if (Object.keys(raw).length > 0) {
 		source = "package.json";
@@ -4932,6 +4969,7 @@ async function listChangedFiles(options) {
 		"diff",
 		"--name-only",
 		"--cached",
+		"--relative",
 		"--diff-filter=ACMR"
 	]);
 	else {
@@ -4939,6 +4977,7 @@ async function listChangedFiles(options) {
 			"diff",
 			"--name-only",
 			"HEAD",
+			"--relative",
 			"--diff-filter=ACMR"
 		]);
 		const untracked = await gitLines(rootDir, [