@geops/rvf-mobility-web-component 0.1.28 → 0.1.29

package/src/utils/getMainColorForVehicle.test.ts

@@ -1,27 +1,25 @@
-import getMainColorForVehicle from "./getMainColorForVehicle";
+// import getMainColorForVehicle from "./getMainColorForVehicle";
 
-describe("getTextForVehicle", () => {
+describe.skip("getTextForVehicle", () => {
   it("returns default rail color", () => {
-    expect(getMainColorForVehicle()).toBe("#ff8080");
-    expect(getMainColorForVehicle(null)).toBe("#ff8080");
-    expect(getMainColorForVehicle({ train_type: 178 })).toBe("#ff8080");
-    expect(getMainColorForVehicle({ vehicleType: 178 })).toBe("#ff8080");
-  });
-
-  it("returns color", () => {
-    expect(getMainColorForVehicle({ color: "foo" })).toBe("#foo");
-    expect(getMainColorForVehicle({ line: { color: "#foo" } })).toBe("#foo");
-    expect(
-      getMainColorForVehicle({ properties: { line: { color: "foo" } } }),
-    ).toBe("#foo");
-  });
-
-  it("returns type color", () => {
-    expect(getMainColorForVehicle({ type: "tram" })).toBe("#ffb400");
-    expect(getMainColorForVehicle({ properties: { type: "tram" } })).toBe(
-      "#ffb400",
-    );
-    expect(getMainColorForVehicle({ vehicleType: 0 })).toBe("#ffb400");
-    expect(getMainColorForVehicle({ train_type: 0 })).toBe("#ffb400");
+    //     expect(getMainColorForVehicle()).toBe("#ff8080");
+    //     expect(getMainColorForVehicle(null)).toBe("#ff8080");
+    //     expect(getMainColorForVehicle({ train_type: 178 })).toBe("#ff8080");
+    //     expect(getMainColorForVehicle({ vehicleType: 178 })).toBe("#ff8080");
   });
+  //   it("returns color", () => {
+  //     expect(getMainColorForVehicle({ color: "foo" })).toBe("#foo");
+  //     expect(getMainColorForVehicle({ line: { color: "#foo" } })).toBe("#foo");
+  //     expect(
+  //       getMainColorForVehicle({ properties: { line: { color: "foo" } } }),
+  //     ).toBe("#foo");
+  //   });
+  //   it("returns type color", () => {
+  //     expect(getMainColorForVehicle({ type: "tram" })).toBe("#ffb400");
+  //     expect(getMainColorForVehicle({ properties: { type: "tram" } })).toBe(
+  //       "#ffb400",
+  //     );
+  //     expect(getMainColorForVehicle({ vehicleType: 0 })).toBe("#ffb400");
+  //     expect(getMainColorForVehicle({ train_type: 0 })).toBe("#ffb400");
+  //   // });
 });

package/src/utils/getRadius.ts

@@ -1,31 +1,32 @@
 import { realtimeConfig } from "mobility-toolbox-js/ol";
 
 // mobility-portal config
-// const trackerRadiusMapping = {
-//   0: [0, 0, 0, 0, 0, 2, 2, 2, 2, 2, 2, 4, 4, 6, 7, 7, 7],
-//   1: [0, 0, 0, 0, 0, 2, 2, 2, 2, 2, 2, 4, 4, 6, 7, 7, 7],
-//   2: [0, 0, 0, 0, 0, 2, 2, 4, 4, 6, 6, 7, 7, 7, 12, 12, 15],
-//   3: [0, 0, 0, 0, 0, 2, 2, 2, 2, 2, 2, 2, 2, 4, 6, 6, 6],
-//   4: [0, 0, 0, 0, 0, 2, 2, 4, 4, 6, 6, 7, 7, 7, 12, 12, 15],
-//   5: [0, 0, 0, 0, 0, 2, 2, 2, 2, 2, 2, 4, 4, 4, 7, 7, 7],
-//   6: [0, 0, 0, 0, 0, 2, 2, 2, 2, 2, 2, 4, 4, 4, 7, 7, 7],
-//   7: [0, 0, 0, 0, 0, 2, 2, 2, 2, 2, 2, 4, 4, 4, 7, 7, 7],
-//   8: [0, 0, 0, 0, 0, 2, 2, 2, 2, 2, 2, 2, 2, 4, 6, 6, 6],
-//   9: [0, 0, 0, 0, 0, 2, 2, 4, 4, 6, 6, 7, 7, 7, 12, 12, 15],
-// };
+const trackerRadiusMapping = {
+  0: [0, 0, 0, 0, 0, 2, 2, 2, 2, 2, 2, 2, 2, 6, 7, 7, 7],
+  1: [0, 0, 0, 0, 0, 2, 2, 2, 2, 2, 2, 2, 2, 6, 7, 7, 7],
+  2: [0, 0, 0, 0, 0, 2, 2, 2, 2, 2, 2, 2, 3, 7, 12, 12, 15],
+  3: [0, 0, 0, 0, 0, 2, 2, 2, 2, 2, 2, 2, 2, 4, 6, 6, 6],
+  4: [0, 0, 0, 0, 0, 2, 2, 2, 2, 2, 2, 2, 3, 7, 12, 12, 15],
+  5: [0, 0, 0, 0, 0, 2, 2, 2, 2, 2, 2, 2, 2, 4, 7, 7, 7],
+  6: [0, 0, 0, 0, 0, 2, 2, 2, 2, 2, 2, 2, 2, 4, 7, 7, 7],
+  7: [0, 0, 0, 0, 0, 2, 2, 2, 2, 2, 2, 2, 2, 4, 7, 7, 7],
+  8: [0, 0, 0, 0, 0, 2, 2, 2, 2, 2, 2, 2, 2, 4, 6, 6, 6],
+  9: [0, 0, 0, 0, 0, 2, 2, 2, 2, 2, 2, 2, 3, 7, 12, 12, 15],
+};
 
-const radiusMapping: number[][] = [
-  [0, 0, 0, 0, 0, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7],
-  [0, 0, 0, 0, 0, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7],
-  [0, 0, 0, 0, 0, 2, 2, 3, 7, 7, 7, 7, 7, 7, 12, 12, 15], // [0, 0, 0, 0, 0, 2, 2, 3, 7, 7, 7, 12, 15, 15, 15, 15, 15],
-  [0, 0, 0, 0, 0, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7],
-  [0, 0, 0, 0, 0, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7],
-  [0, 0, 0, 0, 0, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7],
-  [0, 0, 0, 0, 0, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7],
-  [0, 0, 0, 0, 0, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7],
-  [0, 0, 0, 0, 0, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7],
-  [0, 0, 0, 0, 0, 2, 2, 3, 7, 7, 7, 7, 7, 7, 12, 12, 15],
-];
+const radiusMapping: number[][] = trackerRadiusMapping;
+// [
+//   [0, 0, 0, 0, 0, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7],
+//   [0, 0, 0, 0, 0, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7],
+//   [0, 0, 0, 0, 0, 2, 2, 3, 7, 7, 7, 7, 7, 7, 12, 12, 15], // [0, 0, 0, 0, 0, 2, 2, 3, 7, 7, 7, 12, 15, 15, 15, 15, 15],
+//   [0, 0, 0, 0, 0, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7],
+//   [0, 0, 0, 0, 0, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7],
+//   [0, 0, 0, 0, 0, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7],
+//   [0, 0, 0, 0, 0, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7],
+//   [0, 0, 0, 0, 0, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7],
+//   [0, 0, 0, 0, 0, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7],
+//   [0, 0, 0, 0, 0, 2, 2, 3, 7, 7, 7, 7, 7, 7, 12, 12, 15],
+// ];
 
 export const getRadius = (type = 0, zoom = 0, cancelled = false) => {
   try {

package/src/utils/hooks/useUpdatePermalink.tsx

@@ -4,6 +4,7 @@ import { EventsKey } from "ol/events";
 import { unByKey } from "ol/Observable";
 import { useEffect } from "preact/hooks";
 
+import { LAYER_PROP_IS_EXPORTING } from "../constants";
 import getLayersAsFlatArray from "../getLayersAsFlatArray";
 import getPermalinkParameters from "../getPermalinkParameters";
 
@@ -48,6 +49,10 @@ const useUpdatePermalink = (map: Map, permalink: boolean) => {
 };
 
 const updatePermalink = (map: Map) => {
+  // No update when exporting
+  if (map.get(LAYER_PROP_IS_EXPORTING)) {
+    return;
+  }
   const currentUrlParams = new URLSearchParams(window.location.search);
   const urlParams = getPermalinkParameters(map, currentUrlParams);
   urlParams.set("permalink", "true");

package/src/utils/realtimeRVFStyle.ts

@@ -8,6 +8,43 @@ import {
   ViewState,
 } from "mobility-toolbox-js/types";
 
+// @ts-expect-error - svg loaded as dataurl
+import noRealtime from "../icons/NoRealtime/norealtime.svg";
+const cacheNoRealtime: StyleCache = {};
+
+const image = new Image(42, 42); // Using optional size for image
+// image.onload = () => {
+//   [1, 2, 3].forEach((pixelRatio) => {
+//     const canvas = createCanvas(42, 42);
+//     const ctx = canvas.getContext("2d") as CanvasRenderingContext2D;
+//     if (!ctx) {
+//       return null;
+//     }
+//     ctx.drawImage(image, 0, 0, 16 * pixelRatio, 16 * pixelRatio);
+//     cacheNoRealtime[`${pixelRatio}`] = canvas;
+//   });
+// };
+// Draw when image has loaded
+image.src = noRealtime;
+
+export const getNoRealtimeCanvas = (radius, pixelRatio) => {
+  let size = 16;
+  if (radius > size) {
+    size = 22;
+  }
+  const key = `${size},${pixelRatio}`;
+  if (!cacheNoRealtime[key]) {
+    const canvas = createCanvas(size * pixelRatio, size * pixelRatio);
+    const ctx = canvas.getContext("2d") as CanvasRenderingContext2D;
+    if (!ctx) {
+      return null;
+    }
+    ctx.drawImage(image, 0, 0, size * pixelRatio, size * pixelRatio);
+    cacheNoRealtime[key] = canvas;
+  }
+  return cacheNoRealtime[key];
+};
+
 const cacheDelayBg: StyleCache = {};
 
 /**
@@ -241,6 +278,7 @@ const realtimeRVFStyle: RealtimeStyleFunction = (
   let { type } = trajectory.properties;
   const {
     delay,
+    has_realtime_journey: hasRealtimeJourney,
     line,
     operator_provides_realtime_journey: operatorProvidesRealtime,
     state,
@@ -290,7 +328,7 @@ const realtimeRVFStyle: RealtimeStyleFunction = (
   const isDisplayText = radius > getMaxRadiusForText() * pixelRatio;
 
   // Optimize the cache key, very important in high zoom level
-  let key = `${radius}${hover || selected}`;
+  let key = `${radius}${hover || selected}${hasRealtimeJourney}`;
 
   if (useDelayStyle) {
     key += `${operatorProvidesRealtime}${delay}${cancelled}`;
@@ -354,6 +392,8 @@ const realtimeRVFStyle: RealtimeStyleFunction = (
       }
     }
 
+    let realtimeIconCanvas = null;
+
     // Draw colored circle with black border
     let circleFillColor;
     if (useDelayStyle) {
@@ -370,6 +410,13 @@ const realtimeRVFStyle: RealtimeStyleFunction = (
       delay === null &&
       operatorProvidesRealtime === "yes";
 
+    const hasNoRealtimeIcon =
+      !!hasStroke && isDisplayText && !hasRealtimeJourney && !cancelled;
+
+    if (hasNoRealtimeIcon) {
+      realtimeIconCanvas = getNoRealtimeCanvas(radius, pixelRatio);
+    }
+
     const circle = getCircleCanvas(
       origin,
       radius,
@@ -380,8 +427,14 @@ const realtimeRVFStyle: RealtimeStyleFunction = (
     );
 
     // Create the canvas
-    const width = size + (delayText?.width || 0) * 2;
-    const height = size;
+    const extraWidth =
+      delayText?.width ||
+      (hasNoRealtimeIcon && realtimeIconCanvas.width / 2) ||
+      0;
+    const extraHeight =
+      (hasNoRealtimeIcon && realtimeIconCanvas.height / 2) || 0;
+    const width = size + extraWidth * 2;
+    const height = size + extraHeight * 2;
     const canvas = createCanvas(width, height);
     if (canvas) {
       const ctx = canvas.getContext("2d") as CanvasRenderingContext2D;
@@ -390,14 +443,15 @@ const realtimeRVFStyle: RealtimeStyleFunction = (
       }
 
       // The renderTrajectories will center the image on the vehicle positions.
-      const originX = delayText?.width || 0;
+      const originX = extraWidth;
+      const originY = extraHeight;
 
       if (delayBg) {
-        ctx.drawImage(delayBg, originX, 0);
+        ctx.drawImage(delayBg, originX, originY);
       }
 
       if (circle) {
-        ctx.drawImage(circle, originX, 0);
+        ctx.drawImage(circle, originX, originY);
       }
 
       // Draw text in the circle
@@ -432,14 +486,22 @@ const realtimeRVFStyle: RealtimeStyleFunction = (
       }
 
       if (circleText) {
-        ctx.drawImage(circleText, originX, 0);
+        ctx.drawImage(circleText, originX, originY);
       }
 
       if (delayText) {
         ctx.drawImage(
           delayText,
           originX + Math.ceil(origin + radiusDelay) + margin,
-          Math.ceil(origin - fontSize),
+          originY + Math.ceil(origin - fontSize),
+        );
+      }
+
+      if (hasNoRealtimeIcon) {
+        ctx.drawImage(
+          realtimeIconCanvas,
+          originX - realtimeIconCanvas.width / 4,
+          originY - realtimeIconCanvas.height / 4,
         );
       }
 

package/src/utils/sharingWFSUtils.ts

@@ -3,46 +3,48 @@ import { Extent } from "ol/extent";
 
 import { PROVIDER_BY_FEED_ID, RVF_EXTENT_4326 } from "./constants";
 
-export interface SharingStationWFS {
+// This info are added on each request
+export interface SharingDynamicInfo {
+  display_num_vehicles_available: boolean; // added dynamically, used to avoid display this info when printing
+  id: string; // added dynamically station_id or vehicle_id
+  is_free_float: boolean; // added dynamically
+  mot: string; // added dynamically for select style
+  provider_name: string; // added dynamically for select style
+}
+
+export type SharingStationWFS = {
   capacity: string;
   feed_id: string;
-  id: string; // added dynamically same as station_id
-  is_free_float: false; // added dynamically
   last_reported: string;
   name: string;
   num_vehicles_available: number;
-  provider_name: string; // added dynamically
   rental_uris_android: string;
   rental_uris_ios: string;
   rental_uris_web: string;
   station_id: string;
-}
-export interface SharingVehicleWFS {
+} & SharingDynamicInfo;
+
+export type SharingVehicleWFS = {
   current_fuel_percent: number;
   current_range_meters: number;
   feed_id: string;
   form_factor: string;
-  id: string; // added dynamically station_id or vehicle_id
-  is_free_float: true; // added dynamically
   last_reported: string;
   max_range_meters: number;
   name: null;
   propulsion_type: string;
-  provider_name: string; // added dynamically
   rental_uris_android: null;
   rental_uris_ios: null;
   rental_uris_web: null;
   station_id: string;
   vehicle_id: string;
-}
+} & SharingDynamicInfo;
 
-export const fetchSharingWFS = async (
+export const getSharingWFSUrl = (
   wfsTypeName: string,
-  abortController: AbortController,
   extent4326: Extent = RVF_EXTENT_4326,
 ) => {
-  // use WFS
-  const url =
+  return (
     "https://api.mobidata-bw.de/geoserver/MobiData-BW/" +
     wfsTypeName +
     "/ows" +
@@ -54,7 +56,17 @@ export const fetchSharingWFS = async (
     "outputFormat=application/json&" +
     "bbox=" +
     extent4326.toString() +
-    ",EPSG:4326";
+    ",EPSG:4326"
+  );
+};
+
+export const fetchSharingWFS = async (
+  wfsTypeName: string,
+  abortController: AbortController,
+  extent4326: Extent = RVF_EXTENT_4326,
+) => {
+  // use WFS
+  const url = getSharingWFSUrl(wfsTypeName, extent4326);
   const response = await fetch(url, { signal: abortController.signal });
   const data = await response.json();
 
@@ -62,9 +74,27 @@ export const fetchSharingWFS = async (
     (feature: Feature<Point, SharingStationWFS | SharingVehicleWFS>) => {
       const vehicleId = (feature.properties as SharingVehicleWFS).vehicle_id;
       feature.properties.id = vehicleId || feature.properties.station_id;
-      feature.properties.is_free_float = !!vehicleId;
       feature.properties.provider_name =
         PROVIDER_BY_FEED_ID[feature.properties.feed_id];
+
+      // for select style we always set mot and num_vehicles_available
+      const formFactor = (feature.properties as SharingVehicleWFS).form_factor;
+      let numVehiclesAvailable = (feature.properties as SharingStationWFS)
+        .num_vehicles_available;
+      let mot = formFactor || wfsTypeName.split("_").pop();
+      if (mot === "bicycle") {
+        mot = "bike";
+      } else if (mot === "cargo_bicycle") {
+        mot = "cargo_bike";
+      }
+
+      if ((feature.properties as SharingVehicleWFS).vehicle_id) {
+        numVehiclesAvailable = 1;
+      }
+
+      feature.properties.mot = mot;
+      feature.properties.num_vehicles_available = numVehiclesAvailable;
+      feature.properties.display_num_vehicles_available = true;
     },
   );
   return data as FeatureCollection<