@geonosis/oxlint-plugin-biological-architecture 2.9.0 → 2.10.0

package/CHANGELOG.md

@@ -1,5 +1,23 @@
 # @geonosis/oxlint-plugin-biological-architecture
 
+## 2.10.0
+
+### Minor Changes
+
+- 4c240df: `tissue-no-data-props` forbids state through props, not data (#9).
+  
+  A stateless component handed `collections` by its parent and rendering a carousel cell had no
+  tier: the tissue rule read a data prop as ownership. Data is not state — the route fetched it, or
+  the tissue above did. A tissue may now take any declared data type. What it may not be handed is a
+  handler or setter (a function type, `Dispatch`, `SetStateAction`) or an undeclared one (`any`,
+  `unknown`, `object`, `{}`): `any` was "unknown, therefore allowed", and is now reported.
+  
+  If you migrate against this, re-tier any `cells/` file that only re-exports a non-cell first. A
+  parent that stays in `cells/` and imports such a shim through a bare `cells` barrel is silent today
+  only because the barrel is untraced (#4); when #4's barrel fix lands it picks up
+  `cell-must-not-compose-cell`. A parent this release lets you move to `tissues/` is not affected by
+  that fix — it would only surface if barrels were followed through their re-exports.
+
 ## 2.9.0
 
 ### Minor Changes

package/corpus/tissues/bad-handler-prop.tsx

@@ -0,0 +1,7 @@
+// Breaches tissue-no-data-props: a handler is state coordinated through props. The parent that
+// holds `onSelect` holds state, which makes it a cell — and a cell does not render a tissue.
+import { GoodStateful } from '../cells/good-stateful'
+
+export function BadHandlerProp({ onSelect }: { onSelect: (id: string) => void }) {
+  return <GoodStateful key={String(onSelect)} />
+}

package/corpus/tissues/bad-passthrough.tsx

@@ -1,3 +1,5 @@
-export function BadPassthrough({ children }: { children: unknown }) {
-  return <div>{children as never}</div>
+import type { ReactNode } from 'react'
+
+export function BadPassthrough({ children }: { children: ReactNode }) {
+  return <div>{children}</div>
 }

package/corpus/tissues/bad-untyped-prop.tsx

@@ -0,0 +1,7 @@
+// Breaches tissue-no-data-props: `any` is not a declaration. The tissue hands the value to a
+// typed child; say what it is.
+import { GoodStateful } from '../cells/good-stateful'
+
+export function BadUntypedProp({ order }: { order: any }) {
+  return <GoodStateful key={String(order)} />
+}

package/corpus/tissues/good-data-props.tsx

@@ -0,0 +1,13 @@
+// The shape issue #9 had no tier for: stateless, handed rows by its parent, arranging a cell.
+// Data is not state — a tissue may carry what it hands down.
+import { GoodStateful } from '../cells/good-stateful'
+
+export function GoodDataProps({ rows, title }: { rows: { id: string }[]; title: string }) {
+  return (
+    <section aria-label={title}>
+      {rows.map((row) => (
+        <GoodStateful key={row.id} />
+      ))}
+    </section>
+  )
+}

package/dist/index.js

@@ -542,8 +542,8 @@ down to \`compounds/\`, a store adapter goes sideways to \`organelles/\`. A pare
 hosts a cell (a summary card that opens a modal-hosted form) is two cells side by side: the child
 hosts its own modal and reads whether it is open from the store, the parent writes it, and a
 \`tissues/\` file arranges both. Cells coordinate through a store, never through props from one to
-the other. A stateless adapter between cells is a tissue \u2014 it may take number and boolean layout
-configuration with a literal default (\`step = 10\`). Private siblings of the SAME
+the other. A stateless adapter between cells is a tissue \u2014 it may take the data it hands down
+(\`{ collections: Collection[] }\`); it may not take a handler. Private siblings of the SAME
 component (\`invoice-editor.parts.tsx\` from \`invoice-editor.tsx\`) are one cell and are fine. The
 barrels \`cells/index.ts\`, \`cells/dynamic.ts\` and \`cells/dynamic.tsx\` are exempt \u2014 re-exporting
 siblings is the shape \`cells-folder-index-is-barrel\` requires of them.`,
@@ -6286,35 +6286,37 @@ var ROUTE_FALLBACK_BASENAMES2 = /* @__PURE__ */ new Set([
   "loading.tsx",
   "not-found.tsx"
 ]);
-var ALWAYS_ALLOWED_PROP_NAMES = /* @__PURE__ */ new Set(["children", "className", "params", "searchParams"]);
-var REACT_NODE_TYPE_NAMES = /* @__PURE__ */ new Set([
-  "ComponentType",
-  "Element",
-  "JSX",
-  "PropsWithChildren",
-  "ReactElement",
-  "ReactNode"
-]);
-var isKindVocabulary = (name) => /(Kind|EntityName)$/.test(name);
-function isAllowedTypeRefName(name) {
-  if (REACT_NODE_TYPE_NAMES.has(name)) return true;
-  if (isKindVocabulary(name)) return true;
-  if (name.endsWith("Icon")) return true;
-  if (name.endsWith("IconComponent")) return true;
-  if (name.endsWith("IconType")) return true;
+var HANDLER_TYPE_NAMES = /* @__PURE__ */ new Set(["Dispatch", "Function", "SetStateAction"]);
+var UNDECLARED_KEYWORDS = /* @__PURE__ */ new Set(["TSAnyKeyword", "TSObjectKeyword", "TSUnknownKeyword"]);
+var isHandler = (t) => {
+  if (!t?.type) return false;
+  if (t.type === "TSFunctionType") return true;
+  if (t.type === "TSTypeReference") return HANDLER_TYPE_NAMES.has(t.typeName?.name ?? "");
+  if (t.type === "TSUnionType") return (t.types ?? []).some(isHandler);
   return false;
-}
-function describeTypeAnnotation(t) {
-  if (!t || !t.type) return "unknown";
+};
+var isUndeclared = (t) => {
+  if (!t?.type) return false;
+  if (UNDECLARED_KEYWORDS.has(t.type)) return true;
+  if (t.type === "TSTypeLiteral") return (t.members ?? []).length === 0;
+  if (t.type === "TSUnionType") return (t.types ?? []).some(isUndeclared);
+  return false;
+};
+var KEYWORD_NAMES = {
+  TSAnyKeyword: "any",
+  TSNullKeyword: "null",
+  TSObjectKeyword: "object",
+  TSUndefinedKeyword: "undefined",
+  TSUnknownKeyword: "unknown"
+};
+var describeTypeAnnotation = (t) => {
+  if (!t?.type) return "unknown";
+  if (t.type in KEYWORD_NAMES) return KEYWORD_NAMES[t.type] ?? t.type;
   switch (t.type) {
-    case "TSStringKeyword":
-      return "string";
-    case "TSNumberKeyword":
-      return "number";
-    case "TSBooleanKeyword":
-      return "boolean";
-    case "TSArrayType":
-      return `Array<${describeTypeAnnotation(t.elementType)}>`;
+    case "TSFunctionType":
+      return "a function";
+    case "TSTypeLiteral":
+      return "{}";
     case "TSTypeReference":
       return t.typeName?.name ?? "(unknown-ref)";
     case "TSUnionType":
@@ -6322,47 +6324,7 @@ function describeTypeAnnotation(t) {
     default:
       return t.type;
   }
-}
-function isLiteralStringUnion(t) {
-  if (t.type !== "TSUnionType") return false;
-  const types = t.types ?? [];
-  if (types.length === 0) return false;
-  return types.every((x) => x.type === "TSLiteralType" && typeof x.literal?.value === "string");
-}
-var narrowsAKindVocabulary = (t) => {
-  const name = t.typeName?.name ?? "";
-  if (name !== "Exclude" && name !== "Extract") return false;
-  const [subject] = (t.typeArguments ?? t.typeParameters)?.params ?? [];
-  return subject?.type === "TSTypeReference" && isKindVocabulary(subject.typeName?.name ?? "");
-};
-function isAllowedType(t) {
-  if (!t || !t.type) return true;
-  switch (t.type) {
-    case "TSTypeReference":
-      return isAllowedTypeRefName(t.typeName?.name ?? "") || narrowsAKindVocabulary(t);
-    case "TSUnionType":
-      return isLiteralStringUnion(t);
-    // TSTypeLiteral (inline object shape) — allowed because nested shapes
-    // Are typically ReactNode records; if it turns out to contain data
-    // Primitives, the outer check will miss them (v1 limitation).
-    case "TSTypeLiteral":
-      return true;
-    // Primitives and arrays fall through to forbidden.
-    case "TSStringKeyword":
-    case "TSNumberKeyword":
-    case "TSBooleanKeyword":
-    case "TSArrayType":
-      return false;
-    default:
-      return true;
-  }
-}
-var literalDefaultsOf = (param) => new Map(
-  (param.properties ?? []).flatMap(
-    (property) => property.type === "Property" && property.key?.type === "Identifier" && property.value?.type === "AssignmentPattern" && property.value.right?.type === "Literal" ? [[property.key.name ?? "", property.value.right.value]] : []
-  )
-);
-var isLayoutConfiguration = (t, defaults, prop) => t.type === "TSNumberKeyword" && typeof defaults.get(prop) === "number" || t.type === "TSBooleanKeyword" && typeof defaults.get(prop) === "boolean";
+};
 var tissueNoDataProps = {
   create(context) {
     const normalized = normalise(context.filename);
@@ -6377,20 +6339,17 @@ var tissueNoDataProps = {
       if (!firstParam) return;
       const typeLiteral = firstParam.typeAnnotation?.typeAnnotation;
       if (!typeLiteral || typeLiteral.type !== "TSTypeLiteral") return;
-      const members = typeLiteral.members ?? [];
-      const defaults = literalDefaultsOf(firstParam);
-      for (const member of members) {
+      for (const member of typeLiteral.members ?? []) {
         if (member.key?.type !== "Identifier") continue;
-        const propName = member.key.name ?? "";
-        if (!propName) continue;
-        if (ALWAYS_ALLOWED_PROP_NAMES.has(propName)) continue;
+        const prop = member.key.name ?? "";
+        if (!prop) continue;
         const t = member.typeAnnotation?.typeAnnotation;
         if (!t) continue;
-        if (isAllowedType(t)) continue;
-        if (isLayoutConfiguration(t, defaults, propName)) continue;
+        const messageId = isHandler(t) ? "handler" : isUndeclared(t) ? "undeclared" : void 0;
+        if (messageId === void 0) continue;
         context.report({
-          data: { prop: propName, type: describeTypeAnnotation(t) },
-          messageId: "dataProp",
+          data: { prop, type: describeTypeAnnotation(t) },
+          messageId,
           node: member
         });
       }
@@ -6412,10 +6371,8 @@ var tissueNoDataProps = {
       }
     }
     return {
-      // Only inspect the PUBLIC INTERFACE of the tissue file — the default or
-      // Named export. Inner helper functions (not exported) are file-scoped
-      // Implementation details; their props don't define the tissue's
-      // Contract, so they're out of scope for this rule.
+      // Only the PUBLIC INTERFACE of the tissue file — the default or named export. Inner helpers
+      // are file-scoped implementation; their props do not define the tissue's contract.
       ExportDefaultDeclaration(node) {
         checkDeclaration(node.declaration);
       },
@@ -6424,17 +6381,21 @@ var tissueNoDataProps = {
       }
     };
   },
-  fixShape: `A tissue takes \`children\`, ReactNode slot props, layout variants, \`params\` and \`searchParams\` \u2014 and
-nothing else. A prop typed \`string\`, \`number\`, an array or a domain type (\`id\`, \`initialData\`,
-\`documents\`) means the file owns data, which makes it a CELL: move it to \`cells/\`. A tissue gets its
-content as slots, never as data. Layout configuration is not data: a \`number\` or \`boolean\` prop the
-tissue gives a literal default (\`{ step = 10, wrap = false }\`) is allowed.`,
+  fixShape: `A tissue holds no state, and data is not state: a tissue may take the rows, the cart or the title
+its parent hands it and hand them down to the cells and compounds it arranges (\`{ collections:
+Collection[] }\` rendering a carousel cell is a tissue). What a tissue is never handed is STATE \u2014 a
+handler or a setter (\`onSelect: (id) => void\`, \`setOpen: Dispatch<\u2026>\`) is coordination through
+props, and the parent holding it is a cell, which does not render tissues: move the handler into the
+cell below, or the file to \`cells/\`. And never an undeclared type \u2014 \`any\`, \`unknown\`, \`object\`,
+\`{}\`, alone or in a union \u2014 declare what the child takes. A tissue with no hooks, no store and no
+organelle that composes a cell and takes data is a tissue; do not invent a store to make it a cell.`,
   meta: {
     docs: {
-      description: "Tissues must not own data. Props on a tissue must be limited to `children`, ReactNode slot props, `params`, `searchParams`, icon types, or layout-variant literal unions. Any primitive (`string`/`number`/`boolean`), array type, or arbitrary domain type reference means the file is actually a cell \u2014 move it to cells/. That is lint-theater.2 (Tissue self-sufficiency rule)."
+      description: "A tissue may carry data, never state. Its props may not include a handler or setter (a function type, `Dispatch`, `SetStateAction`, `Function`, or a union holding one) \u2014 that is state coordinated through props, which makes the parent a cell \u2014 nor an undeclared type (`any`, `unknown`, `object`, `{}`, or a union holding one). Every declared data type is allowed: the route fetched it or the tissue above did, and the tissue hands it down (#9)."
     },
     messages: {
-      dataProp: "Tissue prop '{{prop}}' has type '{{type}}' which is not allowed on a tissue. Tissues arrange children without owning data. Move the file from features/*/tissues/ to features/*/cells/ \u2014 cells own data. Allowed tissue props: children, params, searchParams, ReactNode slots, literal-union variants, icon types, and number/boolean layout configuration with a literal default."
+      handler: "Tissue prop '{{prop}}' is {{type}}. A handler or setter is state coordinated through props \u2014 the parent that holds it is a cell, and a cell does not render a tissue. Move the handler into the cell this tissue arranges, or move this file to cells/.",
+      undeclared: "Tissue prop '{{prop}}' is typed '{{type}}', which declares nothing. A tissue hands data to typed children; declare the type the child takes. `any` is not a way past the tier wall."
     },
     schema: [],
     type: "problem"

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@geonosis/oxlint-plugin-biological-architecture",
-  "version": "2.9.0",
+  "version": "2.10.0",
   "types": "./dist/index.d.ts",
   "description": "Biological tier architecture as lint — the union of the dielime and during.day rule sets, shipped as presets.",
   "keywords": [
@@ -45,7 +45,7 @@
     "oxlint": ">=1.77"
   },
   "devDependencies": {
-    "@geonosis/lint-parity": "2.9.0"
+    "@geonosis/lint-parity": "2.10.0"
   },
   "engines": {
     "node": ">=22"

package/corpus/tissues/bad-data-props.tsx

@@ -1,5 +0,0 @@
-import { GoodCompound } from '../compounds/good-compound'
-
-export function BadDataProps({ title }: { title: string }) {
-  return <GoodCompound label={title} />
-}