@geonosis/oxlint-plugin-biological-architecture 2.8.0 → 2.9.0

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # @geonosis/oxlint-plugin-biological-architecture
 
+## 2.9.0
+
+### Minor Changes
+
+- e35392e: `tokens-only-colors` sees a colour that arrives as a default.
+  
+  `({ color = '#090909' })` is never written in a JSX attribute, so the rule's only visitor could not
+  see it: one kit carried the same hex in 72 components, under this rule, at `"error"`, for its whole
+  life. A bare word is still left alone — a default is as often `variant = 'primary'` as a colour.
+
 ## 2.8.0
 
 ### Minor Changes

package/corpus/tokens/bad-default-parameter-colour.tsx

@@ -0,0 +1,11 @@
+export const DefaultedIcon = ({
+  color = '#090909',
+  size = 24
+}: {
+  color?: string
+  size?: number
+}) => (
+  <svg width={size} height={size} viewBox="0 0 24 24">
+    <path d="M4 4h16v16H4z" fill={color} />
+  </svg>
+)

package/dist/index.js

@@ -6866,6 +6866,10 @@ var COLOR_UTILITIES = /* @__PURE__ */ new Set([
 var isColorUtility = (utility) => COLOR_UTILITIES.has(utility.replace(/^.*:/, ""));
 
 // src/rules/tokens-only-colors.ts
+var defaultedName = (node) => {
+  const left = node.left;
+  return left?.type === "Identifier" ? left.name ?? "default" : "default";
+};
 var tokenOffence = (value, prefixes, local) => {
   const variable = variableOf(value);
   if (variable !== void 0) {
@@ -6906,6 +6910,28 @@ var tokensOnlyColors = {
             report("colorLiteral", { property: utility, value: inner });
           }
         }
+      },
+      /**
+       * A colour that arrives as a DEFAULT — `({ color = '#090909' })` — is never written in a JSX
+       * attribute, so the visitor above cannot see it. It reaches the element through a prop and
+       * paints in the brand it was typed for, from the one place nobody looked: seventy-two icons
+       * in one kit carried the same hex this way, under this rule, at "error", for its whole life.
+       * A default is a value the component CHOOSES, which is exactly what a token is for.
+       *
+       * A bare word is left alone. `variant = 'primary'` and `size = 'small'` are defaults too, and
+       * a rule that read every English word as a colour would be turned off within the week.
+       */
+      AssignmentPattern(node) {
+        const right = node.right;
+        if (right?.type !== "Literal" || typeof right.value !== "string") return;
+        const offence = tokenOffence(right.value, prefixes, /* @__PURE__ */ new Set());
+        if (offence === void 0 || offence === "colorLiteral" && isNamedOnly(right.value))
+          return;
+        context.report({
+          data: { property: defaultedName(node), value: right.value },
+          messageId: offence,
+          node
+        });
       }
     };
   },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@geonosis/oxlint-plugin-biological-architecture",
-  "version": "2.8.0",
+  "version": "2.9.0",
   "types": "./dist/index.d.ts",
   "description": "Biological tier architecture as lint — the union of the dielime and during.day rule sets, shipped as presets.",
   "keywords": [
@@ -45,7 +45,7 @@
     "oxlint": ">=1.77"
   },
   "devDependencies": {
-    "@geonosis/lint-parity": "2.8.0"
+    "@geonosis/lint-parity": "2.9.0"
   },
   "engines": {
     "node": ">=22"