@geonosis/oxlint-plugin-biological-architecture 2.5.0 → 2.5.1

package/CHANGELOG.md

@@ -1,5 +1,7 @@
 # @geonosis/oxlint-plugin-biological-architecture
 
+## 2.5.1
+
 ## 2.5.0
 
 ## 2.4.3

package/dist/index.js

@@ -196,6 +196,33 @@ var walkNode = (node, visit) => {
     }
   }
 };
+var FUNCTION_BOUNDARY_TYPES = /* @__PURE__ */ new Set([
+  "ArrowFunctionExpression",
+  "FunctionDeclaration",
+  "FunctionExpression"
+]);
+var SKIPPED_KEYS = /* @__PURE__ */ new Set(["loc", "parent", "range", "scope"]);
+var walkOwnFunctionBody = (body, visit) => {
+  const visited = /* @__PURE__ */ new WeakSet();
+  const walk = (node) => {
+    if (node === null || typeof node !== "object" || visited.has(node)) return;
+    visited.add(node);
+    const record2 = node;
+    if (node !== body && typeof record2.type === "string" && FUNCTION_BOUNDARY_TYPES.has(record2.type)) {
+      return;
+    }
+    if (typeof record2.type === "string") visit(record2);
+    for (const [key, value] of Object.entries(record2)) {
+      if (SKIPPED_KEYS.has(key) || value === null || typeof value !== "object") continue;
+      if (Array.isArray(value)) {
+        for (const item of value) walk(item);
+      } else {
+        walk(value);
+      }
+    }
+  };
+  walk(body);
+};
 var propertyNameOf = (node) => {
   if (node.type !== "MemberExpression" || node.computed === true) return null;
   const property = node.property;
@@ -423,7 +450,22 @@ keeps inside its own body is its own business.`,
 var boundary_time_is_primitive_default = boundaryTimeIsPrimitive;
 
 // src/rules/cell-must-be-stateful.ts
-import * as fs from "fs";
+import * as fs2 from "fs";
+
+// src/rules/lib/reexports.ts
+import fs from "fs";
+function isReexportOnly(file) {
+  try {
+    const src = fs.readFileSync(file, "utf8").replaceAll(/\/\*[\s\S]*?\*\//g, "").replaceAll(/\/\/.*$/gm, "");
+    const hasReexport = /\bexport\b[^;]*\bfrom\b\s*['"]/.test(src);
+    const hasComponent = /\bfunction\b|=>|\breturn\b|<[A-Za-z]/.test(src);
+    return hasReexport && !hasComponent;
+  } catch {
+    return false;
+  }
+}
+
+// src/rules/cell-must-be-stateful.ts
 var STATE_SIGNATURE = /\buse[A-Z]\w*\s*\(|from\s+['"][^'"]*\/organelles(?:\/|['"])|from\s+['"][^'"]*\/stores?(?:\/|['"])|createContext\s*\(/;
 var SIBLING_SUFFIXES = [
   ".tsx",
@@ -438,22 +480,12 @@ var SIBLING_SUFFIXES = [
   ".steps.tsx"
 ];
 var PRIVATE_OR_NON_ENTRY = /\.(parts|sections|layouts|types|icons|sidebar|summary|form|data|steps|stories|test|spec)\.tsx$/;
-function isReexportOnly(file) {
-  try {
-    const src = fs.readFileSync(file, "utf8").replaceAll(/\/\*[\s\S]*?\*\//g, "").replaceAll(/\/\/.*$/gm, "");
-    const hasReexport = /\bexport\b[^;]*\bfrom\b\s*['"]/.test(src);
-    const hasComponent = /\bfunction\b|=>|\breturn\b|<[A-Za-z]/.test(src);
-    return hasReexport && !hasComponent;
-  } catch {
-    return false;
-  }
-}
 function familyHasState(mainFile) {
   const stem = mainFile.replace(/\.tsx$/, "");
   for (const suffix of SIBLING_SUFFIXES) {
     const file = stem + suffix;
     try {
-      if (fs.existsSync(file) && STATE_SIGNATURE.test(fs.readFileSync(file, "utf8"))) {
+      if (fs2.existsSync(file) && STATE_SIGNATURE.test(fs2.readFileSync(file, "utf8"))) {
         return true;
       }
     } catch {
@@ -1832,18 +1864,24 @@ Composing a stateful primitive makes the file a cell. \`export \u2026 from\` is
 });
 var molecule_atoms_only_default = moleculeAtomsOnly;
 
-// src/rules/molecule-must-compose.ts
-import fs2 from "fs";
-function isReexportOnly2(file) {
-  try {
-    const src = fs2.readFileSync(file, "utf8").replaceAll(/\/\*[\s\S]*?\*\//g, "").replaceAll(/\/\/.*$/gm, "");
-    const hasReexport = /\bexport\b[^;]*\bfrom\b\s*['"]/.test(src);
-    const hasComponent = /\bfunction\b|=>|\breturn\b|<[A-Za-z]/.test(src);
-    return hasReexport && !hasComponent;
-  } catch {
-    return false;
+// src/rules/lib/render-tracking.ts
+var rootTagNameOf = (name) => {
+  if (!name) return void 0;
+  if (name.type === "JSXIdentifier") return name.name;
+  if (name.type === "JSXMemberExpression") return name.object?.name;
+  return void 0;
+};
+var collectCompositionLocals = (node, isComposition, into) => {
+  if (node.importKind === "type") return;
+  if (!isComposition(node.source.value)) return;
+  for (const spec of node.specifiers ?? []) {
+    const localName = spec.local?.name;
+    if (localName) into.add(localName);
   }
-}
+};
+var rendersAnyOf = (locals, renderedTagNames) => [...locals].some((local) => renderedTagNames.has(local));
+
+// src/rules/molecule-must-compose.ts
 function isCompositionSource(src) {
   if (/\/(atoms|molecules)(\/|$)/.test(src)) return true;
   if (/^\.\/[^/]+$/.test(src)) return true;
@@ -1856,38 +1894,21 @@ var moleculeMustCompose = {
     const filename = context.filename;
     const isMolecule = /\/molecules\/(?!index\.)[^/]+\.tsx?$/.test(filename);
     if (!isMolecule) return {};
-    if (isReexportOnly2(filename)) return {};
+    if (isReexportOnly(filename)) return {};
     const bioImportLocals = /* @__PURE__ */ new Set();
     const renderedTagNames = /* @__PURE__ */ new Set();
     let programNode = null;
     return {
       ImportDeclaration(node) {
-        if (node.importKind === "type") return;
-        const source = node.source.value;
-        if (!isCompositionSource(source)) return;
-        for (const spec of node.specifiers ?? []) {
-          const localName = spec.local?.name;
-          if (localName) bioImportLocals.add(localName);
-        }
+        collectCompositionLocals(node, isCompositionSource, bioImportLocals);
       },
       JSXOpeningElement(node) {
-        const name = node.name;
-        if (!name) return;
-        if (name.type === "JSXIdentifier") {
-          const id = name;
-          if (id.name) renderedTagNames.add(id.name);
-        } else if (name.type === "JSXMemberExpression") {
-          const member = name;
-          const root = member.object?.name;
-          if (root) renderedTagNames.add(root);
-        }
+        const root = rootTagNameOf(node.name);
+        if (root) renderedTagNames.add(root);
       },
       "Program:exit"(node) {
         programNode = node;
-        const composesByRender = [...bioImportLocals].some(
-          (localName) => renderedTagNames.has(localName)
-        );
-        if (!composesByRender) {
+        if (!rendersAnyOf(bioImportLocals, renderedTagNames)) {
           const shortName = filename.split("/").pop() || filename;
           context.report({
             data: { filename: shortName },
@@ -2089,32 +2110,11 @@ var FALLBACK_BASENAMES = /* @__PURE__ */ new Set([
   "loading.tsx",
   "not-found.tsx"
 ]);
-var SKIP_KEYS = /* @__PURE__ */ new Set(["parent", "loc", "range", "scope"]);
 function collectReturnStatements(body) {
   const out = [];
-  const visited = /* @__PURE__ */ new WeakSet();
-  function walk(node) {
-    if (!node || typeof node !== "object") return;
-    if (visited.has(node)) return;
-    visited.add(node);
-    const n = node;
-    if (node !== body && (n.type === "FunctionDeclaration" || n.type === "FunctionExpression" || n.type === "ArrowFunctionExpression")) {
-      return;
-    }
-    if (n.type === "ReturnStatement") {
-      out.push(node);
-    }
-    for (const key of Object.keys(n)) {
-      if (SKIP_KEYS.has(key)) continue;
-      const v = n[key];
-      if (Array.isArray(v)) {
-        for (const item of v) walk(item);
-      } else if (v && typeof v === "object") {
-        walk(v);
-      }
-    }
-  }
-  walk(body);
+  walkOwnFunctionBody(body, (node) => {
+    if (node.type === "ReturnStatement") out.push(node);
+  });
   return out;
 }
 function tagOf(el) {
@@ -3978,37 +3978,13 @@ var ROUTE_BASENAMES = /* @__PURE__ */ new Set([
   "template.tsx"
 ]);
 var R3F_PACKAGES2 = /* @__PURE__ */ new Set(["@react-three/drei", "@react-three/fiber"]);
-var WALK_SKIP_KEYS = /* @__PURE__ */ new Set(["parent", "loc", "range", "scope"]);
 function functionHasHookCall(body) {
   let found = false;
-  const visited = /* @__PURE__ */ new WeakSet();
-  function walk(node) {
-    if (found) return;
-    if (!node || typeof node !== "object") return;
-    if (visited.has(node)) return;
-    visited.add(node);
-    const n = node;
-    if (n.type === "FunctionDeclaration" || n.type === "FunctionExpression" || n.type === "ArrowFunctionExpression") {
-      if (node !== body) return;
-    }
-    if (n.type === "CallExpression") {
-      const callee = n.callee;
-      if (callee?.type === "Identifier" && callee.name && /^use[A-Z]/.test(callee.name)) {
-        found = true;
-        return;
-      }
-    }
-    for (const key of Object.keys(n)) {
-      if (WALK_SKIP_KEYS.has(key)) continue;
-      const v = n[key];
-      if (Array.isArray(v)) {
-        for (const item of v) walk(item);
-      } else if (v && typeof v === "object") {
-        walk(v);
-      }
-    }
-  }
-  walk(body);
+  walkOwnFunctionBody(body, (node) => {
+    if (found || node.type !== "CallExpression") return;
+    const callee = node.callee;
+    if (callee?.type === "Identifier" && callee.name && /^use[A-Z]/.test(callee.name)) found = true;
+  });
   return found;
 }
 function hasMeaningfulChildren(el) {
@@ -6240,7 +6216,6 @@ export const clock = (): unknown => theClock
 var time_through_the_door_default = timeThroughTheDoor;
 
 // src/rules/tissue-must-compose.ts
-import fs4 from "fs";
 var COMPOSITION_PATTERNS = [
   // Tier segment with a trailing slash OR at the end of the specifier, so both
   // relative (`../cells/x`, `../../feature/cells/x`) and self-subpath feature
@@ -6254,16 +6229,6 @@ var COMPOSITION_PATTERNS = [
   // real composition, not lint-theater.
   /\.(parts|sections|layouts)$/
 ];
-function isReexportOnly3(file) {
-  try {
-    const src = fs4.readFileSync(file, "utf8").replaceAll(/\/\*[\s\S]*?\*\//g, "").replaceAll(/\/\/.*$/gm, "");
-    const hasReexport = /\bexport\b[^;]*\bfrom\b\s*['"]/.test(src);
-    const hasComponent = /\bfunction\b|=>|\breturn\b|<[A-Za-z]/.test(src);
-    return hasReexport && !hasComponent;
-  } catch {
-    return false;
-  }
-}
 var APP_ROUTE_MUST_COMPOSE = /* @__PURE__ */ new Set(["page.tsx", "layout.tsx", "template.tsx"]);
 var APP_ROUTE_FALLBACKS = /* @__PURE__ */ new Set([
   "default.tsx",
@@ -6292,7 +6257,7 @@ var tissueMustCompose = {
     const isAppFallback = /\/app\//.test(normalized) && APP_ROUTE_FALLBACKS.has(basename);
     if (isAppFallback) return {};
     if (!isTissue && !isAppRouteFile) return {};
-    if (isReexportOnly3(filename)) return {};
+    if (isReexportOnly(filename)) return {};
     const bioImportLocals = /* @__PURE__ */ new Set();
     const renderedTagNames = /* @__PURE__ */ new Set();
     let hasMetadataExport = false;
@@ -6316,25 +6281,15 @@ var tissueMustCompose = {
         }
       },
       ImportDeclaration(node) {
-        if (node.importKind === "type") return;
-        const source = node.source.value;
-        if (!COMPOSITION_PATTERNS.some((pattern) => pattern.test(source))) return;
-        for (const spec of node.specifiers ?? []) {
-          const localName = spec.local?.name;
-          if (localName) bioImportLocals.add(localName);
-        }
+        collectCompositionLocals(
+          node,
+          (source) => COMPOSITION_PATTERNS.some((pattern) => pattern.test(source)),
+          bioImportLocals
+        );
       },
       JSXOpeningElement(node) {
-        const name = node.name;
-        if (!name) return;
-        if (name.type === "JSXIdentifier") {
-          const id = name;
-          if (id.name) renderedTagNames.add(id.name);
-        } else if (name.type === "JSXMemberExpression") {
-          const member = name;
-          const root = member.object?.name;
-          if (root) renderedTagNames.add(root);
-        }
+        const root = rootTagNameOf(node.name);
+        if (root) renderedTagNames.add(root);
       },
       "Program:exit"(node) {
         programNode = node;
@@ -6345,10 +6300,7 @@ var tissueMustCompose = {
         if (basename === "page.tsx" && isTrulyEmpty) {
           return;
         }
-        const composesByRender = [...bioImportLocals].some(
-          (localName) => renderedTagNames.has(localName)
-        );
-        if (!composesByRender) {
+        if (!rendersAnyOf(bioImportLocals, renderedTagNames)) {
           const shortName = normalized.split("/").pop() || normalized;
           const reason = bioImportLocals.size === 0 ? "noBioImports" : "bioImportedButNotRendered";
           context.report({

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@geonosis/oxlint-plugin-biological-architecture",
-  "version": "2.5.0",
+  "version": "2.5.1",
   "types": "./dist/index.d.ts",
   "description": "Biological tier architecture as lint — the union of the dielime and during.day rule sets, shipped as presets.",
   "keywords": [
@@ -45,7 +45,7 @@
     "oxlint": ">=1.77"
   },
   "devDependencies": {
-    "@geonosis/lint-parity": "2.5.0"
+    "@geonosis/lint-parity": "2.5.1"
   },
   "engines": {
     "node": ">=22"