@geonosis/oxlint-plugin-biological-architecture 0.4.0 → 0.5.0

package/README.md

@@ -135,6 +135,7 @@ months. Carry these across, or turn the rule off:
 | --- | --- | --- |
 | `no-brand-names` | `{ brands, allowedSubstrings }` | refuses the run |
 | `organelle-dependency` | `{ sharedFeatures }` | only `shared` crosses a feature boundary |
+| `cell-no-cross-feature-organelles` | `{ sharedFeatures }` | only `shared` crosses a feature boundary |
 | `documents-share-one-table` | `{ perKindTables }` | refuses the run |
 | `document-sagas-are-generic` | `{ perKindPrefixes }` | refuses the run |
 | `step-opens-its-own-cell` | `{ engine, within, wrapper }` | refuses the run |
@@ -153,6 +154,39 @@ Two more facts a fork's config will trip on:
   namespace is the plugin's identity, not the package's, so renaming or re-scoping the package does
   not rename a single rule id in a single consumer config.
 
+### Last step of every bump — verify the loaded version, per workspace
+
+**Declared is not loaded.** oxlint resolves a `jsPlugins` specifier from the CONFIG FILE's
+directory, so a nested `apps/<ws>/node_modules/@geonosis/…` left behind at the old version means
+oxlint runs the OLD plugin while every `package.json` and the lockfile say the new one. bun leaves
+a nested copy when a per-workspace `bun add` runs and the root already has one; one consumer measured
+a whole bug report against 0.3.0 that way, on a repo pinned to 0.4.0.
+
+The check that is true on every package manager is the one that asks the resolver, from **each
+workspace directory** — this is what oxlint would load:
+
+```bash
+node --input-type=module -e \
+  'const p = (await import("@geonosis/oxlint-plugin-biological-architecture")).default; console.log(p.meta.version)'
+```
+
+It must print the pinned version. Every published version of this plugin carries `meta.version`, so
+there is no version of it this check cannot read.
+
+Then find the stray copy, and mind that the answer is package-manager-specific:
+
+- **bun / npm** — real directories, so counting them is meaningful:
+  ```bash
+  find . -path "*@geonosis/oxlint-plugin-biological-architecture/package.json" -not -path "*/.git/*"
+  ```
+  More than one is the bug. Fix with
+  `rm -rf apps/*/node_modules/@geonosis packages/*/node_modules/@geonosis && bun install` — no flags,
+  and never `--ignore-scripts` over the whole tree.
+- **pnpm** — `node_modules/@geonosis/*` are SYMLINKS into `.pnpm/`, which keeps every version ever
+  installed. The same `find` answers 7 on a tree that is perfectly correct, and 0 if you exclude
+  `.pnpm`. Read the links instead: `ls -l node_modules/@geonosis` in each workspace, and check the
+  version in the target path.
+
 ## Where to read on
 
 - `RULES.md` — every rule, its preset, which source tree it came from, and how each divergence was

package/corpus/.oxlintrc.json

@@ -11,6 +11,14 @@
     "biological-architecture/atom-no-deps": "error",
     "biological-architecture/cell-must-be-stateful": "error",
     "biological-architecture/cell-must-not-compose-cell": "error",
+    "biological-architecture/cell-no-cross-feature-organelles": [
+      "error",
+      {
+        "sharedFeatures": [
+          "shared"
+        ]
+      }
+    ],
     "biological-architecture/cell-no-tissues": "error",
     "biological-architecture/cells-folder-index-is-barrel": "error",
     "biological-architecture/compound-must-be-stateless": "error",

package/corpus/atoms/bad-aliased-import.tsx

@@ -0,0 +1,4 @@
+// The same breach through the bundler alias — the spelling the corpus never carried for this rule.
+import { Field } from '@kit/ui/molecules/field'
+
+export const BadAliasedImport = Field

package/corpus/atoms/nested/bad-relative-climb.tsx

@@ -0,0 +1,4 @@
+// A climb, not a sibling: the source names the tier only two directories up.
+import { Field } from '../../molecules/field'
+
+export const BadRelativeClimb = Field

package/corpus/features/invoice/cells/bad-aliased-cross-feature-cell.tsx

@@ -0,0 +1,3 @@
+import { BillingEditor } from '@/features/billing/cells/billing-editor'
+
+export const BadAliasedCrossFeatureCell = BillingEditor

package/corpus/features/invoice/cells/bad-aliased-cross-feature-organelle.tsx

@@ -0,0 +1,11 @@
+// The same breach spelled through the bundler alias. Where the import LANDS is the fact; the two
+// spellings must read alike.
+import { useState } from 'react'
+
+import { BillingTotals } from '@/features/billing/organelles/billing-totals'
+
+export function BadAliasedCrossFeatureOrganelle() {
+  const [open] = useState(false)
+
+  return <section>{open ? <BillingTotals /> : null}</section>
+}

package/corpus/features/invoice/cells/bad-aliased-cross-feature-tissue.tsx

@@ -0,0 +1,3 @@
+import { BillingPage } from '@/features/billing/tissues/billing-page'
+
+export const BadAliasedCrossFeatureTissue = BillingPage

package/corpus/features/invoice/cells/bad-relative-cross-feature-cell.tsx

@@ -0,0 +1,3 @@
+import { BillingEditor } from '../../billing/cells/billing-editor'
+
+export const BadRelativeCrossFeatureCell = BillingEditor

package/corpus/features/invoice/cells/bad-relative-cross-feature-organelle.tsx

@@ -0,0 +1,12 @@
+// A cell climbing out of its feature into ANOTHER feature's organelle — the state compartment of a
+// feature this one does not own. organelle-dependency polices organelles/ and no-cross-feature-stores
+// polices stores, so until cell-no-cross-feature-organelles nothing here fired at all.
+import { useState } from 'react'
+
+import { BillingTotals } from '../../billing/organelles/billing-totals'
+
+export function BadRelativeCrossFeatureOrganelle() {
+  const [open] = useState(false)
+
+  return <section>{open ? <BillingTotals /> : null}</section>
+}

package/corpus/features/invoice/cells/bad-relative-cross-feature-tissue.tsx

@@ -0,0 +1,3 @@
+import { BillingPage } from '../../billing/tissues/billing-page'
+
+export const BadRelativeCrossFeatureTissue = BillingPage

package/corpus/features/invoice/cells/good-own-organelle.tsx

@@ -0,0 +1,10 @@
+// A cell hosting its OWN feature's organelle — the whole point of a cell.
+import { useState } from 'react'
+
+import { InvoiceLines } from '../organelles/invoice-lines'
+
+export function GoodOwnOrganelle() {
+  const [open] = useState(false)
+
+  return <section>{open ? <InvoiceLines /> : null}</section>
+}

package/corpus/features/invoice/cells/good-shared-organelle.tsx

@@ -0,0 +1,10 @@
+// The shared feature is infrastructure every feature may read, which is what sharedFeatures names.
+import { useState } from 'react'
+
+import { SaveIndicator } from '@/features/shared/organelles/save-indicator'
+
+export function GoodSharedOrganelle() {
+  const [open] = useState(false)
+
+  return <section>{open ? <SaveIndicator /> : null}</section>
+}

package/corpus/features/invoice/compounds/bad-aliased-cross-feature-store.tsx

@@ -0,0 +1,3 @@
+import { useBillingStore } from '@/features/billing/stores/billing-store'
+
+export const BadAliasedCrossFeatureStore = useBillingStore

package/corpus/features/invoice/compounds/bad-relative-cross-feature-store.tsx

@@ -0,0 +1,5 @@
+// A compound climbing into another feature's store. The string names no feature until it is
+// resolved against this file.
+import { useBillingStore } from '../../billing/stores/billing-store'
+
+export const BadRelativeCrossFeatureStore = useBillingStore

package/corpus/features/invoice/organelles/bad-aliased-cross-feature-organelle.tsx

@@ -0,0 +1,10 @@
+// The aliased twin of bad-relative-cross-feature-organelle.tsx: one breach, two spellings.
+import { BillingTotals } from '@/features/billing/organelles/billing-totals'
+
+export function BadAliasedCrossFeatureOrganelle() {
+  return (
+    <section>
+      <BillingTotals />
+    </section>
+  )
+}

package/corpus/features/invoice/tissues/bad-aliased-cross-feature-organelle.tsx

@@ -0,0 +1,3 @@
+import { BillingTotals } from '@/features/billing/organelles/billing-totals'
+
+export const BadAliasedCrossFeatureOrganelle = BillingTotals

package/corpus/features/invoice/tissues/bad-aliased-cross-feature-store.tsx

@@ -0,0 +1,3 @@
+import { useBillingStore } from '@/features/billing/stores/billing-store'
+
+export const BadAliasedCrossFeatureStore = useBillingStore

package/corpus/features/invoice/tissues/bad-relative-cross-feature-organelle.tsx

@@ -0,0 +1,3 @@
+import { BillingTotals } from '../../billing/organelles/billing-totals'
+
+export const BadRelativeCrossFeatureOrganelle = BillingTotals

package/corpus/features/invoice/tissues/bad-relative-cross-feature-store.tsx

@@ -0,0 +1,3 @@
+import { useBillingStore } from '../../billing/stores/billing-store'
+
+export const BadRelativeCrossFeatureStore = useBillingStore

package/corpus/manifest.json

@@ -4,6 +4,7 @@
     "biological-architecture/atom-no-deps",
     "biological-architecture/cell-must-be-stateful",
     "biological-architecture/cell-must-not-compose-cell",
+    "biological-architecture/cell-no-cross-feature-organelles",
     "biological-architecture/cell-no-tissues",
     "biological-architecture/cells-folder-index-is-barrel",
     "biological-architecture/compound-must-be-stateless",

package/corpus/molecules/bad-aliased-cell-import.tsx

@@ -0,0 +1,3 @@
+import { ProductCell } from '@kit/ui/cells/product'
+
+export const BadAliasedCellImport = ProductCell

package/corpus/molecules/nested/bad-relative-climb.tsx

@@ -0,0 +1,3 @@
+import { ProductCell } from '../../cells/product'
+
+export const BadRelativeClimb = ProductCell

package/dist/{chunk-55NK7NJN.js → chunk-RQQKQPIU.js}

@@ -3,6 +3,7 @@ var FRONTEND = [
   "atom-no-deps",
   "cell-must-be-stateful",
   "cell-must-not-compose-cell",
+  "cell-no-cross-feature-organelles",
   "cell-no-tissues",
   "cells-folder-index-is-barrel",
   "compound-must-be-stateless",

package/dist/index.js

@@ -1,7 +1,7 @@
 import {
   PRESETS,
   rulesOfPreset
-} from "./chunk-55NK7NJN.js";
+} from "./chunk-RQQKQPIU.js";
 
 // src/index.ts
 import { createRequire } from "module";
@@ -271,6 +271,45 @@ siblings is the shape \`cells-folder-index-is-barrel\` requires of them.`,
 });
 var cell_must_not_compose_cell_default = cellMustNotComposeCell;
 
+// src/rules/cell-no-cross-feature-organelles.ts
+var DEFAULT_SHARED_FEATURES = ["shared"];
+var FEATURE_ORGANELLE = /features\/([^/]+)\/organelles\//;
+var organelleFeatureOf = (path2) => FEATURE_ORGANELLE.exec(path2)?.[1];
+var cellNoCrossFeatureOrganelles = directionRule({
+  data: (target, importer) => ({
+    file: importer.file,
+    importedFeature: organelleFeatureOf(target.path) ?? "",
+    ownFeature: importer.feature ?? "",
+    source: target.source
+  }),
+  description: "Cells must not import another feature's organelles. An organelle is a feature's own state compartment; a cell in features/X/ hosts features/X/organelles/* and the features named in sharedFeatures (default: shared). Another feature's state arrives as props from the tissue above.",
+  fixShape: `A cell hosts its OWN feature's organelles. Another feature's organelle is that feature's state
+compartment, and a cell that imports one couples two features through a hook instead of through
+props \u2014 take the value as a prop and let the tissue above arrange both, or move the organelle into a
+feature every cell may read (the rule's \`sharedFeatures\` option, default \`shared\`). Relative and
+aliased sources are judged alike: \`../../billing/organelles/totals\` lands where
+\`@/features/billing/organelles/totals\` lands. Type-only imports are exempt; \`export \u2026 from\` is not.`,
+  forbidden: (target, importer, options) => {
+    const importedFeature = organelleFeatureOf(target.path);
+    return importedFeature !== void 0 && importedFeature !== importer.feature && !new Set(options.sharedFeatures ?? DEFAULT_SHARED_FEATURES).has(importedFeature);
+  },
+  messages: {
+    forbidden: `Cell "{{file}}" in feature "{{ownFeature}}" imports "{{source}}", an organelle of feature "{{importedFeature}}". A cell hosts its own feature's organelles; another feature's state arrives as props from the tissue above. Only features/{{ownFeature}}/organelles/* and the shared features are allowed here.`
+  },
+  optionsFrom: (raw) => raw ?? {},
+  scope: "cells",
+  schema: [
+    {
+      additionalProperties: false,
+      properties: {
+        sharedFeatures: { items: { type: "string" }, type: "array" }
+      },
+      type: "object"
+    }
+  ]
+});
+var cell_no_cross_feature_organelles_default = cellNoCrossFeatureOrganelles;
+
 // src/rules/cell-no-tissues.ts
 var HIGHER_LEVEL_PATTERNS = [
   /(?:features\/[^/]+\/)?tissues\//,
@@ -2622,7 +2661,7 @@ the engine that catches it is not a port and is unaffected.`,
 var no_void_port_default = noVoidPort;
 
 // src/rules/organelle-dependency.ts
-var DEFAULT_SHARED_FEATURES = ["shared"];
+var DEFAULT_SHARED_FEATURES2 = ["shared"];
 var ABOVE_AN_ORGANELLE = [
   /\/cells\//,
   /\/tissues\//,
@@ -2640,7 +2679,7 @@ Cross-feature organelle imports are allowed only from the features named in the
   forbidden: (target, importer, options) => {
     if (ABOVE_AN_ORGANELLE.some((pattern) => pattern.test(target.path))) return true;
     const importedFeature = CROSS_FEATURE_ORGANELLE.exec(target.path)?.[1];
-    return importedFeature !== void 0 && importedFeature !== importer.feature && !new Set(options.sharedFeatures ?? DEFAULT_SHARED_FEATURES).has(importedFeature);
+    return importedFeature !== void 0 && importedFeature !== importer.feature && !new Set(options.sharedFeatures ?? DEFAULT_SHARED_FEATURES2).has(importedFeature);
   },
   messages: {
     forbidden: 'Organelle "{{file}}" cannot import from "{{source}}". Organelles may depend on atoms, molecules, compounds, stores, domains, and sub-organelles (same feature or shared/document/charts).'
@@ -3871,6 +3910,7 @@ var rules = {
   "atom-no-deps": atom_no_deps_default,
   "cell-must-be-stateful": cell_must_be_stateful_default,
   "cell-must-not-compose-cell": cell_must_not_compose_cell_default,
+  "cell-no-cross-feature-organelles": cell_no_cross_feature_organelles_default,
   "cell-no-tissues": cell_no_tissues_default,
   "cells-folder-index-is-barrel": cells_folder_index_is_barrel_default,
   "compound-must-be-stateless": compound_must_be_stateless_default,

package/dist/presets.js

@@ -1,7 +1,7 @@
 import {
   PRESETS,
   rulesOfPreset
-} from "./chunk-55NK7NJN.js";
+} from "./chunk-RQQKQPIU.js";
 export {
   PRESETS,
   rulesOfPreset

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@geonosis/oxlint-plugin-biological-architecture",
-  "version": "0.4.0",
+  "version": "0.5.0",
   "description": "Biological tier architecture as lint — the union of the dielime and during.day rule sets, shipped as presets.",
   "keywords": [
     "oxlint",
@@ -33,7 +33,7 @@
     "oxlint": ">=1.77"
   },
   "devDependencies": {
-    "@geonosis/lint-parity": "0.4.0"
+    "@geonosis/lint-parity": "0.5.0"
   },
   "engines": {
     "node": ">=22"