@geonosis/lint-parity 2.9.0 → 2.10.0

package/CHANGELOG.md

@@ -1,5 +1,16 @@
 # @geonosis/lint-parity
 
+## 2.10.0
+
+### Patch Changes
+
+- 3863c79: `--expect-changed` sees a rule whose findings moved, not only one whose count changed.
+  
+  The corpus claim compared per-rule finding counts, so a rule rewritten to fire twice in new places
+  where it used to fire twice in old ones read as unchanged and the claim was reported unproven. It
+  now compares where each rule fired — `path:line:col`, without the message, so a reworded finding is
+  still the same finding.
+
 ## 2.9.0
 
 ## 2.8.0

package/dist/{chunk-OQSXP7ZK.js → chunk-DFAXDNDR.js}

@@ -148,6 +148,7 @@ ${output.trim()}`);
   }
   return findings;
 };
+var PLACE = /^(.+?:\d+:\d+):/;
 var UNATTRIBUTED = "(unattributed)";
 var ruleOf = (line) => RULE_IN_LINE.exec(line)?.[1] ?? UNATTRIBUTED;
 var asFile = (lines) => lines.length === 0 ? "" : `${lines.join("\n")}
@@ -333,7 +334,7 @@ var corpusOf = ({
   const root = mkdtempSync(join2(tmpdir(), "geonosis-corpus-"));
   const here = join2(root, "corpus");
   const foundIn = (config, side) => {
-    const counts = /* @__PURE__ */ new Map();
+    const places = /* @__PURE__ */ new Map();
     for (const finding of readRun(
       lint({
         config,
@@ -346,9 +347,10 @@ var corpusOf = ({
       side
     )) {
       const rule = ruleIdOf(finding);
-      counts.set(rule, (counts.get(rule) ?? 0) + 1);
+      const place = PLACE.exec(finding)?.[1] ?? finding;
+      places.set(rule, [...places.get(rule) ?? [], place]);
     }
-    return counts;
+    return places;
   };
   let inA = /* @__PURE__ */ new Map();
   let inB = /* @__PURE__ */ new Map();
@@ -362,10 +364,12 @@ var corpusOf = ({
   const configured = [.../* @__PURE__ */ new Set([...rulesNamedBy(configA), ...rulesNamedBy(configB)])].toSorted();
   const off = [.../* @__PURE__ */ new Set([...rulesTurnedOffBy(configA), ...rulesTurnedOffBy(configB)])].filter((rule) => !configured.includes(rule)).toSorted();
   const reach = configured.filter((rule) => exercised.has(rule)).map((rule) => {
-    const foundInA = inA.get(rule) ?? 0;
-    const foundInB = inB.get(rule) ?? 0;
+    const placesA = (inA.get(rule) ?? []).toSorted();
+    const placesB = (inB.get(rule) ?? []).toSorted();
+    const foundInA = placesA.length;
+    const foundInB = placesB.length;
     return {
-      changed: foundInA !== foundInB,
+      changed: placesA.join("\n") !== placesB.join("\n"),
       firedInA: foundInA > 0,
       firedInB: foundInB > 0,
       foundInA,

package/dist/index.d.ts

@@ -59,8 +59,9 @@ declare const formatSummary: (parity: Parity) => string;
 type RuleReach = {
     /**
      * The corpus saw this rule behave differently under the two configs — it started firing, stopped
-     * firing, or fired a different number of times. What a release CLAIMS about a rule is checked
-     * against this, and nothing else.
+     * firing, or fired in a different set of places. A PLACE, not a count: #9 rewrote a rule that fired
+     * twice on the base build and twice on the new one, on files with nothing in common, and comparing
+     * counts read that as untouched. What a release CLAIMS about a rule is checked against this.
      */
     changed: boolean;
     firedInA: boolean;

package/dist/index.js

@@ -17,7 +17,7 @@ import {
   ruleIdOf,
   rulesNamedBy,
   rulesTurnedOffBy
-} from "./chunk-OQSXP7ZK.js";
+} from "./chunk-DFAXDNDR.js";
 export {
   MANIFEST_FILE,
   ParityError,

package/dist/parity-cli.js

@@ -9,7 +9,7 @@ import {
   parseParityArgs,
   resolveOxlint,
   writeEnvelope
-} from "./chunk-OQSXP7ZK.js";
+} from "./chunk-DFAXDNDR.js";
 
 // src/parity-cli.ts
 import { mkdirSync, writeFileSync } from "fs";

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@geonosis/lint-parity",
-  "version": "2.9.0",
+  "version": "2.10.0",
   "types": "./dist/index.d.ts",
   "description": "Findings parity and rule reach over any two oxlint configs — the diff a fork is deleted on.",
   "keywords": [
@@ -45,7 +45,7 @@
     "access": "public"
   },
   "devDependencies": {
-    "@geonosis/ratchet": "2.9.0"
+    "@geonosis/ratchet": "2.10.0"
   },
   "scripts": {
     "build": "tsup",