@geonosis/doctor 2.6.0 → 2.7.0

package/CHANGELOG.md

@@ -1,5 +1,35 @@
 # @geonosis/doctor
 
+## 2.7.0
+
+### Minor Changes
+
+- d90986b: A twelfth question: `seams`. Every glob `adoption.seams` declares has to name a file in the tree
+  (never one under node_modules); one that names nothing is a WARN per glob saying to drop it or
+  name the file that replaced it, no `adoption.seams` at all is a SKIP by name, and a full set is
+  one OK line with the count. `geonosis update` measures a floor's adoption by exactly those files,
+  and during.day carried three dead globs of eight for a month while every bump report read
+  `0 deleted, 0 added` over them. `--only seams` runs it alone.
+
+### Patch Changes
+
+- 7ee2097: `FLOOR_PACKAGES` names `@geonosis/buketi-ui`, the first package on the `kits/*` floor, so the doctor's
+  floor lines ask about it the way they ask about every other publishable floor.
+- c01ea60: The `exercised` check knows a retired rule. A plugin may keep a rule's id resolvable after retiring
+  it — `meta.retired` — so a config that still names it parses; judged as a live rule it read as "not
+  exported" or "never fires", a FAIL against a tree whose only fault is a block the kit made stale.
+  The id is now set aside before the judging, and every verdict names it with the way out: it reports
+  nothing, goes at the next major, remove it from this config. A verdict that would have been OK or
+  SKIP is a WARN while any such id is still named.
+- Updated dependencies [c13ade8]
+  - @geonosis/lint-parity@2.7.0
+
+## 2.6.1
+
+### Patch Changes
+
+- @geonosis/lint-parity@2.6.1
+
 ## 2.6.0
 
 ### Patch Changes

package/README.md

@@ -387,3 +387,16 @@ consumer wrote. It depends on `@geonosis/lint-parity` for the reach engine and o
 the kit's own `layer-walls` config holds every one of those walls.
 
 Apache-2.0.
+
+### `seams` — a declared seam that names nothing
+
+`adoption.seams` in `geonosis.json` is what `geonosis update` measures a floor's adoption by:
+lines deleted against lines added in the files a consumer says hold a floor's shape. A glob whose
+file was deleted and never undeclared measures nothing, and every bump report reads `0 deleted,
+0 added` over it — during.day carried three of eight that way for a month.
+
+| Seen                                            | Line                                                |
+| ----------------------------------------------- | --------------------------------------------------- |
+| no `adoption.seams`                             | **SKIP**, naming the key                            |
+| every glob names a file (never in node_modules) | **OK**, with the count                              |
+| a glob names no file                            | **WARN** per glob, saying to drop or replace it      |

package/dist/{chunk-6ERJOIZS.js → chunk-WUFVAO7G.js}

@@ -113,7 +113,8 @@ var CHECKS = [
   "observability",
   "deployed",
   "rails",
-  "exams"
+  "exams",
+  "seams"
 ];
 var findingMaker = (check) => (subject, verdict, message) => ({
   check,
@@ -461,6 +462,12 @@ var probesOf = async (entry, plugin) => {
     })
   );
 };
+var retiredOf = async (entry, plugin) => {
+  const loaded = await import(pathToFileURL(entry).href);
+  return new Set(
+    Object.entries(loaded.default?.rules ?? {}).filter(([, rule]) => typeof rule?.meta?.retired === "object" && rule.meta.retired !== null).map(([name]) => `${plugin}/${name}`)
+  );
+};
 var grantsOf = async (entry) => {
   const loaded = await import(pathToFileURL(entry).href);
   const plugin = loaded.default?.meta?.name ?? "";
@@ -1245,6 +1252,7 @@ var OBSERVABILITY = "@geonosis/observability";
 var COMPOSITION_ROOT = "src/platform.ts";
 var FLOOR_PACKAGES = [
   "@geonosis/assistant",
+  "@geonosis/buketi-ui",
   "@geonosis/conformance",
   "@geonosis/db",
   "@geonosis/document",
@@ -1629,6 +1637,7 @@ var reasonFrom = (config, oxlint) => {
   }
 };
 var named = (rules) => rules.join(", ");
+var retiredNote = (rules) => rules.length === 1 ? `${rules[0]} is retired by the plugin \u2014 it reports nothing and goes at the next major, so remove it from this config` : `${named(rules)} are retired by the plugin \u2014 they report nothing and go at the next major, so remove them from this config`;
 var countOf = (rules, verb) => rules.length === 1 ? `1 enabled rule ${verb}s` : `${rules.length} enabled rules ${verb}`;
 var ownReach = ({
   config,
@@ -1790,7 +1799,12 @@ var checkExercised = async ({
   repoCorpus,
   root
 }) => {
-  const said2 = (verdict, message) => finding5(config.relative, verdict, message);
+  let retired = [];
+  const said2 = (verdict, message) => retired.length === 0 ? finding5(config.relative, verdict, message) : finding5(
+    config.relative,
+    verdict === "OK" || verdict === "SKIP" ? "WARN" : verdict,
+    `${message}; ${retiredNote(retired)}`
+  );
   if (repoCorpus !== void 0 && !existsSync7(repoCorpus)) {
     return said2(
       "FAIL",
@@ -1809,8 +1823,13 @@ var checkExercised = async ({
   } catch (error) {
     return said2("SKIP", refusal(error));
   }
-  const enabled = enabledHere(config, manifest.plugin);
-  if (enabled.length === 0) return said2("SKIP", `no ${manifest.plugin} rule is enabled here`);
+  const configured2 = enabledHere(config, manifest.plugin);
+  const retiredIds = entry === void 0 ? /* @__PURE__ */ new Set() : await retiredOf(entry, manifest.plugin).catch(() => /* @__PURE__ */ new Set());
+  retired = configured2.filter((rule) => retiredIds.has(rule));
+  const enabled = configured2.filter((rule) => !retiredIds.has(rule));
+  if (enabled.length === 0) {
+    return retired.length === 0 ? said2("SKIP", `no ${manifest.plugin} rule is enabled here`) : said2("WARN", `nothing enabled here is a live ${manifest.plugin} rule`);
+  }
   let reach;
   try {
     reach = corpusOf({ configA: config.path, configB: config.path, corpus, oxlint }).reach;
@@ -2679,7 +2698,7 @@ var checkRunner = ({
 
 // src/doctor.ts
 import { homedir as homedir3 } from "os";
-import { join as join17 } from "path";
+import { join as join18 } from "path";
 import { resolveOxlint } from "@geonosis/lint-parity";
 
 // src/engine.ts
@@ -3000,6 +3019,46 @@ var checkRequiredOptions = async ({
   ];
 };
 
+// src/seams.ts
+import { existsSync as existsSync13, globSync, readFileSync as readFileSync16 } from "fs";
+import { join as join17 } from "path";
+var CONFIG = "geonosis.json";
+var finding12 = findingMaker("seams");
+var NO_SEAMS = `${CONFIG} declares no adoption.seams \u2014 nothing here says which files hold a floor's shape, so no bump can measure what it deleted; declare them when a floor is adopted`;
+var declaredSeams = (root) => {
+  const at = join17(root, CONFIG);
+  if (!existsSync13(at)) return void 0;
+  let parsed;
+  try {
+    parsed = JSON.parse(readFileSync16(at, "utf8"));
+  } catch {
+    return void 0;
+  }
+  const seams = parsed.adoption?.seams;
+  return Array.isArray(seams) ? seams.filter((one) => typeof one === "string") : void 0;
+};
+var namesAFile = (root, glob) => globSync(glob, {
+  cwd: root,
+  exclude: (name) => name === "node_modules" || name.startsWith("node_modules/")
+}).length > 0;
+var checkSeams = ({ root }) => {
+  const seams = declaredSeams(root);
+  if (seams === void 0 || seams.length === 0) return [finding12(CONFIG, "SKIP", NO_SEAMS)];
+  const dead = seams.filter((glob) => !namesAFile(root, glob)).toSorted();
+  if (dead.length === 0) {
+    return [
+      finding12(CONFIG, "OK", `adoption.seams: ${seams.length} seam glob(s), every one names a file`)
+    ];
+  }
+  return dead.map(
+    (glob) => finding12(
+      glob,
+      "WARN",
+      `names no file in this tree, so the seam measures nothing and every bump reads 0 deleted, 0 added over it. Next: take it out of adoption.seams in ${CONFIG}, or name the file that replaced it`
+    )
+  );
+};
+
 // src/doctor.ts
 var exercisedOf = ({
   configs,
@@ -3135,8 +3194,9 @@ var runDoctor = async ({
     ["observability", () => checkObservability({ now: Date.now(), root })],
     ["drift", () => checkDrift({ root, workspaces })],
     ["deployed", () => checkDeployed({ root })],
-    ["rails", () => checkRails({ root, userSettings: join17(home, USER_SETTINGS) })],
-    ["exams", () => checkExams({ root, workspaces })]
+    ["rails", () => checkRails({ root, userSettings: join18(home, USER_SETTINGS) })],
+    ["exams", () => checkExams({ root, workspaces })],
+    ["seams", () => checkSeams({ root })]
   ];
   const collected = [];
   const ran = [];
@@ -3163,6 +3223,7 @@ var ABOUT = {
   drift: "the gates that were set up and are no longer running",
   envelope: "every gate read as many things as it was handed",
   exams: "every adopted floor has a test file that runs its exam",
+  seams: "the seam globs adoption.seams declares each name a file",
   exercised: "every enabled rule fires on at least one corpus file",
   group: "the packages published on one version resolve to one version",
   loaded: "the plugin oxlint would load is the one the manifest pins",

package/dist/doctor-cli.js

@@ -4,7 +4,7 @@ import {
   formatDoctor,
   formatJson,
   runDoctor
-} from "./chunk-6ERJOIZS.js";
+} from "./chunk-WUFVAO7G.js";
 
 // src/doctor-cli.ts
 import { fstatSync, statSync } from "fs";
@@ -135,6 +135,9 @@ var ABOUT = {
               installed floor's own declarations \u2014 every export ending in Conformance \u2014 never off a
               list held here. WARNs, because a floor adopted last week and one whose exam somebody
               deleted look the same from outside.`,
+  seams: `The seam globs adoption.seams declares each name a file. A glob whose file was deleted and
+              never undeclared measures nothing \u2014 every bump reads 0 deleted, 0 added over it \u2014 and a
+              floor's adoption is measured by exactly those files.`,
   exercised: `Every rule a config enables, against the corpus the loaded plugin ships. A rule at
               "error" that can never fire is indistinguishable from a clean tree. The line says what
               its number is evidence ABOUT \u2014 the corpus and the probes, never this tree \u2014 and a rule

package/dist/index.d.ts

@@ -11,7 +11,7 @@ type Overrides = {
  * question one layer out — whether what was reported is what happened; `rails` asks it of the
  * settings an unattended run is bounded by, where a rendered file is not a loaded setting.
  */
-declare const CHECKS: readonly ["loaded", "group", "exercised", "baseline", "runner", "envelope", "drift", "observability", "deployed", "rails", "exams"];
+declare const CHECKS: readonly ["loaded", "group", "exercised", "baseline", "runner", "envelope", "drift", "observability", "deployed", "rails", "exams", "seams"];
 type CheckName = (typeof CHECKS)[number];
 /**
  * `SKIP` is a first-class answer and is printed like any other: a check whose line is missing reads

package/dist/index.js

@@ -48,7 +48,7 @@ import {
   resolveFrom,
   runDoctor,
   satisfies
-} from "./chunk-6ERJOIZS.js";
+} from "./chunk-WUFVAO7G.js";
 export {
   CHECKS,
   COMPOSITION_ROOT,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@geonosis/doctor",
-  "version": "2.6.0",
+  "version": "2.7.0",
   "types": "./dist/index.d.ts",
   "description": "The adoption doctor — declared ≠ loaded, enabled ≠ exercised, a baseline that grew, a runner whose exit code is the only verdict.",
   "keywords": [
@@ -36,10 +36,10 @@
     "dist"
   ],
   "dependencies": {
-    "@geonosis/lint-parity": "2.6.0"
+    "@geonosis/lint-parity": "2.7.0"
   },
   "devDependencies": {
-    "@geonosis/ratchet": "2.6.0"
+    "@geonosis/ratchet": "2.7.0"
   },
   "peerDependencies": {
     "oxlint": ">=1.77"