@geoly-ai/social-hub-cli 0.3.14 → 0.3.16

package/skills/reddit-voc-volume/tests/test_archived_comments.py

@@ -0,0 +1,189 @@
+from __future__ import annotations
+
+import contextlib
+import importlib.util
+import io
+import json
+from pathlib import Path
+import sys
+import unittest
+from unittest import mock
+
+
+SCRIPT = Path(__file__).resolve().parents[1] / "scripts" / "reddit_voc_volume.py"
+SPEC = importlib.util.spec_from_file_location("reddit_voc_volume_under_test", SCRIPT)
+assert SPEC is not None and SPEC.loader is not None
+voc = importlib.util.module_from_spec(SPEC)
+SPEC.loader.exec_module(voc)
+
+
+class ArchivedCommentTests(unittest.TestCase):
+    def run_main(self, *args: str) -> tuple[int, dict]:
+        stdout = io.StringIO()
+        with mock.patch.object(sys, "argv", [str(SCRIPT), *args]), contextlib.redirect_stdout(stdout):
+            code = voc.main()
+        return code, json.loads(stdout.getvalue())
+
+    def test_post_and_comment_id_normalization(self) -> None:
+        self.assertEqual(
+            voc.normalize_reddit_post_id("https://www.reddit.com/r/example/comments/AbC123/a_slug/"),
+            "abc123",
+        )
+        self.assertEqual(voc.normalize_reddit_post_id("t3_ABC123"), "abc123")
+        self.assertEqual(voc.normalize_reddit_post_id("https://redd.it/AbC123"), "abc123")
+        self.assertEqual(voc.normalize_reddit_comment_id("t1_DeF456"), "def456")
+        with self.assertRaisesRegex(ValueError, "comment ID"):
+            voc.normalize_reddit_post_id("t1_def456")
+        with self.assertRaisesRegex(ValueError, "unsupported post URL host"):
+            voc.normalize_reddit_post_id("https://example.com/comments/abc123")
+        with self.assertRaisesRegex(ValueError, "maximum 500"):
+            voc.parse_reddit_comment_ids([f"c{index:x}" for index in range(501)])
+
+    def test_tree_mode_flattens_body_and_preserves_hierarchy(self) -> None:
+        payload = {
+            "data": [
+                {
+                    "kind": "t1",
+                    "data": {
+                        "id": "root1",
+                        "name": "t1_root1",
+                        "link_id": "t3_post1",
+                        "parent_id": "t3_post1",
+                        "author": "alice",
+                        "body": "Root comment",
+                        "created_utc": 100,
+                        "score": 9,
+                        "subreddit": "example",
+                        "replies": {
+                            "data": {
+                                "children": [
+                                    {
+                                        "kind": "t1",
+                                        "data": {
+                                            "id": "child1",
+                                            "name": "t1_child1",
+                                            "link_id": "t3_post1",
+                                            "parent_id": "t1_root1",
+                                            "author": "bob",
+                                            "body": "Child comment",
+                                            "created_utc": 101,
+                                            "score": 3,
+                                            "subreddit": "example",
+                                        },
+                                    },
+                                    {
+                                        "kind": "more",
+                                        "data": {
+                                            "id": "more1",
+                                            "parent_id": "t1_root1",
+                                            "count": 2,
+                                            "children": ["hidden1", "hidden2"],
+                                        },
+                                    },
+                                ]
+                            }
+                        },
+                    },
+                }
+            ]
+        }
+        with mock.patch.object(voc, "arctic_get", return_value=payload) as get:
+            code, out = self.run_main("comments", "https://reddit.com/r/example/comments/post1/slug")
+
+        self.assertEqual(code, 0)
+        self.assertEqual(get.call_args.args[0], "/api/comments/tree")
+        self.assertEqual(get.call_args.args[1]["link_id"], "t3_post1")
+        self.assertEqual(get.call_args.args[1]["limit"], 25_000)
+        self.assertEqual([item["id"] for item in out["items"]], ["root1", "child1"])
+        self.assertEqual(out["items"][0]["child_ids"], ["child1"])
+        self.assertEqual(out["items"][1]["parent_id"], "t1_root1")
+        self.assertEqual(out["items"][1]["depth"], 1)
+        self.assertEqual(out["items"][1]["tree_path"], [0, 0])
+        self.assertEqual(out["items"][1]["body"], "Child comment")
+        self.assertFalse(out["items"][1]["body_truncated"])
+        self.assertFalse(out["tree_complete"])
+        self.assertEqual(out["collapsed"][0]["children"], ["hidden1", "hidden2"])
+        self.assertFalse(out["archive_caveats"]["score_realtime"])
+
+    def test_search_mode_forwards_supported_filters(self) -> None:
+        with mock.patch.object(voc, "arctic_get", return_value={"data": []}) as get:
+            code, out = self.run_main(
+                "comments",
+                "t3_post1",
+                "--source",
+                "search",
+                "--body",
+                "battery life",
+                "--author",
+                "alice",
+                "--after",
+                "2024-01-01",
+                "--before",
+                "2024-02-01",
+                "--parent-id",
+                "top",
+                "--limit",
+                "10",
+                "--sort",
+                "desc",
+            )
+
+        self.assertEqual(code, 0)
+        self.assertEqual(out["retrieval_mode"], "search")
+        self.assertEqual(get.call_args.args[0], "/api/comments/search")
+        params = get.call_args.args[1]
+        self.assertEqual(params["link_id"], "post1")
+        self.assertEqual(params["body"], "battery life")
+        self.assertEqual(params["author"], "alice")
+        self.assertEqual(params["parent_id"], "")
+        self.assertEqual(get.call_args.kwargs["keep_empty_params"], {"parent_id"})
+        self.assertEqual(params["limit"], 10)
+        self.assertEqual(params["sort"], "desc")
+
+    def test_ids_mode_restores_requested_order(self) -> None:
+        payload = {
+            "data": [
+                {"id": "second2", "body": "second", "link_id": "t3_post1", "parent_id": "t3_post1"},
+                {"id": "first1", "body": "first", "link_id": "t3_post1", "parent_id": "t3_post1"},
+            ]
+        }
+        with mock.patch.object(voc, "arctic_get", return_value=payload) as get:
+            code, out = self.run_main("comments", "--ids", "t1_first1,second2")
+
+        self.assertEqual(code, 0)
+        self.assertEqual(get.call_args.args[0], "/api/comments/ids")
+        self.assertEqual(get.call_args.args[1]["ids"], "first1,second2")
+        self.assertEqual([item["id"] for item in out["items"]], ["first1", "second2"])
+
+    def test_tree_failure_and_malformed_payload_are_never_reported_complete(self) -> None:
+        with mock.patch.object(voc, "arctic_get", side_effect=voc.ArcticError("upstream unavailable")):
+            code, out = self.run_main("comments", "post1")
+        self.assertEqual(code, 1)
+        self.assertFalse(out["tree_complete"])
+        self.assertIn("upstream unavailable", out["errors"][0])
+
+        with mock.patch.object(voc, "arctic_get", return_value={"data": {}}):
+            code, out = self.run_main("comments", "post1")
+        self.assertEqual(code, 1)
+        self.assertFalse(out["tree_complete"])
+        self.assertIn("arctic_comments_tree_malformed_payload", out["errors"][0])
+
+    def test_malformed_id_and_out_of_range_limits_fail_before_network(self) -> None:
+        with mock.patch.object(voc, "arctic_get") as get, contextlib.redirect_stderr(io.StringIO()):
+            with mock.patch.object(sys, "argv", [str(SCRIPT), "comments", "--ids", "t3_wrongkind"]):
+                with self.assertRaisesRegex(SystemExit, "2"):
+                    voc.main()
+            with mock.patch.object(sys, "argv", [str(SCRIPT), "comments", "post1", "--limit", "25001"]):
+                with self.assertRaisesRegex(SystemExit, "2"):
+                    voc.main()
+            with mock.patch.object(sys, "argv", [str(SCRIPT), "comments", "post1", "--parent-id", "top"]):
+                with self.assertRaisesRegex(SystemExit, "2"):
+                    voc.main()
+            with mock.patch.object(sys, "argv", [str(SCRIPT), "comments", "--ids", "comment1", "--source", "search"]):
+                with self.assertRaisesRegex(SystemExit, "2"):
+                    voc.main()
+        get.assert_not_called()
+
+
+if __name__ == "__main__":
+    unittest.main()

package/skills/social-hub-admin/SKILL.md

@@ -160,7 +160,6 @@ social-hub agent-teams list
 social-hub agent-teams create --slug my-team --name "My Agent Team" --apply
 social-hub agent-teams update -t <team-id> -j '{"name":"New Name"}' --apply
 social-hub agent-teams add-member -t <team-id> --user <userId> --role manager --apply
-social-hub agent-teams workspace-docs -t <team-id>   # 只读：Hub 内工作区文档索引
 ```
 
 ## 通知渠道

package/skills/social-hub-cli/SKILL.md

@@ -40,10 +40,10 @@ social-hub version --json
 | style-marks / curator / style-guide                          | `social-hub-style-curator`        |
 | 板块画像四眼 / 帖子标注                                      | `social-hub-style-profiles`       |
 | 日历 / scheduled jobs                                        | `social-hub-calendar-jobs`        |
-| 发布闭环（brand→report）                                     | `social-hub-publishing`           |
+| 发布闭环（草稿→计划→发布）                                   | `social-hub-publishing`           |
 | 评论发布前复审/优化（三层 gate 层③）                         | `social-hub-content-review`       |
 | 帖子发布前审核/优化（post-review）                           | `social-hub-post-review`          |
-| 事件 / dashboard / audit / reports                           | `social-hub-events-observability` |
+| 事件 / dashboard / audit                                     | `social-hub-events-observability` |
 | 图谱 / 合规 / 风控                                           | `social-hub-graph-compliance`     |
 | settings / invites / members / api-keys                      | `social-hub-admin`                |
 | brand-registry / brand-fit / trigger 注册表四眼 / brand-auth | `social-hub-admin`                |

package/skills/social-hub-events-observability/SKILL.md

@@ -1,8 +1,8 @@
 ---
 name: social-hub-events-observability
 description: >-
-  互动事件与可观测性：events append/list/export、dashboard summary、audit、reports。
-  用户要记事件、查运营总览、审计或报告库时用本 skill。不用于草稿/计划创建（social-hub-publishing）
+  互动事件与可观测性：events append/list/export、dashboard summary、audit。
+  用户要记事件、查运营总览或审计时用本 skill。不用于草稿/计划创建（social-hub-publishing）
   或 OpenClaw 任务 claim（social-hub-ops-runtime）。
 metadata:
   cliVersion: ">=0.0.12"
@@ -55,21 +55,12 @@ social-hub dashboard summary -t <team-id> --brand <brand-uuid>
 social-hub audit list -t <team-id> -n 50 [--type <prefix>] [--actor agent] [--account <uuid>]
 ```
 
-## 报告库
-
-```bash
-social-hub reports list -t <team-id> -n 20
-social-hub reports create -t <team-id> -j '{"reportType":"content-weekly","title":"Weekly","source":"openclaw","contentMarkdown":"..."}'
-social-hub reports ingest -t <team-id> -j '{"reportType":"content-weekly","source":"external","traceId":"..."}'
-```
-
 ## 写操作护栏
 
 | 操作                             | 要求                                        |
 | -------------------------------- | ------------------------------------------- |
 | `events batch`                   | 先小批量或 `list` 抽样；确认 payload 结构   |
 | `events import-openclaw-history` | **必须**先 `--dry-run`；`-f` 指向可读 JSONL |
-| `reports create`                 | 确认 `reportType` 与 team 权限              |
 
 ## 相关 skill
 

package/skills/social-hub-intelligence/SKILL.md

@@ -42,11 +42,16 @@ social-hub intelligence handoffs-list [--phase research] [--ready-only]
 social-hub intelligence comments-fetch --permalinks "https://www.reddit.com/r/espresso/comments/x1/a/,https://…"
 # 查询评论样本(含父子关系/关键词命中/intent/sentiment 标注)
 social-hub intelligence comments [--post-id t3_xxx] [--subreddit espresso] [--keyword aporro] [--intent complaint] [--sentiment negative]
+# 评论样本**精确总数**(不封顶,无分页;不接受 keyword;昂贵读,禁止轮询)
+# —— comments 列表的 total 被 10000 封顶(totalRelation=gte),要精确基线用这个
+social-hub intelligence comments-count [--post-id t3_xxx] [--subreddit espresso] [--intent complaint] [--sentiment negative] [--origin hub_collector]
 ```
 
 评论正文与评论树在库(reddit*comment_samples);intent/sentiment 由标注 cron
 批量回写(需部署 REDDIT_COMMENT_REVIEW_LLM*\* key)。VOC 帖子任务默认不采评论,
 需要时对命中帖 comments-fetch,或用 coverage 的 needComments 判断缺口后派发。
+口径注意:comments / comments-count 数的是**库内样本行数**(sampleMode=partial_sample),
+不是 Reddit 线程真实评论总数。
 
 ## Emergency Acquisition 回灌(矩阵 skill 自爬数据写回)
 

package/skills/social-hub-migration/SKILL.md

@@ -67,15 +67,6 @@ social-hub openclaw-ingest -t <team-id> -j '{
 
 `sourcePaths` 中的路径默认相对 `sourceRoot`，也支持绝对路径。数组字段包括 `opReportsDirs` 和 `opReportFiles`。重复提交请提供 `idempotencyKey`；enqueue 成功后可通过 `status --run` 查看 `jobId` 与 run 状态。
 
-## workspace 文档 refs
-
-需 `OPENCLAW_WORKSPACE_REFS_ENABLED=true`。
-
-```bash
-social-hub migration workspace-docs list -t <team-id>
-social-hub migration workspace-docs refs -t <team-id> --doc <document-uuid>
-```
-
 **不要**在本 skill 内自动化批量 sync 整个 agent 工作区 `shared/`，除非用户明确要求并指定路径。
 
 运行时查询请用 `social-hub-openclaw-context`（Hub DB 真源），不是解析 Markdown。

package/skills/social-hub-publishing/SKILL.md

@@ -85,10 +85,9 @@ social-hub calendar patch -t <team-id> -e <entryId> --body '{"status":"succeeded
 social-hub events append -t <team-id> --type post.published --payload '{"permalink":"..."}'
 ```
 
-## 帖快照与报告
+## 帖快照
 
 - 帖快照 CRUD / `--brand` 统计：见 **`social-hub-posts`**
-- 报告库：`reports list` / `reports ingest`（`reportType: "content-weekly"`）
 
 ## 写操作护栏
 

package/skills/social-hub-subreddit-pools/SKILL.md

@@ -13,11 +13,11 @@ description: >-
 
 ## ⚠️ 先看清楚:catalog / tier-rules 是**系统级共享**,aliases 才是团队级
 
-| 资源         | 层级           | 全局唯一键                      | `-t <team>` 的作用               |
-| ------------ | -------------- | ------------------------------- | -------------------------------- |
-| `catalog`    | **系统级共享** | `(industryKey, subreddit)`      | 鉴权 + 新建行署名 + 列表视图过滤 |
-| `tier-rules` | **系统级共享** | `subreddit`                     | 鉴权 + 新建行署名 + 列表视图过滤 |
-| `aliases`    | 团队级(真隔离) | `(team, aliasRef, industryKey)` | 真正的数据边界                   |
+| 资源         | 层级           | 全局唯一键                      | `-t <team>` 的作用                  |
+| ------------ | -------------- | ------------------------------- | ----------------------------------- |
+| `catalog`    | **系统级共享** | `(industryKey, subreddit)`      | 鉴权 + 新建行署名 + 列表视图过滤    |
+| `tier-rules` | **系统级共享** | `subreddit`                     | 鉴权 + 新建行署名(**列表默认全量**) |
+| `aliases`    | 团队级(真隔离) | `(team, aliasRef, industryKey)` | 真正的数据边界                      |
 
 对 catalog / tier-rules:
 
@@ -27,16 +27,14 @@ description: >-
   `tier-rules-delete` 的 `--id` 是**全局 id**,任何团队路径都能命中任何一行。
   所以 `catalog-list -t A` 列不出来的行,`catalog-delete -t A --id <行id>` 照样能改
   —— 这是系统级资源的固有结果,**不是 bug**。
-- `catalog-list` / `tier-rules-list` 的 `-t` 只是**按归属署名过滤列表视图**
-  (一个 view filter,不是授权边界)。⚠️ **列表只能看到本团队署名的行,但改是全局的**
-  —— 别把"列表里没有"当成"这个板块不存在"。
-  ⚠️ 加 `--industry-key` **绕不过**署名过滤(它只是再叠一个条件)。要跨团队查重,
-  必须显式加 `--aggregate-visible-teams`(`catalog-list` / `tier-rules-list` 都支持):
+- `catalog-list` 的 `-t` 仍是**按归属署名过滤列表视图**(一个 view filter,不是授权
+  边界)。⚠️ **列表只能看到本团队署名的行,但改是全局的** —— 别把"列表里没有"当成
+  "这个板块不存在"。⚠️ 加 `--industry-key` **绕不过**署名过滤(只是再叠一个条件)。
+  要跨团队查重,必须显式加 `--aggregate-visible-teams`:
 
   ```bash
   # 建行前查重:这个 (industryKey, subreddit) 是不是已经有别的团队录过了
   social-hub pools catalog-list -t <team-id> --aggregate-visible-teams --industry-key coffee -n 200
-  social-hub pools tier-rules-list -t <team-id> --aggregate-visible-teams -n 200
   ```
 
   🔴 **它是「跨可见团队的署名聚合视图」,不是无条件全表**:范围 = 当前登录主体
@@ -45,9 +43,26 @@ description: >-
   但**不是**并发正确性保证。真正兜底重复的是 DB 的全局唯一约束 + upsert 语义:
   撞上了会**更新那一行**(见下),不会新建副本。
 
+- 🔵 **`tier-rules-list` 已改成默认全量**(系统级口径):不带任何 flag 就能看到全库
+  所有 S0–S3 规则,`-t` 只用于鉴权,不再过滤列表。`--aggregate-visible-teams` 对
+  `tier-rules-list` 变成 **no-op**(它只会缩小到"可见团队署名",比默认还窄),留着
+  是为兼容老脚本,新脚本不用加。
+
+  响应带 `scope` 字段,**这是安全语义,别忽略**:
+  - `scope: "system"` = 全量读 → **"列表里没有这个 subreddit" 才等于"没有 tier 记录"**,
+    此时三级闸「查不到 tier → 按 S1 保守」才成立;
+  - `scope: "attribution"`(只有显式传 `scopeTeamId(s)` 时才会出现)= 署名过滤视图 →
+    **空集 ≠ 没有规则**,不能据此下"查不到"的结论。
+
+  ⚠️ 另一条同样重要:**"有行"不等于"该规则在生效"**。列表默认不过滤 `enabled`,
+  停用行照样列出、带 `enabled: false`;worker 判定只取 `enabled=true`。看到
+  `enabled:false` 要按"无有效规则"(即 S1 保守)处理,不要当成放行依据。
+
 - `catalog-create` / `tier-rules-create` 是 **upsert**:提交一个已存在的
   `(industryKey, subreddit)` / `subreddit` 会**更新那一行**(可能是别的团队建的),
-  不会新建一份团队私有副本。
+  不会新建一份团队私有副本。`tier-rules-create` 的响应带 `created`:
+  `created:true`(HTTP 201)= 真新建;`created:false`(HTTP 200)= **你刚改掉了一条
+  已存在的规则**(署名仍是原团队)。看到 `created:false` 请回查那一行原来的值。
 - **归属署名(行上的 `teamId`)不可变**:只在真正新建时写入,后续任何团队编辑都不改它。
   想知道"谁改的"看审计,别看这一列。
 - ⚠️ **`catalog-delete` 实际是 archive**(`status='archived'`),而且影响**全局**:
@@ -67,7 +82,8 @@ social-hub pools aliases-create -t <team-id> -j '{"aliasRef":"persona_pools.P23.
 social-hub pools aliases-update -t <team-id> --id <alias-id> -j '{...}'
 social-hub pools aliases-delete -t <team-id> --id <alias-id>
 
-social-hub pools tier-rules-list -t <team-id> [--tier S0|S1|S2|S3] [--enabled true|false] [--aggregate-visible-teams]
+# tier-rules-list 默认就是全库全量（响应带 scope:"system"）；--aggregate-visible-teams 是兼容用的 no-op
+social-hub pools tier-rules-list -t <team-id> [--tier S0|S1|S2|S3] [--enabled true|false]
 social-hub pools tier-rules-create -t <team-id> -j '{...}'
 social-hub pools tier-rules-update -t <team-id> --id <rule-id> -j '{...}'
 social-hub pools tier-rules-delete -t <team-id> --id <rule-id>
@@ -100,6 +116,11 @@ social-hub pools tier-rules-delete -t <team-id> --id <rule-id>
   catalog 全局只有一行同 `(industryKey, subreddit)`,`-t` 不参与定位。改之前先用
   `catalog-list --aggregate-visible-teams`(或后台页面的跨团队聚合视图)确认这一行的
   归属与内容。
+- `tier-rules-create` 回了 200 + `created:false`:说明这个 subreddit 已有规则,你这次
+  是**更新**(不是"团队定位失效"、也不是新建失败)。该表全局只有一行同 `subreddit`。
+- ⚠️ 旧命名空间 `GET /v1/teams/:teamId/subreddit-intelligence/tier-rules` **仍是默认
+  按署名过滤**(未随本次改动切全量)。要全量口径请走 `pools tier-rules-list` /
+  `subreddit-pools/tier-rules`。
 - `tier-rules-update` 想把规则的 `subreddit` 改成另一条规则已占用的值 → 返回 409。
   以前这里会静默改到那另一条规则上、无视 URL 里的 `--id`;现在明确报冲突。
 - Pool Aliases 页面为空：先确认是否跑过 `db:seed` 或 persona pool bootstrap；再用 `aliases-list` 查当前 team，而不是只看 catalog。