@geode/opengeodeweb-front 10.3.0 → 10.3.1

package/tests/unit/stores/Treeview.nuxt.test.js

@@ -1,66 +1,64 @@
-import { beforeEach, describe, expect, expectTypeOf, test, vi } from "vitest"
-import { createTestingPinia } from "@pinia/testing"
-import { setActivePinia } from "pinia"
+// Third party imports
+import { describe, expect, expectTypeOf, test } from "vitest"
 
+// Local imports
+import { setupActivePinia } from "../../utils"
 import { useTreeviewStore } from "@ogw_front/stores/treeview"
 
-beforeEach(async () => {
-  const pinia = createTestingPinia({
-    stubActions: false,
-    createSpy: vi.fn,
-  })
-  setActivePinia(pinia)
+// CONSTANTS
+const STEP_1 = 1
+
+beforeEach(() => {
+  setupActivePinia()
 })
 
-describe("Treeview Store", () => {
-  describe("state", () => {
-    test("initial state", () => {
-      const treeviewStore = useTreeviewStore()
-      expectTypeOf(treeviewStore.items).toBeArray()
-    })
+describe("treeview store state", () => {
+  test("initial state", () => {
+    const treeviewStore = useTreeviewStore()
+    expectTypeOf(treeviewStore.items).toBeArray()
   })
+})
 
-  describe("actions", () => {
-    describe("addItem", () => {
-      test("test items sorted", () => {
-        const treeviewStore = useTreeviewStore()
+describe("treeview store actions", () => {
+  test("addItem sorted check", () => {
+    const treeviewStore = useTreeviewStore()
+    const testItems = [
+      {
+        geode_object_type: "BRep",
+        name: "test_brep.og_brep",
+        id: "1",
+        viewer_type: "model",
+      },
+      {
+        geode_object_type: "BRep",
+        name: "test_brep_2.og_brep",
+        id: "2",
+        viewer_type: "model",
+      },
+      {
+        geode_object_type: "EdgedCurve2D",
+        name: "test_edgedcurve.og_edc2d",
+        id: "2",
+        viewer_type: "mesh",
+      },
+    ]
 
-        const testItems = [
-          {
-            geode_object_type: "BRep",
-            name: "test_brep.og_brep",
-            id: "1",
-            viewer_type: "model",
-          },
-          {
-            geode_object_type: "BRep",
-            name: "test_brep_2.og_brep",
-            id: "2",
-            viewer_type: "model",
-          },
-          {
-            geode_object_type: "EdgedCurve2D",
-            name: "test_edgedcurve.og_edc2d",
-            id: "2",
-            viewer_type: "mesh",
-          },
-        ]
+    for (let i = 0; i < testItems.length; i += STEP_1) {
+      treeviewStore.addItem(
+        testItems[i].geode_object_type,
+        testItems[i].name,
+        testItems[i].id,
+        testItems[i].viewer_type,
+      )
+      const itemsCopy = [...treeviewStore.items]
+      expect(treeviewStore.items).toStrictEqual(itemsCopy.toSorted())
 
-        for (let i = 0; i < testItems.length; i++) {
-          treeviewStore.addItem(
-            testItems[i].geode_object_type,
-            testItems[i].name,
-            testItems[i].id,
-            testItems[i].viewer_type,
-          )
-          expect(treeviewStore.items.sort()).toBe(treeviewStore.items)
-          for (let i = 0; i < treeviewStore.items.length; i++) {
-            expect(treeviewStore.items[i].children.sort()).toBe(
-              treeviewStore.items[i].children,
-            )
-          }
-        }
-      })
-    })
+      for (let j = 0; j < treeviewStore.items.length; j += STEP_1) {
+        const childrenCopy = [...treeviewStore.items[j].children]
+        expect(treeviewStore.items[j].children).toStrictEqual(
+          childrenCopy.toSorted(),
+        )
+      }
+    }
   })
 })

package/tests/unit/stores/Viewer.nuxt.test.js

@@ -1,29 +1,26 @@
-// Global imports
-
 // Third party imports
-import { setActivePinia } from "pinia"
-import { createTestingPinia } from "@pinia/testing"
 import {
   afterAll,
   beforeAll,
+  beforeEach,
   describe,
-  test,
   expect,
   expectTypeOf,
-  beforeEach,
+  test,
   vi,
 } from "vitest"
 
 import { WebSocket } from "ws"
 // Local imports
-import { useViewerStore } from "@ogw_front/stores/viewer"
-import { useInfraStore } from "@ogw_front/stores/infra"
 import { appMode } from "@ogw_front/utils/app_mode"
+import { setupActivePinia } from "../../utils"
+import { useInfraStore } from "@ogw_front/stores/infra"
+import { useViewerStore } from "@ogw_front/stores/viewer"
 
 // Mock navigator.locks API
-const mockLockRequest = vi.fn().mockImplementation(async (name, callback) => {
-  return callback({ name })
-})
+const mockLockRequest = vi
+  .fn()
+  .mockImplementation(async (name, handler) => await handler({ name }))
 
 vi.stubGlobal("navigator", {
   ...navigator,
@@ -33,19 +30,15 @@ vi.stubGlobal("navigator", {
 })
 
 beforeAll(() => {
-  global.WebSocket = WebSocket
+  globalThis.WebSocket = WebSocket
 })
 
 afterAll(() => {
-  delete global.WebSocket
+  delete globalThis.WebSocket
 })
 
 beforeEach(() => {
-  const pinia = createTestingPinia({
-    stubActions: false,
-    createSpy: vi.fn,
-  })
-  setActivePinia(pinia)
+  setupActivePinia()
 })
 
 describe("Viewer Store", () => {
@@ -56,8 +49,8 @@ describe("Viewer Store", () => {
       expectTypeOf(viewerStore.client).toEqualTypeOf({})
       expectTypeOf(viewerStore.picking_mode).toBeBoolean()
       expectTypeOf(viewerStore.picked_point).toEqualTypeOf({
-        x: null,
-        y: null,
+        x: undefined,
+        y: undefined,
       })
       expectTypeOf(viewerStore.picked_point).toBeNumber()
       expectTypeOf(viewerStore.status).toBeString()
@@ -149,12 +142,12 @@ describe("Viewer Store", () => {
       test("test is_busy", () => {
         const viewerStore = useViewerStore()
         viewerStore.request_counter = 1
-        expect(viewerStore.is_busy).toBe(true)
+        expect(viewerStore.is_busy).toBeTruthy()
       })
       test("test not is_busy", () => {
         const viewerStore = useViewerStore()
         viewerStore.request_counter = 0
-        expect(viewerStore.is_busy).toBe(false)
+        expect(viewerStore.is_busy).toBeFalsy()
       })
     })
   })
@@ -163,7 +156,7 @@ describe("Viewer Store", () => {
       test("test true", async () => {
         const viewerStore = useViewerStore()
         await viewerStore.toggle_picking_mode(true)
-        expect(viewerStore.picking_mode).toBe(true)
+        expect(viewerStore.picking_mode).toBeTruthy()
       })
     })
 

package/tests/unit/utils/validate_schema.nuxt.test.js

@@ -1,38 +1,38 @@
+// Third party imports
 import { describe, expect, test } from "vitest"
 
+// Local imports
 import validate_schema from "@ogw_front/utils/validate_schema"
 
-describe("validate_schema", () => {
+// CONSTANTS
+const MIN_0 = 0
+const MAX_10 = 10
+const VAL_5 = 5
+
+describe("validate schema", () => {
   const schema = {
     $id: "/test",
     type: "object",
     methods: ["POST"],
     properties: {
-      var_1: {
-        type: "string",
-      },
-      var_2: {
-        type: "integer",
-        minimum: 0,
-        maximum: 10,
-      },
+      var_1: { type: "string" },
+      var_2: { type: "integer", minimum: MIN_0, maximum: MAX_10 },
     },
     required: ["var_1", "var_2"],
     additionalProperties: false,
   }
-  var params
 
-  test("Ajv wrong params", async () => {
-    params = {}
-    var { valid, error } = validate_schema(schema, params)
-    expect(valid).toBe(false)
+  test("ajv wrong params", () => {
+    const params = {}
+    const { valid, error } = validate_schema(schema, params)
+    expect(valid).toBeFalsy()
     expect(error).toBe("data must have required property 'var_1'")
   })
 
-  test("Good params", async () => {
-    params = { var_1: "test", var_2: 5 }
-    var { valid, error } = validate_schema(schema, params)
-    expect(valid).toBe(true)
+  test("good params", () => {
+    const params = { var_1: "test", var_2: VAL_5 }
+    const { valid, error } = validate_schema(schema, params)
+    expect(valid).toBeTruthy()
     expect(error).toBe("No errors")
   })
 })

package/tests/utils.js

@@ -1,6 +1,19 @@
-import { createVuetify } from "vuetify"
+// Third party imports
 import * as components from "vuetify/components"
 import * as directives from "vuetify/directives"
+import { createTestingPinia } from "@pinia/testing"
+import { createVuetify } from "vuetify"
+import { setActivePinia } from "pinia"
+
 const vuetify = createVuetify({ components, directives })
 
-export { vuetify }
+function setupActivePinia() {
+  const pinia = createTestingPinia({
+    stubActions: false,
+    createSpy: vi.fn,
+  })
+  setActivePinia(pinia)
+  return pinia
+}
+
+export { setupActivePinia, vuetify }

package/tests/vitest.config.js

@@ -1,9 +1,13 @@
 import { defineConfig } from "vitest/config"
 import { defineVitestProject } from "@nuxt/test-utils/config"
-import path from "path"
+import path from "node:path"
 
-const globalRetry = process.env.CI ? 3 : 0
+const RETRIES = 3
+const DEFAULT_RETRY = 0
 
+const globalRetry = process.env.CI ? RETRIES : DEFAULT_RETRY
+
+// eslint-disable-next-line import/no-default-export
 export default defineConfig({
   test: {
     globals: true,