@genesislcap/vite-builder 15.22.0 → 15.22.2

package/dist/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":"AAEA,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,wBAAwB,CAAC;AAc3D;;;;;;;;;;;;;;;;;;;;;;;GAuBG;yBAEmB,KAAK,YAAY;AAAvC,wBA0KE"}
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":"AAEA,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,wBAAwB,CAAC;AAc3D;;;;;;;;;;;;;;;;;;;;;;;GAuBG;yBAEmB,KAAK,YAAY;AAAvC,wBAmOE"}

package/dist/index.js

@@ -34,6 +34,17 @@ exports.default = (ctx) => tslib_1.__awaiter(void 0, void 0, void 0, function* (
     var _a, _b, _c;
     const { config: { app: { rootElement }, env, http, }, dirs: { cwd }, cli: { isDev, isBuild, isAnalyze, options: { open, https }, }, pkg: { description }, resolve: { alias }, } = ctx;
     const define = (0, build_kit_1.resolveDefineConfig)(env, http, 'vite');
+    /**
+     * The same map, narrowed to keys esbuild will accept as defines (see the `esbuildOptions` note in
+     * `optimizeDeps` below for why the optimizer needs it at all).
+     *
+     * `resolveDefineConfig` derives its keys from `process.env` via pattern match, so a machine with,
+     * say, `GENX-SOMETHING` set would produce a key that is not a valid JS identifier. Vite tolerates
+     * that in its own `define`; esbuild rejects the whole build. Filtering keeps a stray environment
+     * variable from turning into a hard build failure for everyone.
+     */
+    const IDENTIFIER = /^[A-Za-z_$][A-Za-z0-9_$]*$/;
+    const depDefine = Object.fromEntries(Object.entries(define).filter(([key]) => IDENTIFIER.test(key)));
     const handlebars = yield (0, vite_js_1.getHandlebarsModule)();
     const vite = yield (0, vite_js_1.getViteModule)();
     const publicPath = (0, build_kit_1.getPublicPath)();
@@ -146,6 +157,46 @@ exports.default = (ctx) => tslib_1.__awaiter(void 0, void 0, void 0, function* (
              * reference, should we convert the above to a glob.
              */
             include: ['@genesis-community/golden-layout'],
+            /**
+             * GENC-1581 — the `define` above is applied when Vite TRANSFORMS source, but dependency
+             * pre-bundling is a separate esbuild pass that does not inherit it. Any env-driven global
+             * consumed from inside a pre-bundled dependency was therefore left as a bare identifier in
+             * `node_modules/.vite/deps`, and silently resolved to `undefined` at runtime.
+             *
+             * MEASURED before this change: the served `@genesislcap/foundation-utils` chunk contained
+             * `_DEFAULT_USER = DEFAULT_USER;` with no substitution, and the configured value appeared
+             * nowhere in the bundle. `foundation-utils` reads these behind `try {} catch {}`, so the
+             * resulting ReferenceError was swallowed and the variable simply stayed undefined — no
+             * error, no warning, just a feature that never worked. `DEFAULT_USER`/`DEFAULT_PASSWORD`
+             * (login pre-fill) is the case that surfaced it; every dependency-resident define was
+             * equally affected. `API_HOST` masked the problem because `foundation-comms` falls back to
+             * deriving it from `location`, and the dev proxy makes that fallback correct.
+             *
+             * Passing the same map to the optimizer's esbuild keeps source and dependencies consistent.
+             * Vite hashes `optimizeDeps` into the dep-cache key, so changing a value re-optimizes rather
+             * than silently serving a stale chunk.
+             */
+            esbuildOptions: {
+                define: Object.assign({ 
+                    /**
+                     * Vite seeds its OWN optimizer define with `process.env.NODE_ENV` and then spreads
+                     * `esbuildOptions` straight over it (`vite/dist/node/chunks/config.js`: `define: define$1,
+                     * … …esbuildOptions,` — note `supported` gets an explicit deep-merge just below and
+                     * `define` does not). So a bare `define` here REPLACES that map rather than adding to it,
+                     * and pre-bundled deps lose the substitution.
+                     *
+                     * That is not academic: `@reduxjs/toolkit` resolves through its `module` condition to
+                     * `redux-toolkit.modern.mjs` (57 bare `process.env.NODE_ENV` reads) plus `redux` (22),
+                     * and `foundation-redux/src/store.ts` calls `configureStore` at module scope — so any app
+                     * pulling in `@genesislcap/foundation-redux` would get `ReferenceError: process is not
+                     * defined` out of the dep chunk. Dev only (`vite build` applies `define` through Rollup
+                     * for node_modules too), which is exactly the path this change targets.
+                     *
+                     * Re-seeded before the spread. `depDefine` cannot collide with it: its keys are filtered
+                     * to bare identifiers, and this one is dotted.
+                     */
+                    'process.env.NODE_ENV': JSON.stringify(process.env.NODE_ENV || (isDev ? 'development' : 'production')) }, depDefine),
+            },
         },
         base: publicPath,
     };

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@genesislcap/vite-builder",
   "description": "Vite builder",
-  "version": "15.22.0",
+  "version": "15.22.2",
   "license": "SEE LICENSE IN license.txt",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -16,7 +16,7 @@
     "lint:fix": "genx lint -l ox --fix"
   },
   "dependencies": {
-    "@genesislcap/build-kit": "15.22.0",
+    "@genesislcap/build-kit": "15.22.2",
     "consola": "^3.0.2",
     "copyfiles": "^2.4.1",
     "vite": "^7.2.2",