@genesislcap/pbc-reporting-ui 15.19.2-FUI-2610.2 → 15.19.2-canary.2

package/dist/custom-elements.json

@@ -4395,6 +4395,31 @@
         }
       ]
     },
+    {
+      "kind": "javascript-module",
+      "path": "src/old/utils/row-selection.ts",
+      "declarations": [
+        {
+          "kind": "variable",
+          "name": "USER_TOGGLE_MARKER",
+          "type": {
+            "text": "string"
+          },
+          "default": "'__reportingUserCheckboxToggle'",
+          "description": "Set on the row node for the duration of a user checkbox click. @internal"
+        }
+      ],
+      "exports": [
+        {
+          "kind": "js",
+          "name": "USER_TOGGLE_MARKER",
+          "declaration": {
+            "name": "USER_TOGGLE_MARKER",
+            "module": "src/old/utils/row-selection.ts"
+          }
+        }
+      ]
+    },
     {
       "kind": "javascript-module",
       "path": "src/new/components/clone-report-config-modal/clone-report-config-modal.styles.ts",

package/dist/dts/new/main/edit-config/col-filters/col-filters-grid.helpers.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"col-filters-grid.helpers.d.ts","sourceRoot":"","sources":["../../../../../../src/new/main/edit-config/col-filters/col-filters-grid.helpers.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,gBAAgB,EAAE,MAAM,yBAAyB,CAAC;AAQ3D,OAAO,EAAE,aAAa,EAAE,MAAM,0BAA0B,CAAC;AAEzD;;GAEG;AACH,wBAAgB,0BAA0B,CAAC,KAAK,EAAE,gBAAgB,CAAC,aAAa,CAAC,GAAG,IAAI,CAqBvF"}
+{"version":3,"file":"col-filters-grid.helpers.d.ts","sourceRoot":"","sources":["../../../../../../src/new/main/edit-config/col-filters/col-filters-grid.helpers.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,gBAAgB,EAAE,MAAM,yBAAyB,CAAC;AAS3D,OAAO,EAAE,aAAa,EAAE,MAAM,0BAA0B,CAAC;AAEzD;;GAEG;AACH,wBAAgB,0BAA0B,CAAC,KAAK,EAAE,gBAAgB,CAAC,aAAa,CAAC,GAAG,IAAI,CAwBvF"}

package/dist/dts/new/main/edit-config/col-rename-alias/col-rename-alias-grid.helpers.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"col-rename-alias-grid.helpers.d.ts","sourceRoot":"","sources":["../../../../../../src/new/main/edit-config/col-rename-alias/col-rename-alias-grid.helpers.ts"],"names":[],"mappings":"AAAA,OAAO,EACL,eAAe,EACf,SAAS,EACT,mBAAmB,EACnB,gBAAgB,EACjB,MAAM,yBAAyB,CAAC;AAGjC,OAAO,EACL,eAAe,EACf,WAAW,EAIZ,MAAM,WAAW,CAAC;AACnB,OAAO,EAAE,wBAAwB,EAAE,MAAM,+BAA+B,CAAC;AAEzE;;GAEG;AACH,wBAAgB,kBAAkB,CAAC,IAAI,EAAE,wBAAwB,GAAG,wBAAwB,CAU3F;AAED;;GAEG;AACH,wBAAgB,oBAAoB,CAClC,CAAC,SAAS,IAAI,CAAC,WAAW,EAAE,eAAe,CAAC,UAAU,GAAG,eAAe,CAAC,UAAU,CAAC,EACpF,kBAAkB,EAAE,SAAS,EAAE,gBAAgB,GAAE,SAAc,IACvD,QAAQ,eAAe,CAAC,CAAC,CAAC,KAAG,SAAS,CAM/C;AAED;;GAEG;AACH,eAAO,MAAM,0BAA0B,GAAI,UAAU,MAAM,GAAG,MACpD,OAAO,MAAM,EAAE,QAAQ,mBAAmB,CAAC,wBAAwB,CAAC,SAc7E,CAAC;AAEF;;GAEG;AACH,wBAAgB,gCAAgC,CAC9C,KAAK,EAAE,gBAAgB,CAAC,wBAAwB,CAAC,GAChD,IAAI,CAiBN"}
+{"version":3,"file":"col-rename-alias-grid.helpers.d.ts","sourceRoot":"","sources":["../../../../../../src/new/main/edit-config/col-rename-alias/col-rename-alias-grid.helpers.ts"],"names":[],"mappings":"AAAA,OAAO,EACL,eAAe,EACf,SAAS,EACT,mBAAmB,EACnB,gBAAgB,EACjB,MAAM,yBAAyB,CAAC;AAIjC,OAAO,EACL,eAAe,EACf,WAAW,EAIZ,MAAM,WAAW,CAAC;AACnB,OAAO,EAAE,wBAAwB,EAAE,MAAM,+BAA+B,CAAC;AAEzE;;GAEG;AACH,wBAAgB,kBAAkB,CAAC,IAAI,EAAE,wBAAwB,GAAG,wBAAwB,CAU3F;AAED;;GAEG;AACH,wBAAgB,oBAAoB,CAClC,CAAC,SAAS,IAAI,CAAC,WAAW,EAAE,eAAe,CAAC,UAAU,GAAG,eAAe,CAAC,UAAU,CAAC,EACpF,kBAAkB,EAAE,SAAS,EAAE,gBAAgB,GAAE,SAAc,IACvD,QAAQ,eAAe,CAAC,CAAC,CAAC,KAAG,SAAS,CAM/C;AAED;;GAEG;AACH,eAAO,MAAM,0BAA0B,GAAI,UAAU,MAAM,GAAG,MACpD,OAAO,MAAM,EAAE,QAAQ,mBAAmB,CAAC,wBAAwB,CAAC,SAc7E,CAAC;AAEF;;GAEG;AACH,wBAAgB,gCAAgC,CAC9C,KAAK,EAAE,gBAAgB,CAAC,wBAAwB,CAAC,GAChD,IAAI,CAsBN"}

package/dist/dts/old/components/renderers/row-select.renderer.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"row-select.renderer.d.ts","sourceRoot":"","sources":["../../../../../src/old/components/renderers/row-select.renderer.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,iBAAiB,EAAE,mBAAmB,EAAE,MAAM,yBAAyB,CAAC;AACjF,OAAO,EAAE,qBAAqB,EAAuB,MAAM,uCAAuC,CAAC;AACnG,OAAO,EAAyB,iBAAiB,EAAE,MAAM,uBAAuB,CAAC;AAEjF;;;;GAIG;AACH,qBAAa,iBAAkB,SAAQ,iBAAkB,YAAW,iBAAiB;IAE5E,MAAM,EAAE,mBAAmB,GAAG,qBAAqB,CAAC;IAG3D,OAAO,EAAE,OAAO,CAAC;IAEV,UAAU,CAAC,IAAI,KAAA,GAAG,OAAO;IAWzB,IAAI,CAAC,MAAM,EAAE,mBAAmB;IAShC,kBAAkB;IAMlB,aAAa,CAAC,CAAC,KAAA;IAKf,MAAM,IAAI,WAAW;IAIrB,OAAO;IAOP,OAAO,CAAC,MAAM,EAAE,mBAAmB;IAK1C,QAAQ;IAIR,mBAAmB;CAGpB;AAED;;;GAGG;AACH,eAAO,MAAM,yBAAyB,iDAsCrC,CAAC;AAEF;;;;;GAKG;AACH,eAAO,MAAM,8BAA8B,GAAI,qBAAsB,2EAYpE,CAAC;AAEF;;;;;;GAMG;AACH,eAAO,MAAM,6BAA6B;;;;;;;;4BAIxC,CAAC"}
+{"version":3,"file":"row-select.renderer.d.ts","sourceRoot":"","sources":["../../../../../src/old/components/renderers/row-select.renderer.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,iBAAiB,EAAE,mBAAmB,EAAE,MAAM,yBAAyB,CAAC;AACjF,OAAO,EAAE,qBAAqB,EAAuB,MAAM,uCAAuC,CAAC;AACnG,OAAO,EAAyB,iBAAiB,EAAE,MAAM,uBAAuB,CAAC;AAGjF;;;;GAIG;AACH,qBAAa,iBAAkB,SAAQ,iBAAkB,YAAW,iBAAiB;IAE5E,MAAM,EAAE,mBAAmB,GAAG,qBAAqB,CAAC;IAG3D,OAAO,EAAE,OAAO,CAAC;IAEV,UAAU,CAAC,IAAI,KAAA,GAAG,OAAO;IAWzB,IAAI,CAAC,MAAM,EAAE,mBAAmB;IAShC,kBAAkB;IAMlB,aAAa,CAAC,CAAC,KAAA;IAgBf,MAAM,IAAI,WAAW;IAIrB,OAAO;IAOP,OAAO,CAAC,MAAM,EAAE,mBAAmB;IAK1C,QAAQ;IAIR,mBAAmB;CAGpB;AAED;;;GAGG;AACH,eAAO,MAAM,yBAAyB,iDAsCrC,CAAC;AAEF;;;;;GAKG;AACH,eAAO,MAAM,8BAA8B,GAAI,qBAAsB,2EAYpE,CAAC;AAEF;;;;;;GAMG;AACH,eAAO,MAAM,6BAA6B;;;;;;;;4BAIxC,CAAC"}

package/dist/dts/old/utils/row-selection.d.ts

@@ -0,0 +1,21 @@
+import { RowSelectedEvent } from '@ag-grid-community/core';
+/** Set on the row node for the duration of a user checkbox click. @internal */
+export declare const USER_TOGGLE_MARKER = "__reportingUserCheckboxToggle";
+/**
+ * True while `RowSelectRenderer` is applying a user checkbox click.
+ * @remarks
+ * This relies on AG Grid dispatching `rowSelected` synchronously from inside `setSelected()`, while
+ * the marker is still on the node. That holds on both versions in use (v36 `selectRowNode` and v29
+ * `selectThisNode` both set `__selected` and dispatch inline), but a future version that batches
+ * selection events would make the marker silently dead - and no unit test can catch that, because
+ * the test's own `setSelected` stub *is* the synchronous dispatch.
+ * @internal
+ */
+export declare function isUserCheckboxToggle(node: unknown): boolean;
+/**
+ * True when a selection change came from the user rather than from a programmatic
+ * `setSelected()`, which defaults to source `'api'`.
+ * @internal
+ */
+export declare function isUserSelectionEvent(event: RowSelectedEvent): boolean;
+//# sourceMappingURL=row-selection.d.ts.map

package/dist/dts/old/utils/row-selection.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"row-selection.d.ts","sourceRoot":"","sources":["../../../../src/old/utils/row-selection.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,gBAAgB,EAAE,MAAM,yBAAyB,CAAC;AAE3D,+EAA+E;AAC/E,eAAO,MAAM,kBAAkB,kCAAkC,CAAC;AAkBlE;;;;;;;;;GASG;AACH,wBAAgB,oBAAoB,CAAC,IAAI,EAAE,OAAO,GAAG,OAAO,CAM3D;AAED;;;;GAIG;AACH,wBAAgB,oBAAoB,CAAC,KAAK,EAAE,gBAAgB,GAAG,OAAO,CAErE"}

package/dist/esm/new/main/edit-config/col-filters/col-filters-grid.helpers.js

@@ -1,3 +1,4 @@
+import { isUserSelectionEvent } from '../../../../old/utils/row-selection';
 import { actions, selectors } from '../../../store';
 import { GridColumnNames, datasourceNameFromDisplay, lookupColumnIsIncluded, shouldDisableColumn, } from '../shared';
 /**
@@ -7,6 +8,9 @@ export function rowSelectionChangedHandler(event) {
     var _a, _b;
     if (!event.data)
         return;
+    // Ignore programmatic re-selection (`setSelected()` defaults to source `'api'`).
+    if (!isUserSelectionEvent(event))
+        return;
     // gate event listener to only trigger if the data is actually changed by the user
     // (return if setting the same value as in the store, e.g. when first loading
     // the grid data)

package/dist/esm/new/main/edit-config/col-rename-alias/col-rename-alias-grid.helpers.js

@@ -1,4 +1,5 @@
 import { capitalCase } from 'change-case';
+import { isUserSelectionEvent } from '../../../../old/utils/row-selection';
 import { actions, selectors } from '../../../store';
 import { GridColumnNames, datasourceNameFromDisplay, lookupColumnIsRenamed, shouldDisableColumn, } from '../shared';
 /**
@@ -48,6 +49,11 @@ export function renameRowSelectionChangedHandler(event) {
     var _a, _b;
     if (!event.data)
         return;
+    // Ignore programmatic re-selection: `onRowDataUpdated` re-syncs through a bare `setSelected()`
+    // (source `'api'`), and AG Grid re-applies its own selection when the stepper step is revisited.
+    // Neither is a user edit, so neither may write back to `COLUMN_RENAMES`.
+    if (!isUserSelectionEvent(event))
+        return;
     // gate event listener to only trigger if the data is actually changed by the user
     // (return if setting the same value as in the store, e.g. when first loading
     // the grid data)

package/dist/esm/old/components/renderers/row-select.renderer.js

@@ -1,6 +1,7 @@
 import { __decorate } from "tslib";
 import { EDITED_COLUMN_FIELD } from '@genesislcap/foundation-zero-grid-pro';
 import { css, html, observable, FoundationElement } from '@genesislcap/web-core';
+import { USER_TOGGLE_MARKER } from '../../utils/row-selection';
 /**
  * The AG Row Select Renderer element.
  * @public
@@ -35,8 +36,23 @@ export class RowSelectRenderer extends FoundationElement {
         }
     }
     changeHandler(e) {
+        var _a, _b;
         this.checked = e.target.checked;
-        this.params.node.setSelected(this.checked);
+        const node = (_a = this.params) === null || _a === void 0 ? void 0 : _a.node;
+        if (!node)
+            return;
+        // FAST re-emits `change` for programmatic `checked` writes, so only treat this as a user
+        // toggle when the checkbox and the node actually disagree.
+        if (this.checked === ((_b = node.isSelected()) !== null && _b !== void 0 ? _b : false))
+            return;
+        const marked = node;
+        marked[USER_TOGGLE_MARKER] = true;
+        try {
+            node.setSelected(this.checked);
+        }
+        finally {
+            delete marked[USER_TOGGLE_MARKER];
+        }
     }
     getGui() {
         return this;

package/dist/esm/old/utils/row-selection.js

@@ -0,0 +1,40 @@
+/** Set on the row node for the duration of a user checkbox click. @internal */
+export const USER_TOGGLE_MARKER = '__reportingUserCheckboxToggle';
+/**
+ * AG Grid's own UI selection sources. The row checkbox is a custom renderer that reports as
+ * `'api'`, so it is recognised through the node marker instead.
+ * @internal
+ */
+const USER_SELECTION_SOURCES = new Set([
+    'uiSelectAll',
+    'uiSelectAllFiltered',
+    'uiSelectAllCurrentPage',
+    'checkboxSelected',
+    'rowClicked',
+    'spaceKey',
+    'spacePressed', // v29 name for 'spaceKey'
+    'keyboardSelectAll', // v36 Ctrl+A; absent from v29's source union
+]);
+/**
+ * True while `RowSelectRenderer` is applying a user checkbox click.
+ * @remarks
+ * This relies on AG Grid dispatching `rowSelected` synchronously from inside `setSelected()`, while
+ * the marker is still on the node. That holds on both versions in use (v36 `selectRowNode` and v29
+ * `selectThisNode` both set `__selected` and dispatch inline), but a future version that batches
+ * selection events would make the marker silently dead - and no unit test can catch that, because
+ * the test's own `setSelected` stub *is* the synchronous dispatch.
+ * @internal
+ */
+export function isUserCheckboxToggle(node) {
+    return (typeof node === 'object' &&
+        node !== null &&
+        node[USER_TOGGLE_MARKER] === true);
+}
+/**
+ * True when a selection change came from the user rather than from a programmatic
+ * `setSelected()`, which defaults to source `'api'`.
+ * @internal
+ */
+export function isUserSelectionEvent(event) {
+    return USER_SELECTION_SOURCES.has(event.source) || isUserCheckboxToggle(event.node);
+}

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@genesislcap/pbc-reporting-ui",
   "description": "Genesis PBC Reporting UI",
-  "version": "15.19.2-FUI-2610.2",
+  "version": "15.19.2-canary.2",
   "license": "SEE LICENSE IN license.txt",
   "main": "dist/esm/index.js",
   "types": "dist/dts/index.d.ts",
@@ -86,32 +86,32 @@
     "@ag-grid-community/core": "29.2.0"
   },
   "dependencies": {
-    "@genesislcap/foundation-comms": "15.19.2-FUI-2610.2",
-    "@genesislcap/foundation-entity-management": "15.19.2-FUI-2610.2",
-    "@genesislcap/foundation-events": "15.19.2-FUI-2610.2",
-    "@genesislcap/foundation-forms": "15.19.2-FUI-2610.2",
-    "@genesislcap/foundation-logger": "15.19.2-FUI-2610.2",
-    "@genesislcap/foundation-notifications": "15.19.2-FUI-2610.2",
-    "@genesislcap/foundation-ui": "15.19.2-FUI-2610.2",
-    "@genesislcap/foundation-user": "15.19.2-FUI-2610.2",
-    "@genesislcap/foundation-utils": "15.19.2-FUI-2610.2",
-    "@genesislcap/foundation-zero": "15.19.2-FUI-2610.2",
-    "@genesislcap/foundation-zero-grid-pro": "15.19.2-FUI-2610.2",
-    "@genesislcap/grid-pro": "15.19.2-FUI-2610.2",
-    "@genesislcap/rapid-design-system": "15.19.2-FUI-2610.2",
-    "@genesislcap/rapid-grid-pro": "15.19.2-FUI-2610.2",
-    "@genesislcap/web-core": "15.19.2-FUI-2610.2",
+    "@genesislcap/foundation-comms": "15.19.2-canary.2",
+    "@genesislcap/foundation-entity-management": "15.19.2-canary.2",
+    "@genesislcap/foundation-events": "15.19.2-canary.2",
+    "@genesislcap/foundation-forms": "15.19.2-canary.2",
+    "@genesislcap/foundation-logger": "15.19.2-canary.2",
+    "@genesislcap/foundation-notifications": "15.19.2-canary.2",
+    "@genesislcap/foundation-ui": "15.19.2-canary.2",
+    "@genesislcap/foundation-user": "15.19.2-canary.2",
+    "@genesislcap/foundation-utils": "15.19.2-canary.2",
+    "@genesislcap/foundation-zero": "15.19.2-canary.2",
+    "@genesislcap/foundation-zero-grid-pro": "15.19.2-canary.2",
+    "@genesislcap/grid-pro": "15.19.2-canary.2",
+    "@genesislcap/rapid-design-system": "15.19.2-canary.2",
+    "@genesislcap/rapid-grid-pro": "15.19.2-canary.2",
+    "@genesislcap/web-core": "15.19.2-canary.2",
     "@reduxjs/toolkit": "^2.2.5",
     "@types/node": "^22.10.2",
     "change-case": "^5.4.3",
     "lodash": "^4.17.21"
   },
   "devDependencies": {
-    "@genesislcap/eslint-config": "15.19.2-FUI-2610.2",
-    "@genesislcap/foundation-testing": "15.19.2-FUI-2610.2",
-    "@genesislcap/genx": "15.19.2-FUI-2610.2",
-    "@genesislcap/prettier-config": "15.19.2-FUI-2610.2",
-    "@genesislcap/stylelint-config": "15.19.2-FUI-2610.2",
+    "@genesislcap/eslint-config": "15.19.2-canary.2",
+    "@genesislcap/foundation-testing": "15.19.2-canary.2",
+    "@genesislcap/genx": "15.19.2-canary.2",
+    "@genesislcap/prettier-config": "15.19.2-canary.2",
+    "@genesislcap/stylelint-config": "15.19.2-canary.2",
     "@types/json-schema": "^7.0.11",
     "playwright-lighthouse": "^4.0.0",
     "rimraf": "^5.0.0"