@genesislcap/foundation-forms 14.492.0-FUI-2571.4 → 14.492.0

package/dist/esm/form.js

@@ -29,7 +29,7 @@ import { NumberControlRendererEntry } from './jsonforms/renderers/NumberControlR
 import { SegmentedControlRendererEntry } from './jsonforms/renderers/SegmentedControlRenderer';
 import { StringArrayEntry } from './jsonforms/renderers/StringArrayControlRenderer';
 import { StringControlRendererTemplate } from './jsonforms/renderers/StringControlRenderer';
-import { buildReviewSections, downloadCsvTemplate as downloadCsvFile, extractFieldsFromUiSchema, generateCsvTemplate, getDataValueAtPath, logger, mapCsvToSchema, mapGenesisFieldErrorsToAdditionalErrors, parseCsv, } from './utils';
+import { downloadCsvTemplate as downloadCsvFile, extractFieldsFromUiSchema, generateCsvTemplate, logger, mapCsvToSchema, mapGenesisFieldErrorsToAdditionalErrors, parseCsv, } from './utils';
 import { findModalParent, showConfirmationDialog } from './utils/confirmation-dialog-utils';
 import { removeDataPropertiesNotInSchema } from './utils/form-utils';
 import { generateBulkUiSchema, isBulkUiSchema } from './utils/schema-utils';
@@ -149,55 +149,17 @@ let Form = class Form extends LifecycleMixin(FoundationElement) {
          * @public
          */
         this.data = {};
-        /**
-         * Text to appear on submit button
-         * @default Submit
-         * @public
-         */
-        this.submitButtonText = 'Submit';
-        /**
-         * Text to appear on submit button in bulk insert mode
-         * @default Submit AllS
-         * @public
-         */
-        this.bulkSubmitButtonText = 'Submit All';
-        /**
-         * Text to appear on reset button
-         * @default Submit
-         * @public
-         */
-        this.resetButtonText = 'Reset';
         /**
          * Minimum number of items required in bulk insert mode.
          * @public
          */
         this.bulkInsertMinItems = 1;
-        /**
-         * Text to appear on reset button
-         * @public
-         */
-        this.reviewButtonText = 'Review';
-        /**
-         * Heading shown at the top of the review panel.
-         * @public
-         */
-        this.reviewHeading = 'Review';
         /**
          * Tracks the submission status for each row in bulk insert mode.
          * Key is the row index, value is the status object.
          * @public
          */
         this.rowSubmitStatuses = new Map();
-        /**
-         * Whether the form is currently showing the submit-review preview panel.
-         * @internal
-         */
-        this.reviewMode = false;
-        /**
-         * Field label/value pairs rendered in the review panel, grouped into sections.
-         * @internal
-         */
-        this.reviewSections = [];
     }
     resourceNameChanged() {
         return __awaiter(this, void 0, void 0, function* () {
@@ -296,17 +258,6 @@ let Form = class Form extends LifecycleMixin(FoundationElement) {
         const { renderers: defaultRenderers = [], additionalRenderers = [] } = this;
         this.mergedRenderers = [...defaultRenderers, ...additionalRenderers];
     }
-    /**
-     * Value of `reviewIdField` resolved from the current form data, if set.
-     * @internal
-     */
-    get reviewRecordId() {
-        if (!this.reviewIdField) {
-            return undefined;
-        }
-        const value = getDataValueAtPath(this.data, this.reviewIdField);
-        return value === undefined || value === null ? undefined : String(value);
-    }
     /**
      * @internal
      */
@@ -336,60 +287,11 @@ let Form = class Form extends LifecycleMixin(FoundationElement) {
                 yield this._submitBulk();
                 return;
             }
-            // Show review preview if enabled and the form has no validation errors.
-            if (this.showSubmitReview && !this.hasValidationErrors()) {
-                this.reviewSections = yield buildReviewSections(this.data || {}, this.userProvidedUiSchema || this.uischema, this.originalDetailsSchema || this.jsonSchema);
-                this.reviewMode = true;
-                return;
-            }
-            yield this._performSubmit();
-        });
-    }
-    /**
-     * Called from the review panel to go back to the form.
-     * @internal
-     */
-    backFromReview() {
-        this.reviewMode = false;
-    }
-    /**
-     * Called from the review panel submit button to perform the actual submission.
-     * @internal
-     */
-    _submitFromReview() {
-        return __awaiter(this, void 0, void 0, function* () {
-            this.reviewMode = false;
-            yield this._performSubmit();
-        });
-    }
-    /**
-     * Whether the form currently has validation errors. Reads live errors directly from the
-     * json-forms element when it's mounted, so we always use the current validation state
-     * (this.errors can lag in edge cases such as required fields with empty-string values not
-     * yet reported via data-change). Falls back to this.errors when json-forms isn't mounted
-     * (e.g. while the read-only review panel is showing), which is safe since no interactive
-     * editing happens during review.
-     * @internal
-     */
-    hasValidationErrors() {
-        var _a, _b, _c, _d, _e, _f, _g, _h;
-        const jfEl = this.jsonFormsEl;
-        return jfEl
-            ? ((_d = (_c = (_b = (_a = jfEl.jsonforms) === null || _a === void 0 ? void 0 : _a.core) === null || _b === void 0 ? void 0 : _b.errors) === null || _c === void 0 ? void 0 : _c.length) !== null && _d !== void 0 ? _d : 0) > 0 ||
-                ((_h = (_g = (_f = (_e = jfEl.jsonforms) === null || _e === void 0 ? void 0 : _e.core) === null || _f === void 0 ? void 0 : _f.additionalErrors) === null || _g === void 0 ? void 0 : _g.length) !== null && _h !== void 0 ? _h : 0) > 0
-            : this.errors.length > 0;
-    }
-    /**
-     * Performs the actual API submission after review (or directly when review is disabled).
-     * @internal
-     */
-    _performSubmit() {
-        return __awaiter(this, void 0, void 0, function* () {
             const payload = Object.assign({}, this.data);
             const commitPayload = this.buildCommitPayload(payload);
             logger.debug({ payload, errors: this.errors });
             this.$emit('submit', { payload, errors: this.errors });
-            if (Object.entries(payload).length !== 0 && !this.hasValidationErrors() && this.resourceName) {
+            if (Object.entries(payload).length !== 0 && !this.errors.length && this.resourceName) {
                 this.submitting = true;
                 const formSubmitReq = yield this.connect.commitEvent(this.resourceName, commitPayload);
                 this.submitting = false;
@@ -736,8 +638,6 @@ let Form = class Form extends LifecycleMixin(FoundationElement) {
      */
     reset(clearData = true) {
         this.submitted = false;
-        this.reviewMode = false;
-        this.reviewSections = [];
         this.clearRowSubmitStatuses();
         this.serverFieldErrors = [];
         if (clearData) {
@@ -1002,15 +902,6 @@ __decorate([
 __decorate([
     attr({ attribute: 'bulk-insert', mode: 'boolean' })
 ], Form.prototype, "bulkInsert", void 0);
-__decorate([
-    attr({ attribute: 'submit-button-text' })
-], Form.prototype, "submitButtonText", void 0);
-__decorate([
-    attr({ attribute: 'bulk-submit-button-text' })
-], Form.prototype, "bulkSubmitButtonText", void 0);
-__decorate([
-    attr({ attribute: 'reset-button-text' })
-], Form.prototype, "resetButtonText", void 0);
 __decorate([
     attr({
         attribute: 'bulk-insert-min-items',
@@ -1029,27 +920,9 @@ __decorate([
         },
     })
 ], Form.prototype, "bulkInsertMaxItems", void 0);
-__decorate([
-    attr({ attribute: 'show-submit-review', mode: 'boolean' })
-], Form.prototype, "showSubmitReview", void 0);
-__decorate([
-    attr({ attribute: 'review-button-text' })
-], Form.prototype, "reviewButtonText", void 0);
-__decorate([
-    attr({ attribute: 'review-heading' })
-], Form.prototype, "reviewHeading", void 0);
-__decorate([
-    attr({ attribute: 'review-id-field' })
-], Form.prototype, "reviewIdField", void 0);
 __decorate([
     observable
 ], Form.prototype, "rowSubmitStatuses", void 0);
-__decorate([
-    observable
-], Form.prototype, "reviewMode", void 0);
-__decorate([
-    observable
-], Form.prototype, "reviewSections", void 0);
 __decorate([
     volatile
 ], Form.prototype, "isSubmitHidden", null);

package/dist/esm/form.styles.js

@@ -22,17 +22,10 @@ export const foundationFormStyles = css `
     min-width: 64px;
     width: 100%;
     height: 100%;
-    display: flex;
-    flex-direction: column;
-    overflow: hidden;
-    box-sizing: border-box;
-  }
-
-  foundation-form json-forms {
-    flex: 1;
     overflow-y: auto;
-    min-height: 0;
+    display: inline-block;
     scrollbar-color: var(--neutral-stroke-rest) transparent;
+    box-sizing: border-box;
   }
 
   foundation-form .actions {

package/dist/esm/form.template.js

@@ -6,12 +6,11 @@ import { CategorizationWrapper } from './jsonforms/renderers/CategorizationWrapp
 import { DispatchRenderer } from './jsonforms/renderers/dispatch-renderer';
 import { StepperWrapper } from './jsonforms/renderers/StepperWrapperRenderer';
 import { VerticalCategorizationWrapper } from './jsonforms/renderers/VerticalCategorizationWrapperRenderer';
-import { Review } from './review';
-avoidTreeShaking(JSONForms, ArrayListWrapper, CategorizationWrapper, VerticalCategorizationWrapper, DispatchRenderer, StepperWrapper, Review);
+avoidTreeShaking(JSONForms, ArrayListWrapper, CategorizationWrapper, VerticalCategorizationWrapper, DispatchRenderer, StepperWrapper);
 /** @internal */
 export const getPrefixedForm = (prefix) => html `
   <template>
-    ${when((x) => !x.reviewMode && x.bulkInsert, html `
+    ${when((x) => x.bulkInsert, html `
         <div class="csv-upload-section" part="csv-upload">
           <input
             type="file"
@@ -40,76 +39,43 @@ export const getPrefixedForm = (prefix) => html `
           </${prefix}-button>
         </div>
       `)}
-    ${when((x) => !x.reviewMode, html `
-        <json-forms
-          ${ref('jsonFormsEl')}
-          @submit-button-clicked=${(x) => x._submit()}
-          @submit-part=${(x, c) => x.submitPart(c.event)}
-          @submit-single-row=${(x, c) => x.submitSingleRow(c.event.detail.index)}
-          @reset-form=${(x) => x.reset(false)}
-          ?readonly=${(x) => x.readonly}
-          :submitted=${(x) => x.submitted}
-          :renderers=${(x) => x.mergedRenderers}
-          :uischema=${(x) => x.uischema}
-          :schema=${(x) => x.jsonSchema}
-          :data=${(x) => x.data}
-          :serverFieldErrors=${(x) => x.serverFieldErrors}
-          :prefix=${(x) => x.prefix}
-          :rowSubmitStatuses=${(x) => x.rowSubmitStatuses}
-          :bulkInsert=${(x) => x.bulkInsert}
-          @data-change=${(x, c) => x.onChange(c.event)}
-        ></json-forms>
-      `)}
-    ${when((x) => x.reviewMode, html `
-        <foundation-form-review
-          part="review-panel"
-          design-system-prefix=${(x) => x.prefix}
-          heading=${(x) => x.reviewHeading}
-          :recordId=${(x) => x.reviewRecordId}
-          :sections=${(x) => x.reviewSections}
-        ></foundation-form-review>
-      `)}
-    ${when((x) => x.reviewMode || x.isSubmitHidden || x.isResetVisible, html `
+    <json-forms
+      @submit-button-clicked=${(x) => x._submit()}
+      @submit-part=${(x, c) => x.submitPart(c.event)}
+      @submit-single-row=${(x, c) => x.submitSingleRow(c.event.detail.index)}
+      @reset-form=${(x) => x.reset(false)}
+      ?readonly=${(x) => x.readonly}
+      :submitted=${(x) => x.submitted}
+      :renderers=${(x) => x.mergedRenderers}
+      :uischema=${(x) => x.uischema}
+      :schema=${(x) => x.jsonSchema}
+      :data=${(x) => x.data}
+      :serverFieldErrors=${(x) => x.serverFieldErrors}
+      :prefix=${(x) => x.prefix}
+      :rowSubmitStatuses=${(x) => x.rowSubmitStatuses}
+      :bulkInsert=${(x) => x.bulkInsert}
+      @data-change=${(x, c) => x.onChange(c.event)}
+    ></json-forms>
+    ${when((x) => x.isSubmitHidden || x.isResetVisible, html `
         <slot name="userActions" part="userActions" class="actions">
-          ${when((x) => !x.reviewMode && x.isResetVisible, html `
+          ${when((x) => x.isResetVisible, html `
               <${prefix}-button
                 @click="${(x) => x.handleResetClicked()}"
                 class="reset-button"
                 appearance="neutral"
                 data-test-id="reset-button"
               >
-                ${(x) => x.resetButtonText}
-              </${prefix}-button>
-            `)}
-          ${when((x) => x.reviewMode, html `
-              <${prefix}-button
-                @click="${(x) => x.backFromReview()}"
-                class="reset-button"
-                appearance="neutral"
-                data-test-id="review-back-button"
-              >
-                Back
+                Reset
               </${prefix}-button>
             `)}
-          ${when((x) => !x.reviewMode && x.isSubmitHidden, html `
+          ${when((x) => x.isSubmitHidden, html `
               <${prefix}-button
                 @click="${(x) => x._submit()}"
-                ?disabled=${(x) => !x.submitting}
-                class="submit-button"
-                appearance="accent"
-              >
-                ${(x) => (x.bulkInsert ? x.bulkSubmitButtonText : x.submitButtonText)}
-              </${prefix}-button>
-            `)}
-          ${when((x) => x.reviewMode, html `
-              <${prefix}-button
-                @click="${(x) => x._submitFromReview()}"
-                ?disabled=${(x) => x.submitting}
+                ?disable=${(x) => !x.submitting}
                 class="submit-button"
                 appearance="accent"
-                data-test-id="review-submit-button"
               >
-                ${(x) => (x.showSubmitReview ? x.reviewButtonText : x.submitButtonText)}
+                ${(x) => (x.bulkInsert ? 'Submit All' : 'Submit')}
               </${prefix}-button>
             `)}
         </slot>

package/dist/esm/index.js

@@ -2,9 +2,6 @@ export * from './filters';
 export * from './form';
 export * from './form.styles';
 export * from './form.template';
-export * from './review';
-export * from './review.styles';
-export * from './review.template';
 export { MulticolumnDropdownControlRendererEntry, MulticolumnDropdownControlRendererTemplate, } from './jsonforms/renderers/MulticolumnDropdownControlRenderer';
 export { LayoutVerticalCategorizationRendererEntry } from './jsonforms/renderers/LayoutVerticalCategorizationRenderer';
 export { controlWrapperTemplate, controlWrapperStyles, 

package/dist/esm/jsonforms/renderers/CategorizationWrapperRenderer.js

@@ -1,7 +1,6 @@
 import { __decorate } from "tslib";
 import { html, css, observable, customElement, FASTElement, repeat, when, } from '@microsoft/fast-element';
 import { classNames } from '@microsoft/fast-web-utilities';
-import { extractErrorScopes, uiSchemaHasAnyError } from '../../utils/schema-utils';
 /**
  * Resolves the `activeCategory` option (the zero-based index of the category
  * tab that should open on first render) to a valid tab index. Out-of-bounds or
@@ -161,3 +160,48 @@ CategorizationWrapper = __decorate([
     })
 ], CategorizationWrapper);
 export { CategorizationWrapper };
+function uiSchemaHasAnyError(uiSchema, errorScopes) {
+    // Direct scope match
+    if (typeof uiSchema.scope === 'string' &&
+        errorScopes.includes(uiSchema.scope)) {
+        return true;
+    }
+    // Check composite children via options.childElements
+    const options = uiSchema.options;
+    const childElements = options === null || options === void 0 ? void 0 : options.childElements;
+    if (Array.isArray(childElements)) {
+        for (const child of childElements) {
+            if (uiSchemaHasAnyError(child, errorScopes)) {
+                return true;
+            }
+        }
+    }
+    // Check layout children (elements)
+    if (Array.isArray(uiSchema.elements)) {
+        for (const el of uiSchema.elements) {
+            if (uiSchemaHasAnyError(el, errorScopes)) {
+                return true;
+            }
+        }
+    }
+    return false;
+}
+function extractErrorScopes(errors) {
+    var _a;
+    const scopes = new Set();
+    for (const error of errors) {
+        if (error.keyword === 'required' && ((_a = error.params) === null || _a === void 0 ? void 0 : _a.missingProperty)) {
+            const basePath = error.instancePath || '';
+            const prop = error.params.missingProperty;
+            // Normalize the base path
+            const fullPath = basePath === '' ? `#/properties/${prop}` : `#${basePath}/properties/${prop}`;
+            scopes.add(fullPath);
+        }
+        else if (error.instancePath) {
+            // Remove leading slash and convert to JSON Pointer path
+            const instancePath = `#${error.instancePath.replace(/\//g, '/properties/')}`;
+            scopes.add(instancePath);
+        }
+    }
+    return Array.from(scopes);
+}

package/dist/esm/utils/index.js

@@ -1,5 +1,4 @@
 export * from './csv-parser';
-export * from './review-utils';
 export * from './filters';
 export * from './logger';
 export * from './translation';

package/dist/esm/utils/schema-utils.js

@@ -93,54 +93,6 @@ export function isBulkUiSchema(uischema) {
     var _a;
     return (_a = uischema === null || uischema === void 0 ? void 0 : uischema.elements) === null || _a === void 0 ? void 0 : _a.some((element) => element.scope === '#/properties/items' && element.type === 'Control');
 }
-/**
- * Converts AJV validation errors to the JSON Schema scope strings they correspond to
- * (e.g. `#/properties/ADDRESS/properties/STREET`). Used to match errors back to UI
- * schema controls for features like categorization-tab error indicators.
- */
-export function extractErrorScopes(errors) {
-    var _a;
-    const scopes = new Set();
-    for (const error of errors) {
-        if (error.keyword === 'required' && ((_a = error.params) === null || _a === void 0 ? void 0 : _a.missingProperty)) {
-            const basePath = error.instancePath || '';
-            const prop = error.params.missingProperty;
-            const fullPath = basePath === '' ? `#/properties/${prop}` : `#${basePath}/properties/${prop}`;
-            scopes.add(fullPath);
-        }
-        else if (error.instancePath) {
-            // Convert JSON Pointer /ADDRESS/STREET → #/properties/ADDRESS/properties/STREET
-            const instancePath = `#${error.instancePath.replace(/\//g, '/properties/')}`;
-            scopes.add(instancePath);
-        }
-    }
-    return Array.from(scopes);
-}
-/**
- * Returns true when `uiSchema` (or any of its descendants) has a scope that appears
- * in `errorScopes`. Walks both `elements` and `options.childElements`.
- */
-export function uiSchemaHasAnyError(uiSchema, errorScopes) {
-    var _a;
-    if (typeof uiSchema.scope === 'string' &&
-        errorScopes.includes(uiSchema.scope)) {
-        return true;
-    }
-    const childElements = (_a = uiSchema.options) === null || _a === void 0 ? void 0 : _a.childElements;
-    if (Array.isArray(childElements)) {
-        for (const child of childElements) {
-            if (uiSchemaHasAnyError(child, errorScopes))
-                return true;
-        }
-    }
-    if (Array.isArray(uiSchema.elements)) {
-        for (const el of uiSchema.elements) {
-            if (uiSchemaHasAnyError(el, errorScopes))
-                return true;
-        }
-    }
-    return false;
-}
 /**
  * Generates a UI schema suitable for bulk insert mode with array control.
  * @param userProvidedUiSchema - Optional user-provided UI schema to use as childUiSchema