@genesislcap/ai-assistant 15.23.2 → 15.24.0-FUI-2603.10

package/dist/chat-driver.cjs

@@ -4400,6 +4400,78 @@ function accumulate(messages, into) {
 // src/utils/tool-fold.ts
 var TOOL_FOLD_SYMBOL = Symbol("toolFold");
 
+// src/components/chat-driver/turn-failures.ts
+var TURN_FAILURE_EXITS = {
+  contextGuard: {
+    subReason: "context_exhausted",
+    resultReason: "context-exhausted",
+    copy: "I had to stop here \u2014 this conversation has filled the available context. Compact it to free up room, then ask me to continue."
+  },
+  contextOverflow: {
+    subReason: "context_exhausted",
+    resultReason: "context-exhausted",
+    copy: DEFAULT_CONTEXT_OVERFLOW_MESSAGE
+  },
+  malformedToolCall: {
+    subReason: "malformed_tool_call",
+    // Not `malformed-tool-call`: the main-turn reason is named after the provider finish
+    // reason (`MALFORMED_FUNCTION_CALL`) that produces it, and is part of the published
+    // TurnFailureReason union, so the two names cannot be brought into line here.
+    resultReason: "malformed-function-call",
+    copy: "While working on your request, I repeatedly called my tools incorrectly. This often works on a second try \u2014 would you like me to try again? If it happens again, try breaking your request into smaller steps."
+  },
+  responseTruncated: {
+    subReason: "response_truncated",
+    resultReason: "response-truncated",
+    copy: "My response was cut off because a single step reached the model output limit. This usually means one step tried to produce too much at once \u2014 try breaking your request into smaller steps."
+  },
+  timeout: {
+    subReason: "timeout",
+    // There is no `timeout` member of TurnFailureReason, so the main turn reports the
+    // generic `exception`. A sub-agent gets the specific reason because its parent
+    // branches on it to decide whether a retry is worth attempting.
+    resultReason: "exception",
+    copy: "The request timed out. You can ask me to try again, or break this into a smaller step."
+  },
+  unknownToolLimit: {
+    subReason: "unknown_tool_limit",
+    resultReason: "unknown-tool-limit",
+    copy: "I'm sorry, I repeatedly tried to use tools that aren't available to me, so I couldn't complete that. If a 'Download agent log' option appears in the Settings (cog) menu, you can download the log and share it with whoever set up this assistant to help fix the issue."
+  },
+  maxIterations: {
+    subReason: "max_iterations",
+    resultReason: "max-iterations",
+    copy: "I've reached my limit for this response. You can ask me to continue and I'll pick up where I left off."
+  },
+  refusal: {
+    subReason: "refusal",
+    resultReason: "refusal",
+    copy: "This request was declined. Try rephrasing it, or breaking it into smaller steps."
+  },
+  emptyResponse: {
+    subReason: "empty_response",
+    resultReason: "empty-response",
+    copy: "While working on your request, I repeatedly generated a blank response. This often works on a second try \u2014 would you like me to try again? If it happens again, try breaking your request into smaller steps."
+  },
+  providerRefused: {
+    subReason: "provider_refused",
+    resultReason: "provider-refused",
+    // Overridden per wall by `ChatDriver.providerRefusedBubble`, which prefers a
+    // host-supplied message; this is the fallback that method returns.
+    copy: DEFAULT_PROVIDER_REFUSED_MESSAGE
+  },
+  budgetExhausted: {
+    subReason: "budget_exhausted",
+    resultReason: "budget-exhausted",
+    // Overridden per wall by `ChatDriver.budgetExhaustedBubble`, which upgrades this with
+    // "switch to another AI" when a second vendor is reachable.
+    copy: DEFAULT_BUDGET_EXHAUSTED_MESSAGE
+  }
+  // `satisfies`, not an annotation: an annotation would widen `resultReason` to
+  // `TurnFailureReason` and cost the literal types that let `turn-failures.test.ts` pin the
+  // two deliberate divergences at compile time instead of at runtime.
+};
+
 // src/components/chat-driver/chat-driver.ts
 var toolResultImages = (result) => {
   if (!result || typeof result !== "object") return void 0;
@@ -4774,6 +4846,33 @@ var ChatDriver = class _ChatDriver extends EventTarget {
       ...providerRefused ? { providerRefused } : {}
     };
   }
+  /**
+   * End the turn on a terminal failure: fail upward when this driver is a sub-agent, speak
+   * to the user when it is not, and hand the reason to the caller either way.
+   *
+   * Only that fork lives here. Each exit keeps its own `recordTurnError` call, because the
+   * telemetry payload is what legitimately differs between them — attempt counts, token
+   * figures, tool names — and folding it in would mean one optional field per condition.
+   *
+   * `overrides.copy` serves the two walls whose prose is composed per occurrence:
+   * `budgetExhaustedBubble` names the vendor and can offer another, `providerRefusedBubble`
+   * prefers a host-supplied message. Every other exit reads its copy from the table.
+   *
+   * One exit stays out: the `BudgetExhaustedError` catch. Not because its shape differs —
+   * its two telemetry payloads are field-for-field identical — but because its main-turn
+   * branch calls `reportBudgetExhausted`, which is public and also serves
+   * `OrchestratingDriver`'s classification phase, where no tool loop is running. That
+   * method has to survive either way, so routing the catch through here would relocate the
+   * duplication rather than remove it.
+   */
+  endTurnWithFailure(exit, overrides) {
+    if (this.isSubAgent) {
+      this.failSubAgent(exit.subReason, overrides?.budget, overrides?.providerRefused);
+    } else {
+      this.appendDriverNotice(overrides?.copy ?? exit.copy);
+    }
+    return this.turnDone(exit.resultReason, overrides?.budget, overrides?.providerRefused);
+  }
   /**
    * Terminal budget outcome for a wall hit **outside** the tool loop — today,
    * `OrchestratingDriver`'s classification phase, which calls the provider
@@ -4802,7 +4901,7 @@ var ChatDriver = class _ChatDriver extends EventTarget {
    */
   budgetExhaustedBubble(wall) {
     if (this.budgetExhaustedMessageOverride != null) return this.budgetExhaustedMessageOverride;
-    if (wall?.otherVendorAvailable !== true) return DEFAULT_BUDGET_EXHAUSTED_MESSAGE;
+    if (wall?.otherVendorAvailable !== true) return TURN_FAILURE_EXITS.budgetExhausted.copy;
     const subject = wall?.vendorLabel ? `${wall.vendorLabel}'s AI usage limit` : "your AI usage limit";
     return `You've reached ${subject}. Switch to another AI provider in Settings to keep going, or contact your administrator to raise it.`;
   }
@@ -4836,32 +4935,7 @@ var ChatDriver = class _ChatDriver extends EventTarget {
    * has gone unpaid — so there is nothing here to compose. A host override wins verbatim.
    */
   providerRefusedBubble() {
-    return this.providerRefusedMessageOverride ?? DEFAULT_PROVIDER_REFUSED_MESSAGE;
-  }
-  /**
-   * Terminal provider-refusal outcome. Mirrors `reportBudgetExhausted` so the two walls behave
-   * identically from the caller's side, while keeping their diagnostics distinct.
-   *
-   * `kind` reaches the debug log and the result but never the transcript: it is what lets an operator
-   * tell "top up the account" from "rotate the key", and with cause-free user copy this is the only
-   * place that distinction survives.
-   */
-  reportProviderRefused(e) {
-    const detail = providerRefusedDetailOf(e);
-    this.providerRefusedThisTurn = true;
-    this.providerRefusedDetail = detail;
-    logger2.error("ChatDriver: provider refused the request", e);
-    recordTurnError(this.sessionKey, "provider-refused", {
-      agent: this.activeAgentName,
-      provider: this.lastResolvedProviderName,
-      vendor: vendorTypeOfLabel(e.vendorLabel) ?? this.lastResolvedProvider,
-      kind: e.kind,
-      upstreamStatus: e.upstreamStatus,
-      upstreamType: e.upstreamType,
-      isSubAgent: this.isSubAgent
-    });
-    this.appendDriverNotice(this.providerRefusedBubble());
-    return this.turnDone("provider-refused", void 0, detail);
+    return this.providerRefusedMessageOverride ?? TURN_FAILURE_EXITS.providerRefused.copy;
   }
   /** The typed failure reason on a loop result, or `undefined` for a clean turn / handoff. */
   static failureReasonOf(result) {
@@ -6152,12 +6226,10 @@ Output format (strict):
           via: "sub-agent",
           isSubAgent: this.isSubAgent
         });
-        if (this.isSubAgent) {
-          this.failSubAgent("provider_refused", void 0, this.providerRefusedDetail);
-        } else {
-          this.appendDriverNotice(this.providerRefusedBubble());
-        }
-        return this.turnDone("provider-refused", void 0, this.providerRefusedDetail);
+        return this.endTurnWithFailure(TURN_FAILURE_EXITS.providerRefused, {
+          copy: this.providerRefusedBubble(),
+          providerRefused: this.providerRefusedDetail
+        });
       }
       if (this.budgetExhaustedThisTurn) {
         logger2.error("ChatDriver: ending the turn \u2014 a sub-agent hit the AI budget wall");
@@ -6177,12 +6249,10 @@ Output format (strict):
           via: "sub-agent",
           isSubAgent: this.isSubAgent
         });
-        if (this.isSubAgent) {
-          this.failSubAgent("budget_exhausted", this.budgetWallDetail);
-        } else {
-          this.appendDriverNotice(this.budgetExhaustedBubble(this.budgetWallDetail));
-        }
-        return this.turnDone("budget-exhausted", this.budgetWallDetail);
+        return this.endTurnWithFailure(TURN_FAILURE_EXITS.budgetExhausted, {
+          copy: this.budgetExhaustedBubble(this.budgetWallDetail),
+          budget: this.budgetWallDetail
+        });
       }
       const promptCtx = {
         agentName: this.activeAgentName ?? "",
@@ -6347,14 +6417,7 @@ ${tailBody}
           iterations,
           isSubAgent: this.isSubAgent
         });
-        if (this.isSubAgent) {
-          this.failSubAgent("context_exhausted");
-        } else {
-          this.appendDriverNotice(
-            "I had to stop here \u2014 this conversation has filled the available context. Compact it to free up room, then ask me to continue."
-          );
-        }
-        return this.turnDone("context-exhausted");
+        return this.endTurnWithFailure(TURN_FAILURE_EXITS.contextGuard);
       }
       let response;
       try {
@@ -6384,14 +6447,7 @@ ${tailBody}
             finishMessage: e.finishMessage,
             isSubAgent: this.isSubAgent
           });
-          if (this.isSubAgent) {
-            this.failSubAgent("malformed_tool_call");
-          } else {
-            this.appendDriverNotice(
-              "While working on your request, I repeatedly called my tools incorrectly. This often works on a second try \u2014 would you like me to try again? If it happens again, try breaking your request into smaller steps."
-            );
-          }
-          return this.turnDone("malformed-function-call");
+          return this.endTurnWithFailure(TURN_FAILURE_EXITS.malformedToolCall);
         }
         if (e instanceof ResponseTruncatedError) {
           logger2.error("ChatDriver: response truncated at the output-token cap", e);
@@ -6404,14 +6460,7 @@ ${tailBody}
             tools: e.toolNames,
             isSubAgent: this.isSubAgent
           });
-          if (this.isSubAgent) {
-            this.failSubAgent("response_truncated");
-          } else {
-            this.appendDriverNotice(
-              "My response was cut off because a single step reached the model output limit. This usually means one step tried to produce too much at once \u2014 try breaking your request into smaller steps."
-            );
-          }
-          return this.turnDone("response-truncated");
+          return this.endTurnWithFailure(TURN_FAILURE_EXITS.responseTruncated);
         }
         if (e instanceof ContextOverflowError) {
           logger2.error("ChatDriver: the prompt exceeded the model context window", e);
@@ -6424,30 +6473,28 @@ ${tailBody}
             via: "provider",
             isSubAgent: this.isSubAgent
           });
-          if (this.isSubAgent) {
-            this.failSubAgent("context_exhausted");
-          } else {
-            this.appendDriverNotice(DEFAULT_CONTEXT_OVERFLOW_MESSAGE);
-          }
-          return this.turnDone("context-exhausted");
+          return this.endTurnWithFailure(TURN_FAILURE_EXITS.contextOverflow);
         }
         if (e instanceof ProviderRefusedError) {
-          if (this.isSubAgent) {
-            logger2.error("ChatDriver: provider refused the request", e);
-            recordTurnError(this.sessionKey, "provider-refused", {
-              agent: this.activeAgentName,
-              provider: this.lastResolvedProviderName,
-              vendor: vendorTypeOfLabel(e.vendorLabel) ?? this.lastResolvedProvider,
-              kind: e.kind,
-              upstreamStatus: e.upstreamStatus,
-              upstreamType: e.upstreamType,
-              isSubAgent: true
-            });
-            const detail = providerRefusedDetailOf(e);
-            this.failSubAgent("provider_refused", void 0, detail);
-            return this.turnDone("provider-refused", void 0, detail);
+          const detail = providerRefusedDetailOf(e);
+          if (!this.isSubAgent) {
+            this.providerRefusedThisTurn = true;
+            this.providerRefusedDetail = detail;
           }
-          return this.reportProviderRefused(e);
+          logger2.error("ChatDriver: provider refused the request", e);
+          recordTurnError(this.sessionKey, "provider-refused", {
+            agent: this.activeAgentName,
+            provider: this.lastResolvedProviderName,
+            vendor: vendorTypeOfLabel(e.vendorLabel) ?? this.lastResolvedProvider,
+            kind: e.kind,
+            upstreamStatus: e.upstreamStatus,
+            upstreamType: e.upstreamType,
+            isSubAgent: this.isSubAgent
+          });
+          return this.endTurnWithFailure(TURN_FAILURE_EXITS.providerRefused, {
+            copy: this.providerRefusedBubble(),
+            providerRefused: detail
+          });
         }
         if (e instanceof BudgetExhaustedError) {
           this.budgetExhaustedThisTurn = true;
@@ -6477,14 +6524,7 @@ ${tailBody}
             message: e.message,
             isSubAgent: this.isSubAgent
           });
-          if (this.isSubAgent) {
-            this.failSubAgent("timeout");
-          } else {
-            this.appendDriverNotice(
-              "The request timed out. You can ask me to try again, or break this into a smaller step."
-            );
-          }
-          return this.turnDone("exception");
+          return this.endTurnWithFailure(TURN_FAILURE_EXITS.timeout);
         }
         if (e instanceof DOMException && e.name === "AbortError") {
           return this.completeAbortedTurn();
@@ -6536,11 +6576,11 @@ ${tailBody}
           iterations -= 1;
           continue;
         }
-        const failureReason2 = isRefusal ? "refusal" : "empty-response";
+        const exit = isRefusal ? TURN_FAILURE_EXITS.refusal : TURN_FAILURE_EXITS.emptyResponse;
         logger2.error(
           isRefusal ? "ChatDriver: model refused the request (safety decline) \u2014 not retrying" : "ChatDriver: empty model response after all retries"
         );
-        recordTurnError(this.sessionKey, failureReason2, {
+        recordTurnError(this.sessionKey, exit.resultReason, {
           agent: this.activeAgentName,
           provider: this.lastResolvedProviderName,
           attempts: emptyResponseAttempts,
@@ -6550,14 +6590,7 @@ ${tailBody}
           isSubAgent: this.isSubAgent,
           ...response.responseMeta
         });
-        if (this.isSubAgent) {
-          this.failSubAgent(isRefusal ? "refusal" : "empty_response");
-        } else {
-          this.appendDriverNotice(
-            isRefusal ? "This request was declined. Try rephrasing it, or breaking it into smaller steps." : "While working on your request, I repeatedly generated a blank response. This often works on a second try \u2014 would you like me to try again? If it happens again, try breaking your request into smaller steps."
-          );
-        }
-        return this.turnDone(failureReason2);
+        return this.endTurnWithFailure(exit);
       } else {
         const { reasoning, ...rest } = response;
         const displayOnly = {
@@ -6857,14 +6890,7 @@ RECOVERY: this tool failed once \u2014 you may retry it, or take a different val
           availableTools: Object.keys(this.toolHandlers),
           isSubAgent: this.isSubAgent
         });
-        if (this.isSubAgent) {
-          this.failSubAgent("unknown_tool_limit");
-        } else {
-          this.appendDriverNotice(
-            "I'm sorry, I repeatedly tried to use tools that aren't available to me, so I couldn't complete that. If a 'Download agent log' option appears in the Settings (cog) menu, you can download the log and share it with whoever set up this assistant to help fix the issue."
-          );
-        }
-        return this.turnDone("unknown-tool-limit");
+        return this.endTurnWithFailure(TURN_FAILURE_EXITS.unknownToolLimit);
       }
       const firstContinuation = systemCalls[0];
       if (firstContinuation) {
@@ -6875,7 +6901,6 @@ RECOVERY: this tool failed once \u2014 you may retry it, or take a different val
         return this.turnDone();
       }
     }
-    let failureReason;
     if (iterations >= this.maxToolIterations) {
       logger2.warn("ChatDriver: reached max tool iterations, stopping");
       recordTurnError(this.sessionKey, "max-iterations", {
@@ -6885,16 +6910,9 @@ RECOVERY: this tool failed once \u2014 you may retry it, or take a different val
         limit: this.maxToolIterations,
         isSubAgent: this.isSubAgent
       });
-      if (this.isSubAgent) {
-        this.failSubAgent("max_iterations");
-      } else {
-        this.appendDriverNotice(
-          "I've reached my limit for this response. You can ask me to continue and I'll pick up where I left off."
-        );
-      }
-      failureReason = "max-iterations";
+      return this.endTurnWithFailure(TURN_FAILURE_EXITS.maxIterations);
     }
-    return this.turnDone(failureReason);
+    return this.turnDone();
   }
   /**
    * Append prose the DRIVER wrote rather than the model — a failure notice, a limit explanation,