@gempack/squad-mcp 0.6.4 → 0.7.0

package/tools/post-review.mjs

@@ -77,8 +77,7 @@ function parseArgs(argv) {
     }
   }
   if (!out.pr) fail(2, "--pr <number> is required");
-  if (!/^\d+$/.test(out.pr))
-    fail(2, `--pr must be a positive integer, got "${out.pr}"`);
+  if (!/^\d+$/.test(out.pr)) fail(2, `--pr must be a positive integer, got "${out.pr}"`);
   return out;
 }
 
@@ -100,10 +99,7 @@ function ensureGh() {
   const r = spawnSync("gh", ["--version"], { encoding: "utf8" });
   if (r.error) {
     if (r.error.code === "ENOENT") {
-      fail(
-        3,
-        "gh CLI not found in PATH. Install: https://cli.github.com/manual/installation",
-      );
+      fail(3, "gh CLI not found in PATH. Install: https://cli.github.com/manual/installation");
     }
     fail(3, `gh check failed: ${r.error.message}`);
   }
@@ -121,8 +117,19 @@ function runGh(args, body) {
     proc.stderr.on("data", (d) => (stderr += d));
     proc.on("error", reject);
     proc.on("close", (code) => resolve({ code, stdout, stderr }));
-    proc.stdin.write(body);
-    proc.stdin.end();
+    proc.stdin.on("error", reject);
+    // Respect backpressure: if the kernel pipe is full, write() returns false
+    // and we must wait for "drain" before continuing. Pre-fix this code wrote
+    // a large body without awaiting drain, which on small pipe buffers
+    // truncated the body silently (gh exits 0 with the prefix only).
+    const ok = proc.stdin.write(body, (err) => {
+      if (err) reject(err);
+    });
+    if (ok) {
+      proc.stdin.end();
+    } else {
+      proc.stdin.once("drain", () => proc.stdin.end());
+    }
   });
 }
 
@@ -145,11 +152,7 @@ async function main() {
   } catch (err) {
     fail(2, `invalid JSON on stdin: ${err.message}`);
   }
-  if (
-    !consolidation ||
-    typeof consolidation !== "object" ||
-    !consolidation.verdict
-  ) {
+  if (!consolidation || typeof consolidation !== "object" || !consolidation.verdict) {
     fail(
       2,
       "stdin JSON missing required `verdict` field — expected output of apply_consolidation_rules",
@@ -169,14 +172,7 @@ async function main() {
     body = body.replace(/\n\n---\n[\s\S]*$/, "\n");
   }
 
-  const ghArgs = [
-    "pr",
-    "review",
-    opts.pr,
-    `--${payload.action}`,
-    "--body-file",
-    "-",
-  ];
+  const ghArgs = ["pr", "review", opts.pr, `--${payload.action}`, "--body-file", "-"];
   if (opts.repo) ghArgs.push("--repo", opts.repo);
 
   if (opts.dryRun) {
@@ -186,25 +182,19 @@ async function main() {
     );
     process.stdout.write(body);
     process.stdout.write(`EOF\n`);
-    process.stdout.write(
-      `\n# Action: ${payload.action}\n# Summary: ${payload.summary}\n`,
-    );
+    process.stdout.write(`\n# Action: ${payload.action}\n# Summary: ${payload.summary}\n`);
     process.exit(0);
   }
 
   ensureGh();
   const r = await runGh(ghArgs, body);
   if (r.code !== 0) {
-    process.stderr.write(
-      `gh ${payload.action} failed (exit ${r.code}):\n${r.stderr}`,
-    );
+    process.stderr.write(`gh ${payload.action} failed (exit ${r.code}):\n${r.stderr}`);
     process.exit(4);
   }
   // gh prints the review URL on success; surface it to the caller.
   if (r.stdout) process.stdout.write(r.stdout);
-  process.stdout.write(
-    `\nposted: ${payload.action} on PR #${opts.pr} | ${payload.summary}\n`,
-  );
+  process.stdout.write(`\nposted: ${payload.action} on PR #${opts.pr} | ${payload.summary}\n`);
 }
 
 main().catch((err) => {

package/tools/record-learning.mjs

@@ -32,6 +32,7 @@
 
 import { promises as fs } from "node:fs";
 import path from "node:path";
+import { ensureRelativeInsideRoot } from "./_tasks-io.mjs";
 
 const args = process.argv.slice(2);
 
@@ -57,13 +58,11 @@ function parseArgs(argv) {
     const a = argv[i];
     switch (a) {
       case "--accept":
-        if (out.decision)
-          fail(2, "--accept and --reject are mutually exclusive");
+        if (out.decision) fail(2, "--accept and --reject are mutually exclusive");
         out.decision = "accept";
         break;
       case "--reject":
-        if (out.decision)
-          fail(2, "--accept and --reject are mutually exclusive");
+        if (out.decision) fail(2, "--accept and --reject are mutually exclusive");
         out.decision = "reject";
         break;
       case "--agent":
@@ -127,16 +126,14 @@ async function main() {
   if (opts.branch) entry.branch = opts.branch;
   if (opts.scope) entry.scope = opts.scope;
 
-  const target = path.resolve(
-    opts.workspace,
-    opts.file ?? ".squad/learnings.jsonl",
-  );
+  if (opts.file !== undefined) {
+    ensureRelativeInsideRoot(opts.workspace, opts.file, "learnings.path");
+  }
+  const target = path.resolve(opts.workspace, opts.file ?? ".squad/learnings.jsonl");
   await fs.mkdir(path.dirname(target), { recursive: true });
   await fs.appendFile(target, JSON.stringify(entry) + "\n", "utf8");
 
-  process.stdout.write(
-    `recorded: ${opts.decision} on ${opts.agent} — "${opts.finding}"\n`,
-  );
+  process.stdout.write(`recorded: ${opts.decision} on ${opts.agent} — "${opts.finding}"\n`);
   process.stdout.write(`file:     ${target}\n`);
 }
 

package/tools/record-tasks.mjs

@@ -25,12 +25,7 @@
 // validates the full zod schema.
 
 import { promises as fs } from "node:fs";
-import {
-  readTasksFile,
-  writeTasksFile,
-  VALID_PRIORITIES,
-  fail,
-} from "./_tasks-io.mjs";
+import { readTasksFile, writeTasksFile, VALID_PRIORITIES, fail } from "./_tasks-io.mjs";
 
 const args = process.argv.slice(2);
 const PROG = "record-tasks";
@@ -101,9 +96,7 @@ function validateInputs(inputs) {
 
 async function main() {
   const opts = parseArgs(args);
-  const raw = opts.input
-    ? await fs.readFile(opts.input, "utf8")
-    : await readStdin();
+  const raw = opts.input ? await fs.readFile(opts.input, "utf8") : await readStdin();
 
   let inputs;
   try {

package/tools/update-task-status.mjs

@@ -16,12 +16,7 @@
 //   0 success
 //   2 invalid input or task/subtask not found
 
-import {
-  readTasksFile,
-  writeTasksFile,
-  VALID_STATUSES,
-  fail,
-} from "./_tasks-io.mjs";
+import { readTasksFile, writeTasksFile, VALID_STATUSES, fail } from "./_tasks-io.mjs";
 
 const args = process.argv.slice(2);
 const PROG = "update-task-status";
@@ -87,9 +82,7 @@ async function main() {
   const original = data.tasks[idx];
 
   if (opts.subtask !== null) {
-    const sIdx = (original.subtasks ?? []).findIndex(
-      (s) => s.id === opts.subtask,
-    );
+    const sIdx = (original.subtasks ?? []).findIndex((s) => s.id === opts.subtask);
     if (sIdx < 0) {
       fail(PROG, 2, `subtask ${opts.subtask} not found on task ${opts.task}`);
     }