@geminixiang/mikan 1.0.0-beta.85 → 1.0.0-beta.86

package/dist/adapters/github/bot.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"bot.d.ts","sourceRoot":"","sources":["../../../src/adapters/github/bot.ts"],"names":[],"mappings":"AAGA,OAAO,KAAK,EACV,YAAY,EACZ,qBAAqB,EACrB,aAAa,EACb,iBAAiB,EAClB,MAAM,gBAAgB,CAAC;AAcxB,OAAO,EAAgC,SAAS,EAAE,MAAM,iBAAiB,CAAC;AAQ1E,OAAO,KAAK,EAAU,qBAAqB,EAAE,MAAM,uBAAuB,CAAC;AAE3E,OAAO,KAAK,EACV,SAAS,EACT,eAAe,EAKf,eAAe,EAChB,MAAM,YAAY,CAAC;AA+CpB,eAAO,MAAM,wBAAwB,YAAa,MAAM,KAAG,MAAoC,CAAC;AAyEhG,qBAAa,kBAAmB,YAAW,YAAY;IACrD,OAAO,CAAC,QAAQ,CAAC,MAAM,CAAY;IACnC,OAAO,CAAC,QAAQ,CAAC,OAAO,CAAwB;IAChD,OAAO,CAAC,QAAQ,CAAC,MAAM,CAAkB;IACzC,QAAQ,CAAC,GAAG,EAAE,SAAS,CAAC;IACxB,OAAO,CAAC,OAAO,CAAuB;IACtC,OAAO,CAAC,QAAQ,CAAuB;IACvC,OAAO,CAAC,YAAY,CAAuB;IAC3C,OAAO,CAAC,MAAM,CAA0C;IACxD,OAAO,CAAC,SAAS,CAAoC;IACrD,OAAO,CAAC,eAAe,CAA0D;IACjF,OAAO,CAAC,OAAO,CAAQ;IACvB,OAAO,CAAC,QAAQ,CAAS;IACzB,OAAO,CAAC,UAAU,CAA8B;IAChD,OAAO,CAAC,WAAW,CAAS;IAC5B,OAAO,CAAC,iBAAiB,CAA+B;IACxD,OAAO,CAAC,gBAAgB,CAA+B;IAEvD,YAAY,OAAO,EAAE,qBAAqB,EAAE,MAAM,EAAE,eAAe,EAAE,MAAM,CAAC,EAAE,SAAS,EAWtF;IAEK,KAAK,IAAI,OAAO,CAAC,IAAI,CAAC,CA0D3B;IAEK,IAAI,IAAI,OAAO,CAAC,IAAI,CAAC,CAa1B;IAEK,WAAW,CAAC,OAAO,EAAE,MAAM,EAAE,IAAI,EAAE,MAAM,GAAG,OAAO,CAAC,MAAM,CAAC,CAQhE;IAEK,aAAa,CAAC,OAAO,EAAE,MAAM,EAAE,EAAE,EAAE,MAAM,EAAE,IAAI,EAAE,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,CAG5E;IAEK,WAAW,CAAC,OAAO,EAAE,MAAM,EAAE,SAAS,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,CAuBlF;IAED,YAAY,CAAC,KAAK,EAAE,iBAAiB,GAAG,OAAO,CAe9C;IAED,gBAAgB,IAAI,aAAa,CAWhC;IAEK,WAAW,CAAC,GAAG,EAAE,qBAAqB,EAAE,IAAI,EAAE,MAAM,GAAG,OAAO,CAAC,MAAM,CAAC,CAK3E;IAEK,aAAa,CAAC,GAAG,EAAE,qBAAqB,EAAE,SAAS,EAAE,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,CAEhF;IAED,SAAS,CAAC,cAAc,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,GAAG,IAAI,CAErD;IAED,cAAc,CAAC,cAAc,EAAE,MAAM,EAAE,IAAI,EAAE,MAAM,EAAE,EAAE,EAAE,MAAM,GAAG,IAAI,CAErE;IAED,OAAO,CAAC,QAAQ;IAShB,WAAW,CAAC,UAAU,SAA2B,GAAG,IAAI,CAYvD;IAEK,IAAI,IAAI,OAAO,CAAC,IAAI,CAAC,CAiB1B;YAEa,gBAAgB;YAYhB,QAAQ;YAqDR,WAAW;IA4BzB,OAAO,CAAC,aAAa;IAarB,iBAAiB,IAAI,eAAe,CAYnC;IAED,OAAO,CAAC,gBAAgB;IAKxB,OAAO,CAAC,cAAc;IAItB,OAAO,CAAC,WAAW;IAKnB,OAAO,CAAC,YAAY;IAKpB,OAAO,CAAC,MAAM;IAId,OAAO,CAAC,eAAe;YAIT,oBAAoB;YA0BpB,cAAc;YAkEd,mBAAmB;YAgBnB,mBAAmB;YAwBnB,mBAAmB;YA+BnB,eAAe;YA6Bf,eAAe;CA8B9B"}
+{"version":3,"file":"bot.d.ts","sourceRoot":"","sources":["../../../src/adapters/github/bot.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EACV,YAAY,EACZ,qBAAqB,EACrB,aAAa,EACb,iBAAiB,EAClB,MAAM,gBAAgB,CAAC;AAaxB,OAAO,EAAE,SAAS,EAAE,MAAM,iBAAiB,CAAC;AAQ5C,OAAO,KAAK,EAAU,qBAAqB,EAAE,MAAM,uBAAuB,CAAC;AAE3E,OAAO,KAAK,EAEV,mBAAmB,EACnB,SAAS,EACT,eAAe,EACf,gBAAgB,EAMhB,qBAAqB,EACtB,MAAM,YAAY,CAAC;AAOpB,eAAO,MAAM,wBAAwB,YAAa,MAAM,KAAG,MAAoC,CAAC;AA+ChG,qBAAa,kBAAmB,YAAW,YAAY;IACrD,OAAO,CAAC,QAAQ,CAAC,MAAM,CAAY;IACnC,OAAO,CAAC,QAAQ,CAAC,OAAO,CAAwB;IAChD,OAAO,CAAC,QAAQ,CAAC,MAAM,CAAkB;IACzC,QAAQ,CAAC,GAAG,EAAE,SAAS,CAAC;IACxB,OAAO,CAAC,QAAQ,CAAoC;IACpD,OAAO,CAAC,MAAM,CAA0C;IACxD,OAAO,CAAC,eAAe,CAA8D;IACrF,OAAO,CAAC,YAAY,CAA6B;IACjD,OAAO,CAAC,OAAO,CAAQ;IAEvB,YAAY,OAAO,EAAE,qBAAqB,EAAE,MAAM,EAAE,eAAe,EAAE,MAAM,CAAC,EAAE,SAAS,EAKtF;IAED,IAAI,YAAY,IAAI,WAAW,CAAC,gBAAgB,CAAC,CAEhD;IAED,IAAI,aAAa,IAAI,mBAAmB,GAAG,SAAS,CAEnD;IAEK,KAAK,IAAI,OAAO,CAAC,IAAI,CAAC,CAW3B;IAEK,IAAI,IAAI,OAAO,CAAC,IAAI,CAAC,CAG1B;IAEK,WAAW,CAAC,OAAO,EAAE,MAAM,EAAE,IAAI,EAAE,MAAM,GAAG,OAAO,CAAC,MAAM,CAAC,CAQhE;IAEK,aAAa,CAAC,OAAO,EAAE,MAAM,EAAE,EAAE,EAAE,MAAM,EAAE,IAAI,EAAE,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,CAG5E;IAEK,WAAW,CAAC,OAAO,EAAE,MAAM,EAAE,SAAS,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,CAuBlF;IAED,YAAY,CAAC,KAAK,EAAE,iBAAiB,GAAG,OAAO,CAM9C;IAED,gBAAgB,IAAI,aAAa,CAWhC;IAEK,WAAW,CAAC,GAAG,EAAE,qBAAqB,EAAE,IAAI,EAAE,MAAM,GAAG,OAAO,CAAC,MAAM,CAAC,CAK3E;IAEK,aAAa,CAAC,GAAG,EAAE,qBAAqB,EAAE,SAAS,EAAE,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,CAEhF;IAED,SAAS,CAAC,cAAc,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,GAAG,IAAI,CAErD;IAED,cAAc,CAAC,cAAc,EAAE,MAAM,EAAE,IAAI,EAAE,MAAM,EAAE,EAAE,EAAE,MAAM,GAAG,IAAI,CAErE;IAED,OAAO,CAAC,QAAQ;IASV,OAAO,CAAC,QAAQ,EAAE,qBAAqB,GAAG,OAAO,CAAC,IAAI,CAAC,CAY5D;IAED,OAAO,CAAC,OAAO;IAIf,OAAO,CAAC,SAAS;IAiBjB,OAAO,CAAC,gBAAgB;YAUV,cAAc;IAiC5B,OAAO,CAAC,cAAc;IAKtB,OAAO,CAAC,WAAW;IAKnB,OAAO,CAAC,YAAY;IAKpB,OAAO,CAAC,MAAM;IAId,OAAO,CAAC,eAAe;YAIT,oBAAoB;YAwBpB,cAAc;YA0Dd,mBAAmB;YAwBnB,mBAAmB;YA+BnB,eAAe;CA2B9B"}

package/dist/adapters/github/bot.js

@@ -1,44 +1,18 @@
 import { existsSync } from "node:fs";
-import { dirname } from "node:path";
-import { Type } from "typebox";
 import * as log from "../../log.js";
-import { ensureDirExists, readJsonSchemaFileIfExists } from "../../file-guards.js";
-import { atomicWritePrivateFile } from "../../file-guards.js";
 import { resolveChatSessionKey } from "../../sessions/session-key.js";
 import { appendBotResponseLog, appendChannelLog, MessagingEventQueue, splitText, } from "../shared.js";
 import { matchMagicWord, processMessageIntake } from "../intake.js";
+import { readGithubActivity } from "./activity.js";
 import { GithubClient, GITHUB_MAX_COMMENT_LENGTH, githubRetry } from "./client.js";
 import { createGithubAdapters } from "./context.js";
-import { fetchIsPr, fetchPrHeadBranch, GithubOps } from "./github-ops.js";
-import { cloneRepo, conversationRepoDir } from "./repo.js";
+import { GithubOps } from "./github-ops.js";
+import { permissionMeets, repoIsAllowed, userIsAllowed } from "./policy.js";
 import { buildGithubConversationId, createConversationEvent, createOfficeAddress, parseGithubConversationId, } from "../../office/index.js";
 import { GITHUB_ISSUE_BODY_TS, githubReviewCommentTs, parseReviewCommentTs } from "./ids.js";
 import { errorMessage } from "../../unknown-values.js";
-const SyncStateSchema = Type.Object({
-    repos: Type.Record(Type.String(), Type.Object({
-        baseline: Type.String(),
-        cursor: Type.String(),
-        seenComments: Type.Array(Type.Number()),
-        seenIssues: Type.Array(Type.Number()),
-        seenReviewComments: Type.Optional(Type.Array(Type.Number())),
-    })),
-});
-const POLL_OVERLAP_MS = 5 * 60 * 1000;
-const MAX_SEEN_IDS = 5000;
-const REQUEST_POLL_DEBOUNCE_MS = 1500;
-const PERMISSION_RANK = {
-    none: 0,
-    read: 1,
-    triage: 2,
-    write: 3,
-    maintain: 4,
-    admin: 5,
-};
-const REQUIRED_TRIGGER_RANK = PERMISSION_RANK.write;
-function rankOfPermission(name) {
-    return PERMISSION_RANK[name] ?? 0;
-}
 const PERMISSION_CACHE_TTL_MS = 5 * 60 * 1000;
+const BODY_TRIGGER_WINDOW_MS = 10 * 60 * 1000;
 export const formatGithubContinuation = (partNum) => `*(continued ${partNum})*`;
 const GITHUB_REACTIONS = {
     "+1": "+1",
@@ -55,137 +29,54 @@ const GITHUB_REACTIONS = {
     eyes: "eyes",
     saluting_face: "eyes",
 };
-function parseRepoList(repos) {
-    return repos.map((entry) => {
-        const [owner, repo, ...rest] = entry.split("/");
-        if (!owner || !repo || rest.length > 0) {
-            throw new Error(`Invalid GITHUB_REPOS entry (expected owner/repo): ${entry}`);
-        }
-        return { owner: owner.toLowerCase(), repo: repo.toLowerCase() };
-    });
-}
-function pruneSeen(seen) {
-    if (seen.size <= MAX_SEEN_IDS)
-        return;
-    let toDrop = seen.size - MAX_SEEN_IDS / 2;
-    for (const id of seen) {
-        if (toDrop-- <= 0)
-            break;
-        seen.delete(id);
-    }
-}
-function issueNumberFromUrl(issueUrl) {
-    const match = /\/issues\/(\d+)$/.exec(issueUrl);
-    if (!match) {
-        throw new Error(`Cannot parse issue number from ${issueUrl}`);
-    }
-    return Number(match[1]);
-}
-function prNumberFromUrl(pullRequestUrl) {
-    const match = /\/pulls\/(\d+)$/.exec(pullRequestUrl);
-    if (!match) {
-        throw new Error(`Cannot parse PR number from ${pullRequestUrl}`);
-    }
-    return Number(match[1]);
-}
 const MAX_DIFF_HUNK_CHARS = 1500;
 const MAX_THREAD_TURNS = 10;
 const MAX_THREAD_TURN_CHARS = 500;
+function bodyTriggerNote(activity) {
+    switch (activity.kind) {
+        case "assigned":
+            return `[Assigned to you by @${activity.sender.login}]`;
+        case "review_requested":
+            return `[Review requested by @${activity.sender.login}]`;
+        case "opened":
+        case "comment":
+        case "review_comment":
+            return null;
+        default:
+            return activity.kind;
+    }
+}
 export class GithubMessagingBot {
     constructor(handler, config, client) {
-        this.appSlug = null;
-        this.botEmail = null;
-        this.watchedRepos = [];
+        this.identity = null;
         this.queues = new Map();
-        this.repoState = new Map();
         this.permissionCache = new Map();
+        this.bodyTriggers = new Map();
         this.stopped = true;
-        this.stopping = false;
-        this.activePoll = null;
-        this.pollPending = false;
-        this.pollIntervalTimer = null;
-        this.requestPollTimer = null;
         this.handler = handler;
         this.config = config;
-        this.client =
-            client ??
-                new GithubClient({
-                    appId: config.appId,
-                    privateKey: config.privateKey,
-                    installationId: config.installationId,
-                });
-        this.ops = new GithubOps(this.client, { workspace: config.workspace });
+        this.client = client ?? new GithubClient({ token: config.token });
+        this.ops = new GithubOps(this.client);
+    }
+    get capabilities() {
+        return this.config.policy.capabilities;
+    }
+    get agentIdentity() {
+        return this.identity ?? undefined;
     }
     async start() {
+        const user = await this.client.getAuthenticatedUser();
+        this.identity = {
+            login: user.login,
+            email: `${user.id}+${user.login}@users.noreply.github.com`,
+        };
         this.stopped = false;
-        this.stopping = false;
-        this.appSlug = await this.client.getAppSlug();
-        try {
-            const botUserId = await this.client.getUserId(`${this.appSlug}[bot]`);
-            this.botEmail = `${botUserId}+${this.appSlug}[bot]@users.noreply.github.com`;
-        }
-        catch {
-            this.botEmail = `${this.appSlug}[bot]@users.noreply.github.com`;
-        }
-        this.watchedRepos =
-            this.config.repos.length > 0
-                ? parseRepoList(this.config.repos)
-                : (await this.client.listInstallationRepositories()).map((repository) => ({
-                    owner: repository.owner.login.toLowerCase(),
-                    repo: repository.name.toLowerCase(),
-                }));
-        if (this.watchedRepos.length === 0) {
-            log.logWarning("GitHub: installation has no repositories; nothing to poll");
-        }
-        const persisted = this.loadSyncState();
-        const now = new Date().toISOString();
-        for (const repo of this.watchedRepos) {
-            const repoKey = `${repo.owner}/${repo.repo}`;
-            const saved = persisted?.repos[repoKey];
-            this.repoState.set(repoKey, saved
-                ? {
-                    baseline: saved.baseline,
-                    cursor: saved.cursor,
-                    seenComments: new Set(saved.seenComments),
-                    seenIssues: new Set(saved.seenIssues),
-                    seenReviewComments: new Set(saved.seenReviewComments ?? []),
-                }
-                : {
-                    baseline: now,
-                    cursor: now,
-                    seenComments: new Set(),
-                    seenIssues: new Set(),
-                    seenReviewComments: new Set(),
-                });
-        }
-        this.persistSyncState();
-        if (this.stopping)
-            return;
-        this.stopped = false;
-        this.pollIntervalTimer = setInterval(() => {
-            void this.poll();
-        }, this.config.pollIntervalMs);
-        this.pollIntervalTimer.unref();
         log.logConnected("GitHub");
-        log.logInfo(`GitHub bot started as @${this.appSlug}[bot], polling ${this.watchedRepos.length} repo(s) every ${Math.round(this.config.pollIntervalMs / 1000)}s`);
+        log.logInfo(`GitHub bot started as @${user.login}, answering in ${this.config.policy.repos.join(", ")}`);
     }
     async stop() {
-        this.stopping = true;
-        this.pollPending = false;
-        if (this.pollIntervalTimer)
-            clearInterval(this.pollIntervalTimer);
-        if (this.requestPollTimer)
-            clearTimeout(this.requestPollTimer);
-        this.pollIntervalTimer = null;
-        this.requestPollTimer = null;
-        try {
-            if (this.activePoll)
-                await this.activePoll;
-        }
-        finally {
-            this.stopped = true;
-            await Promise.all([...this.queues.values()].map((queue) => queue.close()));
-        }
+        this.stopped = true;
+        await Promise.all([...this.queues.values()].map((queue) => queue.close()));
     }
     async postMessage(channel, text) {
         const ref = parseGithubConversationId(channel);
@@ -220,14 +111,7 @@ export class GithubMessagingBot {
     enqueueEvent(event) {
         if (this.stopped)
             return false;
-        const conversationId = event.address.conversationId;
-        const queue = this.getQueue(conversationId);
-        if (queue.size() >= 5) {
-            log.logWarning(`Event queue full for ${conversationId}, discarding: ${event.text.substring(0, 50)}`);
-            return false;
-        }
-        log.logInfo(`Enqueueing event for ${conversationId}: ${event.text.substring(0, 50)}`);
-        return queue.enqueue(() => {
+        return this.getQueue(event.address.conversationId).offerEvent(event, () => {
             const context = createGithubAdapters(event, this);
             return this.handler.handleEvent(event, this, context);
         });
@@ -235,7 +119,7 @@ export class GithubMessagingBot {
     getMessagingInfo() {
         return {
             name: "github",
-            trustModel: "open-trigger",
+            trustModel: "membership",
             formattingGuide: "## GitHub Formatting (GitHub Flavored Markdown)\n" +
                 "Standard Markdown plus tables, task lists, fenced code blocks, and ```suggestion blocks.\n" +
                 "Reference issues/PRs as #123 and users as @login (mentions notify people — use sparingly).",
@@ -264,147 +148,85 @@ export class GithubMessagingBot {
         }
         return queue;
     }
-    requestPoll(debounceMs = REQUEST_POLL_DEBOUNCE_MS) {
-        if (this.stopped || this.stopping)
+    async receive(delivery) {
+        if (this.stopped || !this.identity)
             return;
-        if (this.activePoll) {
-            this.pollPending = true;
+        const activity = readGithubActivity(delivery);
+        if (!activity)
             return;
-        }
-        if (this.requestPollTimer)
-            return;
-        this.requestPollTimer = setTimeout(() => {
-            this.requestPollTimer = null;
-            void this.poll();
-        }, debounceMs);
-        this.requestPollTimer.unref();
-    }
-    async poll() {
-        if (this.stopped || this.stopping)
-            return;
-        if (this.activePoll) {
-            this.pollPending = true;
-            return;
-        }
-        const activePoll = this.pollWatchedRepos();
-        this.activePoll = activePoll;
         try {
-            await activePoll;
-        }
-        finally {
-            this.activePoll = null;
-            if (this.pollPending) {
-                this.pollPending = false;
-                this.requestPoll();
-            }
+            await this.handleActivity(activity);
         }
-    }
-    async pollWatchedRepos() {
-        let changed = false;
-        for (const repo of this.watchedRepos) {
-            try {
-                changed = (await this.pollRepo(repo)) || changed;
-            }
-            catch (err) {
-                log.logWarning(`GitHub poll failed for ${repo.owner}/${repo.repo}`, errorMessage(err));
-            }
-        }
-        if (changed)
-            this.persistSyncState();
-    }
-    async pollRepo(repo) {
-        const repoKey = `${repo.owner}/${repo.repo}`;
-        const state = this.repoState.get(repoKey);
-        if (!state)
+        catch (err) {
+            log.logWarning(`GitHub: failed to handle ${delivery.event} for ${activity.repo.owner}/${activity.repo.repo}#${activity.number}`, errorMessage(err));
+        }
+    }
+    isAgent(login) {
+        return login.toLowerCase() === this.identity?.login.toLowerCase();
+    }
+    triggerOf(activity, conversationId) {
+        switch (activity.kind) {
+            case "assigned":
+                return activity.target !== null && this.isAgent(activity.target) ? "assign" : null;
+            case "review_requested":
+                return activity.target !== null && this.isAgent(activity.target) ? "review" : null;
+            case "opened":
+                return this.isMentioned(activity.text) ? "mention" : null;
+            case "comment":
+            case "review_comment":
+                if (this.isMentioned(activity.text))
+                    return "mention";
+                return this.isParticipating(conversationId) ? "followup" : null;
+            default:
+                return activity.kind;
+        }
+    }
+    claimBodyTrigger(conversationId) {
+        const now = Date.now();
+        for (const [key, expiresAt] of this.bodyTriggers) {
+            if (expiresAt <= now)
+                this.bodyTriggers.delete(key);
+        }
+        if (this.bodyTriggers.has(conversationId))
             return false;
-        const since = new Date(Date.parse(state.cursor) - POLL_OVERLAP_MS).toISOString();
-        let changed = false;
-        const issues = (await this.client.listIssuesSince(repo.owner, repo.repo, since)) ?? [];
-        changed =
-            (await this.advanceFeed(state, state.seenIssues, issues, (issue) => ({
-                ref: { ...repo, number: issue.number },
-                ts: GITHUB_ISSUE_BODY_TS,
-                user: issue.user.login,
-                text: `# ${issue.title}\n\n${issue.body ?? ""}`.trim(),
-                createdAt: issue.created_at,
-                isPr: Boolean(issue.pull_request),
-            }))) || changed;
-        const comments = (await this.client.listIssueCommentsSince(repo.owner, repo.repo, since)) ?? [];
-        changed =
-            (await this.advanceFeed(state, state.seenComments, comments, (comment) => ({
-                ref: { ...repo, number: issueNumberFromUrl(comment.issue_url) },
-                ts: String(comment.id),
-                user: comment.user.login,
-                text: comment.body,
-                createdAt: comment.created_at,
-            }))) || changed;
-        const reviewComments = (await this.client.listPullReviewCommentsSince(repo.owner, repo.repo, since)) ?? [];
-        changed =
-            (await this.advanceFeed(state, state.seenReviewComments, reviewComments, (comment) => ({
-                ref: { ...repo, number: prNumberFromUrl(comment.pull_request_url) },
-                ts: githubReviewCommentTs(comment.id),
-                user: comment.user.login,
-                text: comment.body,
-                createdAt: comment.created_at,
-                isPr: true,
-                review: {
-                    commentId: comment.id,
-                    path: comment.path,
-                    line: comment.line,
-                    diffHunk: comment.diff_hunk,
-                    inReplyToId: comment.in_reply_to_id,
-                },
-            }))) || changed;
-        pruneSeen(state.seenComments);
-        pruneSeen(state.seenIssues);
-        pruneSeen(state.seenReviewComments);
-        return changed;
+        this.bodyTriggers.set(conversationId, now + BODY_TRIGGER_WINDOW_MS);
+        return true;
     }
-    async advanceFeed(state, seen, items, toIncoming) {
-        let changed = false;
-        for (const item of items) {
-            if (item.updated_at > state.cursor) {
-                state.cursor = item.updated_at;
-                changed = true;
-            }
-            if (item.created_at < state.baseline || seen.has(item.id))
-                continue;
-            seen.add(item.id);
-            changed = true;
-            if (item.user.type === "Bot")
-                continue;
-            await this.handleIncoming(toIncoming(item));
-        }
-        return changed;
-    }
-    loadSyncState() {
-        try {
-            return readJsonSchemaFileIfExists(this.config.syncStatePath, SyncStateSchema, (detail) => `Malformed GitHub sync state at ${this.config.syncStatePath}: ${detail}`);
-        }
-        catch (err) {
-            log.logWarning("GitHub: ignoring unreadable sync state", errorMessage(err));
-            return undefined;
+    async handleActivity(activity) {
+        const { policy } = this.config;
+        if (activity.sender.isBot || this.isAgent(activity.sender.login))
+            return;
+        if (!repoIsAllowed(policy, activity.repo))
+            return;
+        const ref = { owner: activity.repo.owner, repo: activity.repo.repo, number: activity.number };
+        const conversationId = buildGithubConversationId(ref);
+        const trigger = this.triggerOf(activity, conversationId);
+        if (trigger === null || !policy.triggers.has(trigger))
+            return;
+        if (!userIsAllowed(policy, activity.sender.login)) {
+            log.logInfo(`GitHub: ignoring ${conversationId} from ${activity.sender.login} (not in GITHUB_USERS)`);
+            return;
         }
-    }
-    syncStateSnapshot() {
-        const state = { repos: {} };
-        for (const [repoKey, watermark] of this.repoState) {
-            state.repos[repoKey] = {
-                baseline: watermark.baseline,
-                cursor: watermark.cursor,
-                seenComments: [...watermark.seenComments],
-                seenIssues: [...watermark.seenIssues],
-                seenReviewComments: [...watermark.seenReviewComments],
-            };
+        if (!(await this.hasTriggerPermission(ref, activity.sender.login))) {
+            log.logInfo(`GitHub: ignoring ${conversationId} from ${activity.sender.login} (below ${policy.minPermission} permission)`);
+            return;
         }
-        return state;
-    }
-    persistSyncState() {
-        ensureDirExists(dirname(this.config.syncStatePath));
-        atomicWritePrivateFile(this.config.syncStatePath, JSON.stringify(this.syncStateSnapshot()));
+        if (activity.ts === GITHUB_ISSUE_BODY_TS && !this.claimBodyTrigger(conversationId))
+            return;
+        const note = bodyTriggerNote(activity);
+        await this.handleIncoming({
+            ref,
+            ts: activity.ts,
+            user: activity.sender.login,
+            text: note ? `${note}\n\n${activity.text}` : activity.text,
+            createdAt: activity.createdAt,
+            addressed: trigger !== "followup",
+            review: activity.review,
+        });
     }
     mentionPattern() {
-        return this.appSlug ? new RegExp(`@${this.appSlug}(?![\\w-])`, "gi") : null;
+        const login = this.identity?.login;
+        return login ? new RegExp(`@${login}(?![\\w-])`, "gi") : null;
     }
     isMentioned(text) {
         const pattern = this.mentionPattern();
@@ -421,36 +243,28 @@ export class GithubMessagingBot {
         return existsSync(this.office(conversationId).logPath);
     }
     async hasTriggerPermission(ref, user) {
-        const cacheKey = `${ref.owner}/${ref.repo}#${user}`;
+        const cacheKey = `${ref.owner}/${ref.repo}#${user.toLowerCase()}`;
         const cached = this.permissionCache.get(cacheKey);
-        if (cached && Date.now() < cached.expiresAt) {
-            return cached.rank >= REQUIRED_TRIGGER_RANK;
-        }
-        let rank;
+        if (cached && Date.now() < cached.expiresAt)
+            return cached.allowed;
+        let allowed;
         try {
             const role = await githubRetry(() => this.client.getCollaboratorPermission(ref.owner, ref.repo, user));
-            rank = Math.max(rankOfPermission(role.role_name ?? ""), rankOfPermission(role.permission));
+            allowed = permissionMeets(this.config.policy, role);
         }
         catch (err) {
             log.logWarning(`GitHub: permission lookup failed for ${user} on ${ref.owner}/${ref.repo}; denying trigger`, errorMessage(err));
             return false;
         }
         this.permissionCache.set(cacheKey, {
-            rank,
+            allowed,
             expiresAt: Date.now() + PERMISSION_CACHE_TTL_MS,
         });
-        return rank >= REQUIRED_TRIGGER_RANK;
+        return allowed;
     }
     async handleIncoming(item) {
         const conversationId = buildGithubConversationId(item.ref);
-        const mentioned = this.isMentioned(item.text);
         const participating = this.isParticipating(conversationId);
-        if (!mentioned && !participating)
-            return;
-        if (!(await this.hasTriggerPermission(item.ref, item.user))) {
-            log.logInfo(`GitHub: ignoring ${conversationId} comment from ${item.user} (below write permission)`);
-            return;
-        }
         const cleanedText = this.stripMention(item.text);
         const sessionKey = resolveChatSessionKey({
             conversationId,
@@ -475,7 +289,7 @@ export class GithubMessagingBot {
         await processMessageIntake({
             eventBase,
             addressed: true,
-            magicWord: { text: cleanedText, addressed: mentioned, scopeFallback: "never" },
+            magicWord: { text: cleanedText, addressed: item.addressed, scopeFallback: "never" },
             busyPolicy: "queue",
             logEntryBase: {
                 date: item.createdAt,
@@ -491,7 +305,9 @@ export class GithubMessagingBot {
                 this.logToFile(conversationId, entry);
             },
             processAttachments: async () => {
-                await this.prepareConversation(item, conversationId, participating);
+                if (!participating && item.ts !== GITHUB_ISSUE_BODY_TS) {
+                    await this.logIssueContext(item.ref, conversationId, item.createdAt);
+                }
                 return [];
             },
             queueKey: conversationId,
@@ -501,18 +317,6 @@ export class GithubMessagingBot {
             createContext: (event) => createGithubAdapters(event, this),
         });
     }
-    async prepareConversation(item, conversationId, participating) {
-        let isPrHint = item.isPr;
-        if (!participating && item.ts !== GITHUB_ISSUE_BODY_TS) {
-            const issue = await this.logIssueContext(item.ref, conversationId, item.createdAt);
-            if (issue && isPrHint === undefined)
-                isPrHint = Boolean(issue.pull_request);
-        }
-        if (!existsSync(conversationRepoDir(this.office(conversationId)))) {
-            const isPr = isPrHint ?? (await fetchIsPr(this.client, item.ref));
-            await this.ensureRepoClone(item.ref, conversationId, isPr);
-        }
-    }
     async formatReviewMessage(ref, review, cleanedText) {
         const location = review.line !== null ? `${review.path}:${review.line}` : review.path;
         const parts = [`[PR review comment ${githubReviewCommentTs(review.commentId)} on ${location}]`];
@@ -556,7 +360,7 @@ export class GithubMessagingBot {
         }
         catch (err) {
             log.logWarning(`GitHub: could not fetch issue context for ${conversationId}`, errorMessage(err));
-            return null;
+            return;
         }
         const triggerMs = Date.parse(triggerCreatedAt);
         const contextDate = new Date((Number.isFinite(triggerMs) ? triggerMs : Date.now()) - 1000);
@@ -569,33 +373,6 @@ export class GithubMessagingBot {
             attachments: [],
             isMessagingBot: false,
         });
-        return issue;
-    }
-    async ensureRepoClone(ref, conversationId, isPr) {
-        const office = this.office(conversationId);
-        const dir = conversationRepoDir(office);
-        if (existsSync(dir))
-            return;
-        try {
-            office.ensure();
-            const token = await this.client.createScopedInstallationToken(ref.repo, {
-                contents: "read",
-            });
-            const prHeadBranch = isPr ? await fetchPrHeadBranch(this.client, ref) : undefined;
-            await cloneRepo({
-                url: `https://github.com/${ref.owner}/${ref.repo}.git`,
-                dir,
-                token,
-                botLogin: `${this.appSlug}[bot]`,
-                botEmail: this.botEmail ?? `${this.appSlug}[bot]@users.noreply.github.com`,
-                prNumber: isPr ? ref.number : undefined,
-                prHeadBranch,
-            });
-            log.logInfo(`[${conversationId}] Cloned ${ref.owner}/${ref.repo}${isPr ? ` and checked out PR #${ref.number} head as ${prHeadBranch ?? `pr-${ref.number}`}` : ""}`);
-        }
-        catch (err) {
-            log.logWarning(`GitHub: repo clone failed for ${conversationId}`, errorMessage(err));
-        }
     }
 }
 //# sourceMappingURL=bot.js.map