@geminixiang/mikan 1.0.0-beta.78 → 1.0.0-beta.79

package/dist/adapters/slack/bot.js

@@ -1,19 +1,18 @@
 import { SocketModeClient } from "@slack/socket-mode";
 import { WebAPIRateLimitedError, WebClient } from "@slack/web-api";
 import { existsSync, readFileSync } from "node:fs";
-import { readFile, writeFile } from "node:fs/promises";
-import { basename, join } from "node:path";
-import { createConversationEvent, createConversationMessage, } from "../index.js";
-import { createOfficeAddress, listRegisteredOffices } from "../../office/index.js";
+import { readFile } from "node:fs/promises";
+import { basename } from "node:path";
+import { createConversationEvent, createConversationMessage, createOfficeAddress, listRegisteredOffices, } from "../../office/index.js";
 import { COMMAND_MANIFEST } from "../commands/manifest.js";
 import { slackConversationAutoReplyMode, resolveConversationSettings, } from "../../settings/index.js";
-import { evaluateWithJev, JevNotConfiguredError } from "../../harness/index.js";
+import { evaluateWithJev, JevNotConfiguredError } from "../../harness/jev.js";
 import * as log from "../../log.js";
-import { isRecord, readTextFileIfExists } from "../../file-guards.js";
+import { readTextFileIfExists } from "../../file-guards.js";
 import { PRODUCT_NAME, formatForceStopped } from "../messages.js";
-import { appendBotResponseLog, appendChannelLog, MessagingEventQueue, MessagingIntakeTracker, saveIncomingAttachments, withRetry, } from "../shared.js";
+import { appendBotResponseLog, appendChannelLog, MessagingEventQueue, MessagingIntakeTracker, AttachmentRejectedError, saveIncomingAttachments, writeResponseToFile, withRetry, } from "../shared.js";
 import { matchMagicWord, processMessageIntake } from "../intake.js";
-import { readPlatformChannelKind, recordPlatformChannelKind, } from "../../office/projection.js";
+import { readPlatformChannelKind, recordPlatformChannelKind } from "../../office/projection.js";
 import { AssistantThreadRegistry, handleAgentContextChanged, handleAgentDmOpened, handleAssistantThreadStarted, titleAssistantThread, } from "./assistant.js";
 import { createSlackAdapters } from "./context.js";
 import { hasMaterializedChatSession, registerThreadSession, } from "../../sessions/chat-history-sync.js";
@@ -26,6 +25,7 @@ import { querySlackTasks, formatTaskStatus, readTaskRoots, isTaskStatusQuestion,
 import { buildAutoReplyState, JEV_ADDRESSED_INSTRUCTIONS } from "./auto-reply-context.js";
 import { buildTaskIntentState, classifyTaskIntent } from "./task-intent.js";
 import { StreamStartLimiter } from "./stream-limits.js";
+import { errorMessage, isRecord } from "../../unknown-values.js";
 const SLACK_EVENT_ANCHOR_TEXT = "Working on it...";
 function hasMessageContent(message, includeBlocks = true) {
     const content = [message.text, message.files];
@@ -103,13 +103,24 @@ class AttachmentDownloadHttpError extends Error {
     }
 }
 function isRetryableAttachmentDownloadError(error) {
+    if (error instanceof AttachmentRejectedError)
+        return false;
     if (!(error instanceof AttachmentDownloadHttpError))
         return true;
     return error.status === 408 || error.status === 429 || error.status >= 500;
 }
+function assertSlackFileUrl(url) {
+    const { protocol, hostname } = new URL(url);
+    if (protocol === "https:" && (hostname === "slack.com" || hostname.endsWith(".slack.com")))
+        return;
+    throw new AttachmentRejectedError(`refusing to send the bot token to ${hostname}`);
+}
 export class SlackMessagingBot {
+    office(channelId) {
+        return this.workspace.office(createOfficeAddress("slack", channelId));
+    }
     conversationDir(channelId) {
-        return this.workspace.office(createOfficeAddress("slack", channelId)).dir;
+        return this.office(channelId).dir;
     }
     resolveReplyMode(address) {
         return (resolveConversationSettings(this.workspace.office(address)).slack?.replyMode ?? "top-level");
@@ -215,15 +226,19 @@ export class SlackMessagingBot {
         this.handler = handler;
         this.workspace = config.workspace;
         this.botToken = config.botToken;
-        this.socketClient = new SocketModeClient({
-            appToken: config.appToken,
-            clientPingTimeout: 12_000,
-        });
-        this.webClient = new WebClient(config.botToken);
+        this.fetchFn = config.fetch ?? ((input, init) => fetch(input, init));
+        this.socketClient =
+            config.socket ??
+                new SocketModeClient({
+                    appToken: config.appToken,
+                    clientPingTimeout: 12_000,
+                });
+        this.webClient = config.webApi ?? new WebClient(config.botToken, { fetch: config.fetch });
         this.statusClient = new WebClient(config.botToken, {
             timeout: 3000,
             retryConfig: { retries: 0 },
             rejectRateLimitedCalls: true,
+            fetch: config.fetch,
         });
     }
     setEventScheduler(scheduler) {
@@ -286,8 +301,9 @@ export class SlackMessagingBot {
         return slackRetry(async () => {
             const payload = {
                 channel,
-                ...(threadTs !== undefined ? { thread_ts: threadTs } : {}),
-                ...(identity ? { username: identity.username, icon_emoji: identity.iconEmoji } : {}),
+                thread_ts: threadTs,
+                username: identity?.username,
+                icon_emoji: identity?.iconEmoji,
                 ...renderSlackBlocks(this.resolveMentions(text)),
             };
             const result = await this.webClient.chat.postMessage(payload);
@@ -313,8 +329,8 @@ export class SlackMessagingBot {
                 channel,
                 user,
                 text,
-                ...(blocks !== undefined ? { blocks: blocks } : {}),
-                ...(threadTs ? { thread_ts: threadTs } : {}),
+                blocks: blocks,
+                thread_ts: threadTs || undefined,
             });
         });
     }
@@ -327,7 +343,7 @@ export class SlackMessagingBot {
                 channel,
                 text,
                 blocks: blocks,
-                ...(threadTs !== undefined ? { thread_ts: threadTs } : {}),
+                thread_ts: threadTs,
             };
             const result = await this.webClient.chat.postMessage(payload);
             return result.ts;
@@ -366,12 +382,14 @@ export class SlackMessagingBot {
                 ? await this.webClient.conversations.replies({
                     channel,
                     ts: threadTs,
-                    ...(options?.oldest ? { oldest: options.oldest, inclusive: false } : {}),
+                    oldest: options?.oldest || undefined,
+                    inclusive: options?.oldest ? false : undefined,
                     limit,
                 })
                 : await this.webClient.conversations.history({
                     channel,
-                    ...(options?.oldest ? { oldest: options.oldest, inclusive: false } : {}),
+                    oldest: options?.oldest || undefined,
+                    inclusive: options?.oldest ? false : undefined,
                     limit,
                 });
             const messages = (result.messages ?? []);
@@ -427,9 +445,9 @@ export class SlackMessagingBot {
             const result = await this.webClient.apiCall("chat.startStream", {
                 channel,
                 markdown_text: this.resolveMentions(head ?? ""),
-                ...(threadTs ? { thread_ts: threadTs } : {}),
-                ...(this.teamId ? { recipient_team_id: this.teamId } : {}),
-                ...(recipientUserId ? { recipient_user_id: recipientUserId } : {}),
+                thread_ts: threadTs || undefined,
+                recipient_team_id: this.teamId || undefined,
+                recipient_user_id: recipientUserId || undefined,
             });
             const streamTs = result.ts;
             if (!streamTs)
@@ -489,7 +507,7 @@ export class SlackMessagingBot {
         return slackRetry(async () => {
             await this.webClient.assistant.threads.setSuggestedPrompts({
                 channel_id: channel,
-                ...(threadTs ? { thread_ts: threadTs } : {}),
+                thread_ts: threadTs || undefined,
                 prompts,
             });
         });
@@ -518,7 +536,7 @@ export class SlackMessagingBot {
             return;
         void handleAssistantThreadStarted(this.assistantOps(), this.assistantThreads, payload.assistant_thread);
     }
-    handleAgentContextChangedEvent({ event, ack, }) {
+    handleAgentContextChangedEvent({ event, ack }) {
         ack();
         const payload = event;
         if (payload.assistant_thread) {
@@ -560,11 +578,11 @@ export class SlackMessagingBot {
     logBotResponse(channel, text, ts, threadTs, slackBlocks) {
         appendBotResponseLog(this.workspace.office(createOfficeAddress("slack", channel)), text, ts, threadTs, {
             platform: "slack",
-            ...(slackBlocks ? { slackBlocks } : {}),
+            slackBlocks,
         });
     }
     ownsBlockKitMessage(channel, ts, threadTs) {
-        const content = readTextFileIfExists(join(this.conversationDir(channel), "log.jsonl"));
+        const content = readTextFileIfExists(this.office(channel).logPath);
         if (content === undefined)
             return false;
         for (const line of content.trim().split("\n").toReversed()) {
@@ -586,7 +604,7 @@ export class SlackMessagingBot {
     getMessagingInfo() {
         return {
             name: "slack",
-            ...(this.teamId ? { workspaceId: this.teamId } : {}),
+            workspaceId: this.teamId || undefined,
             trustModel: "membership",
             formattingGuide: "## Slack Formatting\nWrite standard Markdown/GFM: **bold**, _italic_, ~~strike~~, `code`, fenced code blocks, [links](url), lists, and pipe tables (rendered as native Slack tables).\nDo NOT use Slack mrkdwn syntax like *single-asterisk bold* or <url|label> links.",
             channels: this.getAllChannels().map((c) => ({ id: c.id, name: c.name })),
@@ -617,7 +635,7 @@ export class SlackMessagingBot {
                     anchorTs = await this.postMessage(conversationId, SLACK_EVENT_ANCHOR_TEXT);
                 }
                 catch (err) {
-                    log.logWarning(`Failed to post Slack event anchor for ${conversationId}`, err instanceof Error ? err.message : String(err));
+                    log.logWarning(`Failed to post Slack event anchor for ${conversationId}`, errorMessage(err));
                     reportUserFacingError(err, {
                         domain: "events",
                         surface: "event_delivery",
@@ -979,7 +997,7 @@ export class SlackMessagingBot {
             text: commandText,
             attachments: [],
             isMessagingBot: false,
-            ...(threadTs ? { threadTs } : {}),
+            threadTs: threadTs || undefined,
         });
         const event = createConversationEvent({
             platform: "slack",
@@ -990,7 +1008,7 @@ export class SlackMessagingBot {
             user: payload.user_id,
             text: commandText,
             attachments: [],
-            ...(threadTs ? { thread_ts: threadTs } : {}),
+            thread_ts: threadTs || undefined,
             sessionKey,
         });
         const context = this.createCommandAdapters({
@@ -999,9 +1017,9 @@ export class SlackMessagingBot {
             userName,
             text: commandText,
             ts: eventTs,
-            ...(isDirectMessage
-                ? { threadTs, sessionKey }
-                : { ephemeralChannelId: conversationId, threadTs, sessionKey }),
+            ephemeralChannelId: isDirectMessage ? undefined : conversationId,
+            threadTs,
+            sessionKey,
         });
         return { event, context };
     }
@@ -1009,13 +1027,11 @@ export class SlackMessagingBot {
         const { event, context } = this.buildSlashCommandEvent(payload, {
             includeText: route.includeText,
             thread: route.thread,
-            ...(route.privateCommand
-                ? {
-                    type: payload.channel_id.startsWith("D")
-                        ? "dm"
-                        : "private_command",
-                }
-                : {}),
+            type: route.privateCommand
+                ? payload.channel_id.startsWith("D")
+                    ? "dm"
+                    : "private_command"
+                : undefined,
         });
         await this.handler.handleEvent(event, this, context);
     }
@@ -1029,35 +1045,18 @@ export class SlackMessagingBot {
         this.socketClient.on("unable_to_socket_mode_start", (err) => {
             log.logWarning("Slack socket unable_to_start", err ? String(err) : "");
         });
-        this.socketClient.on("app_mention", (payload) => {
-            void this.intake.run(() => this.handleAppMention(payload));
-        });
-        this.socketClient.on("message", (payload) => {
-            void this.intake.run(() => this.handleMessageEvent(payload));
-        });
-        this.socketClient.on("slash_commands", (payload) => {
-            void this.intake.run(() => this.handleSlashCommand(payload));
-        });
-        this.socketClient.on("app_home_opened", (payload) => {
-            void this.intake.run(() => this.handleAppHomeOpened(payload));
-        });
-        this.socketClient.on("assistant_thread_started", (payload) => {
-            void this.intake.run(() => this.handleAssistantThreadStarted(payload));
-        });
-        this.socketClient.on("assistant_thread_context_changed", (payload) => {
-            void this.intake.run(() => this.handleAgentContextChangedEvent(payload));
-        });
-        this.socketClient.on("app_context_changed", (payload) => {
-            void this.intake.run(() => this.handleAgentContextChangedEvent(payload));
-        });
-        this.socketClient.on("block_actions", (payload) => {
-            void this.intake.run(() => this.handleBlockAction(payload));
-        });
-        this.socketClient.on("interactive", (payload) => {
-            void this.intake.run(() => this.handleBlockAction(payload));
-        });
-    }
-    async handleAppMention({ event, ack, }) {
+        this.socketClient.on("app_mention", (payload) => this.intake.run(() => this.handleAppMention(payload)));
+        this.socketClient.on("message", (payload) => this.intake.run(() => this.handleMessageEvent(payload)));
+        this.socketClient.on("slash_commands", (payload) => this.intake.run(() => this.handleSlashCommand(payload)));
+        this.socketClient.on("app_home_opened", (payload) => this.intake.run(() => this.handleAppHomeOpened(payload)));
+        this.socketClient.on("assistant_thread_started", (payload) => this.intake.run(() => this.handleAssistantThreadStarted(payload)));
+        this.socketClient.on("assistant_thread_context_changed", (payload) => this.intake.run(() => this.handleAgentContextChangedEvent(payload)));
+        this.socketClient.on("app_context_changed", (payload) => this.intake.run(() => this.handleAgentContextChangedEvent(payload)));
+        const blockAction = ({ body, ack }) => this.intake.run(() => this.handleBlockAction({ body: body, ack }));
+        this.socketClient.on("block_actions", blockAction);
+        this.socketClient.on("interactive", blockAction);
+    }
+    async handleAppMention({ event, ack }) {
         const e = event;
         if (e.channel.startsWith("D")) {
             ack();
@@ -1208,7 +1207,7 @@ export class SlackMessagingBot {
             return false;
         }
     }
-    async handleMessageEvent({ event, ack, }) {
+    async handleMessageEvent({ event, ack }) {
         const e = event;
         if (!this.admitHumanMessage(e, ack))
             return;
@@ -1275,7 +1274,7 @@ export class SlackMessagingBot {
             ack();
         await intake;
     }
-    async handleSlashCommand({ body, ack, }) {
+    async handleSlashCommand({ body, ack }) {
         const payload = body;
         await ack();
         if (!payload.command || !payload.channel_id || !payload.user_id) {
@@ -1298,7 +1297,7 @@ export class SlackMessagingBot {
             });
         }
         catch (err) {
-            log.logWarning("Slack slash command error", err instanceof Error ? err.message : String(err));
+            log.logWarning("Slack slash command error", errorMessage(err));
         }
     }
     handleAppHomeOpened({ event, ack }) {
@@ -1372,7 +1371,7 @@ export class SlackMessagingBot {
         this.logToFile(channelId, {
             date: new Date().toISOString(),
             ts,
-            ...(threadTs ? { threadTs } : {}),
+            threadTs: threadTs || undefined,
             user: userId,
             userName: body.user?.username ?? body.user?.name,
             text,
@@ -1404,7 +1403,7 @@ export class SlackMessagingBot {
             user: userId,
             text,
             attachments: [],
-            ...(threadTs ? { thread_ts: threadTs } : {}),
+            thread_ts: threadTs || undefined,
             sessionKey,
         });
         this.getQueue(this.resolveQueueKey(channelId, sessionKey)).enqueue(async () => {
@@ -1447,21 +1446,21 @@ export class SlackMessagingBot {
         const firstFailure = failed[0];
         if (firstFailure) {
             const { name, error } = firstFailure;
-            const errorMsg = error instanceof Error ? error.message : String(error);
+            const errorMsg = errorMessage(error);
             throw new Error(`Failed to download attachment ${name}: ${errorMsg}`, { cause: error });
         }
         return saved;
     }
     async downloadSlackFile(url, destPath) {
+        assertSlackFileUrl(url);
         await withRetry(async () => {
-            const response = await fetch(url, {
+            const response = await this.fetchFn(url, {
                 headers: { Authorization: `Bearer ${this.botToken}` },
             });
             if (!response.ok) {
                 throw new AttachmentDownloadHttpError(`HTTP ${response.status}: ${response.statusText}`, response.status);
             }
-            const buffer = await response.arrayBuffer();
-            await writeFile(destPath, Buffer.from(buffer));
+            await writeResponseToFile(response, destPath);
         }, { maxAttempts: 3, baseDelayMs: 250, isRateLimited: isRetryableAttachmentDownloadError });
     }
     async logUserMessage(event) {
@@ -1513,7 +1512,7 @@ export class SlackMessagingBot {
         return attachments;
     }
     async getExistingTimestamps(channelId) {
-        const logPath = join(this.conversationDir(channelId), "log.jsonl");
+        const { logPath } = this.office(channelId);
         const timestamps = new Set();
         if (!existsSync(logPath))
             return timestamps;
@@ -1526,7 +1525,7 @@ export class SlackMessagingBot {
                     timestamps.add(entry.ts);
             }
             catch (err) {
-                log.logWarning(`Skipping malformed log entry at ${logPath}:${i + 1}`, err instanceof Error ? err.message : String(err));
+                log.logWarning(`Skipping malformed log entry at ${logPath}:${i + 1}`, errorMessage(err));
             }
         }
         return timestamps;
@@ -1605,8 +1604,7 @@ export class SlackMessagingBot {
         const startTime = Date.now();
         const channelsToBackfill = [];
         for (const [channelId, channel] of this.channels) {
-            const logPath = join(this.conversationDir(channelId), "log.jsonl");
-            if (existsSync(logPath)) {
+            if (existsSync(this.office(channelId).logPath)) {
                 channelsToBackfill.push([channelId, channel]);
             }
         }
@@ -1663,8 +1661,8 @@ export class SlackMessagingBot {
                 this.channels.set(c.id, {
                     id: c.id,
                     name: c.name,
-                    ...(typeof c.is_private === "boolean" ? { isPrivate: c.is_private } : {}),
-                    ...(c.is_shared || c.is_ext_shared ? { isExternallyShared: true } : {}),
+                    isPrivate: typeof c.is_private === "boolean" ? c.is_private : undefined,
+                    isExternallyShared: c.is_shared || c.is_ext_shared ? true : undefined,
                 });
             }
             cursor = result.response_metadata?.next_cursor;