@geekmidas/constructs 3.0.9 → 3.0.11

package/src/endpoints/__tests__/HonoEndpointAdaptor.pgboss-publisher.spec.ts

@@ -8,6 +8,7 @@ import {
 import type { Service } from '@geekmidas/services';
 import { ServiceDiscovery } from '@geekmidas/services';
 import { Hono } from 'hono';
+import { Client } from 'pg';
 import { afterAll, beforeAll, describe, expect, it } from 'vitest';
 import { z } from 'zod';
 import { e } from '../EndpointFactory';
@@ -18,18 +19,33 @@ type OrderEvent =
 	| PublishableMessage<'notification.sent', { orderId: string; type: string }>;
 
 const POSTGRES_URL = 'postgres://geekmidas:geekmidas@localhost:5432/geekmidas';
+const TEST_SCHEMA = 'pgboss_hono_publisher_test';
 
 const uniqueQueue = () =>
 	`test-${Date.now()}-${Math.random().toString(36).substring(7)}`;
 
+// Drop the test schema before pg-boss runs. Without this, a stale schema left
+// behind by an older pg-boss version trips v12's migrator because it sees the
+// `version` table but not the new `job_common` table.
+async function dropTestSchema() {
+	const client = new Client({ connectionString: POSTGRES_URL });
+	await client.connect();
+	try {
+		await client.query(`DROP SCHEMA IF EXISTS "${TEST_SCHEMA}" CASCADE`);
+	} finally {
+		await client.end();
+	}
+}
+
 describe('HonoEndpoint with PgBoss Publisher', () => {
 	let connection: PgBossConnection;
 	let envParser: EnvironmentParser<{}>;
 
 	beforeAll(async () => {
+		await dropTestSchema();
 		connection = new PgBossConnection({
 			connectionString: POSTGRES_URL,
-			schema: 'pgboss_hono_publisher_test',
+			schema: TEST_SCHEMA,
 		});
 		await connection.connect();
 		envParser = new EnvironmentParser({});

package/src/endpoints/__tests__/HonoEndpointAdaptor.spec.ts

@@ -801,7 +801,7 @@ describe('HonoEndpointAdaptor', () => {
 			expect(await response.json()).toEqual({ success: true });
 		});
 
-		it('should return 401 when authorize returns false', async () => {
+		it('should return 403 when authorize returns false', async () => {
 			const endpoint = new Endpoint({
 				route: '/protected',
 				method: 'GET',
@@ -827,11 +827,9 @@ describe('HonoEndpointAdaptor', () => {
 			adaptor.addRoute(serviceDiscovery, app);
 
 			const response = await app.request('/protected');
-			expect(response.status).toBe(401);
-			expect(await response.json()).toEqual({ error: 'Unauthorized' });
-			expect(mockLogger.warn).toHaveBeenCalledWith(
-				'Unauthorized access attempt',
-			);
+			expect(response.status).toBe(403);
+			expect(await response.json()).toEqual({ error: 'Forbidden' });
+			expect(mockLogger.warn).toHaveBeenCalledWith('Forbidden access attempt');
 		});
 
 		it('should handle async authorize functions with headers', async () => {
@@ -873,8 +871,8 @@ describe('HonoEndpointAdaptor', () => {
 			const invalidResponse = await app.request('/protected', {
 				headers: { Authorization: 'Bearer invalid-token' },
 			});
-			expect(invalidResponse.status).toBe(401);
-			expect(await invalidResponse.json()).toEqual({ error: 'Unauthorized' });
+			expect(invalidResponse.status).toBe(403);
+			expect(await invalidResponse.json()).toEqual({ error: 'Forbidden' });
 		});
 
 		it('should authorize with services available', async () => {
@@ -924,7 +922,7 @@ describe('HonoEndpointAdaptor', () => {
 			const invalidResponse = await app.request('/protected', {
 				headers: { Authorization: 'Bearer invalid-token' },
 			});
-			expect(invalidResponse.status).toBe(401);
+			expect(invalidResponse.status).toBe(403);
 		});
 
 		it('should authorize with session', async () => {
@@ -966,7 +964,7 @@ describe('HonoEndpointAdaptor', () => {
 
 			// Test with no token (no session)
 			const noTokenResponse = await app.request('/protected');
-			expect(noTokenResponse.status).toBe(401);
+			expect(noTokenResponse.status).toBe(403);
 		});
 
 		it('should handle authorization errors', async () => {
@@ -1099,7 +1097,7 @@ describe('HonoEndpointAdaptor', () => {
 				body: JSON.stringify({ role: 'viewer' }),
 			});
 
-			expect(response.status).toBe(401);
+			expect(response.status).toBe(403);
 		});
 	});
 

package/src/endpoints/__tests__/MswEndpointAdaptor.spec.ts

@@ -140,7 +140,7 @@ describe('MswEndpointAdaptor', () => {
 		expect(body.name).toBe('Test User');
 	});
 
-	it('should return 401 when authorization fails', async () => {
+	it('should return 403 when authorization fails', async () => {
 		const contextId = crypto.randomUUID();
 		registerContext(contextId, {});
 
@@ -151,7 +151,7 @@ describe('MswEndpointAdaptor', () => {
 			},
 		});
 
-		expect(response.status).toBe(401);
+		expect(response.status).toBe(403);
 	});
 
 	it('should return 200 when authorization passes', async () => {

package/src/endpoints/__tests__/TestEndpointAdaptor.spec.ts

@@ -491,7 +491,7 @@ describe('TestEndpointAdaptor', () => {
 					services: mockServices,
 					headers: { host: 'example.com' },
 				}),
-			).rejects.toThrow('Unauthorized');
+			).rejects.toThrow('Forbidden');
 		});
 
 		it('should allow when authorize uses body to allow', async () => {