@geekmidas/cli 1.10.34 → 1.10.35

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@geekmidas/cli",
-  "version": "1.10.34",
+  "version": "1.10.35",
   "description": "CLI tools for building Lambda handlers, server applications, and generating OpenAPI specs",
   "private": false,
   "type": "module",
@@ -56,11 +56,11 @@
     "prompts": "~2.4.2",
     "tsx": "~4.20.3",
     "yaml": "~2.8.2",
+    "@geekmidas/constructs": "~3.0.9",
+    "@geekmidas/envkit": "~1.0.5",
     "@geekmidas/errors": "~1.0.0",
     "@geekmidas/logger": "~1.0.1",
-    "@geekmidas/constructs": "~3.0.9",
-    "@geekmidas/schema": "~1.0.0",
-    "@geekmidas/envkit": "~1.0.5"
+    "@geekmidas/schema": "~1.0.0"
   },
   "devDependencies": {
     "@types/lodash.kebabcase": "^4.1.9",

package/src/dev/__tests__/index.spec.ts

@@ -892,6 +892,125 @@ describe('Workspace Dev Server', () => {
 
 			expect(result.valid).toBe(true);
 		});
+
+		it('should validate a properly configured Vite app', async () => {
+			const appDir = join(testDir, 'apps/web');
+			mkdirSync(appDir, { recursive: true });
+
+			writeFileSync(join(appDir, 'vite.config.ts'), 'export default {}');
+			writeFileSync(
+				join(appDir, 'package.json'),
+				JSON.stringify({
+					name: 'web',
+					devDependencies: { vite: '^5.0.0' },
+					scripts: { dev: 'vite' },
+				}),
+			);
+
+			const result = await validateFrontendApp('web', 'apps/web', testDir);
+
+			expect(result.valid).toBe(true);
+			expect(result.errors).toHaveLength(0);
+		});
+
+		it('should validate a properly configured Remix app', async () => {
+			const appDir = join(testDir, 'apps/web');
+			mkdirSync(appDir, { recursive: true });
+
+			writeFileSync(join(appDir, 'vite.config.ts'), 'export default {}');
+			writeFileSync(
+				join(appDir, 'package.json'),
+				JSON.stringify({
+					name: 'web',
+					devDependencies: {
+						'@remix-run/dev': '^2.0.0',
+						vite: '^5.0.0',
+					},
+					scripts: { dev: 'remix vite:dev' },
+				}),
+			);
+
+			const result = await validateFrontendApp('web', 'apps/web', testDir);
+
+			expect(result.valid).toBe(true);
+			expect(result.errors).toHaveLength(0);
+		});
+
+		it('should warn but stay valid for a custom frontend with a dev script', async () => {
+			const appDir = join(testDir, 'apps/web');
+			mkdirSync(appDir, { recursive: true });
+
+			// No recognized config, no recognized dep — but has a dev script
+			writeFileSync(
+				join(appDir, 'package.json'),
+				JSON.stringify({
+					name: 'web',
+					dependencies: { react: '^18.0.0' },
+					scripts: { dev: 'node serve.mjs' },
+				}),
+			);
+
+			const result = await validateFrontendApp('web', 'apps/web', testDir);
+
+			expect(result.valid).toBe(true);
+			expect(result.errors).toHaveLength(0);
+			expect(result.warnings).toContainEqual(
+				expect.stringContaining('No recognized frontend framework detected'),
+			);
+		});
+
+		it('should error for a custom frontend without a dev script', async () => {
+			const appDir = join(testDir, 'apps/web');
+			mkdirSync(appDir, { recursive: true });
+
+			writeFileSync(
+				join(appDir, 'package.json'),
+				JSON.stringify({
+					name: 'web',
+					dependencies: { react: '^18.0.0' },
+				}),
+			);
+
+			const result = await validateFrontendApp('web', 'apps/web', testDir);
+
+			expect(result.valid).toBe(false);
+			expect(result.errors).toContainEqual(
+				expect.stringContaining('No "dev" script found'),
+			);
+		});
+
+		it('should validate strictly against an explicit framework', async () => {
+			const appDir = join(testDir, 'apps/web');
+			mkdirSync(appDir, { recursive: true });
+
+			// Has next.config.js + next dep — auto-detect would say nextjs
+			writeFileSync(join(appDir, 'next.config.js'), 'module.exports = {}');
+			writeFileSync(
+				join(appDir, 'package.json'),
+				JSON.stringify({
+					name: 'web',
+					dependencies: { next: '^14.0.0' },
+					scripts: { dev: 'next dev' },
+				}),
+			);
+
+			// Caller explicitly declares Vite — should fail because vite
+			// config and vite dep are missing.
+			const result = await validateFrontendApp(
+				'web',
+				'apps/web',
+				testDir,
+				'vite',
+			);
+
+			expect(result.valid).toBe(false);
+			expect(result.errors).toContainEqual(
+				expect.stringContaining('Vite config file not found'),
+			);
+			expect(result.errors).toContainEqual(
+				expect.stringContaining('Vite not found in dependencies'),
+			);
+		});
 	});
 
 	describe('validateFrontendApps', () => {

package/src/dev/index.ts

@@ -55,6 +55,7 @@ import type {
 	TelescopeConfig,
 } from '../types';
 import {
+	type FrontendFramework,
 	getAppBuildOrder,
 	getDependencyEnvVars,
 	type NormalizedWorkspace,
@@ -641,13 +642,79 @@ export function checkPortConflicts(
 }
 
 /**
- * Next.js config file patterns to check.
+ * Per-framework validation spec for supported frontend frameworks.
  */
-const NEXTJS_CONFIG_FILES = [
-	'next.config.js',
-	'next.config.ts',
-	'next.config.mjs',
-];
+interface FrontendFrameworkSpec {
+	displayName: string;
+	configFiles: string[];
+	dependency: string;
+	installCommand: string;
+}
+
+const FRONTEND_FRAMEWORKS: Record<FrontendFramework, FrontendFrameworkSpec> = {
+	nextjs: {
+		displayName: 'Next.js',
+		configFiles: [
+			'next.config.js',
+			'next.config.ts',
+			'next.config.mjs',
+			'next.config.cjs',
+		],
+		dependency: 'next',
+		installCommand: 'pnpm add next react react-dom',
+	},
+	remix: {
+		displayName: 'Remix',
+		configFiles: [
+			'remix.config.js',
+			'remix.config.mjs',
+			'remix.config.ts',
+			'vite.config.js',
+			'vite.config.ts',
+			'vite.config.mjs',
+			'vite.config.cjs',
+		],
+		dependency: '@remix-run/dev',
+		installCommand: 'pnpm add -D @remix-run/dev',
+	},
+	vite: {
+		displayName: 'Vite',
+		configFiles: [
+			'vite.config.js',
+			'vite.config.ts',
+			'vite.config.mjs',
+			'vite.config.cjs',
+		],
+		dependency: 'vite',
+		installCommand: 'pnpm add -D vite',
+	},
+};
+
+/**
+ * Auto-detect the frontend framework by scanning package.json deps and config
+ * files. Dependency match wins over config file match because deps are more
+ * distinctive (a Remix app has both vite.config.ts AND @remix-run/dev).
+ */
+function detectFrontendFramework(
+	fullPath: string,
+	deps: Record<string, string>,
+): FrontendFramework | undefined {
+	const order: FrontendFramework[] = ['nextjs', 'remix', 'vite'];
+	for (const name of order) {
+		if (deps[FRONTEND_FRAMEWORKS[name].dependency]) {
+			return name;
+		}
+	}
+	for (const name of order) {
+		const hasConfig = FRONTEND_FRAMEWORKS[name].configFiles.some((file) =>
+			existsSync(join(fullPath, file)),
+		);
+		if (hasConfig) {
+			return name;
+		}
+	}
+	return undefined;
+}
 
 /**
  * Validation result for a frontend app.
@@ -660,59 +727,88 @@ export interface FrontendValidationResult {
 }
 
 /**
- * Validate a frontend (Next.js) app configuration.
- * Checks for Next.js config file and dependency.
+ * Validate a frontend app configuration.
+ *
+ * If `framework` is provided, validates strictly against that framework's
+ * expected config file and dependency. Otherwise auto-detects the framework
+ * from package.json and config files. If no recognized framework is found, the
+ * app is allowed through with a warning provided it has a `dev` script.
+ *
  * @internal Exported for testing
  */
 export async function validateFrontendApp(
 	appName: string,
 	appPath: string,
 	workspaceRoot: string,
+	framework?: FrontendFramework,
 ): Promise<FrontendValidationResult> {
 	const errors: string[] = [];
 	const warnings: string[] = [];
 	const fullPath = join(workspaceRoot, appPath);
 
-	// Check for Next.js config file
-	const hasConfigFile = NEXTJS_CONFIG_FILES.some((file) =>
-		existsSync(join(fullPath, file)),
-	);
-
-	if (!hasConfigFile) {
+	const packageJsonPath = join(fullPath, 'package.json');
+	if (!existsSync(packageJsonPath)) {
 		errors.push(
-			`Next.js config file not found. Expected one of: ${NEXTJS_CONFIG_FILES.join(', ')}`,
+			`package.json not found at ${appPath}. Run: pnpm init in the app directory.`,
 		);
+		return { appName, valid: false, errors, warnings };
 	}
 
-	// Check for package.json
-	const packageJsonPath = join(fullPath, 'package.json');
-	if (existsSync(packageJsonPath)) {
-		try {
-			// eslint-disable-next-line @typescript-eslint/no-require-imports
-			const pkg = require(packageJsonPath);
-			const deps = { ...pkg.dependencies, ...pkg.devDependencies };
+	let pkg: {
+		dependencies?: Record<string, string>;
+		devDependencies?: Record<string, string>;
+		scripts?: Record<string, string>;
+	};
+	try {
+		// eslint-disable-next-line @typescript-eslint/no-require-imports
+		pkg = require(packageJsonPath);
+	} catch {
+		errors.push(`Failed to read package.json at ${packageJsonPath}`);
+		return { appName, valid: false, errors, warnings };
+	}
 
-			if (!deps.next) {
-				errors.push(
-					'Next.js not found in dependencies. Run: pnpm add next react react-dom',
-				);
-			}
+	const deps: Record<string, string> = {
+		...pkg.dependencies,
+		...pkg.devDependencies,
+	};
 
-			// Check for dev script
-			if (!pkg.scripts?.dev) {
-				warnings.push(
-					'No "dev" script found in package.json. Turbo expects a "dev" script to run.',
-				);
-			}
-		} catch {
-			errors.push(`Failed to read package.json at ${packageJsonPath}`);
+	const resolvedFramework =
+		framework ?? detectFrontendFramework(fullPath, deps);
+
+	if (resolvedFramework) {
+		const spec = FRONTEND_FRAMEWORKS[resolvedFramework];
+		const hasConfig = spec.configFiles.some((file) =>
+			existsSync(join(fullPath, file)),
+		);
+		if (!hasConfig) {
+			errors.push(
+				`${spec.displayName} config file not found. Expected one of: ${spec.configFiles.join(', ')}`,
+			);
+		}
+		if (!deps[spec.dependency]) {
+			errors.push(
+				`${spec.displayName} not found in dependencies. Run: ${spec.installCommand}`,
+			);
 		}
 	} else {
-		errors.push(
-			`package.json not found at ${appPath}. Run: pnpm init in the app directory.`,
+		warnings.push(
+			'No recognized frontend framework detected (Next.js, Vite, Remix). ' +
+				'The app will run via its "dev" script. Set `framework` in your app config to enable strict validation.',
 		);
 	}
 
+	if (!pkg.scripts?.dev) {
+		if (resolvedFramework) {
+			warnings.push(
+				'No "dev" script found in package.json. Turbo expects a "dev" script to run.',
+			);
+		} else {
+			errors.push(
+				'No "dev" script found in package.json. Without a recognized framework or a dev script, there is nothing to run.',
+			);
+		}
+	}
+
 	return {
 		appName,
 		valid: errors.length === 0,
@@ -737,6 +833,7 @@ export async function validateFrontendApps(
 				appName,
 				app.path,
 				workspace.root,
+				app.framework as FrontendFramework | undefined,
 			);
 			results.push(result);
 		}

package/src/init/versions.ts

@@ -45,7 +45,7 @@ export const GEEKMIDAS_VERSIONS = {
 	'@geekmidas/storage': '~2.0.2',
 	'@geekmidas/studio': '~1.0.0',
 	'@geekmidas/telescope': '~1.0.0',
-	'@geekmidas/testkit': '~1.0.5',
+	'@geekmidas/testkit': '~1.0.6',
 	'@geekmidas/cli': CLI_VERSION,
 } as const;