@geekity/cms 0.29.0 → 0.30.0

package/dist/web/conversation.js

@@ -5,10 +5,10 @@ import { postLabel, postTypeOf } from '../content/post-type.js';
 import { RSVP_LABELS } from '../content/rsvp.js';
 import { readAllQuoteAuthorizations } from '../federation/quotes.js';
 import { actorHandle, guessedName, quoteFrom, replyFrom, REPLY_ACTIVITY_TYPE, } from '../federation/replies.js';
-import { authorContext, authorFeedHref, siteAuthorContext } from './authors.js';
+import { authorContext, authorFeedHref, profileContext, siteAuthorContext } from './authors.js';
 import { activityStreamsId, isListed, isServed, permalinkOfObjectId } from './documents.js';
-import { isRepliesKey, repliesFeedPath, repliesKey } from './feed-source.js';
-import { COMMENT_PAGE_PREFIX, commentPageHref, feedGuid, replyGuid } from './guids.js';
+import { isKey, repliesFeedPath, repliesKey } from './feed-source.js';
+import { COMMENT_PAGE_PREFIX, commentPageHref, feedGuid } from './guids.js';
 import { absoluteUrl } from './negotiate.js';
 import { sanitizeCommentHtml } from './sanitize.js';
 const RSVP_GROUP_ORDER = ['yes', 'maybe', 'interested', 'no'];
@@ -76,7 +76,12 @@ function postConversation(context, document) {
 function gather(context, document, seen = new Set([document.path])) {
     const objectId = activityStreamsId(document, context.baseUrl);
     const root = rootOf(context, document);
-    const activities = objectId === undefined ? [] : activitiesAround(context.admin, objectId);
+    const stored = context.admin.listCommentsFor(document.slug);
+    const users = context.users();
+    // What was imported from the fediverse is walked from too: an answer to an
+    // imported note names the note, which no logged activity may carry.
+    const origins = stored.flatMap((comment) => comment.source === 'activitypub' && comment.origin !== undefined ? [comment.origin] : []);
+    const activities = objectId === undefined ? [] : activitiesAround(context.admin, [objectId, ...origins]);
     const naming = authorNaming(context.admin);
     const quotes = objectId === undefined
         ? []
@@ -88,7 +93,11 @@ function gather(context, document, seen = new Set([document.path])) {
     const mentions = [...quotes];
     const answers = [];
     const held = new Map();
-    const reacted = new Set();
+    // One like per actor, so a like imported from the site this one replaced
+    // and the same person's like delivered here are one.
+    const reacted = new Set(stored.flatMap(({ kind, actor }) => actor === undefined || (kind !== 'like' && kind !== 'boost' && kind !== 'repost')
+        ? []
+        : [`${kind === 'like' ? 'like' : 'boost'}\0${actor}`]));
     const isEvent = postTypeOf(document) === 'event';
     for (const activity of activities) {
         const answer = isEvent ? RSVP_ACTIVITIES[activity.activityType] : undefined;
@@ -99,7 +108,7 @@ function gather(context, document, seen = new Set([document.path])) {
                 continue;
             const author = naming(activity.actorId);
             answers.push({
-                id: activity.activityId ?? `${activity.actorId}#rsvp`,
+                ...unstored(activity.activityId ?? `${activity.actorId}#rsvp`),
                 source: 'activitypub',
                 kind: 'reply',
                 author,
@@ -119,17 +128,21 @@ function gather(context, document, seen = new Set([document.path])) {
             // belongs to that reply's own conversation, wherever it is shown.
             if (activity.objectId !== objectId)
                 continue;
-            // One like per actor, however many times it was delivered, and none at
-            // all once its actor has taken it back.
+            // One like per actor, however many times it was delivered, and none
+            // at all once its actor has taken it back.
             const key = `${kind}\0${activity.actorId}`;
             if (reacted.has(key))
                 continue;
             if (activity.activityId !== null && withdrawn.has(activity.activityId))
                 continue;
+            if (activity.activityId !== null &&
+                heldComment(context.admin, activity.activityId) !== undefined) {
+                continue;
+            }
             reacted.add(key);
             const author = naming(activity.actorId);
             (kind === 'like' ? likes : boosts).push({
-                id: activity.activityId ?? `${activity.actorId}#${kind}`,
+                ...unstored(activity.activityId ?? `${activity.actorId}#${kind}`),
                 source: 'activitypub',
                 kind,
                 author,
@@ -143,13 +156,14 @@ function gather(context, document, seen = new Set([document.path])) {
             continue;
         }
         const reply = replyFrom(activity);
-        if (reply === undefined)
+        if (reply === undefined || heldComment(context.admin, reply.id) !== undefined)
             continue;
-        written.push(federatedInteraction(reply, naming(activity.actorId)));
+        const parent = heldComment(context.admin, reply.inReplyTo);
+        written.push(federatedInteraction(parent === undefined ? reply : { ...reply, inReplyTo: parent.id }, naming(activity.actorId)));
     }
-    for (const stored of context.admin.listCommentsFor(document.slug)) {
-        const comment = interactionOf(stored, document.permalink);
-        if (stored.status !== 'approved') {
+    for (const record of stored) {
+        const comment = interactionOf(record, document.permalink, context.baseUrl, users);
+        if (record.status !== 'approved') {
             held.set(comment.id, comment);
             continue;
         }
@@ -219,7 +233,7 @@ function commentThread(context, id) {
     };
 }
 function replyNamed(context, document, url) {
-    return namedIn(context, document, gather(context, document), url)?.id;
+    return namedIn(context, document, gather(context, document), url);
 }
 /** The entry of a gathered conversation a URL names, held ones included. */
 function namedIn(context, document, said, url) {
@@ -230,8 +244,8 @@ function namedIn(context, document, said, url) {
     catch {
         return undefined;
     }
-    const commentId = commentNamedBy(named, document, context.baseUrl);
-    return [...said.written, ...said.held.values()].find((reply) => reply.id === commentId ||
+    const key = keyNamedBy(named, document, context.baseUrl);
+    return [...said.written, ...said.held.values()].find((reply) => reply.key === key ||
         reply.id === named.href ||
         (reply.url !== null && absoluteUrl(reply.url, context.baseUrl) === named.href));
 }
@@ -249,35 +263,30 @@ function heldAt(context, url) {
     }
     return { kind: 'reply', post, reply };
 }
-function repliesTo(context, segment) {
-    if (!isRepliesKey(segment)) {
-        const stored = context.admin.getComment(segment);
-        if (stored?.source !== 'comment')
-            return undefined;
-        const post = context.store.getBySlug(stored.slug);
-        return post === undefined ? undefined : repliesIn(context, post, segment);
-    }
+function repliesTo(context, key) {
+    if (!isKey(key))
+        return undefined;
     // Each source's index is asked in turn, so a key naming nothing costs three
     // lookups and no more (TASK-327).
-    const [document] = context.store.listByRepliesKey(segment);
+    const [document] = context.store.listByRepliesKey(key);
     if (document !== undefined) {
-        if (repliesKey(feedGuid(document, context.baseUrl)) === segment) {
+        if (repliesKey(feedGuid(document, context.baseUrl)) === key) {
             return repliesIn(context, document, null);
         }
         const root = threadRootOf(context, document);
-        return root === undefined ? undefined : repliesIn(context, root, rootOf(context, document));
+        return root === undefined ? undefined : repliesIn(context, root, key);
     }
-    const [comment] = context.admin.listCommentsByRepliesKey(segment);
+    const comment = context.admin.getComment(key);
     if (comment !== undefined) {
         const post = context.store.getBySlug(comment.slug);
-        return post === undefined ? undefined : repliesIn(context, post, comment.id);
+        return post === undefined ? undefined : repliesIn(context, post, key);
     }
-    for (const activity of context.admin.listRepliesByKey(segment)) {
+    for (const activity of context.admin.listRepliesByKey(key)) {
         const reply = replyFrom(activity);
         if (reply === undefined)
             continue;
         const post = documentNamed(context, reply.id);
-        return post === undefined ? undefined : repliesIn(context, post, reply.id);
+        return post === undefined ? undefined : repliesIn(context, post, key);
     }
     return undefined;
 }
@@ -285,17 +294,17 @@ function repliesTo(context, segment) {
  * The direct replies of one reply in a document's thread, or of the document
  * itself, while the document is served and the reply is one a reader sees.
  */
-function repliesIn(context, post, id) {
+function repliesIn(context, post, key) {
     if (!isServed(post, context.store.now()))
         return undefined;
     const thread = postConversation(context, post).replies;
-    const reply = id === null ? null : visibleReply(thread, id);
+    const reply = key === null ? null : visibleReply(thread, key);
     if (reply === undefined)
         return undefined;
     return {
         post,
         reply,
-        replies: directReplies(reply?.replies ?? thread).map((entry) => ({ ...entry, parent: reply })),
+        replies: repliesFed(reply?.replies ?? thread).map((entry) => ({ ...entry, parent: reply })),
     };
 }
 function upstreamsOf(context, document) {
@@ -367,16 +376,16 @@ function documentNamed(context, url, depth = 0) {
         return undefined;
     }
     if (named.origin === new URL(context.baseUrl).origin) {
-        const id = commentIdAt(named.pathname);
-        if (id !== undefined) {
-            const comment = context.admin.getComment(id);
+        const key = commentKeyAt(named.pathname);
+        if (key !== undefined) {
+            const comment = context.admin.getComment(key);
             return comment === undefined ? undefined : context.store.getBySlug(comment.slug);
         }
         const permalink = permalinkOfObjectId(`${named.origin}${named.pathname}`, context.baseUrl);
         const found = permalink === undefined ? undefined : context.store.getByPermalink(permalink);
         return found ?? context.store.getByStoredObjectId(named.href);
     }
-    const [comment] = context.admin.listCommentsAt(named.href);
+    const comment = context.admin.listCommentsAt(named.href)[0] ?? heldComment(context.admin, named.href);
     if (comment !== undefined)
         return context.store.getBySlug(comment.slug);
     for (const activity of context.admin.listActivitiesAbout([named.href])) {
@@ -447,7 +456,7 @@ export function commentNames(id, permalink, baseUrl) {
 /** A reply post as the thread's own shape, answering `inReplyTo`. */
 function replyPostInteraction(context, post, id, inReplyTo) {
     return {
-        id,
+        ...unstored(id),
         source: 'post',
         kind: 'reply',
         author: documentAuthor(context, post),
@@ -464,27 +473,32 @@ function documentAuthor(context, post) {
     const users = context.users();
     const site = readSiteSettings(context.contentDir);
     const author = authorContext(users, post.author) ?? siteAuthorContext(users, site.author);
+    return bylineAuthor(author, site.title);
+}
+/** A byline as the thread names its author, `fallback` when it names nobody. */
+function bylineAuthor(author, fallback) {
     return {
-        name: author?.name ?? site.title,
+        name: author?.name ?? fallback,
         handle: null,
         url: author?.url ?? null,
         avatar: author?.avatar ?? null,
         actorId: null,
         feed: author?.username === undefined ? null : authorFeedHref(author.username, 'rss'),
+        username: author?.username ?? null,
     };
 }
-/** The comment a URL on this site names by its page or by its anchor on the post. */
-function commentNamedBy(url, document, baseUrl) {
+/** The key a URL on this site names by a comment's page or by an anchor on the post. */
+function keyNamedBy(url, document, baseUrl) {
     const post = new URL(absoluteUrl(document.permalink, baseUrl));
     if (url.origin !== post.origin)
         return undefined;
-    const onItsPage = commentIdAt(url.pathname);
+    const onItsPage = commentKeyAt(url.pathname);
     if (onItsPage !== undefined)
         return onItsPage;
     const anchor = `#${commentAnchor('')}`;
     if (url.pathname !== post.pathname || !url.hash.startsWith(anchor))
         return undefined;
-    return decoded(url.hash.slice(anchor.length));
+    return url.hash.slice(anchor.length);
 }
 /**
  * What a reply answers, from the top of the thread down to its parent.
@@ -554,7 +568,7 @@ function siteConversation(context, limit) {
         offset += page.length;
         for (const activity of page) {
             const reply = replyFrom(activity);
-            if (reply === undefined)
+            if (reply === undefined || heldComment(context.admin, reply.id) !== undefined)
                 continue;
             // A note answering another note is as much this post's as one answering
             // the post, so the post is found the way a reply post finds its thread.
@@ -576,26 +590,31 @@ function siteConversation(context, limit) {
             said.push({ ...quote, post });
         }
     }
-    for (const stored of context.admin.listComments({
-        status: 'approved',
-        limit: limit * OVERSCAN,
-    })) {
-        const post = context.store.getBySlug(stored.slug);
-        if (!shown(post))
-            continue;
-        said.push({ ...interactionOf(stored, post.permalink), post });
-    }
     // Each post's thread, read once: where each reply sits and what it carries
     // is the thread's to say, so the site's feed and the post's agree.
     const threads = new Map();
     const placedOn = (post) => {
         let found = threads.get(post.path);
         if (found === undefined) {
-            found = new Map(placed(postConversation(context, post).replies).map((reply) => [reply.id, reply]));
+            found = new Map(saidIn(postConversation(context, post)).map((reply) => [reply.id, reply]));
             threads.set(post.path, found);
         }
         return found;
     };
+    // A stored comment is taken from its post's thread rather than read on its
+    // own, so a reaction or an event's RSVP, which the thread holds apart, is
+    // left out here as it is from the post's feed.
+    for (const stored of context.admin.listComments({
+        status: 'approved',
+        limit: limit * OVERSCAN,
+    })) {
+        const post = context.store.getBySlug(stored.slug);
+        if (!shown(post))
+            continue;
+        const entry = placedOn(post).get(stored.id);
+        if (entry !== undefined)
+            said.push({ ...entry, post });
+    }
     // A reply post is in the feed of the thread it is shown in, unlisted or
     // not: the thread is listed, and the reply post is one of its answers.
     for (const answer of context.store.listReplyPosts({ limit: limit * OVERSCAN })) {
@@ -606,7 +625,7 @@ function siteConversation(context, limit) {
         if (reply !== undefined)
             said.push({ ...reply, post });
     }
-    return newestFirst(said, limit).map((entry) => {
+    return newestFirst(said.filter(conversational), limit).map((entry) => {
         const thread = placedOn(entry.post);
         return {
             ...(thread.get(entry.id) ?? { ...entry, parent: null }),
@@ -619,7 +638,7 @@ function siteConversation(context, limit) {
 function directCounts(context, documents) {
     return new Map(documents.map((document) => [
         document.permalink,
-        directReplies(postConversation(context, document).replies).length,
+        repliesFed(postConversation(context, document).replies).length,
     ]));
 }
 /**
@@ -653,7 +672,7 @@ function quotesOf(admin, approvals, objectId, naming) {
             if (quote?.id !== approval.quote || quote.quoted !== objectId)
                 continue;
             quotes.push({
-                id: quote.id,
+                ...unstored(quote.id),
                 source: 'activitypub',
                 kind: 'mention',
                 author: naming(quote.actorId),
@@ -674,7 +693,7 @@ function quotesOf(admin, approvals, objectId, naming) {
 /** One logged fediverse reply as the thread's own shape. */
 function federatedInteraction(reply, author) {
     return {
-        id: reply.id,
+        ...unstored(reply.id),
         source: 'activitypub',
         kind: 'reply',
         author,
@@ -688,24 +707,33 @@ function federatedInteraction(reply, author) {
         replies: [],
     };
 }
+function unstored(id) {
+    return { id, key: repliesKey(id), guid: id, migrated: false };
+}
 /** One stored comment as the thread's own shape. */
-function interactionOf(comment, permalink) {
+function interactionOf(comment, permalink, baseUrl, users) {
+    // A user the site no longer has is named as the comment was signed.
+    const user = users.find((candidate) => candidate.username === comment.user);
     return {
         id: comment.id,
+        key: comment.id,
+        guid: comment.source === 'comment'
+            ? absoluteUrl(commentPageHref(comment.id), baseUrl)
+            : (comment.origin ?? comment.url ?? comment.id),
+        migrated: comment.migrated === true,
         source: comment.source,
         kind: comment.kind,
-        author: {
-            name: comment.author.name,
-            // A commenter has no fediverse identity: they gave a name, maybe a
-            // website, and nothing that names them anywhere else.
-            handle: null,
-            url: comment.author.url,
-            // Only a webmention has one: it came out of the source page's `h-card`,
-            // and a form asks nobody for a picture.
-            avatar: comment.author.avatar === null ? null : avatarHref(comment.author.avatar),
-            actorId: null,
-            feed: comment.source === 'webmention' ? comment.author.url : null,
-        },
+        author: user === undefined
+            ? {
+                name: comment.author.name,
+                handle: comment.actor === undefined ? null : (actorHandle(comment.actor) ?? null),
+                url: comment.author.url,
+                avatar: comment.author.avatar === null ? null : avatarHref(comment.author.avatar),
+                actorId: comment.actor ?? null,
+                feed: comment.source === 'webmention' ? comment.author.url : null,
+                username: null,
+            }
+            : bylineAuthor(profileContext(user), comment.author.name),
         // Where it can be read. A comment written here has a page of its own
         // (TASK-318); a webmention lives on the page it was sent from, and its
         // `url` says so. A theme that prints `url` for a fediverse reply prints a
@@ -725,46 +753,53 @@ function interactionOf(comment, permalink) {
     };
 }
 /**
- * The `id` a comment is anchored at on the page.
+ * The stored comment holding a fediverse note or activity id as its origin:
+ * one imported from the site this one replaced, keyed by that id as it would
+ * have been had it arrived here (TASK-336). A delivery or a fetch of the same
+ * id is that comment again, and the stored one wins, since it is the one the
+ * moderator decided on and the thread anchors.
+ */
+export function heldComment(admin, id) {
+    const comment = admin.getComment(repliesKey(id));
+    return comment?.origin === id ? comment : undefined;
+}
+/**
+ * The `id` a thread entry is anchored at on the page, by its key.
  *
  * Prefixed rather than bare so a comment can never collide with a heading
  * anchor the post's own Markdown produced.
  */
-export function commentAnchor(id) {
-    return `comment-${id}`;
+export function commentAnchor(key) {
+    return `comment-${key}`;
 }
-/** The id of the comment whose page a path is, or `undefined` (TASK-319). */
-export function commentIdAt(pathname) {
+/** The key of the comment whose page a path is, or `undefined` (TASK-319). */
+export function commentKeyAt(pathname) {
     if (!pathname.startsWith(COMMENT_PAGE_PREFIX) || !pathname.endsWith('/'))
         return undefined;
-    const encoded = pathname.slice(COMMENT_PAGE_PREFIX.length, -1);
-    if (encoded === '' || encoded.includes('/'))
-        return undefined;
-    return decoded(encoded);
-}
-function decoded(value) {
-    try {
-        return decodeURIComponent(value);
-    }
-    catch {
-        return undefined;
-    }
+    const key = pathname.slice(COMMENT_PAGE_PREFIX.length, -1);
+    return isKey(key) ? key : undefined;
 }
-/**
- * Everything said in a conversation, at every depth and in no order: the
- * replies and the mentions.
- *
- * The likes and the boosts are left out because they say nothing. A feed item
- * is somebody's words, and "@ada liked this" has none to carry — a reader
- * polling a comments feed would get an entry with an empty body and no way to
- * tell what it was for.
- */
+/** What a post's comments feed carries, at every depth and in no order. */
 export function spokenIn(conversation) {
+    return saidIn(conversation).filter(conversational);
+}
+/** The mentions and every visible reply of a conversation, each with its parent. */
+function saidIn(conversation) {
     return [
         ...conversation.mentions.map((mention) => ({ ...mention, parent: null })),
         ...placed(conversation.replies),
     ];
 }
+/**
+ * Whether a feed carries it and a reply count counts it (TASK-335): somebody's
+ * words, a reply or a mention, said here. A like, a boost or a repost says
+ * nothing — "@ada liked this" would be an item with an empty body — and a
+ * migrated entry was published before the site came here, so a reader must
+ * not see it as new.
+ */
+function conversational(entry) {
+    return !entry.migrated && (entry.kind === 'reply' || entry.kind === 'mention');
+}
 /** Every visible reply of a thread at any depth, each with the reply it sits under. */
 function placed(replies, parent = null) {
     return directReplies(replies).flatMap((reply) => [
@@ -780,15 +815,9 @@ function placed(replies, parent = null) {
 function directReplies(replies) {
     return replies.flatMap((reply) => (isWithheld(reply) ? directReplies(reply.replies) : [reply]));
 }
-/**
- * The `/replies/` feed of one reply: a native comment's by its id, anything
- * else's by the key of its guid, as is a native comment whose id would read
- * as a key.
- */
-function repliesHrefOf(reply, baseUrl) {
-    return repliesFeedPath(reply.source === 'comment' && !isRepliesKey(reply.id)
-        ? reply.id
-        : repliesKey(replyGuid(reply, baseUrl)));
+/** The direct replies a feed carries and a count advertises. */
+function repliesFed(replies) {
+    return directReplies(replies).filter(conversational);
 }
 /**
  * Interactions as a comments feed carries them: newest first, at most `limit`,
@@ -807,10 +836,10 @@ export function feedComments(said, options) {
             ? thread === undefined
                 ? undefined
                 : feedGuid(thread, baseUrl)
-            : replyGuid(entry.parent, baseUrl);
-        const replies = directReplies(entry.replies);
+            : entry.parent.guid;
+        const replies = repliesFed(entry.replies);
         return {
-            id: replyGuid(entry, baseUrl),
+            id: entry.guid,
             url: absoluteUrl(entry.url ?? '/', baseUrl),
             author: entry.author.name,
             published: entry.published,
@@ -821,7 +850,7 @@ export function feedComments(said, options) {
                 : {
                     replies: {
                         count: replies.length,
-                        feed: absoluteUrl(repliesHrefOf(entry, baseUrl), baseUrl),
+                        feed: absoluteUrl(repliesFeedPath(entry.key), baseUrl),
                     },
                 }),
             ...(entry.author.feed === null
@@ -955,7 +984,8 @@ function threadOf(said, under = said.root) {
         const list = siblings(said.held.get(id)?.inReplyTo ?? said.root, id, true);
         if (list === undefined)
             return undefined;
-        const entry = { id, withheld: true, replies: [] };
+        const key = isKey(id) ? id : repliesKey(id);
+        const entry = { id, key, withheld: true, replies: [] };
         list.push(entry);
         withheld.set(id, entry);
         return entry;
@@ -965,12 +995,12 @@ function threadOf(said, under = said.root) {
     }
     return top;
 }
-/** The entry of a thread with this id that a reader can see, at any depth. */
-export function visibleReply(replies, id) {
+/** The entry of a thread with this key that a reader can see, at any depth. */
+export function visibleReply(replies, key) {
     for (const reply of replies) {
-        if (!isWithheld(reply) && reply.id === id)
+        if (!isWithheld(reply) && reply.key === key)
             return reply;
-        const found = visibleReply(reply.replies, id);
+        const found = visibleReply(reply.replies, key);
         if (found !== undefined)
             return found;
     }
@@ -1021,10 +1051,10 @@ const REACTIONS = {
  * stops when a round finds nothing new, which it must, because a row is
  * collected once and there are finitely many.
  */
-function activitiesAround(admin, objectId) {
+function activitiesAround(admin, objectIds) {
     const collected = new Map();
-    const asked = new Set([objectId]);
-    let frontier = [objectId];
+    const asked = new Set(objectIds);
+    let frontier = [...asked];
     while (frontier.length > 0) {
         const next = [];
         for (const activity of admin.listActivitiesAbout(frontier)) {
@@ -1106,6 +1136,7 @@ function authorNaming(admin) {
             avatar: icon === null ? null : avatarHref(icon),
             actorId,
             feed: null,
+            username: null,
         };
         known.set(actorId, author);
         return author;