@geekbeer/minion 3.40.1 → 3.40.2

package/core/routes/skills.js

@@ -49,7 +49,7 @@ function parseFrontmatter(content) {
  * written to every enabled plugin's directory so switching Primary doesn't
  * break skill availability.
  *
- * @param {string} name - Skill slug (e.g. "execution-report")
+ * @param {string} name - Skill slug (e.g. "daily-check")
  * @param {object} opts
  * @param {string} opts.content - Skill body (markdown without frontmatter)
  * @param {string} [opts.description] - Skill description for frontmatter
@@ -103,7 +103,7 @@ async function writeSkillToLocal(name, { content, description, display_name, typ
  * Read a local skill and push it to HQ.
  * Reusable by workflow push to auto-sync pipeline skills.
  *
- * @param {string} name - Skill slug (e.g. "execution-report")
+ * @param {string} name - Skill slug (e.g. "daily-check")
  * @param {object} [opts]
  * @param {string} [opts.workspaceId] - Target workspace ID (overrides WORKSPACE_ID env var)
  * @returns {Promise<object>} HQ response
@@ -391,8 +391,9 @@ async function skillRoutes(fastify, opts) {
       log_file: logFile,
     })
 
-    // Dispatched steps also run /execution-report so the post-execution hook
-    // can read back the structured output and forward it to HQ for review.
+    // For dispatched steps, the post-execution hook reads the outcome record
+    // (set by workflow-runner from the CLI exit code via the local outcome API)
+    // and forwards the summary to HQ so reviewers can see the step's report.
     const isDispatchedStep = execution_id && step_index != null
     const runOptions = {}
     if (role) runOptions.role = role
@@ -437,7 +438,7 @@ async function skillRoutes(fastify, opts) {
         // Post-execution hook: report step completion to HQ
         if (isDispatchedStep) {
           try {
-            // Read execution report generated by /execution-report skill
+            // Read the outcome record saved by workflow-runner
             let outputSummary = null
             try {
               const execRecord = await executionStore.getById(effectiveExecutionId)

package/docs/api-reference.md

@@ -867,7 +867,7 @@ push するとパイプライン内のスキル名が `skill_version_id` に解
 ```json
 {
   "name": "my-workflow",
-  "pipeline_skill_names": ["skill-1", "skill-2", "execution-report"],
+  "pipeline_skill_names": ["skill-1", "skill-2"],
   "pipeline": [
     {
       "skill_version_id": "uuid",
@@ -1748,7 +1748,7 @@ Response:
   {
     "id": "uuid",
     "name": "routine-name",
-    "pipeline_skill_names": ["skill-1", "execution-report"],
+    "pipeline_skill_names": ["skill-1"],
     "content": "...",
     "is_active": true,
     "cron_expression": "0 9 * * 1-5",

package/linux/routes/directives.js

@@ -112,15 +112,12 @@ async function directiveRoutes(fastify) {
 
       try {
         // Execute as a single-skill workflow
-        // skipExecutionReport: the orchestration template has its own
-        // completion report (section 5), so /execution-report is redundant
-        // and would use the wrong (local) execution ID.
         const result = await workflowRunner.runWorkflow({
           id: effectiveExecutionId,
           name: workflowName,
           pipeline_skill_names: [skill_name],
           workspace_id: workspaceId,
-        }, { skipExecutionReport: true })
+        })
 
         console.log(`[Directive] Execution completed: ${skill_name} (success: ${result.execution_id ? 'yes' : 'no'})`)
       } catch (err) {

package/linux/routine-runner.js

@@ -5,8 +5,7 @@
  *
  * Key design:
  * - All skills in a routine run in ONE CLI session (context preserved)
- * - /execution-report is automatically appended to report outcome
- * - Marker file written before session start for skill-to-execution mapping
+ * - Outcome is reported to the local API by the runner itself based on CLI exit code
  * - Same tmux execution model as workflow-runner
  */
 
@@ -66,7 +65,7 @@ async function executeRoutineSession(routine, executionId, skillNames) {
   const homeDir = config.HOME_DIR
   const sessionName = generateSessionName(routine.id, executionId)
 
-  // Build prompt: run each skill in sequence, then execution-report
+  // Build prompt: run each skill in sequence
   const primary = getActivePrimary()
   const formatSkill = primary && typeof primary.formatSkillInvocation === 'function'
     ? primary.formatSkillInvocation.bind(primary)
@@ -78,8 +77,7 @@ async function executeRoutineSession(routine, executionId, skillNames) {
     ? `## Context\n\n${routine.context}\n\n---\n\n`
     : ''
 
-  const reportSkill = formatSkill('execution-report')
-  const prompt = `${contextPrefix}Run the following skills in order: ${skillCommands}. After completing all skills, run ${reportSkill} to report the results.`
+  const prompt = `${contextPrefix}Run the following skills in order: ${skillCommands}.`
 
   // Exit code file to capture CLI result
   const exitCodeFile = `/tmp/tmux-exit-${sessionName}`
@@ -88,7 +86,7 @@ async function executeRoutineSession(routine, executionId, skillNames) {
   const logFile = logManager.getLogPath(executionId)
 
   console.log(`[RoutineRunner] Executing routine: ${routine.name}`)
-  console.log(`[RoutineRunner] Skills: ${skillNames.join(' → ')} → execution-report`)
+  console.log(`[RoutineRunner] Skills: ${skillNames.join(' → ')}`)
   console.log(`[RoutineRunner] tmux session: ${sessionName}`)
   console.log(`[RoutineRunner] Log file: ${logFile}`)
 
@@ -281,6 +279,7 @@ async function runRoutine(routine) {
   const result = await executeRoutineSession(routine, executionId, pipelineSkillNames)
 
   const completedAt = new Date().toISOString()
+  const outcome = result.success ? 'success' : 'failure'
 
   // Save: routine completed
   await executionStore.save({
@@ -290,7 +289,7 @@ async function runRoutine(routine) {
     routine_name: routine.name,
     workspace_id: routine.workspace_id || '',
     status: result.success ? 'completed' : 'failed',
-    outcome: result.success ? null : 'failure',
+    outcome,
     started_at: startedAt,
     completed_at: completedAt,
     parent_execution_id: null,
@@ -298,6 +297,40 @@ async function runRoutine(routine) {
     log_file: logFile,
   })
 
+  // Extract summary from execution log file (captured via tmux pipe-pane)
+  let summary = result.success
+    ? `All skills completed successfully: ${pipelineSkillNames.join(', ')}`
+    : `Routine failed: ${result.error || 'unknown error'}`
+  try {
+    const logData = await logManager.readLog(executionId, { tail: 200 })
+    if (logData && logData.content && logData.content.trim().length > 0) {
+      const MAX_SUMMARY_LENGTH = 10000
+      const content = logData.content.trim()
+      summary = content.length > MAX_SUMMARY_LENGTH
+        ? content.slice(-MAX_SUMMARY_LENGTH)
+        : content
+    }
+  } catch (err) {
+    console.error(`[RoutineRunner] Failed to read log for summary: ${err.message}`)
+  }
+
+  // Report outcome via local API
+  try {
+    const resp = await fetch(`http://localhost:${config.AGENT_PORT || 8080}/api/executions/${executionId}/outcome`, {
+      method: 'POST',
+      headers: { 'Content-Type': 'application/json' },
+      body: JSON.stringify({
+        outcome,
+        summary,
+      }),
+    })
+    if (!resp.ok) {
+      console.error(`[RoutineRunner] Failed to report outcome: ${resp.status}`)
+    }
+  } catch (err) {
+    console.error(`[RoutineRunner] Failed to report outcome: ${err.message}`)
+  }
+
   // Update last_run in local store
   await routineStore.updateLastRun(routine.id)
 

package/linux/workflow-runner.js

@@ -383,7 +383,7 @@ async function runWorkflow(workflow, options = {}) {
     console.error(`[WorkflowRunner] Failed to read log for summary: ${err.message}`)
   }
 
-  // Report outcome via local API (same data the execution-report skill used to send)
+  // Report outcome via local API
   try {
     const resp = await fetch(`http://localhost:${config.AGENT_PORT || 8080}/api/executions/${executionId}/outcome`, {
       method: 'POST',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@geekbeer/minion",
-  "version": "3.40.1",
+  "version": "3.40.2",
   "description": "AI Agent runtime for Minion - manages status and skill deployment on VPS",
   "main": "linux/server.js",
   "bin": {

package/roles/engineer.md

@@ -6,7 +6,6 @@
 
 - **スキル実行**: 割り当てられたワークフローステップ（スキル）を確実に実行する
 - **タスク完了**: スキルの指示に従い、成果物を生成する
-- **結果報告**: 実行結果を `/execution-report` または API 経由で報告する
 
 ## 重要なルール
 

package/win/routes/directives.js

@@ -94,7 +94,7 @@ async function directiveRoutes(fastify) {
           name: workflowName,
           pipeline_skill_names: [skill_name],
           workspace_id: workspaceId,
-        }, { skipExecutionReport: true })
+        })
 
         console.log(`[Directive] Execution completed: ${skill_name} (success: ${result.execution_id ? 'yes' : 'no'})`)
       } catch (err) {

package/win/routine-runner.js

@@ -58,13 +58,12 @@ async function executeRoutineSession(routine, executionId, skillNames) {
   const contextPrefix = routine.context
     ? `## Context\n\n${routine.context}\n\n---\n\n`
     : ''
-  const reportSkill = formatSkill('execution-report')
-  const prompt = `${contextPrefix}Run the following skills in order: ${skillCommands}. After completing all skills, run ${reportSkill} to report the results.`
+  const prompt = `${contextPrefix}Run the following skills in order: ${skillCommands}.`
 
   const logFile = logManager.getLogPath(executionId)
 
   console.log(`[RoutineRunner] Executing routine: ${routine.name}`)
-  console.log(`[RoutineRunner] Skills: ${skillNames.join(' -> ')} -> execution-report`)
+  console.log(`[RoutineRunner] Skills: ${skillNames.join(' -> ')}`)
   console.log(`[RoutineRunner] Session: ${sessionName}`)
   console.log(`[RoutineRunner] Log file: ${logFile}`)
 
@@ -220,6 +219,7 @@ async function runRoutine(routine) {
 
   const result = await executeRoutineSession(routine, executionId, pipelineSkillNames)
   const completedAt = new Date().toISOString()
+  const outcome = result.success ? 'success' : 'failure'
 
   await executionStore.save({
     id: executionId,
@@ -228,7 +228,7 @@ async function runRoutine(routine) {
     routine_name: routine.name,
     workspace_id: routine.workspace_id || '',
     status: result.success ? 'completed' : 'failed',
-    outcome: result.success ? null : 'failure',
+    outcome,
     started_at: startedAt,
     completed_at: completedAt,
     parent_execution_id: null,
@@ -236,6 +236,40 @@ async function runRoutine(routine) {
     log_file: logFile,
   })
 
+  // Extract summary from execution log file (captured via pty logStream)
+  let summary = result.success
+    ? `All skills completed successfully: ${pipelineSkillNames.join(', ')}`
+    : `Routine failed: ${result.error || 'unknown error'}`
+  try {
+    const logData = await logManager.readLog(executionId, { tail: 200 })
+    if (logData && logData.content && logData.content.trim().length > 0) {
+      const MAX_SUMMARY_LENGTH = 10000
+      const content = logData.content.trim()
+      summary = content.length > MAX_SUMMARY_LENGTH
+        ? content.slice(-MAX_SUMMARY_LENGTH)
+        : content
+    }
+  } catch (err) {
+    console.error(`[RoutineRunner] Failed to read log for summary: ${err.message}`)
+  }
+
+  // Report outcome via local API
+  try {
+    const resp = await fetch(`http://localhost:${config.AGENT_PORT || 8080}/api/executions/${executionId}/outcome`, {
+      method: 'POST',
+      headers: { 'Content-Type': 'application/json' },
+      body: JSON.stringify({
+        outcome,
+        summary,
+      }),
+    })
+    if (!resp.ok) {
+      console.error(`[RoutineRunner] Failed to report outcome: ${resp.status}`)
+    }
+  } catch (err) {
+    console.error(`[RoutineRunner] Failed to report outcome: ${err.message}`)
+  }
+
   await routineStore.updateLastRun(routine.id)
 
   runningExecutions.delete(executionId)