@geekbeer/minion 3.23.0 → 3.23.1

package/core/db.js

@@ -451,9 +451,12 @@ function migrateSchema(db) {
 
       console.log('[DB] Migration 3 complete: memories.project_id added')
     } catch (err) {
-      // Column may already exist (duplicate column error)
-      console.warn(`[DB] Migration 3 skipped: ${err.message}`)
-      try { db.exec("INSERT OR IGNORE INTO schema_version (version) VALUES (3)") } catch {}
+      if (hasColumn(db, 'memories', 'project_id')) {
+        console.warn(`[DB] Migration 3 skipped (column already exists): ${err.message}`)
+        try { db.exec("INSERT OR IGNORE INTO schema_version (version) VALUES (3)") } catch {}
+      } else {
+        console.error(`[DB] Migration 3 FAILED — memories.project_id not added: ${err.message}`)
+      }
     }
   }
 
@@ -472,8 +475,12 @@ function migrateSchema(db) {
 
       console.log('[DB] Migration 4 complete: chat_sessions.workspace_id added')
     } catch (err) {
-      console.warn(`[DB] Migration 4 skipped: ${err.message}`)
-      try { db.exec("INSERT OR IGNORE INTO schema_version (version) VALUES (4)") } catch {}
+      if (hasColumn(db, 'chat_sessions', 'workspace_id')) {
+        console.warn(`[DB] Migration 4 skipped (column already exists): ${err.message}`)
+        try { db.exec("INSERT OR IGNORE INTO schema_version (version) VALUES (4)") } catch {}
+      } else {
+        console.error(`[DB] Migration 4 FAILED — chat_sessions.workspace_id not added: ${err.message}`)
+      }
     }
   }
 
@@ -492,10 +499,66 @@ function migrateSchema(db) {
 
       console.log('[DB] Migration 5 complete: todos.session_id / injection_count added')
     } catch (err) {
-      console.warn(`[DB] Migration 5 skipped: ${err.message}`)
-      try { db.exec("INSERT OR IGNORE INTO schema_version (version) VALUES (5)") } catch {}
+      if (hasColumn(db, 'todos', 'session_id') && hasColumn(db, 'todos', 'injection_count')) {
+        console.warn(`[DB] Migration 5 skipped (columns already exist): ${err.message}`)
+        try { db.exec("INSERT OR IGNORE INTO schema_version (version) VALUES (5)") } catch {}
+      } else {
+        console.error(`[DB] Migration 5 FAILED — todos columns not added: ${err.message}`)
+      }
+    }
+  }
+
+  // Repair step: fix DBs where migrations were incorrectly marked as done
+  // but columns were never actually added (caused by the old catch-all error handling)
+  repairMissingColumns(db)
+}
+
+/**
+ * Check if a table has a specific column.
+ * @param {import('better-sqlite3').Database} db
+ * @param {string} table
+ * @param {string} column
+ * @returns {boolean}
+ */
+function hasColumn(db, table, column) {
+  const cols = db.prepare(`PRAGMA table_info(${table})`).all()
+  return cols.some(c => c.name === column)
+}
+
+/**
+ * Repair missing columns that should have been added by migrations.
+ * Handles DBs where migrations were marked as done but ALTER TABLE actually failed.
+ */
+function repairMissingColumns(db) {
+  const repairs = [
+    { table: 'memories', column: 'project_id', sql: 'ALTER TABLE memories ADD COLUMN project_id TEXT DEFAULT NULL' },
+    { table: 'chat_sessions', column: 'workspace_id', sql: 'ALTER TABLE chat_sessions ADD COLUMN workspace_id TEXT DEFAULT NULL' },
+    { table: 'todos', column: 'session_id', sql: 'ALTER TABLE todos ADD COLUMN session_id TEXT' },
+    { table: 'todos', column: 'injection_count', sql: 'ALTER TABLE todos ADD COLUMN injection_count INTEGER NOT NULL DEFAULT 0' },
+  ]
+
+  for (const { table, column, sql } of repairs) {
+    if (!hasColumn(db, table, column)) {
+      try {
+        console.warn(`[DB] Repair: adding missing column ${table}.${column}`)
+        db.exec(sql)
+        console.log(`[DB] Repair: ${table}.${column} added successfully`)
+      } catch (err) {
+        console.error(`[DB] Repair FAILED for ${table}.${column}: ${err.message}`)
+      }
     }
   }
+
+  // Ensure indexes exist after repair
+  try {
+    db.exec(`
+      CREATE INDEX IF NOT EXISTS idx_memories_project_id ON memories(project_id);
+      CREATE INDEX IF NOT EXISTS idx_chat_sessions_workspace ON chat_sessions(workspace_id, updated_at DESC);
+      CREATE INDEX IF NOT EXISTS idx_todos_session ON todos(session_id);
+    `)
+  } catch (err) {
+    console.warn(`[DB] Repair index creation skipped: ${err.message}`)
+  }
 }
 
 /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@geekbeer/minion",
-  "version": "3.23.0",
+  "version": "3.23.1",
   "description": "AI Agent runtime for Minion - manages status and skill deployment on VPS",
   "main": "linux/server.js",
   "bin": {