@gcorevideo/player 2.8.0 → 2.8.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gcorevideo/player",
-  "version": "2.8.0",
+  "version": "2.8.2",
   "description": "Gcore JavaScript video player",
   "main": "dist/index.js",
   "type": "module",
@@ -37,9 +37,6 @@
     "assert": "^2.1.0",
     "rollup": "^4.27.4",
     "rollup-plugin-polyfill-node": "^0.13.0",
-    "rollup-plugin-sass": "^1.14.0",
-    "rollup-plugin-string": "^3.0.0",
-    "sass": "^1.83.0",
     "typescript": "^5.7.2"
   },
   "dependencies": {

package/rollup.config.js

@@ -2,27 +2,15 @@
 import commonjs from '@rollup/plugin-commonjs';
 import json from '@rollup/plugin-json';
 import resolve from '@rollup/plugin-node-resolve';
-import sass from 'rollup-plugin-sass';
-import { string } from 'rollup-plugin-string';
 import polyfillNode from 'rollup-plugin-polyfill-node';
 
 export default [
   {
     input: 'lib/index.js',
     plugins: [
-      sass({
-        output: 'dist/index.css',
-        verbose: true,
-      }),
       resolve(),
       commonjs(),
       json(),
-      string({
-        include: [
-          '**/*.ejs',
-          '**/*.svg',
-        ],
-      }),
       polyfillNode(),
     ],
     output: [

package/src/plugins/dash-playback/DashPlayback.ts

@@ -13,7 +13,7 @@ import DASHJS, {
 } from 'dashjs'
 import { trace } from '../../trace/index.js'
 
-import { BitrateInfo, QualityLevel, TimePosition, TimeValue } from '../../playback.types.js'
+import { QualityLevel, TimePosition, TimeValue } from '../../playback.types.js'
 
 const AUTO = -1
 
@@ -34,6 +34,7 @@ type LocalTimeCorrelation = {
 
 const T = 'DashPlayback'
 
+// @ts-expect-error
 export default class DashPlayback extends HTML5Video {
   _levels: QualityLevel[] | null = null
 
@@ -299,7 +300,7 @@ export default class DashPlayback extends HTML5Video {
   }
 
   // override
-  _setupSrc() {
+  private override _setupSrc() {
     // this playback manages the src on the video element itself
   }
 
@@ -386,27 +387,31 @@ export default class DashPlayback extends HTML5Video {
     this.trigger(Events.PLAYBACK_STATS_ADD, { dvr: status })
   }
 
-  _updateSettings() {
+  override _updateSettings() {
     if (this._playbackType === Playback.VOD) {
+      // @ts-expect-error
       this.settings.left = ['playpause', 'position', 'duration']
     } else if (this.dvrEnabled) {
+      // @ts-expect-error
       this.settings.left = ['playpause']
     } else {
+      // @ts-expect-error
       this.settings.left = ['playstop']
     }
-
+    // @ts-expect-error
     this.settings.seekEnabled = this.isSeekEnabled()
     this.trigger(Events.PLAYBACK_SETTINGSUPDATE)
   }
 
-  _onPlaybackError = (event: DashPlaybackErrorEvent) => {
+  private _onPlaybackError = (event: DashPlaybackErrorEvent) => {
     // TODO
+    trace(`${T} _onPlaybackError`, { event })
   }
 
-  _onDASHJSSError = (event: DashErrorEvent) => {
+  private _onDASHJSSError = (event: DashErrorEvent) => {
+    trace(`${T} _onDASHJSSError`, { event })
     // TODO
     // only report/handle errors if they are fatal
-    // hlsjs should automatically handle non fatal errors
     this._stopTimeUpdateTimer()
     if (event.error === 'capability' && event.event === 'mediasource') {
       // No support for MSE
@@ -542,10 +547,10 @@ export default class DashPlayback extends HTML5Video {
   }
 
   get dvrEnabled() {
-    assert.ok(
-      this._dash,
-      'An instance of dashjs MediaPlayer is required to get the DVR status',
-    )
+    if (!this._dash) {
+      trace(`${T} dvrEnable no dash player instance`)
+      return false
+    }
     return (
       this._dash?.getDVRWindowSize() >= this._minDvrSize &&
       this.getPlaybackType() === Playback.LIVE

package/src/plugins/hls-playback/HlsPlayback.ts

@@ -61,6 +61,7 @@ type CustomListener = {
 // TODO level, code, description, etc
 type ErrorInfo = Record<string, unknown>;
 
+// @ts-expect-error
 export default class HlsPlayback extends HTML5Video {
   private _ccIsSetup = false;
 
@@ -436,7 +437,7 @@ export default class HlsPlayback extends HTML5Video {
 
   // override
   // this playback manages the src on the video element itself
-  _setupSrc(srcUrl: string) { } // eslint-disable-line no-unused-vars
+  private override _setupSrc(srcUrl: string) { } // eslint-disable-line no-unused-vars
 
   _startTimeUpdateTimer() {
     if (this._timeUpdateTimer) {
@@ -511,13 +512,17 @@ export default class HlsPlayback extends HTML5Video {
 
   _updateSettings() {
     if (this._playbackType === Playback.VOD) {
+      // @ts-expect-error
       this.settings.left = ['playpause', 'position', 'duration'];
     } else if (this.dvrEnabled) {
+      // @ts-expect-error
       this.settings.left = ['playpause'];
     } else {
+      // @ts-expect-error
       this.settings.left = ['playstop'];
     }
 
+      // @ts-expect-error
     this.settings.seekEnabled = this.isSeekEnabled();
     this.trigger(Events.PLAYBACK_SETTINGSUPDATE);
   }

package/src/utils/mediaSources.ts

@@ -65,13 +65,13 @@ export function buildSourcesPriorityList(
   }
 
   function addHls() {
-    if (sources.hls && HlsPlayback.canPlay(sources.hls)) {
+    if (sources.hls && HlsPlayback.canPlay(sources.hls, undefined)) {
       msl.push(sources.hls)
       sources.hls = null
     }
     if (
       sources.master?.endsWith('.m3u8') &&
-      HlsPlayback.canPlay(sources.master)
+      HlsPlayback.canPlay(sources.master, undefined)
     ) {
       msl.push(sources.master)
       sources.master = null
@@ -79,7 +79,7 @@ export function buildSourcesPriorityList(
   }
 
   function addDash() {
-    if (sources.dash && DashPlayback.canPlay(sources.dash)) {
+    if (sources.dash && DashPlayback.canPlay(sources.dash, undefined)) {
       msl.push(sources.dash)
       sources.dash = null
     }