@gcorevideo/player 2.28.10 → 2.28.12

package/dist/index.embed.js

@@ -49329,21 +49329,22 @@ class HTML5Video extends BasePlayback {
         super._onEnded();
     }
     _handleBufferingEvents() {
-        // TODO use the logic from the base class to detect if it's stalled or resumed, because in the latter case the current behavior is not correct
-        if (!this.stallTimerId) {
-            this.stallTimerId = setTimeout(() => {
-                this.stallTimerId = null;
-                const error = this.createError({
-                    code: PlaybackErrorCode.MediaSourceUnavailable,
-                    level: PlayerError.Levels.FATAL,
-                    message: 'Stall timeout',
-                    description: 'Playback stalled for too long',
-                });
-                this.trigger(Events$1.PLAYBACK_ERROR, error);
-                setTimeout(() => this.stop(), 0);
-            }, STALL_TIMEOUT);
-        }
         super._handleBufferingEvents();
+        // TODO test case: playback stalled and then resumed. The should be no MediaSourceUnavailable/"Stall timeout" error
+        if (!this._isBuffering || this.stallTimerId) {
+            return;
+        }
+        this.stallTimerId = setTimeout(() => {
+            this.stallTimerId = null;
+            const error = this.createError({
+                code: PlaybackErrorCode.MediaSourceUnavailable,
+                level: PlayerError.Levels.FATAL,
+                message: 'Stall timeout',
+                description: 'Playback stalled for too long',
+            });
+            this.trigger(Events$1.PLAYBACK_ERROR, error);
+            setTimeout(() => this.stop(), 0);
+        }, STALL_TIMEOUT);
     }
     _onPlaying() {
         if (this.stallTimerId) {

package/dist/index.js

@@ -49490,21 +49490,22 @@ class HTML5Video extends BasePlayback {
         super._onEnded();
     }
     _handleBufferingEvents() {
-        // TODO use the logic from the base class to detect if it's stalled or resumed, because in the latter case the current behavior is not correct
-        if (!this.stallTimerId) {
-            this.stallTimerId = setTimeout(() => {
-                this.stallTimerId = null;
-                const error = this.createError({
-                    code: PlaybackErrorCode.MediaSourceUnavailable,
-                    level: PlayerError.Levels.FATAL,
-                    message: 'Stall timeout',
-                    description: 'Playback stalled for too long',
-                });
-                this.trigger(Events$1.PLAYBACK_ERROR, error);
-                setTimeout(() => this.stop(), 0);
-            }, STALL_TIMEOUT);
-        }
         super._handleBufferingEvents();
+        // TODO test case: playback stalled and then resumed. The should be no MediaSourceUnavailable/"Stall timeout" error
+        if (!this._isBuffering || this.stallTimerId) {
+            return;
+        }
+        this.stallTimerId = setTimeout(() => {
+            this.stallTimerId = null;
+            const error = this.createError({
+                code: PlaybackErrorCode.MediaSourceUnavailable,
+                level: PlayerError.Levels.FATAL,
+                message: 'Stall timeout',
+                description: 'Playback stalled for too long',
+            });
+            this.trigger(Events$1.PLAYBACK_ERROR, error);
+            setTimeout(() => this.stop(), 0);
+        }, STALL_TIMEOUT);
     }
     _onPlaying() {
         if (this.stallTimerId) {
@@ -50043,7 +50044,7 @@ class Player {
     }
 }
 
-var version$1 = "2.28.10";
+var version$1 = "2.28.12";
 
 var packages = {
 	"node_modules/@clappr/core": {

package/lib/playback/HTML5Video.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"HTML5Video.d.ts","sourceRoot":"","sources":["../../src/playback/HTML5Video.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,YAAY,EAAE,MAAM,cAAc,CAAA;AAG3C,OAAO,EAAE,YAAY,EAAE,MAAM,mBAAmB,CAAA;AAGhD,OAAO,EAAE,UAAU,EAAE,MAAM,8CAA8C,CAAA;AAMzE,MAAM,CAAC,OAAO,OAAO,UAAW,SAAQ,YAAY;IAClD,OAAO,CAAC,YAAY,CAAuB;IAE3C;;OAEG;IACM,WAAW,CAAC,SAAS,EAAE,GAAG,EAAE,OAAO,CAAC,EAAE,YAAY;IAkBlD,UAAU;IAIV,QAAQ;IAQR,sBAAsB;IAkBtB,UAAU;IAQV,QAAQ;IAQjB,IAAI,WAAW,IAAI,UAAU,EAAE,CAgB9B;IAGD,IAAI,iBAAiB,sBAiBpB;IAED,gBAAgB,CAAC,EAAE,EAAE,MAAM;CAa5B"}
+{"version":3,"file":"HTML5Video.d.ts","sourceRoot":"","sources":["../../src/playback/HTML5Video.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,YAAY,EAAE,MAAM,cAAc,CAAA;AAG3C,OAAO,EAAE,YAAY,EAAE,MAAM,mBAAmB,CAAA;AAGhD,OAAO,EAAE,UAAU,EAAE,MAAM,8CAA8C,CAAA;AAMzE,MAAM,CAAC,OAAO,OAAO,UAAW,SAAQ,YAAY;IAClD,OAAO,CAAC,YAAY,CAAuB;IAE3C;;OAEG;IACM,WAAW,CAAC,SAAS,EAAE,GAAG,EAAE,OAAO,CAAC,EAAE,YAAY;IAkBlD,UAAU;IAIV,QAAQ;IAQR,sBAAsB;IAmBtB,UAAU;IAQV,QAAQ;IAQjB,IAAI,WAAW,IAAI,UAAU,EAAE,CAgB9B;IAGD,IAAI,iBAAiB,sBAiBpB;IAED,gBAAgB,CAAC,EAAE,EAAE,MAAM;CAa5B"}

package/lib/playback/HTML5Video.js

@@ -33,21 +33,22 @@ export default class HTML5Video extends BasePlayback {
         super._onEnded();
     }
     _handleBufferingEvents() {
-        // TODO use the logic from the base class to detect if it's stalled or resumed, because in the latter case the current behavior is not correct
-        if (!this.stallTimerId) {
-            this.stallTimerId = setTimeout(() => {
-                this.stallTimerId = null;
-                const error = this.createError({
-                    code: PlaybackErrorCode.MediaSourceUnavailable,
-                    level: PlayerError.Levels.FATAL,
-                    message: 'Stall timeout',
-                    description: 'Playback stalled for too long',
-                });
-                this.trigger(ClapprEvents.PLAYBACK_ERROR, error);
-                setTimeout(() => this.stop(), 0);
-            }, STALL_TIMEOUT);
-        }
         super._handleBufferingEvents();
+        // TODO test case: playback stalled and then resumed. The should be no MediaSourceUnavailable/"Stall timeout" error
+        if (!this._isBuffering || this.stallTimerId) {
+            return;
+        }
+        this.stallTimerId = setTimeout(() => {
+            this.stallTimerId = null;
+            const error = this.createError({
+                code: PlaybackErrorCode.MediaSourceUnavailable,
+                level: PlayerError.Levels.FATAL,
+                message: 'Stall timeout',
+                description: 'Playback stalled for too long',
+            });
+            this.trigger(ClapprEvents.PLAYBACK_ERROR, error);
+            setTimeout(() => this.stop(), 0);
+        }, STALL_TIMEOUT);
     }
     _onPlaying() {
         if (this.stallTimerId) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gcorevideo/player",
-  "version": "2.28.10",
+  "version": "2.28.12",
   "description": "Gcore JavaScript video player",
   "main": "dist/index.js",
   "type": "module",

package/src/playback/HTML5Video.ts

@@ -48,21 +48,22 @@ export default class HTML5Video extends BasePlayback {
   }
 
   override _handleBufferingEvents() {
-    // TODO use the logic from the base class to detect if it's stalled or resumed, because in the latter case the current behavior is not correct
-    if (!this.stallTimerId) {
-      this.stallTimerId = setTimeout(() => {
-        this.stallTimerId = null
-        const error = this.createError({
-          code: PlaybackErrorCode.MediaSourceUnavailable,
-          level: PlayerError.Levels.FATAL,
-          message: 'Stall timeout',
-          description: 'Playback stalled for too long',
-        })
-        this.trigger(ClapprEvents.PLAYBACK_ERROR, error)
-        setTimeout(() => this.stop(), 0)
-      }, STALL_TIMEOUT)
-    }
     super._handleBufferingEvents()
+    // TODO test case: playback stalled and then resumed. The should be no MediaSourceUnavailable/"Stall timeout" error
+    if (!this._isBuffering || this.stallTimerId) {
+      return
+    }
+    this.stallTimerId = setTimeout(() => {
+      this.stallTimerId = null
+      const error = this.createError({
+        code: PlaybackErrorCode.MediaSourceUnavailable,
+        level: PlayerError.Levels.FATAL,
+        message: 'Stall timeout',
+        description: 'Playback stalled for too long',
+      })
+      this.trigger(ClapprEvents.PLAYBACK_ERROR, error)
+      setTimeout(() => this.stop(), 0)
+    }, STALL_TIMEOUT)
   }
 
   override _onPlaying() {