@gcorevideo/player 2.22.12 → 2.22.13

package/dist/plugins/index.js

@@ -13320,7 +13320,7 @@ class ClipsPlugin extends UICorePlugin {
 
 const templateHtml$1 = "<ul class=\"context-menu-list\">\n    <% if(options) { %>\n        <% for (var i = 0; i < options.length; i++) { %>\n        <li class=\"context-menu-list-item <%= options[i].class %>\"\n            data-<%= options[i].name %>><%= options[i].label %></li>\n        <% } %>\n    <% } %>\n</ul>\n";
 
-var version$1 = "2.22.12";
+var version$1 = "2.22.13";
 
 var packages = {
 	"node_modules/@clappr/core": {
@@ -16018,7 +16018,7 @@ class PlaybackRate extends UICorePlugin {
     // private prevSelectedRate: string | undefined
     selectedRate = DEFAULT_PLAYBACK_RATE;
     metadataLoaded = false;
-    playbackSettingsUpdateReceived = false;
+    // private playbackSettingsUpdateReceived = false
     mountTimerId = null;
     /**
      * @internal
@@ -16077,10 +16077,14 @@ class PlaybackRate extends UICorePlugin {
     }
     onActiveContainerChange() {
         this.metadataLoaded = false;
-        this.playbackSettingsUpdateReceived = false;
+        // this.playbackSettingsUpdateReceived = false
         this.listenTo(this.core.activePlayback, Events.PLAYBACK_STOP, this.onStop);
         this.listenTo(this.core.activePlayback, Events.PLAYBACK_PLAY, this.onPlay);
-        this.listenTo(this.core.activePlayback, Events.PLAYBACK_SETTINGSUPDATE, this.onSettingsUpdate);
+        // this.listenTo(
+        //   this.core.activePlayback,
+        //   Events.PLAYBACK_SETTINGSUPDATE,
+        //   this.onSettingsUpdate,
+        // )
         this.listenTo(this.core.activePlayback, PlaybackEvents.PLAYBACK_RATE_CHANGED, this.onPlaybackRateChange);
         this.listenTo(this.core.activeContainer, Events.CONTAINER_LOADEDMETADATA, this.onMetaDataLoaded);
     }
@@ -16107,35 +16111,30 @@ class PlaybackRate extends UICorePlugin {
             i18n: this.core.i18n,
         })));
     }
-    onSettingsUpdate() {
-        trace(`${T$7} onSettingsUpdate`, {
-            playbackType: this.core.activePlayback.getPlaybackType(),
-            dvrEnabled: this.core.activePlayback.dvrEnabled,
-        });
-        this.playbackSettingsUpdateReceived = true;
-        if (this.metadataLoaded) {
-            if (this.mountTimerId) {
-                clearTimeout(this.mountTimerId);
-                this.mountTimerId = null;
-            }
-            this.mount();
-        }
-    }
+    // private onSettingsUpdate() {
+    //   trace(`${T} onSettingsUpdate`, {
+    //     playbackType: this.core.activePlayback.getPlaybackType(),
+    //     dvrEnabled: this.core.activePlayback.dvrEnabled,
+    //   })
+    //   this.playbackSettingsUpdateReceived = true
+    //   if (this.metadataLoaded) {
+    //     if (this.mountTimerId) {
+    //       clearTimeout(this.mountTimerId)
+    //       this.mountTimerId = null
+    //     }
+    //     this.mount()
+    //   }
+    // }
     onMetaDataLoaded() {
         trace(`${T$7} onMetaDataLoaded`, {
             playbackType: this.core.activePlayback.getPlaybackType(),
             dvrEnabled: this.core.activePlayback.dvrEnabled,
         });
         this.metadataLoaded = true;
-        if (this.playbackSettingsUpdateReceived) {
+        this.mountTimerId = setTimeout(() => {
+            this.mountTimerId = null;
             this.mount();
-        }
-        else {
-            this.mountTimerId = setTimeout(() => {
-                this.mountTimerId = null;
-                this.mount();
-            }, 25);
-        }
+        }, 25);
     }
     allRateElements() {
         return this.$el.find('#playback-rate-menu li');
@@ -16182,7 +16181,6 @@ class PlaybackRate extends UICorePlugin {
             i18n: this.core.i18n,
             playbackRates: this.playbackRates,
         }));
-        // this.mount()
         return this;
     }
     /**

package/lib/plugins/playback-rate/PlaybackRate.d.ts

@@ -47,7 +47,6 @@ export type PlaybackRateSettings = {
 export declare class PlaybackRate extends UICorePlugin {
     private selectedRate;
     private metadataLoaded;
-    private playbackSettingsUpdateReceived;
     private mountTimerId;
     /**
      * @internal
@@ -85,7 +84,6 @@ export declare class PlaybackRate extends UICorePlugin {
     private onMediaControlRendered;
     private onGearRendered;
     private mount;
-    private onSettingsUpdate;
     private onMetaDataLoaded;
     private allRateElements;
     private rateElement;

package/lib/plugins/playback-rate/PlaybackRate.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"PlaybackRate.d.ts","sourceRoot":"","sources":["../../../src/plugins/playback-rate/PlaybackRate.ts"],"names":[],"mappings":"AAAA,OAAO,EAAU,YAAY,EAAsB,IAAI,EAAK,MAAM,cAAc,CAAA;AAkBhF;;GAEG;AACH,MAAM,MAAM,kBAAkB,GAAG;IAC/B,KAAK,EAAE,MAAM,CAAA;IACb,KAAK,EAAE,MAAM,CAAA;CACd,CAAA;AAED;;GAEG;AACH,MAAM,MAAM,oBAAoB,GAAG;IACjC,OAAO,CAAC,EAAE,kBAAkB,EAAE,CAAA;IAC9B,YAAY,CAAC,EAAE,MAAM,CAAA;CACtB,CAAA;AAgBD;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GA8BG;AACH,qBAAa,YAAa,SAAQ,YAAY;IAI5C,OAAO,CAAC,YAAY,CAAwB;IAE5C,OAAO,CAAC,cAAc,CAAQ;IAE9B,OAAO,CAAC,8BAA8B,CAAQ;IAE9C,OAAO,CAAC,YAAY,CAAuB;IAE3C;;OAEG;IACH,IAAI,IAAI,WAEP;IAED;;OAEG;IACH,IAAI,gBAAgB;;MAEnB;IAED,OAAO,CAAC,MAAM,CAAC,QAAQ,CAAC,cAAc,CAAuB;IAE7D,OAAO,CAAC,MAAM,CAAC,QAAQ,CAAC,YAAY,CAAqB;gBAE7C,IAAI,EAAE,IAAI;IAOtB,OAAO,KAAK,aAAa,GAExB;IAED;;OAEG;IACH,IAAa,UAAU;;MAItB;IAED;;OAEG;IACH,IAAa,MAAM;;;MAKlB;IAED;;OAEG;IACM,UAAU;IASnB,OAAO,CAAC,WAAW;IAenB,OAAO,CAAC,uBAAuB;IAuB/B,OAAO,CAAC,sBAAsB;IAK9B,OAAO,CAAC,cAAc;IAKtB,OAAO,CAAC,KAAK;IAsBb,OAAO,CAAC,gBAAgB;IAexB,OAAO,CAAC,gBAAgB;IAgBxB,OAAO,CAAC,eAAe;IAIvB,OAAO,CAAC,WAAW;IAMnB,OAAO,CAAC,oBAAoB;IAe5B,OAAO,CAAC,WAAW;IAoBnB;;OAEG;IACM,MAAM;IAoBf;;OAEG;IACM,OAAO;IAwBhB,OAAO,CAAC,MAAM;IAWd,OAAO,CAAC,QAAQ;IAOhB,OAAO,CAAC,iBAAiB;IAQzB,OAAO,CAAC,MAAM;IAEd,OAAO,CAAC,QAAQ;IAYhB,OAAO,CAAC,MAAM;IAMd,OAAO,CAAC,eAAe;IAUvB,OAAO,CAAC,QAAQ;IAQhB,OAAO,CAAC,oBAAoB;IAa5B,OAAO,CAAC,qBAAqB;CAM9B"}
+{"version":3,"file":"PlaybackRate.d.ts","sourceRoot":"","sources":["../../../src/plugins/playback-rate/PlaybackRate.ts"],"names":[],"mappings":"AAAA,OAAO,EAAU,YAAY,EAAsB,IAAI,EAAK,MAAM,cAAc,CAAA;AAkBhF;;GAEG;AACH,MAAM,MAAM,kBAAkB,GAAG;IAC/B,KAAK,EAAE,MAAM,CAAA;IACb,KAAK,EAAE,MAAM,CAAA;CACd,CAAA;AAED;;GAEG;AACH,MAAM,MAAM,oBAAoB,GAAG;IACjC,OAAO,CAAC,EAAE,kBAAkB,EAAE,CAAA;IAC9B,YAAY,CAAC,EAAE,MAAM,CAAA;CACtB,CAAA;AAgBD;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GA8BG;AACH,qBAAa,YAAa,SAAQ,YAAY;IAI5C,OAAO,CAAC,YAAY,CAAwB;IAE5C,OAAO,CAAC,cAAc,CAAQ;IAI9B,OAAO,CAAC,YAAY,CAAuB;IAE3C;;OAEG;IACH,IAAI,IAAI,WAEP;IAED;;OAEG;IACH,IAAI,gBAAgB;;MAEnB;IAED,OAAO,CAAC,MAAM,CAAC,QAAQ,CAAC,cAAc,CAAuB;IAE7D,OAAO,CAAC,MAAM,CAAC,QAAQ,CAAC,YAAY,CAAqB;gBAE7C,IAAI,EAAE,IAAI;IAOtB,OAAO,KAAK,aAAa,GAExB;IAED;;OAEG;IACH,IAAa,UAAU;;MAItB;IAED;;OAEG;IACH,IAAa,MAAM;;;MAKlB;IAED;;OAEG;IACM,UAAU;IASnB,OAAO,CAAC,WAAW;IAenB,OAAO,CAAC,uBAAuB;IAuB/B,OAAO,CAAC,sBAAsB;IAK9B,OAAO,CAAC,cAAc;IAKtB,OAAO,CAAC,KAAK;IAqCb,OAAO,CAAC,gBAAgB;IAYxB,OAAO,CAAC,eAAe;IAIvB,OAAO,CAAC,WAAW;IAMnB,OAAO,CAAC,oBAAoB;IAe5B,OAAO,CAAC,WAAW;IAoBnB;;OAEG;IACM,MAAM;IAkBf;;OAEG;IACM,OAAO;IAwBhB,OAAO,CAAC,MAAM;IAWd,OAAO,CAAC,QAAQ;IAOhB,OAAO,CAAC,iBAAiB;IAQzB,OAAO,CAAC,MAAM;IAEd,OAAO,CAAC,QAAQ;IAYhB,OAAO,CAAC,MAAM;IAMd,OAAO,CAAC,eAAe;IAUvB,OAAO,CAAC,QAAQ;IAQhB,OAAO,CAAC,oBAAoB;IAa5B,OAAO,CAAC,qBAAqB;CAM9B"}

package/lib/plugins/playback-rate/PlaybackRate.js

@@ -57,7 +57,7 @@ export class PlaybackRate extends UICorePlugin {
     // private prevSelectedRate: string | undefined
     selectedRate = DEFAULT_PLAYBACK_RATE;
     metadataLoaded = false;
-    playbackSettingsUpdateReceived = false;
+    // private playbackSettingsUpdateReceived = false
     mountTimerId = null;
     /**
      * @internal
@@ -118,10 +118,14 @@ export class PlaybackRate extends UICorePlugin {
     onActiveContainerChange() {
         trace(`${T} onActiveContainerChange`);
         this.metadataLoaded = false;
-        this.playbackSettingsUpdateReceived = false;
+        // this.playbackSettingsUpdateReceived = false
         this.listenTo(this.core.activePlayback, Events.PLAYBACK_STOP, this.onStop);
         this.listenTo(this.core.activePlayback, Events.PLAYBACK_PLAY, this.onPlay);
-        this.listenTo(this.core.activePlayback, Events.PLAYBACK_SETTINGSUPDATE, this.onSettingsUpdate);
+        // this.listenTo(
+        //   this.core.activePlayback,
+        //   Events.PLAYBACK_SETTINGSUPDATE,
+        //   this.onSettingsUpdate,
+        // )
         this.listenTo(this.core.activePlayback, PlaybackEvents.PLAYBACK_RATE_CHANGED, this.onPlaybackRateChange);
         this.listenTo(this.core.activeContainer, Events.CONTAINER_LOADEDMETADATA, this.onMetaDataLoaded);
     }
@@ -150,35 +154,30 @@ export class PlaybackRate extends UICorePlugin {
             i18n: this.core.i18n,
         })));
     }
-    onSettingsUpdate() {
-        trace(`${T} onSettingsUpdate`, {
-            playbackType: this.core.activePlayback.getPlaybackType(),
-            dvrEnabled: this.core.activePlayback.dvrEnabled,
-        });
-        this.playbackSettingsUpdateReceived = true;
-        if (this.metadataLoaded) {
-            if (this.mountTimerId) {
-                clearTimeout(this.mountTimerId);
-                this.mountTimerId = null;
-            }
-            this.mount();
-        }
-    }
+    // private onSettingsUpdate() {
+    //   trace(`${T} onSettingsUpdate`, {
+    //     playbackType: this.core.activePlayback.getPlaybackType(),
+    //     dvrEnabled: this.core.activePlayback.dvrEnabled,
+    //   })
+    //   this.playbackSettingsUpdateReceived = true
+    //   if (this.metadataLoaded) {
+    //     if (this.mountTimerId) {
+    //       clearTimeout(this.mountTimerId)
+    //       this.mountTimerId = null
+    //     }
+    //     this.mount()
+    //   }
+    // }
     onMetaDataLoaded() {
         trace(`${T} onMetaDataLoaded`, {
             playbackType: this.core.activePlayback.getPlaybackType(),
             dvrEnabled: this.core.activePlayback.dvrEnabled,
         });
         this.metadataLoaded = true;
-        if (this.playbackSettingsUpdateReceived) {
+        this.mountTimerId = setTimeout(() => {
+            this.mountTimerId = null;
             this.mount();
-        }
-        else {
-            this.mountTimerId = setTimeout(() => {
-                this.mountTimerId = null;
-                this.mount();
-            }, 25);
-        }
+        }, 25);
     }
     allRateElements() {
         return this.$el.find('#playback-rate-menu li');
@@ -226,7 +225,6 @@ export class PlaybackRate extends UICorePlugin {
             i18n: this.core.i18n,
             playbackRates: this.playbackRates,
         }));
-        // this.mount()
         return this;
     }
     /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gcorevideo/player",
-  "version": "2.22.12",
+  "version": "2.22.13",
   "description": "Gcore JavaScript video player",
   "main": "dist/index.js",
   "type": "module",

package/src/plugins/playback-rate/PlaybackRate.ts

@@ -85,7 +85,7 @@ export class PlaybackRate extends UICorePlugin {
 
   private metadataLoaded = false
 
-  private playbackSettingsUpdateReceived = false
+  // private playbackSettingsUpdateReceived = false
 
   private mountTimerId: TimerId | null = null
 
@@ -167,14 +167,14 @@ export class PlaybackRate extends UICorePlugin {
   private onActiveContainerChange() {
     trace(`${T} onActiveContainerChange`)
     this.metadataLoaded = false
-    this.playbackSettingsUpdateReceived = false
+    // this.playbackSettingsUpdateReceived = false
     this.listenTo(this.core.activePlayback, Events.PLAYBACK_STOP, this.onStop)
     this.listenTo(this.core.activePlayback, Events.PLAYBACK_PLAY, this.onPlay)
-    this.listenTo(
-      this.core.activePlayback,
-      Events.PLAYBACK_SETTINGSUPDATE,
-      this.onSettingsUpdate,
-    )
+    // this.listenTo(
+    //   this.core.activePlayback,
+    //   Events.PLAYBACK_SETTINGSUPDATE,
+    //   this.onSettingsUpdate,
+    // )
     this.listenTo(
       this.core.activePlayback,
       PlaybackEvents.PLAYBACK_RATE_CHANGED,
@@ -219,20 +219,20 @@ export class PlaybackRate extends UICorePlugin {
       )
   }
 
-  private onSettingsUpdate() {
-    trace(`${T} onSettingsUpdate`, {
-      playbackType: this.core.activePlayback.getPlaybackType(),
-      dvrEnabled: this.core.activePlayback.dvrEnabled,
-    })
-    this.playbackSettingsUpdateReceived = true
-    if (this.metadataLoaded) {
-      if (this.mountTimerId) {
-        clearTimeout(this.mountTimerId)
-        this.mountTimerId = null
-      }
-      this.mount()
-    }
-  }
+  // private onSettingsUpdate() {
+  //   trace(`${T} onSettingsUpdate`, {
+  //     playbackType: this.core.activePlayback.getPlaybackType(),
+  //     dvrEnabled: this.core.activePlayback.dvrEnabled,
+  //   })
+  //   this.playbackSettingsUpdateReceived = true
+  //   if (this.metadataLoaded) {
+  //     if (this.mountTimerId) {
+  //       clearTimeout(this.mountTimerId)
+  //       this.mountTimerId = null
+  //     }
+  //     this.mount()
+  //   }
+  // }
 
   private onMetaDataLoaded() {
     trace(`${T} onMetaDataLoaded`, {
@@ -240,14 +240,10 @@ export class PlaybackRate extends UICorePlugin {
       dvrEnabled: this.core.activePlayback.dvrEnabled,
     })
     this.metadataLoaded = true
-    if (this.playbackSettingsUpdateReceived) {
+    this.mountTimerId = setTimeout(() => {
+      this.mountTimerId = null
       this.mount()
-    } else {
-      this.mountTimerId = setTimeout(() => {
-        this.mountTimerId = null
-        this.mount()
-      }, 25)
-    }
+    }, 25)
   }
 
   private allRateElements(): ZeptoResult {
@@ -313,8 +309,6 @@ export class PlaybackRate extends UICorePlugin {
       }),
     )
 
-    // this.mount()
-
     return this
   }
 

package/src/plugins/playback-rate/__tests__/PlaybackRate.test.ts

@@ -77,15 +77,6 @@ describe('PlaybackRate', () => {
             // @ts-ignore
           ).toMatchPlaybackRateLabel('1x')
         })
-        it('should attach to the media when playback settings update is received', async () => {
-          core.activePlayback.emit(Events.PLAYBACK_SETTINGSUPDATE)
-          core.activeContainer.emit(Events.CONTAINER_SETTINGSUPDATE)
-          expect(bottomGear.addItem).toHaveBeenCalledWith('rate', playbackRate.$el)
-          expect(
-            bottomGear.$el.find('li[data-rate]').text(),
-            // @ts-ignore
-          ).toMatchPlaybackRateLabel('1x')
-        })
       })
       describe('when DVR is not available', () => {
         beforeEach(() => {
@@ -143,7 +134,7 @@ describe('PlaybackRate', () => {
     })
   })
   describe('options.defaultValue', () => {
-    beforeEach(() => {
+    beforeEach(async () => {
       core.options.playbackRate = {
         defaultValue: 1.5,
       }
@@ -157,8 +148,7 @@ describe('PlaybackRate', () => {
       core.activeContainer.isDvrEnabled.mockReturnValue(true)
       core.activePlayback.emit(Events.PLAYBACK_LOADEDMETADATA)
       core.activeContainer.emit(Events.CONTAINER_LOADEDMETADATA)
-      core.activePlayback.emit(Events.PLAYBACK_SETTINGSUPDATE)
-      core.activeContainer.emit(Events.CONTAINER_SETTINGSUPDATE)
+      await new Promise((resolve) => setTimeout(resolve, 25))
     })
     it('should set the selected rate to the defaultValue', () => {
       expect(core.activePlayback.setPlaybackRate).toHaveBeenCalledWith(1.5)