@gavin-hu/my-pi-agent 0.17.0 → 0.19.0

package/extensions/job/index.ts

@@ -5,7 +5,8 @@
  * processes with their output streamed to log files; the status chip shows
  * running and unreported-failure counts, and finished jobs are reported to the
  * model — and shown as a bytefly notice — at the next turn, or by triggering one
- * turn for a `wake` job.
+ * turn for a `wake` job as soon as the agent is idle, including right after a
+ * running turn settles.
  *
  * Load with:  pi --extension ./extensions/job
  */
@@ -13,7 +14,7 @@
 import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
 import { isExtensionEnabled } from "../../lib/env.ts";
 import { JOB_FINISHED_CHANNEL, type JobFinishedEvent } from "../../lib/events.ts";
-import { noticeMessage, type NoticeMessage } from "../../lib/notice.ts";
+import { burstText, noticeMessage, type NoticeMessage } from "../../lib/notice.ts";
 import { createPendingReporter, registerPendingChannel } from "../../lib/report.ts";
 import { registerCommands } from "./commands.ts";
 import { formatCompletion, jobOutcome, shortLabel } from "./format.ts";
@@ -25,8 +26,13 @@ import type { JobRecord } from "./types.ts";
 const JOB_CONTEXT_MARKER = "[BACKGROUND JOBS]";
 
 function buildContext(jobs: JobRecord[]): string {
-	const lines = jobs.map((job) => formatCompletion(job));
-	return `${JOB_CONTEXT_MARKER}\n${jobs.length} background job${jobs.length === 1 ? "" : "s"} finished:\n${lines.join("\n")}\nRun \`job logs <id>\` for output.`;
+	const count = jobs.length;
+	return burstText({
+		marker: JOB_CONTEXT_MARKER,
+		headline: `${count} background job${count === 1 ? "" : "s"} finished`,
+		lines: jobs.map((job) => formatCompletion(job)),
+		hint: "Run `job logs <id>` for output.",
+	});
 }
 
 /** The shared notice for pending completions: model text plus renderer details. */
@@ -66,15 +72,17 @@ export default function jobs(pi: ExtensionAPI, deps: JobsDeps = {}): void {
 	if (!isExtensionEnabled("job")) return;
 	const runtime = deps.runtime ?? createJobsRuntime();
 
-	// Opt-in wake: a `wake` job finished while the agent is idle. The reporter
-	// reports *all* pending completions, not just the waking one, so a job that
-	// finished earlier is not silently marked seen and dropped.
+	// Opt-in wake: a `wake` job finished. The reporter reports *all* pending
+	// completions, not just the waking one, so a job that finished earlier is not
+	// silently marked seen and dropped, and it retries a completion that arrived
+	// mid-turn once the run settles.
 	const reporter = createPendingReporter<JobRecord>({
 		wake: (notice) => pi.sendMessage(notice, { triggerTurn: true }),
 		pending: () => runtime.pendingCompletions(),
 		markReported: (records) => runtime.markReported(records.map((job) => job.id)),
 		buildNotice: jobNotice,
 		source: "job",
+		wakeRequested: () => runtime.pendingCompletions().some((job) => job.wake),
 	});
 
 	registerTools(pi, runtime);

package/extensions/memory/store.ts

@@ -74,17 +74,24 @@ export function readMemoryFile(path: string): string {
 	return readFileSync(path, "utf-8");
 }
 
-/** Coarse identity of a store file, for cheap change detection. */
+/**
+ * Identity of a store file, for cheap change detection.
+ *
+ * The stamp is nanoseconds, not milliseconds: an edit that keeps the file's size
+ * is otherwise invisible for a whole millisecond, which is long enough for an
+ * editor that writes in place. `size` stays a number so the doctor's byte counts
+ * read the same.
+ */
 export interface MemoryFileStamp {
-	mtimeMs: number;
+	mtimeNs: bigint;
 	size: number;
 }
 
 /** Freshness stamp for a store file; `undefined` when it is missing or unstattable. */
 export function memoryFileStamp(path: string): MemoryFileStamp | undefined {
 	try {
-		const info = statSync(path);
-		return { mtimeMs: info.mtimeMs, size: info.size };
+		const info = statSync(path, { bigint: true });
+		return { mtimeNs: info.mtimeNs, size: Number(info.size) };
 	} catch {
 		return undefined;
 	}
@@ -93,7 +100,7 @@ export function memoryFileStamp(path: string): MemoryFileStamp | undefined {
 /** Whether two stamps describe the same file state. */
 export function sameStamp(a: MemoryFileStamp | undefined, b: MemoryFileStamp | undefined): boolean {
 	if (a === undefined || b === undefined) return a === b;
-	return a.mtimeMs === b.mtimeMs && a.size === b.size;
+	return a.mtimeNs === b.mtimeNs && a.size === b.size;
 }
 
 /** Note text of every bullet line, sanitized to one terminal-safe line. */

package/extensions/plan/blocks.ts

@@ -14,7 +14,7 @@
  * step.
  */
 
-import { FENCE, HEADING } from "./steps.ts";
+import { FENCE, HEADING } from "./sections.ts";
 
 /** How a block is rendered and grouped. */
 export type PlanBlockKind = "heading" | "paragraph" | "list" | "code" | "quote" | "table" | "hr" | "blank";
@@ -176,7 +176,7 @@ export function planBlocks(plan: string): PlanBlock[] {
 }
 
 /** The block containing source line `line`, or the nearest block before it. */
-export function blockAt(blocks: PlanBlock[], line: number): PlanBlock | undefined {
+export function blockAt(blocks: readonly PlanBlock[], line: number): PlanBlock | undefined {
 	let candidate: PlanBlock | undefined;
 	for (const block of blocks) {
 		if (block.start <= line && line <= block.end) return block;
@@ -186,6 +186,27 @@ export function blockAt(blocks: PlanBlock[], line: number): PlanBlock | undefine
 	return candidate;
 }
 
+/**
+ * The nearest block with content at or before `line`, else the first one after
+ * it: what a comment in blank space belongs to.
+ *
+ * A blank line is a block, so {@link blockAt} may name one, but a comment cannot
+ * hang on nothing: the review page renders no line for a blank block, so an
+ * anchor there is one it can never attach a thread to.
+ */
+export function contentBlockAt(blocks: readonly PlanBlock[], line: number): PlanBlock | undefined {
+	let before: PlanBlock | undefined;
+	for (const block of blocks) {
+		const content = block.kind !== "blank";
+		if (block.start <= line) {
+			if (content) before = block;
+			continue;
+		}
+		if (content) return before ?? block;
+	}
+	return before;
+}
+
 /** The source inside a fenced code block, without its opening and closing fence lines. */
 export function codeBody(block: PlanBlock): string[] {
 	if (block.kind !== "code") return block.lines.slice();

package/extensions/plan/commands.ts

@@ -2,15 +2,18 @@
  * Slash command for the plan-mode extension.
  *
  * `/plan` toggles plan mode, or enters it and sends an optional task;
- * `Ctrl+Alt+P` toggles too. Two subcommands are reserved: `/plan review [path]`
+ * `Ctrl+Alt+P` toggles too. Four subcommands are reserved: `/plan review [path]`
  * opens a plan in the browser (and sends saved comments to the model as a
- * refinement), and `/plan list` shows the plans directory, newest first, with
- * Enter opening a review.
+ * refinement), `/plan share [stop]` prints or revokes the link a teammate opens,
+ * `/plan list` shows the plans directory, newest first with Enter opening a
+ * review, and `/plan cancel` leaves the mode without approving.
  */
 
 import type { ExtensionAPI, ExtensionContext } from "@earendil-works/pi-coding-agent";
 import { isRemoteTurn } from "../../lib/interaction.ts";
 import { READ_ONLY_SUMMARY } from "../../lib/plan-entry.ts";
+import { qrLines } from "../../lib/qr.ts";
+import { withRailsSuppressed } from "../../lib/rails.ts";
 import { feedbackSummary } from "./feedback.ts";
 import { PlanIndexComponent, formatPlanIndex } from "./plan-index.ts";
 import { runBrowserReview } from "./review.ts";
@@ -21,6 +24,7 @@ import { createPlanWebReview, type PlanWebReview } from "./web.ts";
 const ENABLED_NOTICE = `Plan mode enabled — ${READ_ONLY_SUMMARY}.`;
 const DISABLED_NOTICE = "Plan mode disabled — full access restored.";
 const REVIEW_PREFIX = "review";
+const SHARE_PREFIX = "share";
 const LIST_PREFIX = "list";
 const CANCEL_PREFIX = "cancel";
 
@@ -67,6 +71,44 @@ function isReviewSubcommand(prompt: string): boolean {
 	return target.endsWith(".md") || target.includes("/") || target.includes("\\");
 }
 
+/**
+ * Whether a command line is the reserved `share` subcommand. Exact `share` and
+ * `share stop` are; `share the tokens` stays a task.
+ */
+function isShareSubcommand(prompt: string): boolean {
+	const text = prompt.toLowerCase();
+	return text === SHARE_PREFIX || text === `${SHARE_PREFIX} stop`;
+}
+
+/**
+ * `/plan share`: print the link (and a QR) a teammate opens, or revoke it. The
+ * browser page has the same button; this is the path a phone-owned or remote
+ * session needs, where there is no page to click.
+ */
+async function shareReview(web: PlanWebReview, prompt: string, ctx: ExtensionContext): Promise<void> {
+	const stopping = prompt.toLowerCase().endsWith("stop");
+	const result = stopping ? await web.stopSharing() : await web.share();
+	if (!result) {
+		ctx.ui.notify("Plan share: no browser review is open; run /plan review first.", "warning");
+		return;
+	}
+	if (stopping) {
+		ctx.ui.notify("Plan share: reviewers can no longer open this review.", "info");
+		return;
+	}
+	const link = result.state.links.at(-1);
+	if (!result.state.sharing || !link) {
+		ctx.ui.notify(`Plan share: ${result.state.reason ?? "no link is available"}.`, "warning");
+		return;
+	}
+	const lines = ["Review link: " + link.url, ...(await qrLines(link.url))];
+	// One link is one person, so more than one is the team the page can list.
+	if (result.state.links.length > 1) {
+		lines.push(`${result.state.links.length} links shared — the page lists every link and who each one posts as.`);
+	}
+	ctx.ui.notify(lines.join("\n"), "info");
+}
+
 /**
  * Open `planPath` in the browser and, if the user saves comments, hand them to
  * the model. A cancel is silent beyond a notice; nothing is sent.
@@ -137,6 +179,10 @@ async function openPlanIndex(
 	ctx: ExtensionContext,
 ): Promise<void> {
 	const dir = await runtime.plans.dirFor(ctx.cwd);
+	// A store an older version kept in the checkout was just moved in; the list is
+	// where a user notices their plans are somewhere else.
+	const moved = runtime.plans.takeNotice();
+	if (moved) ctx.ui.notify(moved, "info");
 	const summarise = async (): Promise<Awaited<ReturnType<typeof runtime.plans.index>>> => runtime.plans.index(ctx.cwd);
 	const summaries = await summarise();
 
@@ -147,22 +193,26 @@ async function openPlanIndex(
 
 	// The review runs after the screen closes, so the input focus is free again.
 	let selected: (PlanSummary | undefined) | undefined;
-	await ctx.ui.custom<void>((tui, theme, _keybindings, done) => {
-		const component = new PlanIndexComponent({
-			summaries,
-			dir,
-			theme,
-			onSelect: (summary) => {
-				selected = summary;
-				done();
-			},
-			onClose: () => done(),
-			reload: summarise,
-			requestRender: () => tui.requestRender(),
-			viewportRows: () => tui.terminal?.rows,
-		});
-		return component;
-	});
+	// A dock list shares the editor slot with the goal and todo rails, so it takes
+	// the dock to itself for as long as it is open, like the other list screens.
+	await withRailsSuppressed(pi, () =>
+		ctx.ui.custom<void>((tui, theme, _keybindings, done) => {
+			const component = new PlanIndexComponent({
+				summaries,
+				dir,
+				theme,
+				onSelect: (summary) => {
+					selected = summary;
+					done();
+				},
+				onClose: () => done(),
+				reload: summarise,
+				requestRender: () => tui.requestRender(),
+				viewportRows: () => tui.terminal?.rows,
+			});
+			return component;
+		}),
+	);
 	if (selected) await reviewInBrowser(pi, runtime, web, selected.path, ctx);
 }
 
@@ -173,11 +223,13 @@ export function registerCommands(
 ): void {
 	pi.registerCommand("plan", {
 		description:
-			"Toggle plan mode (read-only exploration), enter it with an optional task, list saved plans, review one in the browser, or cancel planning without approving",
+			"Toggle plan mode (read-only exploration), enter it with an optional task, list saved plans, review one in the browser, share that review with a link, or cancel planning without approving",
 		getArgumentCompletions: (prefix) => {
 			const text = prefix.trimStart();
 			if (text.includes(" ")) return null;
-			const subcommands = [LIST_PREFIX, REVIEW_PREFIX, CANCEL_PREFIX].filter((name) => name.startsWith(text));
+			const subcommands = [LIST_PREFIX, REVIEW_PREFIX, SHARE_PREFIX, CANCEL_PREFIX].filter((name) =>
+				name.startsWith(text),
+			);
 			return subcommands.length > 0 ? subcommands.map((value) => ({ value, label: value })) : null;
 		},
 		handler: async (args, ctx) => {
@@ -198,6 +250,10 @@ export function registerCommands(
 				await openPlanIndex(pi, runtime, web, ctx);
 				return;
 			}
+			if (isShareSubcommand(prompt)) {
+				await shareReview(web, prompt, ctx);
+				return;
+			}
 			if (isReviewSubcommand(prompt)) {
 				await reviewInBrowser(pi, runtime, web, reviewTarget(prompt), ctx);
 				return;