@galda/cli 0.10.71 → 0.10.72

package/app/index.html

@@ -2120,6 +2120,12 @@
   /* the note is body prose like every other section's — same 14px / −.012em / --ink as
      .rbody (Masa 2026-07-22: it was a shade lighter and read as a different kind of text) */
   .redesign .ropen .v{margin:4px 0 0 !important}
+  /* A malformed .manager-run.json advisory (goal #733, Masa 2026-07-26): plain
+     danger-red text, no box — this must not read as calm/resolved like a normal
+     note (Masa: "めっちゃdoneっぽい"). Same --danger token .prfail already uses
+     for a blocked PR, so it speaks the SAME "needs your attention" language the
+     app already has, rather than inventing a new one. */
+  .redesign .ropen.rdeclerr .v{color:var(--danger) !important}
   /* sections — Linear-docs bold sentence-case headings + high-contrast body.
      margins are !important: the app's pre-existing .lg / .sa-item rules load first and
      otherwise tie/beat these on specificity, flattening the Linear-docs rhythm. */
@@ -6308,7 +6314,16 @@ const FS_ICONS = {
 // per-project count icons (HANDOFF-v45 §10): To Do = rounded square, Review = Scan
 // (magnifier) — both stroked, NEUTRAL ink (never green); shape is the only distinction.
 const FS_ICO_TD = '<svg class="pcg" viewBox="0 0 24 24"><rect x="5" y="5" width="14" height="14" rx="3.5"/></svg>';
-const FS_ICO_SCAN = '<svg class="pcg" viewBox="0 0 24 24"><circle cx="10.5" cy="10.5" r="5.5"/><path d="M19 19l-4.5-4.5"/></svg>';
+// Eye, not magnifying glass or checkmark (Masa 2026-07-26): the magnifying-glass
+// read as "search". The first replacement — a square with a checkmark inside,
+// matching FS_ICO_TD's (To Do) frame — read as "done" instead ("あれ、これだと
+// めっちゃdoneっぽいわ"): a checkmark is universally a completion signal, and
+// pairing it with To Do's exact square made it worse, not better. An eye carries
+// neither "search" nor "done" — it says "look at this", which is what Review
+// actually is. Standard minimal eye glyph (outline + pupil), legible at the real
+// 11px render size (verified: a smaller pupil or added detail merges into a
+// blob at that size — this is the simplest shape that still reads as an eye).
+const FS_ICO_SCAN = '<svg class="pcg" viewBox="0 0 24 24"><path d="M1 12s4-8 11-8 11 8 11 8-4 8-11 8-11-8-11-8z"/><circle cx="12" cy="12" r="3"/></svg>';
 // hover-only Reply / Edit / Delete on a To Do row (§1.5-10; flagship ACTS port)
 function fsActs(goalId){
   if (goalId == null || !state.goals.some((g) => g.id === goalId)) return '';
@@ -9177,6 +9192,15 @@ function saRowFromDigest(r, gs, ts){
       run: (() => {
         return latestGoalRunForOutcome(g?.id, ts, outcome);
       })(),
+      // The worker DID try to declare something but it came out unusable (goal #733,
+      // 2026-07-26: a Write followed by an Edit broke the JSON mid-edit; Review showed
+      // no "Open it" section and no explanation, indistinguishable from "nothing to
+      // run"). engine/server.mjs's readRunDeclaration sets task.runDeclError in that
+      // case; only shown when there's no successful `run` to display instead.
+      runDeclError: (() => {
+        const t = ts.find((x) => r.goalIds.includes(x.goalId) && x.runDeclError);
+        return t?.runDeclError ?? null;
+      })(),
       // Explicit review-summary display fields (spec §11: the card's shape follows the
       // task). A goal's reviewSummary may carry them directly (e.g. a conversational task
       // that reports an Answer + its Activity, or a ticket whose test count / diff totals
@@ -9603,11 +9627,20 @@ function saItemHtml(it, i){
   // failure reason land after the press. Nothing declared → no section (§1.5-3). ──
   // it.run?.compare/title alone (no cmd/url) has nothing a press can start — a
   // compare-only or title-only declaration must not draw the "Start it" button.
+  // it.runDeclError (2026-07-26, goal #733): the worker DID try to declare an
+  // artifact/command, but .manager-run.json came out unusable (e.g. a Write then
+  // an Edit broke the JSON mid-edit) — this must not look identical to "nothing
+  // to run" (§1.5-3 no empty box still applies: don't invent a fake Open it, but
+  // don't stay silent about a real attempt either). Same honest-advisory shape as
+  // prRepairBody below. A reply is the repair path: the worker rewrites the file.
+  const runDeclErrorBody = (!((it.run?.cmd || it.run?.url)) && it.runDeclError)
+    ? `<div class="ropen rdeclerr"><p class="rbody v">${failureLang() === 'ja' ? 'AIが開けるものを用意しようとしましたが、記録が読み取れませんでした。返信して直させてください。' : 'The AI tried to declare something to open here, but the record was unreadable. Reply to have it rewritten.'}</p></div>`
+    : '';
   const openBody = (it.run?.cmd || it.run?.url)
     ? `<div class="ropen" id="runlocal${i}"><button type="button" class="olink" data-saact="preview:${i}" id="prevlink${i}">${esc(it.run.url || 'Start it')}<span class="ar">↗</span></button><p class="rbody v">${esc(it.run.note || it.run.cmd || 'Starts when you press it.')}</p></div>`
     : it.pr
       ? `<div class="ropen"><a class="olink" href="${esc(it.pr)}" target="_blank" rel="noopener">${esc(it.pr)}<span class="ar">↗</span></a><p class="rbody v">Review and merge this pull request to finish the item.</p></div>`
-      : '';
+      : runDeclErrorBody;
   const prRepairBody = it.goal?.prError
     ? `<div class="prfail"><b>${esc(it.goal.prRepair?.title || 'PR blocked')}</b> <span class="dim">${esc(it.goal.prError)}</span>${it.goal.prRepair?.steps?.length ? `<ul>${it.goal.prRepair.steps.map((s) => `<li>${esc(s)}</li>`).join('')}</ul>` : ''}${it.goal.prRepair?.dirtyFiles?.length ? `<div class="dim">dirty: ${it.goal.prRepair.dirtyFiles.map(esc).join(' · ')}</div>` : ''}<div class="acts2"><button class="errbtn" data-saact="retrypr:${i}">${failureLang() === 'ja' ? 'PR再試行' : 'Retry PR'}</button><button class="errbtn" data-saact="glog:${i}">${failureLang() === 'ja' ? 'ログ確認' : 'View log'}</button></div></div>`
     : '';

package/engine/lib.mjs

@@ -3151,8 +3151,21 @@ export function workerPrompt(task, goal, lastFailure, agentName = 'claude-code',
     // (research, summaries, answers) simply skip this — the worker decides,
     // never us.
     `- 人が実際に動かして結果を見られる依頼なら、最後にプロジェクト直下へ ${RUN_DECL_FILE} を書く: {"cmd": "<起動コマンド>", "url": "<開くURL>", "note": "<何が見えるか1行>", "check": "<人に何を見て判断してほしいか1行>", "title": "<この作業のチケット名。対象が分かる程度に説明的で動作を含む短い名前。例「看板モードの追加」「ヘッダのズレの修正」。依頼文をそのまま写さない>"}。Manager はこれを使って人に「動かして見る」と「何を見ればいいか」を出す。動かして見せるものが無い依頼（調査・要約・質問への回答など）では書かなくてよい。`,
+    // Root-cause prevention (goal #733, 2026-07-26): the worker Wrote this file,
+    // then Edit'd it, and the edit broke the JSON mid-edit — Manager silently
+    // dropped the whole declaration (fixed separately: it now surfaces an honest
+    // note instead of vanishing). But the honest note is a recovery, not a fix —
+    // the real fix is stopping the corruption before it happens. Edit requires an
+    // exact byte-for-byte match against the file's current content; a small slip
+    // (a stray character, a stale in-memory copy) breaks the JSON with no error
+    // the worker would notice, because it happens in the tool call, not in
+    // anything it reads back. Write overwrites the whole file atomically — there
+    // is no "current content" to mismatch against — so telling the worker to
+    // always fully overwrite rather than partially edit removes the failure mode
+    // structurally, not just its symptom.
+    `- ${RUN_DECL_FILE} は毎回 Write で全文を書き直すこと。Edit で一部だけ直さない（既存内容と一致しないと壊れたJSONになり、Managerに握りつぶされて人に何も表示されない）。`,
     `- Markdown・設計文書・調査メモなど文章そのものが成果物なら、${RUN_DECL_FILE} に別のHTMLや過去のURLを書かない。最終回答に成果物の本文も貼り、保存先のMarkdownリンクを添えること。「ファイルに書きました」だけで終わらない。`,
-    `- 「ローカルで見れない」というフィードバックには、ターミナル操作や npx の再実行を案内して終わらないこと。${RUN_DECL_FILE} を実際に開ける内容へ更新し、可能なら自分でURLへ接続確認してから完了すること。`,
+    `- 「ローカルで見れない」というフィードバックには、ターミナル操作や npx の再実行を案内して終わらないこと。${RUN_DECL_FILE} を Write で全文書き直して実際に開ける内容へ更新し、可能なら自分でURLへ接続確認してから完了すること。`,
     // Links are rendered as links. The product cannot tell a real one from a
     // decorative one, so the only place this can be held is here.
     `- 自分が作っていない場所へのリンクを報告に書かない（存在しないURLや「詳しくはここ」のような飾りのリンクは、そのままリンクとして人に表示される）。`,

package/engine/server.mjs

@@ -2407,7 +2407,18 @@ function readRunDeclaration(task, workDir) {
   try { unlinkSync(file); } catch { /* best effort — never fail a task over cleanup */ }
   const run = parseRunDeclaration(raw);
   if (!run) {
-    sendAct(task, `run declaration ignored — ${RUN_DECL_FILE} was not usable JSON`);
+    // The worker DID try to declare something (the file exists) but it came out
+    // unusable — e.g. a Write followed by an Edit that broke the JSON mid-edit
+    // (goal #733, 2026-07-26: Masa saw a working artifact with no "Open it" and
+    // no explanation at all — the Review card just silently had no section,
+    // indistinguishable from "nothing to run"). Silence was already the honest
+    // answer for a request with nothing to run; it stops being honest the moment
+    // a declaration was attempted and swallowed. Keep a short snippet of what was
+    // actually written (raw content is deleted above and never otherwise
+    // recoverable) so both the activity log and the Review card can say WHY,
+    // instead of the human having to guess or dig through file loss.
+    task.runDeclError = { snippet: String(raw ?? '').slice(0, 200) };
+    sendAct(task, `run declaration ignored — ${RUN_DECL_FILE} was not usable JSON: ${task.runDeclError.snippet.slice(0, 80)}`);
     return;
   }
   task.run = { ...run, dir: workDir };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@galda/cli",
-  "version": "0.10.71",
+  "version": "0.10.72",
   "type": "module",
   "description": "Galda - hand off work to Claude Code or Codex, get proof back. Runs on your existing subscription, no extra API cost.",
   "scripts": {