@galda/cli 0.10.7 → 0.10.8

package/engine/lib.mjs

@@ -2400,3 +2400,55 @@ export async function verifyLicenseToken({ token, publicJwk = LICENSE_PUBLIC_JWK
 export function shouldEmitSetupCompleted({ isMcpClient, alreadySeen, flagExists }) {
   return Boolean(isMcpClient) && !alreadySeen && !flagExists;
 }
+
+// Onboarding funnel: a goal can only produce real changes if it runs inside a
+// real code repo. When the agent is started ad-hoc (e.g. `node bin/...` in the
+// user's HOME), the seeded default project points at a non-repo dir → the
+// worker no-ops (nothing to edit) yet the goal is marked "done" — the exact
+// blocker for "実装が始まる". This decides, BEFORE running, whether we must ask
+// the user which folder to work in. `isRepo` is passed in (the git probe is
+// I/O, done by the caller) so this stays pure/testable. Home is never a valid
+// work root — even a git-init'd home dir is "no project chosen yet".
+export function needsProjectFolder({ dir, homeDir, isRepo } = {}) {
+  if (!dir) return true;
+  const norm = (p) => String(p).replace(/\/+$/, '');
+  if (homeDir && norm(dir) === norm(homeDir)) return true;
+  return !isRepo;
+}
+
+// A short, ≤60-char display label for a repo dir, shown home-relative (~/…) so
+// the folder-choice options read cleanly on the board card.
+export function folderLabel(dir, homeDir = '') {
+  if (!dir) return '';
+  let d = String(dir);
+  const h = String(homeDir || '').replace(/\/+$/, '');
+  if (h && (d === h || d.startsWith(h + '/'))) d = '~' + d.slice(h.length);
+  return d.length <= 60 ? d : '…' + d.slice(-59);
+}
+
+// Build the "which folder should I work in?" clarifying question from detected
+// repos. Reuses the existing needsInput card ({text, options:string[]}), and
+// adds kind:'folder' + folders[] + lang so the /answer handler rebinds the
+// goal's project to the chosen repo (instead of appending to goal.text like a
+// task clarification). `folders` = [{label, dir}]. Options are capped/shaped to
+// what the board expects (≤8 entries, each ≤60 chars) with a trailing
+// "somewhere else" escape for a typed path.
+export function buildFolderQuestion(folders = [], { lang = 'ja' } = {}) {
+  const capped = folders.slice(0, 7).map((f) => ({ label: String(f.label || f.dir || ''), dir: f.dir }));
+  const other = lang === 'en' ? 'Somewhere else…' : '別の場所を指定…';
+  const text = lang === 'en' ? 'Which folder should I work in?' : 'どのフォルダで実装しますか？';
+  return { text, options: [...capped.map((f) => f.label), other], folders: capped, kind: 'folder', lang, other };
+}
+
+// Resolve a folder-choice answer (a picked option label, or a typed path) back
+// to an absolute dir. Returns { dir } or null (→ the "somewhere else" sentinel /
+// an unrecognized answer, which the caller re-asks on). Match by label first,
+// then exact dir, then treat an absolute-looking answer as a literal path.
+export function resolveFolderAnswer(answer, folders = []) {
+  const a = String(answer ?? '').trim();
+  if (!a) return null;
+  const hit = folders.find((f) => f.label === a || f.dir === a);
+  if (hit) return { dir: hit.dir };
+  if (a.startsWith('/') || a.startsWith('~')) return { dir: a };
+  return null;
+}

package/engine/server.mjs

@@ -13,13 +13,14 @@
 
 import { createServer } from 'node:http';
 import { spawn, execFile, spawnSync } from 'node:child_process';
-import { readFileSync, writeFileSync, appendFileSync, existsSync, mkdirSync, statSync } from 'node:fs';
+import { readFileSync, writeFileSync, appendFileSync, existsSync, mkdirSync, statSync, readdirSync } from 'node:fs';
 import { emitEvent } from './analytics-client.mjs';
 import { randomBytes, createHash } from 'node:crypto';
 import { resolve, dirname, join, basename } from 'node:path';
 import { homedir } from 'node:os';
 import { fileURLToPath } from 'node:url';
 import { pathToFileURL } from 'node:url';
+import { needsProjectFolder, folderLabel, buildFolderQuestion, resolveFolderAnswer } from './lib.mjs';
 import { parseStreamEvents, parsePlan, refinePlanTasks, findOverlappingGoal, canEditGoal, canDeleteGoal, shouldAskClarification, workerExitReason, isForcedStop, workerResultText, taskCountsAsComplete, resolveWantsPR, resolveGoalSource, buildGoalSummary, buildGoalProofMd, buildReviewRuleSection, nextGoalStatus, isPrMerged, isPrApproved, reviewToDoneStatus, advanceReviewGoal, revertReviewGoal, approveGoal, dismissGoal, permissionModeFor, isPlanReview, nextAfterPlanApprove, GOAL_MODES, parseSkillFrontmatter, collectSkills, retestGoal, cancelRetestGoal, computeRetestOutcome, revertGoal, planRevertActions, archiveGoal, unarchiveGoal, undismissGoal, parseNumstat, truncateDiffText, sumUsage, resolveEntryUrl, parseGitLog, diffNewCommits, replayQueueLog, reconcileOrphanGoals, reorderQueue, sortQueueByPriority, TASK_PRIORITIES, validateWorkflowColumns, DEFAULT_WORKFLOW_COLUMNS, validateReviewDefinition, DEFAULT_REVIEW_DEFINITION, buildEphemeralSeedLog, buildEphemeralSeedProjects, trimTaskActivityForState, buildAskContext, WORKER_TOOLS, verifyCfAccessJwt, resolveIdentity, goalVisibleTo, clampParallelLimit, canStartMore, nextRunnableTasks, goalsConflict, detectConflicts, isUiChange, shouldCaptureProof, shouldCaptureBaseline, hasTestRelevantChanges, buildExecutionPlan, buildContextHandoffSummary, buildFailurePostmortem, appendFailureMemory, latestFailurePolicy, classifyChangeRisk, checkRunBudget, usageBudgetTokens, isRateLimited, nextResumeDelay, checkFreeTierLimit, resolveEntitlement, resolveCachedEntitlement, FREE_TIER_LIMITS, verifyLicenseToken, shouldEmitSetupCompleted } from './lib.mjs';
 import { openPR } from './pr.mjs';
 import { runVerification, exerciseUi } from './verify.mjs';
@@ -428,6 +429,10 @@ async function authFromCfAccess(req) {
   }
 }
 
+// Where to look for the user's repos (folder-choice options) and which dir is
+// "not a real project" (never a valid work root). Defaults to the OS home;
+// overridable for tests / operators whose repos live elsewhere.
+const HOME = process.env.MANAGER_SCAN_HOME || homedir();
 const projectsFile = join(DATA_DIR, 'projects.json');
 if (!existsSync(projectsFile)) {
   const cwd = process.cwd();
@@ -784,6 +789,30 @@ function repoDefaultBranch(dir) {
   try { return gitSync(dir, ['symbolic-ref', '--short', 'refs/remotes/origin/HEAD']).replace(/^origin\//, ''); }
   catch { return 'main'; }
 }
+// Non-throwing "is this a real git work tree?" probe. The onboarding guard uses
+// it to refuse running a goal against a non-repo (which would no-op) and to
+// validate a folder the user picks.
+function isGitRepo(dir) {
+  try { return !!dir && existsSync(dir) && gitSync(dir, ['rev-parse', '--is-inside-work-tree']) === 'true'; }
+  catch { return false; }
+}
+// Shallow-scan the user's HOME for candidate repos to offer as folder choices
+// (depth-1: direct children of HOME with a `.git` — matches how devs keep repos
+// side by side, and stays fast/safe vs. a deep `find`). The typed-path escape
+// in the folder question covers anything deeper.
+function detectRepos(homeDir) {
+  const out = [];
+  try {
+    for (const name of readdirSync(homeDir)) {
+      if (name.startsWith('.')) continue;
+      const dir = join(homeDir, name);
+      try {
+        if (statSync(dir).isDirectory() && existsSync(join(dir, '.git'))) out.push({ dir, label: folderLabel(dir, homeDir) });
+      } catch { /* unreadable entry — skip */ }
+    }
+  } catch { /* unreadable home — return whatever we have */ }
+  return out.slice(0, 12);
+}
 // Each goal works in its OWN git worktree, branched fresh from origin/<default>,
 // under <repo>/.manager-wt/goal-<id>. So: (1) the user's real working dir is
 // never touched; (2) each goal's diff contains only that goal's changes on top
@@ -2661,11 +2690,25 @@ const server = createServer(async (req, res) => {
         // no PR) — the reviewer just Approves (files it) or Dismisses (drops
         // it). This is how "needs my judgment" reaches the phone without kicking
         // off an implementation run.
+        // Onboarding funnel (docs/HANDOFF-ONBOARDING-conversational.md): a real
+        // implementation goal can only produce changes inside a real code repo.
+        // If the active project points at a non-repo (e.g. the HOME dir when the
+        // agent was started ad-hoc), running would no-op — nothing to edit — yet
+        // report "done". Instead of that fake "fixed", ask which folder first,
+        // reusing the needsInput clarifying card; the answer (POST /answer)
+        // rebinds this goal to the chosen repo, then planning proceeds. Skipped
+        // for pending/review items (they never spawn a worker).
+        const runnable = !pending && !review;
+        const needsFolder = runnable && needsProjectFolder({ dir: project.dir, homeDir: HOME, isRepo: isGitRepo(project.dir) });
+        const folderQuestion = needsFolder
+          ? buildFolderQuestion(detectRepos(HOME), { lang: /[぀-ヿ㐀-鿿]/.test(text) ? 'ja' : 'en' })
+          : undefined;
         const goalAgent = workerAgent(agent);
         const priorFailureMemory = recentProjectFailureMemory(projectId, text.trim());
         const goal = {
           id: nextId++, projectId, text: text.trim().slice(0, 8000),
-          status: review ? 'review' : pending ? 'pending' : 'planning',
+          status: needsFolder ? 'needsInput' : review ? 'review' : pending ? 'pending' : 'planning',
+          question: folderQuestion,
           reviewOnly: review ? true : undefined,
           note: review && typeof note === 'string' && note.trim() ? note.trim().slice(0, 8000) : undefined,
           wantsPR: review ? false : resolveWantsPR(pr, text, getReviewDefinition(projectId).defaultWantsPR),
@@ -2695,7 +2738,7 @@ const server = createServer(async (req, res) => {
         // pending = deliberately shelved (Phase 2 material): never planned,
         // never queued, until POST /api/goals/:id/activate. review-only items
         // are terminal-until-human too, so they also skip planGoal.
-        if (!pending && !review) {
+        if (runnable && !needsFolder) {
           planGoal(goal).catch((e) => {
             goal.status = 'failed'; goal.prError = String(e).slice(0, 300); saveGoal(goal);
           });
@@ -2994,6 +3037,34 @@ const server = createServer(async (req, res) => {
       let answer = '';
       try { answer = String(JSON.parse(body || '{}').answer ?? '').trim(); } catch {}
       if (!answer) return json(res, 400, { error: 'answer required' });
+      // Folder-choice answer (onboarding funnel): rebind the goal to the chosen
+      // repo rather than appending to goal.text — a folder isn't a task
+      // clarification. Validate it's a real repo (and not HOME); if not, re-ask
+      // with a fresh detected list so we never fall through to a no-op run.
+      if (goal.question?.kind === 'folder') {
+        const resolved = resolveFolderAnswer(answer, goal.question.folders || []);
+        let dir = resolved?.dir || answer;
+        if (dir.startsWith('~')) dir = join(HOME, dir.slice(1).replace(/^\/+/, ''));
+        if (dir !== HOME && isGitRepo(dir)) {
+          const existing = projects.find((p) => p.dir === dir);
+          let proj = existing;
+          if (!proj) {
+            proj = { id: uniqueProjectId(basename(dir)), name: basename(dir), dir };
+            projects.push(proj); saveProjects();
+          }
+          goal.projectId = proj.id;
+          goal.question = null;
+          goal.clarified = true;
+          goal.status = 'planning';
+          saveGoal(goal);
+          planGoal(goal).catch((e) => { goal.status = 'failed'; goal.prError = String(e).slice(0, 300); saveGoal(goal); });
+          return json(res, 200, goal);
+        }
+        // not a usable repo → keep asking (don't run a no-op)
+        goal.question = buildFolderQuestion(detectRepos(HOME), { lang: goal.question.lang || 'ja' });
+        saveGoal(goal);
+        return json(res, 200, goal);
+      }
       goal.text = `${goal.text}\n[確認: ${goal.question?.text ?? ''} → ${answer}]`;
       goal.clarified = true; // answered once → planGoal must never re-ask (persisted via saveGoal)
       goal.question = null;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@galda/cli",
-  "version": "0.10.7",
+  "version": "0.10.8",
   "type": "module",
   "description": "Galda - hand off work to your Claude Code, get proof back. Runs on your existing subscription, no extra API cost.",
   "scripts": {