@galda/cli 0.10.32 → 0.10.34

package/bin/manager-for-ai.mjs

@@ -11,7 +11,7 @@ import { existsSync } from 'node:fs';
 import { join, resolve, dirname } from 'node:path';
 import { fileURLToPath, pathToFileURL } from 'node:url';
 import { createServer } from 'node:net';
-import { isCommandOnPath, resolveConnectedAgents } from '../engine/lib.mjs';
+import { isCommandOnPath, resolveConnectedAgents, resolveOpenBrowserDefault } from '../engine/lib.mjs';
 
 const ROOT = resolve(dirname(fileURLToPath(import.meta.url)), '..');
 const say = (m) => console.log(`[galda] ${m}`);
@@ -78,7 +78,11 @@ if (ffmpeg.error || ffmpeg.status !== 0) {
 }
 
 // 4) start the server (state in ~/.manager-for-ai unless MANAGER_HOME is set)
-process.env.MANAGER_OPEN_BROWSER = process.env.MANAGER_OPEN_BROWSER ?? '1';
+// Default to opening a browser only for an interactive (human) run. A worker or
+// CI that shells out to this CLI is non-interactive (piped stdout) and must never
+// pop a Google sign-in window on the user's desktop — 2026-07-18 incident. An
+// explicit MANAGER_OPEN_BROWSER (including empty) is always respected.
+process.env.MANAGER_OPEN_BROWSER = resolveOpenBrowserDefault({ existing: process.env.MANAGER_OPEN_BROWSER, isTTY: Boolean(process.stdout.isTTY) });
 // Public-build defaults (this CLI is the shipped entry point): point at the
 // deployed billing worker + the fixed-URL relay unless the operator overrides.
 // Set on env BEFORE importing the server so it reads them like any other config.

package/engine/lib.mjs

@@ -3335,6 +3335,38 @@ export function shouldEscalateConnectGateHint(waitedMs, email, thresholdMs = 150
   return Number(waitedMs) >= thresholdMs && Boolean(String(email ?? '').trim());
 }
 
+// Whether a booting manager should auto-open a browser window. A browser only
+// ever opens for a HUMAN-launched interactive manager. Ephemeral spawns — the
+// test helper (startServer), proof/verify capture instances — must never touch
+// the user's desktop: they boot with a throwaway license-less MANAGER_HOME,
+// which reads as "not signed in" and would pop a Google sign-in window per boot
+// (2026-07-18 incident: UI goals sprayed multiple Chrome sign-in windows while
+// workers ran the test suite, because MANAGER_OPEN_BROWSER=1 leaked in from the
+// launcher env into worker→test child processes). The reliable "a human asked
+// for this" signal is a concrete MANAGER_PORT: the launcher (bin/manager-for-ai
+// .mjs) resolves a real port BEFORE spawn, while every ephemeral spawn uses
+// MANAGER_PORT=0 (OS-assigned). So port 0 is never a browser-opening boot.
+export function shouldOpenBrowserOnBoot({ openBrowser, platform, managerPort } = {}) {
+  if (String(openBrowser) !== '1') return false;
+  if (platform !== 'darwin') return false;
+  if (String(managerPort ?? '') === '0') return false; // ephemeral / test / proof spawn
+  return true;
+}
+
+// The launcher (bin/manager-for-ai.mjs) side of the same rule: what to DEFAULT
+// MANAGER_OPEN_BROWSER to when the operator did not set it. shouldOpenBrowserOnBoot
+// is the belt on the spawn side (ephemeral port-0 boots never open); this is the
+// belt on the entry side. A human who ran `npx @galda/cli` in a terminal has an
+// interactive stdout (isTTY); a worker / CI / automation that shells out to the
+// CLI to "verify against a real server" is non-interactive (piped) — and must
+// never pop a Google sign-in window on the user's desktop (that path resolves a
+// real port, so the port-0 belt alone would not catch it). An explicit value
+// (including empty, meaning "self-hosted, no hosted flow") is always respected.
+export function resolveOpenBrowserDefault({ existing, isTTY } = {}) {
+  if (existing !== undefined && existing !== null) return String(existing);
+  return isTTY ? '1' : '0';
+}
+
 // --- device-flow (PKCE) sign-in helpers --------------------------------------
 // The browser no longer delivers the minted token to a live loopback port —
 // the engine POLLS the Worker to claim it (device-flow). PKCE ties the claim to

package/engine/server.mjs

@@ -21,7 +21,7 @@ import { homedir } from 'node:os';
 import { fileURLToPath } from 'node:url';
 import { pathToFileURL } from 'node:url';
 import { needsProjectFolder, folderLabel, buildFolderQuestion, resolveFolderAnswer, classifyFolderTarget, buildFolderInitConfirm, isFolderInitConfirmed, needsReviewPreference, buildReviewPreferenceQuestion, resolveReviewPreferenceAnswer, routeQuestionAnswer, notUnderstoodNote, parseRelocalizedQuestion, classifyAuthProbe, authBannerText, makeSigninChallenge, parseClaimResponse } from './lib.mjs';
-import { parseStreamEvents, parsePlan, refinePlanTasks, findOverlappingGoal, canEditGoal, canDeleteGoal, shouldAskClarification, workerExitReason, isForcedStop, workerResultText, taskCountsAsComplete, resolveWantsPR, resolveGoalSource, buildGoalSummary, buildGoalProofMd, buildGoalPrBody, buildReviewRuleSection, nextGoalStatus, isPrMerged, isPrApproved, reviewToDoneStatus, advanceReviewGoal, revertReviewGoal, approveGoal, dismissGoal, permissionModeFor, isPlanReview, nextAfterPlanApprove, GOAL_MODES, parseSkillFrontmatter, collectSkills, retestGoal, cancelRetestGoal, computeRetestOutcome, revertGoal, planRevertActions, archiveGoal, unarchiveGoal, undismissGoal, parseNumstat, truncateDiffText, sumUsage, resolveEntryUrl, parseGitLog, diffNewCommits, replayQueueLog, reconcileOrphanGoals, reorderQueue, sortQueueByPriority, TASK_PRIORITIES, validateWorkflowColumns, DEFAULT_WORKFLOW_COLUMNS, validateReviewDefinition, DEFAULT_REVIEW_DEFINITION, buildEphemeralSeedLog, buildEphemeralSeedProjects, trimTaskActivityForState, buildAskContext, WORKER_TOOLS, verifyCfAccessJwt, resolveIdentity, goalVisibleTo, clampParallelLimit, canStartMore, nextRunnableTasks, goalsConflict, detectConflicts, pickFoldTarget, isUiChange, shouldCaptureProof, shouldCaptureBaseline, hasTestRelevantChanges, buildExecutionPlan, buildContextHandoffSummary, buildFailurePostmortem, appendFailureMemory, latestFailurePolicy, classifyChangeRisk, checkRunBudget, usageBudgetTokens, isRateLimited, nextResumeDelay, checkFreeTierLimit, resolveEntitlement, resolveCachedEntitlement, FREE_TIER_LIMITS, QUEUED_GOAL_STATUSES, verifyLicenseToken, shouldEmitSetupCompleted, pickAnalyticsUid, shouldEmitFreeExhausted, detectRequestLanguage, isNothingVerifiable, classifyComposerIntentHeuristic, buildIntentPrompt, parseIntentResponse, buildBoardSnapshot, validateBoardSnapshot, boardIsEmpty, decideBoardPull, resolveConnectedAgents, pickAvailableAgent, pickUtilityAgent, utilityModel, liveTakeoverDecision } from './lib.mjs';
+import { parseStreamEvents, parsePlan, refinePlanTasks, findOverlappingGoal, canEditGoal, canDeleteGoal, shouldAskClarification, workerExitReason, isForcedStop, workerResultText, taskCountsAsComplete, resolveWantsPR, resolveGoalSource, buildGoalSummary, buildGoalProofMd, buildGoalPrBody, buildReviewRuleSection, nextGoalStatus, isPrMerged, isPrApproved, reviewToDoneStatus, advanceReviewGoal, revertReviewGoal, approveGoal, dismissGoal, permissionModeFor, isPlanReview, nextAfterPlanApprove, GOAL_MODES, parseSkillFrontmatter, collectSkills, retestGoal, cancelRetestGoal, computeRetestOutcome, revertGoal, planRevertActions, archiveGoal, unarchiveGoal, undismissGoal, parseNumstat, truncateDiffText, sumUsage, resolveEntryUrl, parseGitLog, diffNewCommits, replayQueueLog, reconcileOrphanGoals, reorderQueue, sortQueueByPriority, TASK_PRIORITIES, validateWorkflowColumns, DEFAULT_WORKFLOW_COLUMNS, validateReviewDefinition, DEFAULT_REVIEW_DEFINITION, buildEphemeralSeedLog, buildEphemeralSeedProjects, trimTaskActivityForState, buildAskContext, WORKER_TOOLS, verifyCfAccessJwt, resolveIdentity, goalVisibleTo, clampParallelLimit, canStartMore, nextRunnableTasks, goalsConflict, detectConflicts, pickFoldTarget, isUiChange, shouldCaptureProof, shouldCaptureBaseline, hasTestRelevantChanges, buildExecutionPlan, buildContextHandoffSummary, buildFailurePostmortem, appendFailureMemory, latestFailurePolicy, classifyChangeRisk, checkRunBudget, usageBudgetTokens, isRateLimited, nextResumeDelay, checkFreeTierLimit, resolveEntitlement, resolveCachedEntitlement, FREE_TIER_LIMITS, QUEUED_GOAL_STATUSES, verifyLicenseToken, shouldEmitSetupCompleted, pickAnalyticsUid, shouldEmitFreeExhausted, detectRequestLanguage, isNothingVerifiable, classifyComposerIntentHeuristic, buildIntentPrompt, parseIntentResponse, buildBoardSnapshot, validateBoardSnapshot, boardIsEmpty, decideBoardPull, resolveConnectedAgents, pickAvailableAgent, pickUtilityAgent, utilityModel, liveTakeoverDecision, shouldOpenBrowserOnBoot } from './lib.mjs';
 import { openPR } from './pr.mjs';
 import { runVerification, exerciseUi } from './verify.mjs';
 
@@ -4110,7 +4110,7 @@ server.listen(PORT, '127.0.0.1', () => {
   PORT = server.address().port; // the OS-assigned one when MANAGER_PORT=0
   try { server6.listen(PORT, '::1'); } catch { /* IPv6 loopback unavailable */ }
   console.log(`[manager] Manager for AI → http://localhost:${PORT}/?key=${ACCESS_KEY}`);
-  if (process.env.MANAGER_OPEN_BROWSER === '1' && process.platform === 'darwin') {
+  if (shouldOpenBrowserOnBoot({ openBrowser: process.env.MANAGER_OPEN_BROWSER, platform: process.platform, managerPort: process.env.MANAGER_PORT })) {
     // Hosted flow (billing worker + named app configured): the user lives in
     // app.galda.app, driven over the relay — they must NEVER be dropped on a
     // localhost board or an access key (Masa 2026-07-15: 「npm→ターミナル→

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@galda/cli",
-  "version": "0.10.32",
+  "version": "0.10.34",
   "type": "module",
   "description": "Galda - hand off work to Claude Code or Codex, get proof back. Runs on your existing subscription, no extra API cost.",
   "scripts": {