@galda/cli 0.10.101 → 0.10.102

package/app/index.html

@@ -3793,7 +3793,7 @@ function buildReviewDigest({ goals, tasks } = {}){
   for (const g of goals ?? []) {
     if (g?.status !== 'review') continue;
     const goalTasks = (tasks ?? []).filter((t) => t.goalId === g.id);
-    const proofTask = goalTasks.find((t) => t.proof);
+    const proofTask = latestProofTask(goalTasks);
     const checkLine = (g.reviewSummary?.check || g.plan?.[0] || g.text || '').replace(/\s+/g, ' ').trim().slice(0, 66);
     // Mirrors lib.mjs isPlanReview: a plan awaiting approval reads "PLAN — approve
     // to execute" and carries its plan body so the reviewer sees the plan in place.
@@ -9247,7 +9247,7 @@ function peraData(){
   const gs = (state.goals || []).filter((g) => g.projectId === state.active);
   const ts = (state.tasks || []).filter((t) => t.projectId === state.active);
   return buildReviewDigest({ goals: gs, tasks: ts }).map((r) => {
-    const pt = ts.find((t) => r.goalIds.includes(t.goalId) && t.proof && (t.proof.png || t.proof.gif));
+    const pt = latestProofTask(ts.filter((t) => r.goalIds.includes(t.goalId)), true);
     return { ...r, proofTaskId: pt?.id ?? null, proofImg: pt?.proof?.png ?? pt?.proof?.gif ?? null };
   });
 }
@@ -9360,6 +9360,8 @@ function closeSummaryPera(){ $('summaryOverlay').classList.remove('show'); }
 // settles it (see saSync's "returned to review" reset).
 // ============================================================================
 const SA = { open: false, items: [], diffs: {}, actLog: {}, msgs: {}, convOpen: new Set(), shotBox: {}, detOpen: new Set(), diffOpen: new Set(), attachments: {}, focusGid: null, focusScrolled: false, focusTimer: null, cur: null, solo: null, lastMarkup: null };
+// Same convention as the existing ?dev=1 devbar flag — off unless someone opts in by URL.
+const SA_DEV = new URLSearchParams(location.search).get('dev') === '1';
 function saReplyAttachmentsHtml(goalId){
   return (SA.attachments[goalId] || []).map((a, i) => `<span class="sa-replythumb"><img src="${esc(a.url)}" alt="Attached image"><button type="button" data-saarm="${goalId}:${i}" aria-label="Remove image">×</button></span>`).join('');
 }
@@ -9394,6 +9396,17 @@ function latestGoalOutcomeTask(goalId, tasks){
 }
 function taskAttemptId(t){ return t?.attemptId || (t?.id != null ? `task-${t.id}` : null); }
 function taskSortTime(t){ return Date.parse(t?.finishedAt || t?.startedAt || t?.createdAt || 0) || 0; }
+// The proof a reviewer is being asked to look at is the NEWEST one. A reply re-runs
+// the work and takes its own shot, so the goal accumulates several. Every call site
+// used to be `tasks.find((t) => t.proof)`, which returns the OLDEST — the card then
+// showed the first attempt's screenshot underneath the latest attempt's words
+// (Result already sorts by time via latestGoalOutcomeTask). `image` = the call site
+// renders a thumbnail and needs a png/gif, not a proof that only carries a video.
+function latestProofTask(tasks, image = false){
+  return (tasks || [])
+    .filter((t) => t.proof && (!image || t.proof.png || t.proof.gif))
+    .sort((a, b) => taskSortTime(b) - taskSortTime(a))[0] || null;
+}
 function latestGoalRunForOutcome(goalId, tasks, outcome){
   if (outcome?.run) return { taskId: outcome.id, attemptId: taskAttemptId(outcome), inherited: false, ...outcome.run };
   const runs = (tasks || []).filter((t) => t.goalId === goalId && t.run)
@@ -9424,7 +9437,7 @@ function saRowFromDigest(r, gs, ts){
     // here so the card never calls that state a generic failure.
     const interruptedTask = [...ts].filter((t) => r.goalIds.includes(t.goalId) && t.status === 'interrupted')
       .sort((a, b) => taskSortTime(b) - taskSortTime(a))[0] || null;
-    const pt = ts.find((t) => r.goalIds.includes(t.goalId) && t.proof && (t.proof.png || t.proof.gif));
+    const pt = latestProofTask(ts.filter((t) => r.goalIds.includes(t.goalId)), true);
     // "What we did" (H23 §2, replaces the old Plan/Review-thread folds): one bullet
     // per finished requirement task's own report; falls back to the goal's plan
     // steps when nothing has finished yet (e.g. a plan awaiting approval — the plan
@@ -9463,9 +9476,9 @@ function saRowFromDigest(r, gs, ts){
       attempt: g?.reviewAttempt ?? null,
       unmappedChangedFiles: outcome?.unmappedChangedFiles ?? [],
       requirementVerification: outcome?.requirementVerification ?? null,
-      requirementCoverage: ts.filter((t) => t.goalId === g?.id && (t.detail || t.title)).sort((a, b) => (a.num ?? 0) - (b.num ?? 0)).map((t) => ({ text: String(t.reply ? t.detail : t.title).replace(/\s+/g, ' ').trim(), taskStatus: t.status, evidenceStatus: t.requirementEvidence?.requirements?.[0]?.status ?? null })),
+      requirementCoverage: ts.filter((t) => t.goalId === g?.id && (t.detail || t.title)).sort((a, b) => (a.num ?? 0) - (b.num ?? 0)).map((t) => ({ text: String((t.reply ? t.detail : t.title) ?? t.title ?? '').replace(/\s+/g, ' ').trim(), taskStatus: t.status, evidenceStatus: t.requirementEvidence?.requirements?.[0]?.status ?? null })),
       requirementEvidence: outcome?.requirementEvidence?.requirements ?? [],
-      requirementCoverage: ts.filter((t) => t.goalId === g?.id && (t.detail || t.title) && (!t.reply || !t.replyFrom || t.replyFrom === 'you')).sort((a, b) => (a.num ?? 0) - (b.num ?? 0)).map((t) => ({ text: String(t.reply ? t.detail : t.title).replace(/\s+/g, ' ').trim(), status: t.status })),
+      requirementCoverage: ts.filter((t) => t.goalId === g?.id && (t.detail || t.title) && (!t.reply || !t.replyFrom || t.replyFrom === 'you')).sort((a, b) => (a.num ?? 0) - (b.num ?? 0)).map((t) => ({ text: String((t.reply ? t.detail : t.title) ?? t.title ?? '').replace(/\s+/g, ' ').trim(), status: t.status })),
       did, siblings, risk: g?.risk ?? null,
       verificationInfraError: g?.verificationInfraError ?? r.verificationInfraError ?? null,
       prNote: g?.prNote ?? null,
@@ -9573,7 +9586,7 @@ function saRowFromDigest(r, gs, ts){
 // the goal + its tasks exactly as buildReviewDigest does for a review goal.
 function saSoloDigestRow(g, ts){
   const goalTasks = (ts ?? []).filter((t) => t.goalId === g.id);
-  const proofTask = goalTasks.find((t) => t.proof);
+  const proofTask = latestProofTask(goalTasks);
   const checkLine = (g.reviewSummary?.check || g.plan?.[0] || g.text || '').replace(/\s+/g, ' ').trim().slice(0, 66);
   return {
     goalIds: [g.id], reviewNumber: goalReviewNumber({ goal: g, tasks: ts }), checkLine,
@@ -10404,26 +10417,37 @@ function saRender(){
   const S = $('seeall'); if (!S) return;
   // SSE, diff fetches and action responses rebuild the dialog. Remember the
   // review body's position before replacing it so reading never jumps to top.
+  // A raw scrollTop number is not enough: if a new review card lands ABOVE the
+  // one being read (saSync pushes it earlier in SA.items), restoring the same
+  // scrollTop lands on different content — the card visually jumps ("ガクッ").
+  // Anchor on the card currently at/near the top of the viewport instead, and
+  // after the rebuild re-align that same card back to the same offset.
   const previousBody = S.querySelector('.sa-body');
   const previousScrollTop = previousBody?.scrollTop ?? 0;
-  const restoreScroll = Boolean(previousBody) && SA.focusGid == null;
-  // A reply changes the height of the card being replied to (new thread line, status
-  // change) — restoring a raw scrollTop pixel then leaves the viewport at the same
-  // number but showing DIFFERENT content, a visible jolt on whatever card the person
-  // was actually reading (2026-07-29). Anchor on that card's own goalId instead: find
-  // the topmost visible card before the rebuild, and after the rebuild scroll so that
-  // SAME card sits at the SAME on-screen position, regardless of how much other cards
-  // above it grew or shrank.
+  // Preserve scroll even while a focus-flash is in flight: a new incoming review
+  // (saSync from SSE) used to skip this whenever SA.focusGid was still set, snapping
+  // the body back to scrollTop 0 and jerking the person's read position. The focus
+  // block below only force-scrolls the focused card to the top ONCE per flash window
+  // (SA.focusScrolled — see below), so it no longer fights this restore on later
+  // renders within that window.
+  const restoreScroll = Boolean(previousBody);
   let anchorGid = null, anchorOffset = 0;
+  // No `previousScrollTop > 0` guard here on purpose (task-917): right after opening,
+  // or right after the focus-flash auto-scroll lands a card at the top, scrollTop IS 0
+  // while a real card is still on screen. Skipping the anchor capture at exactly that
+  // scrollTop silently let a newly-inserted card take over position 0 with no scroll
+  // adjustment — the card someone was looking at got replaced under them without the
+  // scrollbar moving at all, which read as the exact same "ガクッ" jump the anchor
+  // logic below was built to prevent. Anchor whenever there is a previous body, full stop.
   if (restoreScroll) {
-    const containerTop = previousBody.getBoundingClientRect().top;
-    // The card actually being read sits near the middle of the viewport, not whatever
-    // sliver of a previous card's bottom edge still peeks in at the very top.
-    const midY = containerTop + previousBody.clientHeight / 2;
-    for (const el of previousBody.querySelectorAll('.sa-item')) {
+    const bodyRect = previousBody.getBoundingClientRect();
+    const midY = bodyRect.top + previousBody.clientHeight / 2;
+    const cards = [...previousBody.querySelectorAll('.sa-item[data-gid]')];
+    const anchor = cards.find((el) => {
       const r = el.getBoundingClientRect();
-      if (r.top <= midY && r.bottom >= midY) { anchorGid = el.dataset.gid; anchorOffset = r.top - containerTop; break; }
-    }
+      return r.top <= midY && r.bottom >= midY;
+    }) || cards.find((el) => el.getBoundingClientRect().bottom > bodyRect.top);
+    if (anchor) { anchorGid = anchor.dataset.gid; anchorOffset = anchor.getBoundingClientRect().top - bodyRect.top; }
   }
   const focusedReplyGoal = document.activeElement?.matches?.('#seeall .sa-chat')
     ? document.activeElement.dataset.goal
@@ -10438,17 +10462,51 @@ function saRender(){
   const curIdx = pending.findIndex((x) => x.goalId === SA.cur);
   const posLabel = solo ? '' : (pending.length && curIdx >= 0 ? `${curIdx + 1} / ${pending.length}` : '');
   const hdKeys = solo ? '↑↓ MOVE · ESC CLOSE' : '↑↓ MOVE · A APPROVE · D DISMISS · ESC CLOSE';
-  const markup = `<div class="sa-panel"><div class="sa-hd"><span class="t">${hdTitle}</span><span class="c">${c}</span><span class="sa-count">${posLabel}</span><span class="keys">${hdKeys}</span><button class="sa-x" data-saact="close:0">✕</button></div>
+  // Manual repro aid for the "ガクッ" scroll-jump bug (task-870): behind ?dev=1 only,
+  // never in a normal session. Lets a person scroll into a review card and then trigger
+  // a synthetic "new review just arrived" render the same way saSync does mid-read.
+  const devInjectBtn = SA_DEV ? '<button class="sa-x" data-saact="devinject:0" title="Insert a fake review above the current scroll (dev only)">+TEST</button>' : '';
+  const markup = `<div class="sa-panel"><div class="sa-hd"><span class="t">${hdTitle}</span><span class="c">${c}</span><span class="sa-count">${posLabel}</span><span class="keys">${hdKeys}</span>${devInjectBtn}<button class="sa-x" data-saact="close:0">✕</button></div>
     <div class="sa-body">${SA.items.length ? SA.items.map((it, i) => saItemHtml(it, i)).join('') : '<div class="sa-empty">Nothing waiting for review.</div>'}</div></div>`;
   // Most SSE goal/task events are unrelated to the card the person is reading.
   // Replacing #seeall with identical markup destroyed and recreated every node,
   // producing a blank flash and resetting browser-owned state. Keep the current
   // dialog DOM when its semantic markup did not change; the board behind it can
   // still refresh normally.
-  if (SA.lastMarkup === markup && S.querySelector('.sa-panel')) return;
+  if (SA.lastMarkup === markup && S.querySelector('.sa-panel')) {
+    // A focus change does not alter the card markup, but it still has a visual
+    // side effect: move the newly focused card before paint. Handle that on the
+    // existing DOM instead of returning early and waiting for the later rAF.
+    if (SA.focusGid != null && !SA.focusScrolled) {
+      const el = S.querySelector(`.sa-item[data-gid="${SA.focusGid}"]`);
+      if (el) {
+        saScrollCardToTop(el);
+        SA.focusScrolled = true;
+        el.classList.add('sa-flash');
+        if (!SA.focusTimer) SA.focusTimer = setTimeout(() => { SA.focusGid = null; SA.focusTimer = null; }, 1400);
+      }
+    }
+    return;
+  }
   SA.lastMarkup = markup;
   S.innerHTML = markup;
   const body = S.querySelector('.sa-body');
+  let focusPlacedNow = false;
+  // H14's "scroll the focused card to top" used to always run one requestAnimationFrame
+  // after this point. That's still required for the very FIRST render of a fresh
+  // saOpen(): #seeall is still `display:none` here (the .open class is added by the
+  // caller right after saRender() returns), so getBoundingClientRect() on anything
+  // inside is all-zero and a synchronous scroll here would be a no-op.
+  // But once the panel is already open (S.classList has 'open'), a LATER render
+  // arriving mid-flash (saSync/devinject, task-909) can and must place the card
+  // synchronously here, in the same pass as the anchor restore below — deferring it
+  // to the next rAF left a one-frame window where the browser could paint with the
+  // OLD (pre-focus) scrollTop, then snap to the correct position a frame later: a
+  // visible double-jump ("ガクッ") the first time a card arrived during that window.
+  if (body && S.classList.contains('open') && SA.focusGid != null && !SA.focusScrolled) {
+    const el = body.querySelector(`.sa-item[data-gid="${SA.focusGid}"]`);
+    if (el) { saScrollCardToTop(el); SA.focusScrolled = true; focusPlacedNow = true; }
+  }
   // Once the person scrolls, their position wins over the short opening-focus
   // animation. Programmatic opening scroll fires this too, which is fine: the
   // first placement happened and later SSE ticks should preserve it.
@@ -10464,12 +10522,16 @@ function saRender(){
                        // also what actually grows a replied-to card's height, so the scroll anchor
                        // below must run AFTER it, not before (2026-07-29 jolt fix).
   if (body && restoreScroll) {
-    const anchorEl = anchorGid != null ? body.querySelector(`.sa-item[data-gid="${anchorGid}"]`) : null;
-    if (anchorEl) {
-      const newOffset = anchorEl.getBoundingClientRect().top - body.getBoundingClientRect().top;
-      body.scrollTop += (newOffset - anchorOffset);
-    } else {
-      body.scrollTop = previousScrollTop;
+    // An explicit focus move wins for this render. Later SSE renders have
+    // focusScrolled=true and return to the normal reading-anchor preservation.
+    if (!focusPlacedNow) {
+      const anchorEl = anchorGid != null ? body.querySelector(`.sa-item[data-gid="${anchorGid}"]`) : null;
+      if (anchorEl) {
+        const newOffset = anchorEl.getBoundingClientRect().top - body.getBoundingClientRect().top;
+        body.scrollTop += (newOffset - anchorOffset);
+      } else {
+        body.scrollTop = previousScrollTop;
+      }
     }
   }
   for (const det of S.querySelectorAll('[data-detkey]')) {
@@ -10502,17 +10564,18 @@ function saRender(){
     if (im.complete && im.naturalWidth === 0) drop();
     else im.addEventListener('error', drop, { once: true });
   }
-  // H14: if a single-review focus is pending, bring the card's HEADER (#tag + In review
-  // + title) to the very top of the scroll area — never mid-card (Masa 2026-07-20) — and
-  // flash a blue ring. Re-scroll on EVERY render for the focus window — the post-diff
-  // saSync rebuild resets .sa-body scroll to the top, so a one-shot scroll would land back
-  // there. Self-clears after ~1.4s (outlasts the localhost diff fetch) so live SSE ticks
-  // stop yanking the view.
+  // H14: if a single-review focus is pending, flash a blue ring on its card. The
+  // scroll-to-top placement already happened synchronously above whenever the panel
+  // was visible at render time; this rAF is the fallback for the still-`display:none`
+  // first render of saOpen() (SA.focusScrolled stays false above, since the panel
+  // isn't open yet), plus it always adds the flash class and starts the self-clear
+  // timer, neither of which affect scroll position. Self-clears after ~1.4s (outlasts
+  // the localhost diff fetch) so live SSE ticks stop yanking the view.
   if (SA.focusGid != null) {
     requestAnimationFrame(() => {
       const el = S.querySelector(`.sa-item[data-gid="${SA.focusGid}"]`);
       if (!el) return;
-      saScrollCardToTop(el);
+      if (!SA.focusScrolled) { saScrollCardToTop(el); SA.focusScrolled = true; }
       el.classList.add('sa-flash');
       if (!SA.focusTimer) SA.focusTimer = setTimeout(() => { SA.focusGid = null; SA.focusTimer = null; }, 1400);
     });
@@ -10852,6 +10915,15 @@ $('seeall').addEventListener('click', async (e) => {
   // #reviewOverlay sits above #seeall, and a folded goal shows read-only there since
   // canReview=false hides Approve/Dismiss), or restore it via /unfold. Handled before the
   // SA.items[i] lookup below.
+  // Dev-only repro aid (task-870, gated by SA_DEV/?dev=1): simulate a new review card
+  // arriving mid-read the same way saSync splices one in from SSE, so the scroll-jump
+  // fix above can be checked by hand without waiting for a real worker to finish.
+  if (k === 'devinject') {
+    if (!SA_DEV) return;
+    SA.items.unshift(saDevSeedItem());
+    saRender();
+    return;
+  }
   if (k === 'foldopen') return openReviewChecklist(Number(v));
   if (k === 'foldundo') {
     let r; try { r = await fetch(withKey(`/api/goals/${v}/unfold`), { method: 'POST' }); }
@@ -11503,6 +11575,35 @@ $('toggle').onclick = () => { $('side').classList.toggle('collapsed'); rememberS
 // V3-C dev escape hatch (Masa決定 2026-07-07): flagship hides the top bar; ?dev=1
 // (or localStorage devbar=1) shows it there for development (layout/theme switchers).
 if (new URLSearchParams(location.search).get('dev') === '1' || localStorage.getItem('devbar') === '1') document.body.classList.add('devbar');
+// Manual repro aid for the scroll-jump-on-new-review bug (task-870), ?dev=1 only: a
+// floating button that opens the Review dialog pre-loaded with several synthetic cards
+// (no real worker/PR needed), so the "+TEST" button inside the dialog (see saRender) has
+// something to scroll through. Never shown outside an explicit ?dev=1 session.
+let saDevSeq = 0;
+function saDevSeedItem(){
+  saDevSeq++;
+  const n = saDevSeq;
+  return {
+    goalId: -n, ids: [-n], st: 0, goal: {}, title: `Test review #${n}`,
+    report: `Synthetic review card #${n} — for manually checking the scroll position stays put when a new card is inserted (task-870).`,
+    pr: null, testResult: null, tokenOpt: null,
+    metaFiles: [`fixtures/dev-review-${n}.mjs  +${n} −${n}`], metaAdd: `+${n}`, metaDel: `−${n}`,
+  };
+}
+if (SA_DEV) {
+  const btn = document.createElement('button');
+  btn.textContent = 'Open test review (dev)';
+  btn.title = 'Opens the Review dialog with fake cards so the scroll-jump fix (task-870) can be checked by hand: scroll down, then press +TEST in the dialog header.';
+  btn.style.cssText = 'position:fixed;right:16px;bottom:16px;z-index:9999;padding:8px 12px;border-radius:8px;border:1px solid var(--line,#444);background:var(--panel,#222);color:var(--ink,#eee);cursor:pointer;font:12px/1.2 inherit';
+  btn.addEventListener('click', () => {
+    SA.open = true; SA.solo = null; SA.detOpen = new Set(); SA.focusGid = null;
+    SA.items = Array.from({ length: 6 }, () => saDevSeedItem());
+    SA.cur = SA.items[0].goalId;
+    saRender();
+    $('seeall').classList.add('open');
+  });
+  document.body.appendChild(btn);
+}
 // Feedback 7: layout switcher — apply + persist the chosen arrangement.
 function applyLayout(){
   document.body.dataset.layout = state.layout || 'current';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@galda/cli",
-  "version": "0.10.101",
+  "version": "0.10.102",
   "type": "module",
   "description": "Galda - hand off work to Claude Code or Codex, get proof back. Runs on your existing subscription, no extra API cost.",
   "scripts": {